athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-15T03:03:28+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42545MuonSegmentTagTool - Skip bad extrapolations2021-04-15T03:03:28+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonSegmentTagTool - Skip bad extrapolationsHi,
it could rarely happen that the extrapolations to a surface are such bad that the covariance becomes invalid leading to the FPE reported in ATLASRECTS-6184. Now, a check is added to skip the corresponding extensions.Hi,
it could rarely happen that the extrapolations to a surface are such bad that the covariance becomes invalid leading to the FPE reported in ATLASRECTS-6184. Now, a check is added to skip the corresponding extensions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42543CLID: remove package information2021-04-21T11:11:47+02:00Frank WinklmeierCLID: remove package informationRemove `PackageInfo` (package name and version) from the CLID
database. This information was never correctly filled (full story in ATEAM-731). The `PackageInfo` class is kept as a dummy until the `IClassIDSvc` interface in Gaudi has been...Remove `PackageInfo` (package name and version) from the CLID
database. This information was never correctly filled (full story in ATEAM-731). The `PackageInfo` class is kept as a dummy until the `IClassIDSvc` interface in Gaudi has been adjusted.
This is likely going to cause problems in incremental builds due to the format change of the `clid.db` (one column removed). So this has to run as a ~"full-build" and merging needs to be synchronized with the CI node cleanup on Saturday.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42542Move up the WARNING suppression initialisation in the code2021-04-15T03:03:19+02:00Mark SuttonMove up the WARNING suppression initialisation in the codeTake tntialisation of the suppression of the WARNING output out from
the inner loop, such that it is not reinitialised for each channelTake tntialisation of the suppression of the WARNING output out from
the inner loop, such that it is not reinitialised for each channelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42540AT: Adding AsgDeadHVCellRemovalTool for electron and photon clusters2021-04-16T11:55:34+02:00Bjoern WendlandAT: Adding AsgDeadHVCellRemovalTool for electron and photon clustersPhoton and electron clusters in EMEC bad HV regions are removed using the `AsgDeadHVCellRemovalTool` for affected runs in data 2016. More information can be found on this [twiki page](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/E...Photon and electron clusters in EMEC bad HV regions are removed using the `AsgDeadHVCellRemovalTool` for affected runs in data 2016. More information can be found on this [twiki page](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/EGammaIdentificationRun2#Removal_of_Electron_Photon_clust).https://gitlab.cern.ch/atlas/athena/-/merge_requests/42539Requirement of successful in pT calculation to L2 inside-out mode2021-04-16T03:03:27+02:00Yohei YamaguchiRequirement of successful in pT calculation to L2 inside-out modeA requirement of successful in pT calculation is added to L2 inside-out mode.
This modification doesn't decrease efficiency for muons significantly, but decrease input rate to EF steps.
Discussions are found in ATR-21003.
tagging @nakah...A requirement of successful in pT calculation is added to L2 inside-out mode.
This modification doesn't decrease efficiency for muons significantly, but decrease input rate to EF steps.
Discussions are found in ATR-21003.
tagging @nakahama , @cdiez and @skanayamhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42538JetUncertainties: FatJet JMR uncertainty fixes2021-04-15T03:05:57+02:00Jonas Till RoemerJetUncertainties: FatJet JMR uncertainty fixesTwo fixes for the `CP::FFJetSmearingTool`:
- Inline functions in header so they do not violate the one definition rule (ODR)
- Add `DECLARE_NAMESPACE_TOOL_FACTORY(CP, FFJetSmearingTool)` macro
The first bug prevented the header file fr...Two fixes for the `CP::FFJetSmearingTool`:
- Inline functions in header so they do not violate the one definition rule (ODR)
- Add `DECLARE_NAMESPACE_TOOL_FACTORY(CP, FFJetSmearingTool)` macro
The first bug prevented the header file from being imported in different translation units. The second bug made it impossible to create an instance of the tool using the ToolSvc in python.
@mswiatlo @cdelitzs @dmelini @xingguohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42537Fix memory leak in BPHY112021-04-16T10:17:39+02:00Adam Edward BartonFix memory leak in BPHY11A fix for the memory leak in !41495.
@kbelobor can you verify this works as you expect.
cc @wwalkoA fix for the memory leak in !41495.
@kbelobor can you verify this works as you expect.
cc @wwalkohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42536Adding validation histograms for HLT GSF tracks2021-04-15T03:02:57+02:00Zoe Olivia EarnshawAdding validation histograms for HLT GSF tracksModified TrigInDetAnalysisUser and TrigInDetValidation to produce validation histograms for GSF electrons. Validated that plots work against recent nightly (9th April)
Associated Jira ticket: https://its.cern.ch/jira/browse/ATR-23230Modified TrigInDetAnalysisUser and TrigInDetValidation to produce validation histograms for GSF electrons. Validated that plots work against recent nightly (9th April)
Associated Jira ticket: https://its.cern.ch/jira/browse/ATR-23230https://gitlab.cern.ch/atlas/athena/-/merge_requests/42535Fix detection whether TruthParticle decorations should be applied or not.2021-04-16T03:04:59+02:00Goetz GayckenFix detection whether TruthParticle decorations should be applied or not.The decoration availability check is performed per container, thus testing
the availability of a certain decoration for each truth particle is incorrect.
Now, decorations are not applied if all the decorations are already present in
the ...The decoration availability check is performed per container, thus testing
the availability of a certain decoration for each truth particle is incorrect.
Now, decorations are not applied if all the decorations are already present in
the TruthParticle container.
This is meant to address the disappearance of truth decorations (after and including master/2021-04-02) which are needed to produce InDet PhysVal n-tuples e.g. in InDetPhysValMonitoring art nightly tests. The reason why the truth decorations were present in earlier nightlies and disappeared then is still not understood, though.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42534DESM_MCP: Remove CosmicMuonCollection2021-04-15T03:02:29+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDESM_MCP: Remove CosmicMuonCollectionHi,
in jobs running with `DESDM_MCP`, one can find WARNING messages like
```
WARNING add: can not find type [CosmicMuonCollection] in clid db
```
This container was part of the run-I EDM and had been removed for run-III. Now, I removed ...Hi,
in jobs running with `DESDM_MCP`, one can find WARNING messages like
```
WARNING add: can not find type [CosmicMuonCollection] in clid db
```
This container was part of the run-I EDM and had been removed for run-III. Now, I removed it from the job options to also remove the warning.
Closes: ATR-23188https://gitlab.cern.ch/atlas/athena/-/merge_requests/42533Add primary tag to many primary combined triggers (ATR-22594)2021-04-16T03:03:35+02:00Mark Andrew OwenAdd primary tag to many primary combined triggers (ATR-22594)Add primary tag to many primary combined triggers and also fix stray tight in HLT_g45_loose_tight_6j45_L14J15p0ETA25Add primary tag to many primary combined triggers and also fix stray tight in HLT_g45_loose_tight_6j45_L14J15p0ETA25https://gitlab.cern.ch/atlas/athena/-/merge_requests/42532Phase1 L1Muon menu (ATR-23227)2021-04-16T03:03:51+02:00Daniele ZanziPhase1 L1Muon menu (ATR-23227)addition Phase1 L1Muon thresholds in menuaddition Phase1 L1Muon thresholds in menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42531Tile mbts streams2021-04-16T03:02:34+02:00Luisa CarvalhoTile mbts streamsAdding MBTS chains for Tile as requested here ATR-23216Adding MBTS chains for Tile as requested here ATR-23216https://gitlab.cern.ch/atlas/athena/-/merge_requests/42530additional histograms for egamma ART2021-04-30T16:59:19+02:00Daniela Kuchleradditional histograms for egamma ARTadditional histograms for more detailed checks of conversion reconstruction performance: ported added code from master to rel 21 to keep the ART plots compatibel (!41482 and !42460)additional histograms for more detailed checks of conversion reconstruction performance: ported added code from master to rel 21 to keep the ART plots compatibel (!41482 and !42460)https://gitlab.cern.ch/atlas/athena/-/merge_requests/42528L1Topo jFEX Small R Jets2021-05-13T03:04:20+02:00Anil Sonayanil.sonay@cern.chL1Topo jFEX Small R JetsSeveral of implementation has been carried by this MR:
- Phase1 L1Calo input, jFEX small R jets has been implemented for L1Topo, as it is ready now: ATR-23360
* Require to configure eFEX and jFEX at the same time : ATR-23334
- Related...Several of implementation has been carried by this MR:
- Phase1 L1Calo input, jFEX small R jets has been implemented for L1Topo, as it is ready now: ATR-23360
* Require to configure eFEX and jFEX at the same time : ATR-23334
- Related TOB implemented according to naming convention in ATR-23095
* All the naming convention for new TOBs has been propagated into L1Topo type, to be used in the menu : ATR-23196
- FPEAuditor warning has been fixed : ATR-23390 required by ATR-22942
- Mapping of LUT replaced by vector, to gather element by the indexeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42526EgammaARTmonitoring_plotsMaker.py flake8 fixes and autopep8 format2021-04-21T14:24:34+02:00Christos Anastopouloschristos.anastopoulos@cern.chEgammaARTmonitoring_plotsMaker.py flake8 fixes and autopep8 formathttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42525Sweeping !42421 from 21.9 to 21.3.
Add some flags so we can work with phase II2021-04-15T03:06:07+02:00Atlas NightlybuildSweeping !42421 from 21.9 to 21.3.
Add some flags so we can work with phase IIAdd some flags so we can work with phase II
See merge request atlas/athena!42421Add some flags so we can work with phase II
See merge request atlas/athena!42421https://gitlab.cern.ch/atlas/athena/-/merge_requests/42524Sweeping !42500 from master to 21.2.
fix AsgServiceConfig/AnaAlgorithmConfig ...2021-04-14T03:05:16+02:00Atlas NightlybuildSweeping !42500 from master to 21.2.
fix AsgServiceConfig/AnaAlgorithmConfig python unit test failurefix AsgServiceConfig/AnaAlgorithmConfig python unit test failure
See merge request atlas/athena!42500fix AsgServiceConfig/AnaAlgorithmConfig python unit test failure
See merge request atlas/athena!42500https://gitlab.cern.ch/atlas/athena/-/merge_requests/42523MuonCSC_CnvTools+MuonCnvToolInterfacesMuonCnvToolInterfaces: const fixes.2021-04-15T03:05:05+02:00Scott SnyderMuonCSC_CnvTools+MuonCnvToolInterfacesMuonCnvToolInterfaces: const fixes.Make interfaces of CscRdoContByteStreamTool const.
Make interfaces of ICSC_RDOtoByteStreamTool const.
Remove duplicate declaration of ICSC_RDOtoByteStreamTool.Make interfaces of CscRdoContByteStreamTool const.
Make interfaces of ICSC_RDOtoByteStreamTool const.
Remove duplicate declaration of ICSC_RDOtoByteStreamTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42522LArCalibUtils: Clean up documentation.2021-04-14T03:03:46+02:00Scott SnyderLArCalibUtils: Clean up documentation.Remove some obsolete documentation.Remove some obsolete documentation.