athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-01-11T19:15:00+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68108Remove getTruthTauP4Prompt function from TauTruthMatchingTool - outdated2024-01-11T19:15:00+01:00Antonio De MariaRemove getTruthTauP4Prompt function from TauTruthMatchingTool - outdatedThis MR is removing "getTruthTauP4Prompt" function from the TauTruthMatchingTool. These functions are trying to access elements which are not decorated anymore on the tau, so they are outdated (already outdated in R21)
Tagging @martindlThis MR is removing "getTruthTauP4Prompt" function from the TauTruthMatchingTool. These functions are trying to access elements which are not decorated anymore on the tau, so they are outdated (already outdated in R21)
Tagging @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65661remove GridDriver from release2023-10-26T09:51:23+02:00Nils Erik Krumnackremove GridDriver from releaseGridDriver is based on Ganga, which is not really the current
recommendation anymore, or even last year's recommendation. Given
that some problems are being reported in conjunction with GridDriver
I'm just removing it (as agreed with th...GridDriver is based on Ganga, which is not really the current
recommendation anymore, or even last year's recommendation. Given
that some problems are being reported in conjunction with GridDriver
I'm just removing it (as agreed with the AMG conveners). Users ought
to be using PrunDriver instead.
cc @hrussell @gwatts @ekourlithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27882Remove handles to ROBDataProvider from HltEventLoopMgr2019-11-15T03:02:27+01:00Rafal Bielskirafal.bielski@cern.chRemove handles to ROBDataProvider from HltEventLoopMgrThe code was a leftover from the migration from release 21. The handles were not actually used for anything in the current HltEventLoopMgr. The functionality which needed ROBDataProvider in HltEventLoopMgr in release 21 is now implemente...The code was a leftover from the migration from release 21. The handles were not actually used for anything in the current HltEventLoopMgr. The functionality which needed ROBDataProvider in HltEventLoopMgr in release 21 is now implemented by TrigByteStreamInputSvc. Moreover, the ITrigROBDataProviderSvc interface is not used online at all.
cc @wiedenmahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41306Remove hardcoded BIS78 protections for Run3 MDT calibration2021-03-08T20:57:21+01:00Nicolas KoehlerRemove hardcoded BIS78 protections for Run3 MDT calibrationHi,
now that we have a MDT calibration DB entry for BIS78, we can remove the hardcoded protections (sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/41294 into ~"21.3" and ~"21.9").
Best, NicoHi,
now that we have a MDT calibration DB entry for BIS78, we can remove the hardcoded protections (sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/41294 into ~"21.3" and ~"21.9").
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40979Remove hardcoded BMG cabling2021-03-30T03:04:19+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRemove hardcoded BMG cablingHi,
this MR removes the hardcoded BMG cabling from the `MDTCabling` algorithm. The cabling has been added by hand at a time where no maps were available in COOL. However, the best knowledge conditions tags contain a BMG cabling and thi...Hi,
this MR removes the hardcoded BMG cabling from the `MDTCabling` algorithm. The cabling has been added by hand at a time where no maps were available in COOL. However, the best knowledge conditions tags contain a BMG cabling and this hack is not needed. Closes ATLASSIM-5020
Adding: @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39288Remove hardcoded manipulation of WriteHandle names in MuonCreatorAlg2020-12-19T03:04:09+01:00Nicolas KoehlerRemove hardcoded manipulation of WriteHandle names in MuonCreatorAlgHi,
so far, in `MuonCreatorAlg`, the names of the `WriteHandleKey<xAOD::MuonSegmentContainer>` and `WriteHandleKey<Trk::SegmentCollection>` were modified via hardcoded strings. This MR removes that and does these string manipulations al...Hi,
so far, in `MuonCreatorAlg`, the names of the `WriteHandleKey<xAOD::MuonSegmentContainer>` and `WriteHandleKey<Trk::SegmentCollection>` were modified via hardcoded strings. This MR removes that and does these string manipulations already during the configuration.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35861Remove hardcoded MDT radius from MdtCalibrationTool2020-08-26T03:04:46+02:00Nicolas KoehlerRemove hardcoded MDT radius from MdtCalibrationToolHi,
this MR removes on hardcoded instance of the MDT radius inside the MdtCalibrationTool.
Best, NicoHi,
this MR removes on hardcoded instance of the MDT radius inside the MdtCalibrationTool.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26085Remove hard-coded MDT radius values.2019-08-25T03:01:57+02:00Edward DiehlRemove hard-coded MDT radius values.Remove hard-coded MDT radius values in reconstruction code. Switch to
using detectorElement()->innerTubeRadius() which works for both MDT
and sMDT chambers. Fixes problem of excess number of holes for even
layers of sMDT chambers.
...Remove hard-coded MDT radius values in reconstruction code. Switch to
using detectorElement()->innerTubeRadius() which works for both MDT
and sMDT chambers. Fixes problem of excess number of holes for even
layers of sMDT chambers.
Passed tests in RunTier0Tests.pyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43802remove hard-coded paths in Sherpa tarCreator2021-05-29T03:04:11+02:00Christian Gutschowremove hard-coded paths in Sherpa tarCreatorOne of the sub-steps of the Sherpa tarCreator uses Python to create a bash script that sets up cvmfs-based library paths to the various dependencies used by the OpenMPI-enabled version of Sherpa on cvmfs, which we use for process integra...One of the sub-steps of the Sherpa tarCreator uses Python to create a bash script that sets up cvmfs-based library paths to the various dependencies used by the OpenMPI-enabled version of Sherpa on cvmfs, which we use for process integrations. These paths are currently hardcoded. This change set is to remove the hardcoded paths in favour of environment-variable-based path setting.
cc @fsiegert @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41294Remove hardcoded Run3 BIS78 checks in MDT calibration2021-03-06T03:04:47+01:00Nicolas KoehlerRemove hardcoded Run3 BIS78 checks in MDT calibrationHi,
now that we have a MDT calibration DB entry for BIS78, we can remove the hardcoded protections.
Best, NicoHi,
now that we have a MDT calibration DB entry for BIS78, we can remove the hardcoded protections.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40920Remove Hard Coded Strip Pitch in MM Digitization2021-02-26T17:25:40+01:00Patrick ScholerRemove Hard Coded Strip Pitch in MM DigitizationThis MR fixes the usage of a hardcoded and wrong strip pitch in the MM digitizationThis MR fixes the usage of a hardcoded and wrong strip pitch in the MM digitizationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56073remove hard-coded tags from config2022-10-10T08:26:00+02:00Constantin Heideggerremove hard-coded tags from configThis MR removes hard-coded tag names for NSW calibration and passivation condition folders.This MR removes hard-coded tag names for NSW calibration and passivation condition folders.Constantin HeideggerConstantin Heideggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60248Remove hardcoded tau isolation from L1Topo2023-02-01T21:44:20+01:00Paula Martinez SuarezRemove hardcoded tau isolation from L1TopoRead tau isolation WPs from L1Menu. <br>
Update for L1TopoSmulation and HLTSeeding. <br>
Local test does not show any change in trigger counts.
Tagging @asonay and @rbielski for double-check.Read tau isolation WPs from L1Menu. <br>
Update for L1TopoSmulation and HLTSeeding. <br>
Local test does not show any change in trigger counts.
Tagging @asonay and @rbielski for double-check.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32199Remove hard-coded turn off of NSW detectors in Sim_tf2020-05-25T08:05:23+02:00Nicolas KoehlerRemove hard-coded turn off of NSW detectors in Sim_tfHi,
this MR fixes the issue that when running `Sim_tf` with NSW layouts, the `Micromegas` and `sTGC` were not added to the `SimulatedDetectors (string)` since the DetFlags geometry flag was always turned off. Also sweeping to ~"21.9" an...Hi,
this MR fixes the issue that when running `Sim_tf` with NSW layouts, the `Micromegas` and `sTGC` were not added to the `SimulatedDetectors (string)` since the DetFlags geometry flag was always turned off. Also sweeping to ~"21.9" and ~master.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64964Remove header parsing for typedefs2023-08-11T19:36:36+02:00Marcin NowakRemove header parsing for typedefsNot needed any more due to ROOT RNTuple type system improvementsNot needed any more due to ROOT RNTuple type system improvementshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48781Remove header that should not be in use anymore2021-12-03T21:43:32+01:00Christos Anastopouloschristos.anastopoulos@cern.chRemove header that should not be in use anymoreRemove header that should not be in use anymoreRemove header that should not be in use anymorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31969Remove HepMC-specific iterators from the interfaces of filters.2020-04-15T13:37:36+02:00Andrii VerbytskyiRemove HepMC-specific iterators from the interfaces of filters.This MR is needed afor the preparation to migrate Athena to HepMC3, it removes the custom iterators which are not present in HepMC3.
- Briefly, the HepMC-specific iterators like ` HepMC::GenEvent::particle_const_iterator` or `HepMC::...This MR is needed afor the preparation to migrate Athena to HepMC3, it removes the custom iterators which are not present in HepMC3.
- Briefly, the HepMC-specific iterators like ` HepMC::GenEvent::particle_const_iterator` or `HepMC::GenVertex::particle_iterator` are to clumsy and will be removed everywhere in the future.
- For this particular MR, the iterators are just either used to refer to a particle and the replacement is trivial, or these are used in functions like `findAncestor(const HepMC::GenVertex::particle_iterator& firstAncestor,
const HepMC::GenVertex::particle_iterator& endAncestor, ... )`
In the files affected by this MR the functions `findAncestor(const HepMC::GenVertex::particle_iterator& firstAncestor,
const HepMC::GenVertex::particle_iterator& endAncestor,...` are always called on the whole vector of particles, i.e. `firstAncestor` is always `particles_out_const_begin()` and `endAncestor` is always `particles_out_const_end()`. The iterators are NOT independent. Therefore instead of the pair of iterators the function takes a pointer to vertex as an argument and derives the proper iterators internally.
- `findAncestor` is the most confusing name for these functions, but I don't fix it so far.
Tagging @akraszna @ewelina @jchapman
https://gitlab.cern.ch/atlas/athena/-/merge_requests/67214Remove HI legacy menu sequence definition2023-11-21T13:08:18+01:00Tomasz BoldRemove HI legacy menu sequence definitionThis is just minor cleanup of HI menu.
Testing was a bit challenging though as HI tests fails and I had to turn off egamma.
In addition I have made a following modification to one of test to increase execution "probability" and realy se...This is just minor cleanup of HI menu.
Testing was a bit challenging though as HI tests fails and I had to turn off egamma.
In addition I have made a following modification to one of test to increase execution "probability" and realy see events passed by chains:
@asmaga @kciesla - you may consider such change to make test more relevant.
```diff
--- a/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_HI_run3_build.py
+++ b/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_HI_run3_build.py
@@ -11,18 +11,20 @@ from TrigValTools.TrigValSteering.Common import find_file
# Specify trigger menu once here:
-triggermenu = 'Dev_HI_run3_v1_TriggerValidation_prescale'
+#triggermenu = 'Dev_HI_run3_v1_TriggerValidation_prescale'
+triggermenu = 'Dev_HI_run3_v1'
hlt = ExecStep.ExecStep()
hlt.type = 'athenaHLT'
hlt.job_options = 'TriggerJobOpts/runHLT_standalone.py'
hlt.input = 'data_hi_2023'
-hlt.args = f'-c "setMenu=\'{triggermenu}\';'
+hlt.args = f'-c "setMenu=\'{triggermenu}\';forceEnableAllChains=True;'
hlt.args += ';'.join(['flags.Trigger.L1MuonSim.NSWVetoMode=False',
'flags.Trigger.L1MuonSim.doMMTrigger=False',
'flags.Trigger.L1MuonSim.doPadTrigger=False',
- 'flags.Trigger.L1MuonSim.doStripTrigger=False']) + '"'
+ 'flags.Trigger.L1MuonSim.doStripTrigger=False',
+ 'flags.Trigger.forceEnableAllChains=True']) + '"'
hlt.fpe_auditor = True
hlt.max_events = -1
hlt.args += ' -o output'
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/68919Remove HIRecExample legacy config package2024-02-15T20:35:07+01:00Thomas StreblerRemove HIRecExample legacy config packageRemoved the full HIRecExample package hosting only legacy configs, now replaced by CA ones.
Cleaned up the RecExample scripts referencing them. Most of them are about to be removed with !68693 anyway
Needed for !68501Removed the full HIRecExample package hosting only legacy configs, now replaced by CA ones.
Cleaned up the RecExample scripts referencing them. Most of them are about to be removed with !68693 anyway
Needed for !68501https://gitlab.cern.ch/atlas/athena/-/merge_requests/45529Remove hit-based sp/trk edms from TrigEDM to avoid HLTResult truncation (ATR-...2021-08-02T03:03:39+02:00Kunihiro NaganoRemove hit-based sp/trk edms from TrigEDM to avoid HLTResult truncation (ATR-23952)- For some events, Hit-based DV trigger's space point EDM gets too large to cause HLTResult truncation- For some events, Hit-based DV trigger's space point EDM gets too large to cause HLTResult truncation