athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-02-12T03:03:22+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/40548SCT_Digitization: Fix clang warnings.2021-02-12T03:03:22+01:00Scott SnyderSCT_Digitization: Fix clang warnings.Missing override keywords.Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23639SCT_Digitization: Fix compilation with clang.2019-05-24T03:02:06+02:00Scott SnyderSCT_Digitization: Fix compilation with clang.Ambiguity in applying operator+ to Gaudi::Property.Ambiguity in applying operator+ to Gaudi::Property.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57807SCT_Digitization: Fix cppcheck warning.2022-10-25T09:42:09+02:00Scott SnyderSCT_Digitization: Fix cppcheck warning.Prefer preincrement of iterator classes.Prefer preincrement of iterator classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30599SCT_Digitization: Fix use of non-const static data.2020-02-26T03:03:00+01:00Scott SnyderSCT_Digitization: Fix use of non-const static data.Fixes warning uncovered by pending thread-safety checker changes.Fixes warning uncovered by pending thread-safety checker changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22295SCT_Digitization: Increase test timeout.2019-04-02T03:02:22+02:00Scott SnyderSCT_Digitization: Increase test timeout.Test has been timing out.Test has been timing out.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56153SCTEncode test fix2022-08-25T17:58:20+02:00Cristiano SebastianiSCTEncode test fixQuick fix for ATLASRECTS-7201 , affecting nightlies and the CI. The problem is due to an invalid ReadCondHandle never scheduled by SCT_CablingCondAlgFromCoraCool.
Tag: @gemmerenQuick fix for ATLASRECTS-7201 , affecting nightlies and the CI. The problem is due to an invalid ReadCondHandle never scheduled by SCT_CablingCondAlgFromCoraCool.
Tag: @gemmerenCristiano SebastianiCristiano Sebastianihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54279SCTErrMonAlg: added modulemap histos back into DQ2022-06-16T14:58:45+02:00Cristiano SebastianiSCTErrMonAlg: added modulemap histos back into DQAdded back in DQ histo maps of modules out of configuration for SCT monitoring.
tag: @grancagnAdded back in DQ histo maps of modules out of configuration for SCT monitoring.
tag: @grancagnhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50041SCTErrMonAlg: fixing fixed size array issue (ATLASRECTS-6607)2022-02-15T09:43:11+01:00Cristiano SebastianiSCTErrMonAlg: fixing fixed size array issue (ATLASRECTS-6607)Providing a fix for ATLASRECTS-6607 in SCTErrMonAlg where an out-of-bounds store was found due to a fixed size array.Providing a fix for ATLASRECTS-6607 in SCTErrMonAlg where an out-of-bounds store was found due to a fixed size array.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61920SCTErrMonAlg: fix legacy flags usage2023-03-28T22:14:45+02:00Tadej Novaktadej.novak@cern.chSCTErrMonAlg: fix legacy flags usageAlso rename the argument to `flags`.Also rename the argument to `flags`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31920SCTErrMonAlg: unused RAII lock_guard2020-04-14T03:02:29+02:00Christos Anastopouloschristos.anastopoulos@cern.chSCTErrMonAlg: unused RAII lock_guardHey,
I picked this up due
to
https://gitlab.cern.ch/atlas/athena/-/merge_requests/31749
but prb this is a pre-existing issue @oda ?
More or less this is kind of a known bugprone situation for RAII types
Running clang-tidy
...Hey,
I picked this up due
to
https://gitlab.cern.ch/atlas/athena/-/merge_requests/31749
but prb this is a pre-existing issue @oda ?
More or less this is kind of a known bugprone situation for RAII types
Running clang-tidy
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-unused-raii.html
does this fix
```
+++ b/InnerDetector/InDetMonitoring/SCT_Monitoring/src/SCTErrMonAlg.cxx
@@ -72,7 +72,7 @@ StatusCode SCTErrMonAlg::fillHistograms(const EventContext& ctx) const {
// The numbers of disabled modules, links, strips do not change during a run.
if (m_isFirstConfigurationDetails) {
- lock_guard{m_mutex};
+ lock_guard give_me_a_name{m_mutex};
if (m_isFirstConfigurationDetails) {
ATH_CHECK(fillConfigurationDetails(ctx));
m_isFirstConfigurationDetails = false;
```
And then just put ``glock`` for ``give_me_a_name`` ...
Anyhow without a name the subsequent statement happens after the lock has been destructed which I assume is not what you want as then why have a lock guard guarding nothing.
silly example
https://godbolt.org/z/XAvLzKhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20868SCTExtension: Use ReadHandle(Key). Remove const_cast. Inherit AthReentrantAlg...2019-02-06T03:01:55+01:00Susumu OdaSCTExtension: Use ReadHandle(Key). Remove const_cast. Inherit AthReentrantAlgorithm.SCTExtension package
* Use ReadHandle(Key).
* Remove const_cast.
* Inherit AthReentrantAlgorithm.SCTExtension package
* Use ReadHandle(Key).
* Remove const_cast.
* Inherit AthReentrantAlgorithm.https://gitlab.cern.ch/atlas/athena/-/merge_requests/29067SCT_G4_SD: cmake fix2019-12-21T03:02:13+01:00Scott SnyderSCT_G4_SD: cmake fixRemove reference to undefined macro GMOCK_LIBRARIES.
Closes SCT_G4_SD-20191219Remove reference to undefined macro GMOCK_LIBRARIES.
Closes SCT_G4_SD-20191219https://gitlab.cern.ch/atlas/athena/-/merge_requests/36742SCT_GeoModel: Fix cppcheck warnings.2020-09-29T03:02:02+02:00Scott SnyderSCT_GeoModel: Fix cppcheck warnings.- Pass class instances by const reference, not by value.
- Prefer using an initializer list to assigning members
in a ctor body.
- Clarify object lifetime.- Pass class instances by const reference, not by value.
- Prefer using an initializer list to assigning members
in a ctor body.
- Clarify object lifetime.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56501SCT_GeoModel: initialize and build detector description from SQLite file2022-09-28T15:43:19+02:00Marilena BandieramonteSCT_GeoModel: initialize and build detector description from SQLite fileThis MR introduces the possibility to initialise and build the SCT geometry starting from
an SQLite file that describes the raw geometry.
In order to properly build the readout geometry a new argument of type
GeoModelIO::ReadGeoModel*...This MR introduces the possibility to initialise and build the SCT geometry starting from
an SQLite file that describes the raw geometry.
In order to properly build the readout geometry a new argument of type
GeoModelIO::ReadGeoModel* was added to the constructor
of SCT_UniqueComponentFactory to distinguish the way the geometry is built:
* Null pointer: the geometry is built from GeometryDB (standard workflow)
* Otherwise the geometry is built from SQLite file (new DD workflow)
The standard workflow is not modified by this MR and the new dd workflow can be activated
via job option.
The code has been tested locally running a simulation job.
The results when running the standard configuration are bitwise identical w.r.t the previous ones.
With the new workflow configuration the simulation runs successfully to the end.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49166SCT_GeoModel+SCT_Monitoring: Fix clang13 warnings.2021-12-16T15:43:35+01:00Scott SnyderSCT_GeoModel+SCT_Monitoring: Fix clang13 warnings.Unused variables.Unused variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36681SCT_GeoModel: Thread-safety cleanup.2020-09-25T03:03:12+02:00Scott SnyderSCT_GeoModel: Thread-safety cleanup.const consistency.
Remove most ATLAS_NOT_THREAD_SAFE annotations (except for registerCallback).const consistency.
Remove most ATLAS_NOT_THREAD_SAFE annotations (except for registerCallback).https://gitlab.cern.ch/atlas/athena/-/merge_requests/49283SCT_GeoModel: Update for thread-safety checker const changes.2021-12-21T15:42:58+01:00Scott SnyderSCT_GeoModel: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68765SCT_GeoModel - Use intrusive ptrs2024-02-17T19:06:38+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chSCT_GeoModel - Use intrusive ptrsInstead of ref/unref use the GeoModel smart pointer.Instead of ref/unref use the GeoModel smart pointer.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65321SCT heavyions webdisplay config cleanup2023-09-19T21:55:32+02:00Cristiano SebastianiSCT heavyions webdisplay config cleanupClean up of the configuration file of the DQ webdisplay in preparation for the heavyions run. Many names mismatch and obsolete histograms.
Tag: @grancagnClean up of the configuration file of the DQ webdisplay in preparation for the heavyions run. Many names mismatch and obsolete histograms.
Tag: @grancagnhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66823SCT Heavy Ion webdsiplay update: add coverage plot2023-11-01T07:52:52+01:00Cristiano SebastianiSCT Heavy Ion webdsiplay update: add coverage plotAdding SCT coverage histogram to heavy ion webdisplay. Used by the remote shifters for Data Quality assessment.
tag: @grancagnAdding SCT coverage histogram to heavy ion webdisplay. Used by the remote shifters for Data Quality assessment.
tag: @grancagn