athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-03-22T03:02:06+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/22009SCT_RawDataByteStreamCnv: Updating SCT_RodDecoder according to ATLAS Coding G...2019-03-22T03:02:06+01:00Kristian BjoerkeSCT_RawDataByteStreamCnv: Updating SCT_RodDecoder according to ATLAS Coding GuidelinesUpdating the SCT_RodEncoder after a review of the code in light of the ATLAS Coding Guidelines (https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/CodingGuidelines). Some related changes also made other parts of the package.
Tested...Updating the SCT_RodEncoder after a review of the code in light of the ATLAS Coding Guidelines (https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/CodingGuidelines). Some related changes also made other parts of the package.
Tested with RunTier0Tests.py with release master,x86_64,slc6,gcc8,opt,2019-03-17T2152,Athena.
q221 not passed: Error related to TriggerMenu (ERROR Problems when importing TauDef.py, disabling tau chains.)
q341 passed!
See attached logfile: [RunTier0Tests.log](/uploads/7ea41ca10766195976a1045dbfc0ae03/RunTier0Tests.log)
As a part of the ATLAS Qualification Task of @krbjoerk to review the SCT ByteStreamConverter in light of the ATLAS Coding Guidelines.
Technical supervisor: @odahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38159SCT_RawDataByteStreamCnv: Use AthConstConverter.2020-11-13T03:05:47+01:00Scott SnyderSCT_RawDataByteStreamCnv: Use AthConstConverter.Use AthConstConverter base class.
Further thread-safety cleanups and fixes.Use AthConstConverter base class.
Further thread-safety cleanups and fixes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69653SCT_RawDataByteStreamCnv: Use input file from CVMFS2024-03-11T11:03:21+01:00Tadej Novaktadej.novak@cern.chSCT_RawDataByteStreamCnv: Use input file from CVMFSCloses ATLASRECTS-7932.
/cc @csebastiCloses ATLASRECTS-7932.
/cc @csebastihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62120SCT_RawDataContainerCnv_p4: use pool to avoid many small allocations2023-04-25T14:04:59+02:00Christos Anastopouloschristos.anastopoulos@cern.chSCT_RawDataContainerCnv_p4: use pool to avoid many small allocationsIn heapTrack of 100 ttbar events one sees
```
4467 17133768 calls to allocation functions with 20.18M peak consumption from
4468 std::_MakeUniq<>::__single_object std::make_unique<>()
4469 at /cvmf...In heapTrack of 100 ttbar events one sees
```
4467 17133768 calls to allocation functions with 20.18M peak consumption from
4468 std::_MakeUniq<>::__single_object std::make_unique<>()
4469 at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/bits/unique_ptr.h:962
4470 in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-03-31T2101/Athena/23.0.23/InstallArea/x86_64-centos7-gcc11-opt/lib/libInDetEventAthenaPool.so
4471 SCT_RawDataContainerCnv_p4::persToTrans(SCT_RawDataContainer_p4 const*, InDetRawDataContainer<>*, MsgStream&)
4472 at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/InDetEventAthenaPool/src/SCT_RawDataContainerCnv_p4.cxx:157
4473 17133768 calls with 20.18M peak consumption from:
```
Try to use pool in order to avoid ~ 200k allocation per eventhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64233SCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online case2023-07-13T00:38:51+02:00Christos Anastopouloschristos.anastopoulos@cern.chSCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online caseSCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online case
For now default false
Follow-up to !63914SCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online case
For now default false
Follow-up to !63914https://gitlab.cern.ch/atlas/athena/-/merge_requests/20374SCT RDO updates to reduce size for overlay MC (ATLASSIM-3903)2019-09-27T21:13:43+02:00Susumu OdaSCT RDO updates to reduce size for overlay MC (ATLASSIM-3903)SCT RDO updates to reduce size for overlay MC
https://its.cern.ch/jira/browse/ATLASSIM-3903
- SCT3_RawData_p4 was created to have an unsigned short for a data word and a unsigned short for strip (<=13 bits) and row (<=3 bits) numbe...SCT RDO updates to reduce size for overlay MC
https://its.cern.ch/jira/browse/ATLASSIM-3903
- SCT3_RawData_p4 was created to have an unsigned short for a data word and a unsigned short for strip (<=13 bits) and row (<=3 bits) numbers.
- SCT_RawDataContainer_p4 was created to drop the unused error words.
- The packing of fired strips in digitization with the Expanded mode was changed in SCT_FrontEnd and SCT_ClusteringTool.
https://gitlab.cern.ch/atlas/athena/merge_requests/20213 is the corresponding MR for the master branch.
https://gitlab.cern.ch/atlas/athena/merge_requests/20456 is the corresponding MR for the 21.0 branch.
RunTier0Tests.py did not find unexpected differences. [RunTier0Tests.log](/uploads/44e7fbffaaeabbca66e6ac4ffa90e880/RunTier0Tests.log)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20213SCT RDO updates to reduce size for overlay MC (ATLASSIM-3903)2019-01-21T01:53:42+01:00Susumu OdaSCT RDO updates to reduce size for overlay MC (ATLASSIM-3903)SCT RDO updates to reduce size for overlay MC
https://its.cern.ch/jira/browse/ATLASSIM-3903
* SCT3_RawData_p4 was created to have an unsigned short for a data word and a unsigned short for strip (<=13 bits) and row (<=3 bits) numb...SCT RDO updates to reduce size for overlay MC
https://its.cern.ch/jira/browse/ATLASSIM-3903
* SCT3_RawData_p4 was created to have an unsigned short for a data word and a unsigned short for strip (<=13 bits) and row (<=3 bits) numbers.
* SCT_RawDataContainer_p4 was created to drop the unused error words.
* The packing of fired strips in digitization with the Expanded mode was changed in SCT_FrontEnd and SCT_ClusteringTool.
RunTier0Tests.py did not find unexpected differences. [RunTier0Tests.log](/uploads/c6e9837b908c6b8390e8aa6efce35dca/RunTier0Tests.log)
https://gitlab.cern.ch/atlas/athena/merge_requests/20374 is the corresponding MR for the 21.3 branch.
https://gitlab.cern.ch/atlas/athena/merge_requests/20456 is the corresponding MR for the 21.0 branch.https://gitlab.cern.ch/atlas/athena/-/merge_requests/37965SCT_ReadoutGeometry+CommissionEvent: cmake fix2020-11-07T03:03:48+01:00Scott SnyderSCT_ReadoutGeometry+CommissionEvent: cmake fixRemove references to undefined and unneeded EIGEN_INCLUDE_DIRS,
ROOT_INCLUDE_DIRS.Remove references to undefined and unneeded EIGEN_INCLUDE_DIRS,
ROOT_INCLUDE_DIRS.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44789SCT_ReadoutGeometry: Fix clang warnings.2021-07-02T03:04:13+02:00Scott SnyderSCT_ReadoutGeometry: Fix clang warnings.Missing override keywords.Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66131SCT_ReadoutGeometry: Fix cppcheck warnings.2023-10-06T15:57:43+02:00Scott SnyderSCT_ReadoutGeometry: Fix cppcheck warnings.Explicitly qualify virtual functions called from constructors to make it
clear that virtual dispatch does not happen.Explicitly qualify virtual functions called from constructors to make it
clear that virtual dispatch does not happen.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30882SCT_ReadoutGeometry+TRT_ReadoutGeometry: cmake fix2020-03-06T03:02:50+01:00Scott SnyderSCT_ReadoutGeometry+TRT_ReadoutGeometry: cmake fixRemove references to nonexistent package CLIDSvc.Remove references to nonexistent package CLIDSvc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67159SCT_SpacePoint add move2023-11-16T13:56:08+01:00Christos Anastopouloschristos.anastopoulos@cern.chSCT_SpacePoint add moveSCT_SpacePoint add moveSCT_SpacePoint add movehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26391SCT Spacepoint Cuts for Noisesup algorithm2019-10-05T03:02:45+02:00Somadutta BhattaSCT Spacepoint Cuts for Noisesup algorithmThis MR is to introduce cuts on SCT Spacepoints for noises algorithm's migration to AthenaMT.
Related to ATR-19863.
Tagging @tbold @mvozakThis MR is to introduce cuts on SCT Spacepoints for noises algorithm's migration to AthenaMT.
Related to ATR-19863.
Tagging @tbold @mvozakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51409SCT_TdaqEnabledCond: fix handling of conditions for Run1 data [ATLASRECTS-6864]2022-03-21T21:43:56+01:00Cristiano SebastianiSCT_TdaqEnabledCond: fix handling of conditions for Run1 data [ATLASRECTS-6864]Fix for test_data11_7tev.sh failing in the ART monitoring (ATLASRECTS-6864).
SCT_TdaqEnabledCondAlg was not configured properly when running on Run1 data, the input condition folder for Run1 should be "/TDAQ/EnabledResources/ATLAS/SCT/Ro...Fix for test_data11_7tev.sh failing in the ART monitoring (ATLASRECTS-6864).
SCT_TdaqEnabledCondAlg was not configured properly when running on Run1 data, the input condition folder for Run1 should be "/TDAQ/EnabledResources/ATLAS/SCT/Robins" and not "/TDAQ/Resources/ATLAS/SCT/Robins" (>=Run 2).https://gitlab.cern.ch/atlas/athena/-/merge_requests/67319SCTTracksMonTool: use std math functions2023-11-23T11:49:08+01:00Tadej Novaktadej.novak@cern.chSCTTracksMonTool: use std math functionsUse `std` math functions in `SCTTracksMonTool`. Will probably fix narrowing conversion warnings in the dev nightlies.
/cc @ssnyderUse `std` math functions in `SCTTracksMonTool`. Will probably fix narrowing conversion warnings in the dev nightlies.
/cc @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68768SCT units legacy test cleanup (ATLIDTRKCP-534)2024-02-12T19:25:25+01:00Cristiano SebastianiSCT units legacy test cleanup (ATLIDTRKCP-534)Remove legacy tests from SCT_RawDataByteStreamCnv and SCT_ConditionsAlgorithms -> ATLIDTRKCP-534Remove legacy tests from SCT_RawDataByteStreamCnv and SCT_ConditionsAlgorithms -> ATLIDTRKCP-534https://gitlab.cern.ch/atlas/athena/-/merge_requests/65306SCT: Use consistent default geometry tags in unit tests2023-08-26T05:51:15+02:00Tadej Novaktadej.novak@cern.chSCT: Use consistent default geometry tags in unit testsUse consistent default geometry tags in SCT unit tests.Use consistent default geometry tags in SCT unit tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41470Second attempt: Removing obsolete Run 2 files from Egamma side2021-03-17T11:37:21+01:00Debottam Bakshi GuptaSecond attempt: Removing obsolete Run 2 files from Egamma sideRemoving rest of the obsolete python files from TrigEgammaHypo as discussed ATR-22836. Adding @fwinklRemoving rest of the obsolete python files from TrigEgammaHypo as discussed ATR-22836. Adding @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42313Second fix for ATLASRECTS-60002021-04-08T03:02:35+02:00William Axel LeightSecond fix for ATLASRECTS-6000I made a stupid mistake in copying and pasting and used z instead of r for ordering the pseudomeasurements. Additionally, the special exceptions for comparing RPC and MDT hits should only apply to the case when the hits are in the same c...I made a stupid mistake in copying and pasting and used z instead of r for ordering the pseudomeasurements. Additionally, the special exceptions for comparing RPC and MDT hits should only apply to the case when the hits are in the same chamber, otherwise they can simply be ordered by r.
Closes ATLASRECTS-6000https://gitlab.cern.ch/atlas/athena/-/merge_requests/65417second fix for ATLHI-483, unstable particles with no decay vertex2023-09-11T15:13:05+02:00Aaron Angeramisecond fix for ATLHI-483, unstable particles with no decay vertexCloses ATLHI-483Closes ATLHI-483