athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-15T01:34:07+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68881Add ability to ignore trigger in meta-diff and enable it for workflow tests2024-02-15T01:34:07+01:00Tadej Novaktadej.novak@cern.chAdd ability to ignore trigger in meta-diff and enable it for workflow testsAdd ability to ignore trigger in `meta-diff` and enable it for workflow tests.
This could probably be done with regexes but as this is ~urgent, let's hardcode keys for now.
/cc @tsulaia @tamartin @martindl @khooAdd ability to ignore trigger in `meta-diff` and enable it for workflow tests.
This could probably be done with regexes but as this is ~urgent, let's hardcode keys for now.
/cc @tsulaia @tamartin @martindl @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68860Physics Menu cleanup of legacy tau+x chains and fixed a typo in group name2024-02-15T16:57:08+01:00Gianantonio Pezzullog.pezzullo@yale.eduPhysics Menu cleanup of legacy tau+x chains and fixed a typo in group namePhysics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784Physics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784https://gitlab.cern.ch/atlas/athena/-/merge_requests/68839Debug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfo2024-02-14T18:15:18+01:00Jennifer Rachel CurranDebug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfoUpdate to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (a...Update to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (and where they are called in trigRecoExe.py) as this step is being added to the script that reads the values in the root files for the debug recovery web application so is not needed here.
ATR-26595
@mark @wiedenmahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68837TileByteStream: Fix Tile ROD decoder initialization (ATR-28780)2024-02-13T20:10:04+01:00Siarhei HarkushaTileByteStream: Fix Tile ROD decoder initialization (ATR-28780)Tile ROD decoder has been fixed to explicitely retrieve (initialize)
Tile cabling service since it is used during initialization.
Tile ROD decoder test, JO and reference files have been updated accordingly.Tile ROD decoder has been fixed to explicitely retrieve (initialize)
Tile cabling service since it is used during initialization.
Tile ROD decoder test, JO and reference files have been updated accordingly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68827TrigAnalysisTest: move CI test to CA2024-02-15T20:33:44+01:00Bertrand Martin Dit LatourTrigAnalysisTest: move CI test to CAHello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of...Hello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of RecExCommon in !68693.
A follow up MR will migrate the other tests in this package.
Tagging @fwinkl .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68819Adjustment for the calratio triggers to adress high rate2024-02-16T18:54:00+01:00Tatiana OvsiannikovaAdjustment for the calratio triggers to adress high rate- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6...- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1jJ160
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_EMPTY
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_UNPAIRED_ISO
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU40HT
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60HM
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU140
- add few more chains for emf preselection comparison:
- HLT_j20_CLEANllp_momemfrac024_calratio_roiftf_preselj20emf24_L1TAU60
- HLT_j20_CLEANllp_momemfrac012_calratio_roiftf_preselj20emf12_L1T
- HLT_j30_CLEANllp_momemfrac006_calrtold_L1TAU60https://gitlab.cern.ch/atlas/athena/-/merge_requests/68791Build Script Fixes, main branch (2024.02.12.)2024-02-13T00:54:12+01:00Attila KrasznahorkayBuild Script Fixes, main branch (2024.02.12.)This is a sibling / replacement for !68785.
I fixed the GeoModel setup in the build scripts by getting rid of the spaces in `ATLAS_GEOMODEL_FORCEDOWNLOAD_MESSAGE`. Unfortunately BASH can be a primadonna with propagating quotes correctly...This is a sibling / replacement for !68785.
I fixed the GeoModel setup in the build scripts by getting rid of the spaces in `ATLAS_GEOMODEL_FORCEDOWNLOAD_MESSAGE`. Unfortunately BASH can be a primadonna with propagating quotes correctly. :frowning: I tried a few things, but this seemed the easiest / most pragmatic. :thinking:
As !68785, this is meant to fix ATLINFR-5244.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68719Fix for failing nightly tests2024-02-09T10:18:21+01:00Lidija ZivkovicFix for failing nightly testsThis is fixing failure in [nightly](https://test-atrvshft.web.cern.ch/test-atrvshft/ART_monitor/Monitor/Build/2024-02-07T2101/main_Athena_x86_64-el9-gcc13-opt/TriggerTest/trig_data_v1PhysP1lowMu_build)This is fixing failure in [nightly](https://test-atrvshft.web.cern.ch/test-atrvshft/ART_monitor/Monitor/Build/2024-02-07T2101/main_Athena_x86_64-el9-gcc13-opt/TriggerTest/trig_data_v1PhysP1lowMu_build)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68702ATR-28264 - migrating HI Jets to CA2024-02-09T13:25:35+01:00Martin RybarATR-28264 - migrating HI Jets to CA* Migration of the HI jet trigger to CA (ATR-28264)
* Removing non-CA configuration
* Fix for ATR-28041
* Tagging @asmaga and @kciesla as HI trigger coordinators and @stapiaar as software coordinator
* CA version tested against non-CA wi...* Migration of the HI jet trigger to CA (ATR-28264)
* Removing non-CA configuration
* Fix for ATR-28041
* Tagging @asmaga and @kciesla as HI trigger coordinators and @stapiaar as software coordinator
* CA version tested against non-CA with the same trigger counts seen
* CA version tested with the full HI menu (test_trig_mc_v1DevHI_newJO_build.py)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68685Correct silently failing ACTS CI test2024-02-08T14:50:51+01:00Carlo Varnicarlo.varni@cern.chCorrect silently failing ACTS CI testA silly mistake form my side.
We were not checking the intermediate steps of this CI test, and one of them was indeed failing due to a python code change that removed two configuration functions. We are not checking the intermediate ste...A silly mistake form my side.
We were not checking the intermediate steps of this CI test, and one of them was indeed failing due to a python code change that removed two configuration functions. We are not checking the intermediate steps and return a failure when appropriate, all remaining references to those now-removed configuration functions have been removed.
Tagging ~urgent since the affected CI test is silently failinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68630ATR-28761 Removal of remaining legacy combined items - J, XE2024-02-08T10:20:24+01:00Zhongyukun Xuzhongyukun.xu@cern.chATR-28761 Removal of remaining legacy combined items - J, XETo replace legacy combined items with Phase-1 and clean upTo replace legacy combined items with Phase-1 and clean uphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68570BPHY13, 23 and 25 update2024-02-28T15:03:14+01:00Xin ChenBPHY13, 23 and 25 updateUpdated BPHY13, BPHY23 and BPHY25. For BPHY13, made 4-muon single-vertex fit with charmonium mass constraints (instead of replying on charmonium revertex). For BPHY23, added the multi-track single-vertex fitter and corresponding changes ...Updated BPHY13, BPHY23 and BPHY25. For BPHY13, made 4-muon single-vertex fit with charmonium mass constraints (instead of replying on charmonium revertex). For BPHY23, added the multi-track single-vertex fitter and corresponding changes in python. For BPHY25, removed Ks and added 3-body decays like B- -> J/psi Lambda pbar, and corresponding changes in python.
Development of BPHY13, BPHY23 and BPHY25 can be found in the following JIRAs:
https://its.cern.ch/jira/browse/ATLBPHYS-34
https://its.cern.ch/jira/browse/ATLBPHYS-219
https://its.cern.ch/jira/browse/ATLBPHYS-298Xin ChenXin Chenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68512remove InDetRecExample to avoid warnings2024-02-02T11:45:51+01:00Ewelina Maria Lobodzinskaremove InDetRecExample to avoid warningsremove InDetRecExample to avoid warningsremove InDetRecExample to avoid warningshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68453Fix bug in PCBT decision2024-03-11T17:30:41+01:00Baptiste Ravinabaptiste.ravina@cern.chFix bug in PCBT decisionSimple fix to the bug introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/68193Simple fix to the bug introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/68193https://gitlab.cern.ch/atlas/athena/-/merge_requests/68440Debug stream recovery, Fix to trig reco2024-01-30T16:14:17+01:00Jennifer Rachel CurranDebug stream recovery, Fix to trig recoBug fix to previous MR: !67981, add condition before executing dbgPosRun on output BS file (after stream selection) in trigRecoExe.py to prevent failures when condition is not met.
@wiedenma @markBug fix to previous MR: !67981, add condition before executing dbgPosRun on output BS file (after stream selection) in trigRecoExe.py to prevent failures when condition is not met.
@wiedenma @markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68429fix typo in WP setup2024-01-30T09:42:17+01:00Binbin Dongfix typo in WP setupfixed the typo in the WPs for GN2v01 continuous
cc @fsilifixed the typo in the WPs for GN2v01 continuous
cc @fsilihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68392New derivation format: BPHY262024-01-31T15:26:16+01:00Yue XuNew derivation format: BPHY26We would like to request for a new derivation format -- BPHY26. The ART tests for BPHY26 are also created.We would like to request for a new derivation format -- BPHY26. The ART tests for BPHY26 are also created.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68388fix failing acts art test2024-01-29T10:57:07+01:00Carlo Varnicarlo.varni@cern.chfix failing acts art testThis fixes a problem in one of our acts art testsThis fixes a problem in one of our acts art testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68357added check in ZdcRecConfig for online environment; small binning change in Z...2024-01-30T15:49:05+01:00Yuhan Guoadded check in ZdcRecConfig for online environment; small binning change in ZDC monitoring histogramsadded a check in flags for online/offline environment; if online, do turn trigger-validation tool offadded a check in flags for online/offline environment; if online, do turn trigger-validation tool offhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68331Fix bugs in the random seeding of the JER uncertainty2024-02-21T12:05:54+01:00Christopher YoungFix bugs in the random seeding of the JER uncertainty@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data ...@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data it is more correct to use the max(MC,data) resolution. This was not anticipated when the tool was originally written but results in very small changes. Finally advanced users can set the seed themselves, but this currently set the seed the same for all jets which is not a usual use-case so this has also been modified.