athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-10-01T03:03:52+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/36842ZdcIdentifier: Enable thread-safety checking.2020-10-01T03:03:52+02:00Scott SnyderZdcIdentifier: Enable thread-safety checking.Enable thread-safety checking.
Make static data const.Enable thread-safety checking.
Make static data const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50176ZDC_GeoM: Work around gcc12 warning.2022-02-03T15:43:24+01:00Scott SnyderZDC_GeoM: Work around gcc12 warning.Work around gcc12 false positive warning.Work around gcc12 false positive warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47030ZDC_GeoM: Enable thread-safety checking.2021-10-09T19:04:30+02:00Scott SnyderZDC_GeoM: Enable thread-safety checking.Enable thread-safety checking.
Clean up warnings.Enable thread-safety checking.
Clean up warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34461ZDC_GeoM+BeamPipeGeoModel+CavernInfraGeoModel: Fix clang 10 warning.2020-07-07T03:03:13+02:00Scott SnyderZDC_GeoM+BeamPipeGeoModel+CavernInfraGeoModel: Fix clang 10 warning.If a dtor is declared final, the class itself should also be declared final.If a dtor is declared final, the class itself should also be declared final.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60049ZDC fixes for Run 2 reconstruction2023-01-25T15:42:19+01:00Brian Andrew Colebrian.cole@cern.chZDC fixes for Run 2 reconstructionChanges to ZDCFitWrapper and ZDCPulseAnalyzer to adapt Run 3 version of code to Run 2 (2015)Changes to ZDCFitWrapper and ZDCPulseAnalyzer to adapt Run 3 version of code to Run 2 (2015)https://gitlab.cern.ch/atlas/athena/-/merge_requests/66208ZDCFitWrapper: Initialize constant term in PrePulse wrapper in DoInitialize()2023-10-04T16:23:29+02:00Peter Alan SteinbergZDCFitWrapper: Initialize constant term in PrePulse wrapper in DoInitialize()Change from @bcole restores missing initializer in ZDCFitWrapper.cxx in ZDCFitExpFermiPrePulse::DoInitialize. I ran @christos setup from https://its.cern.ch/jira/browse/ATLASRECTS-7759 twice in two separate directories (just changing th...Change from @bcole restores missing initializer in ZDCFitWrapper.cxx in ZDCFitExpFermiPrePulse::DoInitialize. I ran @christos setup from https://its.cern.ch/jira/browse/ATLASRECTS-7759 twice in two separate directories (just changing the raw data to a Minbias file from Run 461681). I also ran his "acmd diff-root" script (as given) on the two files and I see no change.
`````
Py:diff-root INFO comparing over [100] entries...
Py:diff-root INFO comparing [1138] leaves over entries...
Py:diff-root INFO Found [2204448] identical leaves
Py:diff-root INFO Found [0] different leaves
Py:diff-root INFO all good.
`````
I would appreciate a cross check of this, but this looks promising. Scripts and output can be found here: /eos/atlas/atlascerngroupdisk/det-zdc/norepro/https://gitlab.cern.ch/atlas/athena/-/merge_requests/54743ZdcEventTPCnv: migrate to const TPCnv2022-07-04T15:43:55+02:00Frank WinklmeierZdcEventTPCnv: migrate to const TPCnvMigrate to const TPCnv and enable thread-checker.Migrate to const TPCnv and enable thread-checker.Frank WinklmeierFrank Winklmeierhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57273ZdcEventTPCnv: Fix thread-safety checker warnings.2022-10-05T09:42:33+02:00Scott SnyderZdcEventTPCnv: Fix thread-safety checker warnings.Fix (disabled-by-default) warnings about calls to unchecked code.Fix (disabled-by-default) warnings about calls to unchecked code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36914ZdcEvent: Fix cppcheck warnings.2020-10-03T03:10:28+02:00Scott SnyderZdcEvent: Fix cppcheck warnings.- Prefer pre-increment (or range-for) to postincrement.
- Prefer using an initialization list to initializing membesr
in a ctor body.- Prefer pre-increment (or range-for) to postincrement.
- Prefer using an initialization list to initializing membesr
in a ctor body.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36841ZdcEvent: Enable thread-safety checking.2020-10-01T03:03:19+02:00Scott SnyderZdcEvent: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57274ZdcEventAthenaPool: Enable thread-safety checking.2022-10-05T09:42:36+02:00Scott SnyderZdcEventAthenaPool: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65745ZDC: Enable "LHCf" functional form for 2023 analysis2023-09-19T21:55:32+02:00Brian Andrew Colebrian.cole@cern.chZDC: Enable "LHCf" functional form for 2023 analysisSwitch the pp2023 and PbPb2023 configurations to use the "LHCf" function form for pulse fitting
Fix the annoying error messages re: initial value outside limitsSwitch the pp2023 and PbPb2023 configurations to use the "LHCf" function form for pulse fitting
Fix the annoying error messages re: initial value outside limitshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35558ZDC development branch to be merged into 21.22020-12-14T01:28:53+01:00Pengqi YinZDC development branch to be merged into 21.2There was a mistake happened during the last MR. So a new MR is required and references to the old one: atlas/athena!35437
Update info from previous MR:
1. Updates to pulse fitting to improve performance for 2018 PbPb
2. Add repass ...There was a mistake happened during the last MR. So a new MR is required and references to the old one: atlas/athena!35437
Update info from previous MR:
1. Updates to pulse fitting to improve performance for 2018 PbPb
2. Add repass for the pulse fitting to reduce the effect of the low energy peak (lower than 1n peak) which is due to the large pile-up events.
3. Improve the baseline matching performance for delayed and undelayed samples.
4. Change the 2018 fit function to "FermiExpLinear".
5. Update standalone test files in "tools" folder.https://gitlab.cern.ch/atlas/athena/-/merge_requests/35437ZDC development branch to be merged into 21.22020-08-13T03:04:48+02:00Pengqi YinZDC development branch to be merged into 21.2Merge development branch "21.2-zdc-dev-Bill-standalone" into 21.2
1. Updates to pulse fitting to improve performance for 2018 PbPb
2. Add repass for the pulse fitting to reduce the effect of the low energy peak (lower than 1n peak) whic...Merge development branch "21.2-zdc-dev-Bill-standalone" into 21.2
1. Updates to pulse fitting to improve performance for 2018 PbPb
2. Add repass for the pulse fitting to reduce the effect of the low energy peak (lower than 1n peak) which is due to the large pile-up events.
3. Improve the baseline matching performance for delayed and undelayed samples.
4. Change the 2018 fit function to "FermiExpLinear".
5. Update standalone test files in "tools" folder.https://gitlab.cern.ch/atlas/athena/-/merge_requests/38526ZDC development branch to be merged into 21.02021-03-24T15:24:21+01:00Pengqi YinZDC development branch to be merged into 21.0Merge development branch "21.0-ZDC-OnlyCopyZdcAnalysis" into 21.0. The branch contains the latest edits from 21.2. The 21.2 version was last updated and MR-approved 3 months ago. Here is the link: https://gitlab.cern.ch/atlas/athena/-/me...Merge development branch "21.0-ZDC-OnlyCopyZdcAnalysis" into 21.0. The branch contains the latest edits from 21.2. The 21.2 version was last updated and MR-approved 3 months ago. Here is the link: https://gitlab.cern.ch/atlas/athena/-/merge_requests/35558
These changes include:
1. Updates to pulse fitting to improve performance for 2018 PbPb
2. Add repass for the pulse fitting to reduce the effect of the low energy peak (lower than 1n peak) which is due to the large pile-up events.
3. Improve the baseline matching performance for delayed and undelayed samples.
4. Change the 2018 fit function to "FermiExpLinear".
5. Update standalone test files in "tools" folder.
6. Fraction calculation for LGOverflows.
Now we are updating the 21.0 ZDCAnalysis to be consistent with the latest version on 21.2.
@steinberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66885ZDC configuration files for webdisplay development2023-11-09T18:33:00+01:00Peter Alan SteinbergZDC configuration files for webdisplay developmentThis MR adds simple configuration files for DQM webdisplay development for the output of ForwardDetectors/ZDC/ZdcMonitoring. These just add the ZDC config directory and one histogram in the output, but they will be substantially expande...This MR adds simple configuration files for DQM webdisplay development for the output of ForwardDetectors/ZDC/ZdcMonitoring. These just add the ZDC config directory and one histogram in the output, but they will be substantially expanded in the next week or so.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68026ZDC config should not configure GeoModelSvc directly2024-01-07T02:06:20+01:00Tadej Novaktadej.novak@cern.chZDC config should not configure GeoModelSvc directlyZDC config should not configure (legacy) `GeoModelSvc` directly.ZDC config should not configure (legacy) `GeoModelSvc` directly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58070ZdcConditions: make ZdcLucrodMapRun3 singleton const2022-11-04T18:15:20+01:00Frank WinklmeierZdcConditions: make ZdcLucrodMapRun3 singleton constMake the `ZdcLucrodMapRun3` singleton const and DO NOT disable the
thread-checker.
cc @steinberMake the `ZdcLucrodMapRun3` singleton const and DO NOT disable the
thread-checker.
cc @steinberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70010ZdcConditions+InDetSimEvent: Fix cppcheck warnings.2024-03-21T11:39:51+01:00Scott SnyderZdcConditions+InDetSimEvent: Fix cppcheck warnings.Pass strings by const reference, not by value.Pass strings by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47065ZdcConditions: Fix clang warning.2021-10-13T15:42:28+02:00Scott SnyderZdcConditions: Fix clang warning.Unused private data member.
(Left commented-out because it's still referenced from already
commented-out code.)Unused private data member.
(Left commented-out because it's still referenced from already
commented-out code.)