athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-21T12:05:54+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68331Fix bugs in the random seeding of the JER uncertainty2024-02-21T12:05:54+01:00Christopher YoungFix bugs in the random seeding of the JER uncertainty@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data ...@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data it is more correct to use the max(MC,data) resolution. This was not anticipated when the tool was originally written but results in very small changes. Finally advanced users can set the seed themselves, but this currently set the seed the same for all jets which is not a usual use-case so this has also been modified.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68306PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/share/SUSY6.py: A...2024-01-24T12:04:01+01:00Nathan Dale YoungPhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY/share/SUSY6.py: Adding r-tag into list of SUSY6 for newly available samplesThis MR adds the r-tags of new signal samples into the list of DAOD_RPVLL samples which toggles filtering to keep the derivation sizes smaller. These samples are for the SUSY disappearing track group which relies on special reconstructio...This MR adds the r-tags of new signal samples into the list of DAOD_RPVLL samples which toggles filtering to keep the derivation sizes smaller. These samples are for the SUSY disappearing track group which relies on special reconstruction techniques.
The added r-tags are based on samples produced here: [https://its.cern.ch/jira/browse/ATLMCPROD-10493](https://its.cern.ch/jira/browse/ATLMCPROD-10493)
and here: [https://its.cern.ch/jira/browse/ATLMCPROD-10713](https://its.cern.ch/jira/browse/ATLMCPROD-10713)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68198add L1jJ160 seed since L1J100 is a legacy2024-01-18T13:34:39+01:00Tatiana Ovsiannikovaadd L1jJ160 seed since L1J100 is a legacyA small addition to Calratio triggers for next data tacking:
* Add L1jJ160 seed since L1J100 is a legacy.
* Keep L1J100 for comparison.A small addition to Calratio triggers for next data tacking:
* Add L1jJ160 seed since L1J100 is a legacy.
* Keep L1J100 for comparison.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68188Moving DiPhoton TLA L1Topo Items from MC to Physics L1 Menu2024-02-02T19:44:06+01:00Marco MontellaMoving DiPhoton TLA L1Topo Items from MC to Physics L1 MenuMoving the following L1Topo algorithm to Physics L1 Menu ahead of firmware compilation:
L1_2DR15-0M30-2eEM12L, L1_13DR25-25M70-2eEM12L
Current destination is Board Topo2, FPGA 1, clock 0.
----
Tagging @rgugel for supervisionMoving the following L1Topo algorithm to Physics L1 Menu ahead of firmware compilation:
L1_2DR15-0M30-2eEM12L, L1_13DR25-25M70-2eEM12L
Current destination is Board Topo2, FPGA 1, clock 0.
----
Tagging @rgugel for supervisionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68177test new chains for VBF HZy with invisible decay trigger ATR-284432024-01-16T16:21:11+01:00Qiuping Shentest new chains for VBF HZy with invisible decay trigger ATR-28443The merge request aims to add test chains of VBF HZy with invisible decay for ATR-28443.
We investigated dedicated triggers for VBFH HZy. The weighted PS rate and efficiency are evaluated and shown in the table. We need to know the leve...The merge request aims to add test chains of VBF HZy with invisible decay for ATR-28443.
We investigated dedicated triggers for VBFH HZy. The weighted PS rate and efficiency are evaluated and shown in the table. We need to know the level of the unique rate and cost for these under-studied triggers.![VBFH_Trig_efficiency](/uploads/af7ccf16ed81ab6fe0d23baf979b64fa/VBFH_Trig_efficiency.jpg)Qiuping ShenQiuping Shenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68166Fix missing mcChannelNumber and add BTagging to EXOT152024-01-17T10:37:01+01:00Alexander BasanFix missing mcChannelNumber and add BTagging to EXOT15Application of GRL to data events caused mcChannelNumber to disappear. Fix this by checking the SkipTriggerRequirement as for the EXOT15MCThinningTool. Add AntiKt4EMTopoJets_BTagging201810 and BTagging_AntiKt4EMTopo_201810 containers to ...Application of GRL to data events caused mcChannelNumber to disappear. Fix this by checking the SkipTriggerRequirement as for the EXOT15MCThinningTool. Add AntiKt4EMTopoJets_BTagging201810 and BTagging_AntiKt4EMTopo_201810 containers to enable BTagging.
This is for a study to extend the CalRatio analysis to include tops in the final state. Currently being done in R21. Currently there’s no b-tagging information in EXOT15, and when adding it, we found a bug affecting mcChannel, introduced some releases ago.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68161ATR-28667 - Implementation of L1Topo ZeroBias Algorithm2024-02-05T10:10:02+01:00Marco MontellaATR-28667 - Implementation of L1Topo ZeroBias AlgorithmDraft MR tracking the development of the ZeroBias Topo algorithm.
As of Jan 15, the MR only contains a skeleton C++ ZeroBiasAlg class that does nothing beyond initialisation and definition of the relevant parameters. The class was defin...Draft MR tracking the development of the ZeroBias Topo algorithm.
As of Jan 15, the MR only contains a skeleton C++ ZeroBiasAlg class that does nothing beyond initialisation and definition of the relevant parameters. The class was defined inheriting from CountingAlg, based on the eEmMultiplicity example.
> An alternative pathway would have been to define the ZeroBiasAlg class in the python configuration inheriting from MultiplicityAlgo, following the examples in [TopoAlgos.py](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Base/TopoAlgos.py#0226). If this alternative solution is in fact preferable I can easily switch.
Assuming the C++ path is correct, should the algorithm be instantiated and the parameters initialised in [TopoAlgoDefMultiplicity.py](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TopoAlgoDefMultiplicity.py)?
---
Tagging @astruebi @lidiaz @rgugel @jajimene (and @mark)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68146Added forceFullSimConfig for EGamma analysis configs for testing (ATLASG-2661)2024-01-31T18:55:56+01:00Thomas StreblerAdded forceFullSimConfig for EGamma analysis configs for testing (ATLASG-2661)Follow up to !67929, which introduced a hard error in case latest EGamma recommendations are used with fast sim samples
```
ElectronCalibra... ERROR Sample is FastSim but no AF3 calibration is available yet with es2022_R22_PRE recommen...Follow up to !67929, which introduced a hard error in case latest EGamma recommendations are used with fast sim samples
```
ElectronCalibra... ERROR Sample is FastSim but no AF3 calibration is available yet with es2022_R22_PRE recommendations. Please get in touch with the EGamma CP group in case you are using this
```
A configurable property is introduced here to force the use of full sim EGamma configs on fast sim samples for testing purposes. Clear warnings are displayed in that case.
```
if self.forceFullSimConfig:
print("WARNING! You are running ElectronWorkingPointConfig forcing full sim config")
print("WARNING! This is only intended to be used for testing purposes")
```
Configuration exploited to solve failing Analysis tests, closes ATLASG-2661https://gitlab.cern.ch/atlas/athena/-/merge_requests/68096Remove explicit enum support in AthConfigFlag and use type2024-01-10T18:42:06+01:00Tadej Novaktadej.novak@cern.chRemove explicit enum support in AthConfigFlag and use typeRemove explicit enum support in `AthConfigFlag` and use type.
Also fix argument parsing with the type checking.
/cc @fwinklRemove explicit enum support in `AthConfigFlag` and use type.
Also fix argument parsing with the type checking.
/cc @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68022Add utility for FastCaloSim standalone2024-01-08T06:56:46+01:00Joshua Falco Beirerjoshua.beirer@cern.chAdd utility for FastCaloSim standaloneNeeded includes for FastCaloSim standalone code developmentsNeeded includes for FastCaloSim standalone code developmentshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67985Set correct values for large-R truth label2024-01-09T16:57:30+01:00Chris Malena DelitzschSet correct values for large-R truth labelA bug was discovered for the large-R truth labels `R10TruthLabel_R21Precision` and `R10TruthLabel_R21Precision_2022v1` (not present in main). For these labels, the tool always defaulted back to the trimmed truth jets rather than the ungr...A bug was discovered for the large-R truth labels `R10TruthLabel_R21Precision` and `R10TruthLabel_R21Precision_2022v1` (not present in main). For these labels, the tool always defaulted back to the trimmed truth jets rather than the ungroomed truth jets `AntiKt10TruthJets` because the values were not set in the initialize function but earlier when setting up the tool which does not work. To be able to run the correct truth labelling, the splitting scale variables `Split12` and `Split23` have to be reconstructed for the `AntiKt10TruthJets` which is handled by the changes to JetCommon.
Happy holidays!
Tagging @fballi @camacho @dcamarer @mdiamant @jzahredd @rleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67981Debug Stream, Addition of New Histograms and Fixes to the transform2024-01-30T13:28:50+01:00Jennifer Rachel CurranDebug Stream, Addition of New Histograms and Fixes to the transformNew python file added that creates an empty file with the BSFile structure and changes to trigRecoExe to accommodate the additional function and to rename the empty BSFile to RAW.pool.root if no events are selected for the chosen streams...New python file added that creates an empty file with the BSFile structure and changes to trigRecoExe to accommodate the additional function and to rename the empty BSFile to RAW.pool.root if no events are selected for the chosen streams. This prevents failures at T0 when events are actually just rejected by the HLT and/or stream selection when running the TriggerTransform for debug recovery.
Addition of two new trees in HIST_DEBUGSTREAMMON.ntup.root to display :
1. The output of running the postRun step debug stream analysis on BS file that contains events after the streamSelection
2. The differences between the Pre and Post debug stream analysis steps that required the addition of new function to add the Tree and histograms that show the difference in the Pre/Pos histograms in dbgAnalysis
An existing function in dbgAnalysis was modified to add in the HLT_accepted_events histogram to HIST_DEBUGSTREAMMON.ntup.root. Some additions to trigRecoExe to accommodate these changes were made.
@wiedenma @mark ATR-26595https://gitlab.cern.ch/atlas/athena/-/merge_requests/67936Change the jet scale when computing certain jet mods2023-12-20T12:24:06+01:00Guillaume Lucas AlbouyChange the jet scale when computing certain jet modsThis MR changes the scale of the jet used in `JetConstituentFrac.cxx` and `JetGroomMRatio.cxx` to `"JetConstitScaleMomentum"` to rightly compute the jet mods. Currently the mods are not computed with a fixed scale leading to inconsistenc...This MR changes the scale of the jet used in `JetConstituentFrac.cxx` and `JetGroomMRatio.cxx` to `"JetConstitScaleMomentum"` to rightly compute the jet mods. Currently the mods are not computed with a fixed scale leading to inconsistency in jet tools.
Tagging @cdelitzs, @delsarthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67926DerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticles2023-12-19T16:00:45+01:00Bertrand Martin Dit LatourDerivationFrameworkMCTruth: keep all daughters of TruthTausWithDecayParticlesHello,
This MR changes the number of generations of daughter particles retained when building the TruthTausWithDecayParticles/TruthTausWithDecayVertices collections.
It was previously set to 1 but this can lead to pathological situation...Hello,
This MR changes the number of generations of daughter particles retained when building the TruthTausWithDecayParticles/TruthTausWithDecayVertices collections.
It was previously set to 1 but this can lead to pathological situations, e.g. when the truth tau decays to kaons: if we don't know what the kaon decays to, we cannot properly compute the truth visible tau momentum.
When set to -1, we retain all generations, and this seems to fix the problem.
A priori, we can now recompute the various decorations of TruthTaus using TruthTausWithDecayParticles/TruthTausWithDecayVertices, such as `pt/eta/phi/m_vis`, the number of neutral/charged pions, ...
We will need to rework a bit BuildTruthTaus to do this.
The only variables we don't seem to get is `polarizationPhi` and `polarizationTheta` decorations, they exist for TruthTaus but not TruthTausWithDecayParticles, however these seem to always be 0.
We'll still have to check we can rerun photon dressing for TruthTausWithDecayParticles.
Marking as urgent as we'd need this for the upcoming DAOD_PHYS production that is imminent (ATLASDPD-2017).
Tagging @ademaria and @lfiorini .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67924Fixes for ATLASRECTS-78642024-01-10T15:31:21+01:00Christos Anastopouloschristos.anastopoulos@cern.chFixes for ATLASRECTS-7864It seems
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p0960r3.html
```Allow initializing aggregates from a parenthesized list of values```
made it only to C++20 .
So the "parenthesis" troubles C++17 (what we use with gcc11)...It seems
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p0960r3.html
```Allow initializing aggregates from a parenthesized list of values```
made it only to C++20 .
So the "parenthesis" troubles C++17 (what we use with gcc11)
Let's do "old school" aggragateshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67862TrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX swit...2023-12-20T09:33:00+01:00Ondrej PencTrigConfData, TrigConfIO: update of the L1CTPFiles structure to add CTPX switch matrix.This extends the L1CTPFiles structure with the CTPX switch matrix and updates/adds associated functions.
Tested in the L1CT lab in initialL1CT and ATLAS partitions.
Important for data taking, should be tested at P1 on the week from 15 Ja...This extends the L1CTPFiles structure with the CTPX switch matrix and updates/adds associated functions.
Tested in the L1CT lab in initialL1CT and ATLAS partitions.
Important for data taking, should be tested at P1 on the week from 15 Jan 2024.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67844BPHY22: adding container to the output2023-12-18T14:51:37+01:00Laily SultanaliyevaBPHY22: adding container to the outputWith new update the container with two track candidate (BPHY22DiTrkCandidates) will be stored in the output files.With new update the container with two track candidate (BPHY22DiTrkCandidates) will be stored in the output files.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67716TrigValTools: don't check file existence when running unit tests2023-12-11T10:16:28+01:00Bertrand Martin Dit LatourTrigValTools: don't check file existence when running unit testsHello,
As realised in !67637, trigger tests using `RootMergeStep` are failing when running unit tests.
Currently, in `dry_run` mode (unit tests), the script looks for files that don't exist and returns an error.
Cheers,
BertrandHello,
As realised in !67637, trigger tests using `RootMergeStep` are failing when running unit tests.
Currently, in `dry_run` mode (unit tests), the script looks for files that don't exist and returns an error.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67710CPAlgorithms: add protections to EventSelection algorithms when running with ...2023-12-09T08:12:01+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: add protections to EventSelection algorithms when running with missing inputsEvent selectors that run on lepton collections should be allowed to run on only electrons or only muons, but not neither. This MR implements this at the C++ level in the relevant algorithms, but also offers error messages in the high-lev...Event selectors that run on lepton collections should be allowed to run on only electrons or only muons, but not neither. This MR implements this at the C++ level in the relevant algorithms, but also offers error messages in the high-level python configuration to catch wrong settings.
This is needed for the AMG PHYSLITE tutorial next week, so tagging as urgent.
~urgenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67681Patching MC23d configuration2023-12-08T11:10:53+01:00John Derek ChapmanPatching MC23d configurationSome issues were found in the first version of the MC23d configuration in !67101.
One of which could not be worked around. Unfortunately a `23.0.32.2,Athena` build will be required.
This merge request should fix them.
NB The `MC23dSimu...Some issues were found in the first version of the MC23d configuration in !67101.
One of which could not be worked around. Unfortunately a `23.0.32.2,Athena` build will be required.
This merge request should fix them.
NB The `MC23dSimulationNoIoV`, `MC23dSimulationSingleIoV`, `MC23dSimulationMultipleIoV` and
`MC23cSimulationMultipleIoVCalibrationHits` functions were not added as the simulation step will not
be re-run for MC23d. MC23c HITS will be used.
Tagging @tadej, @ewelina, @jferrand, @jmaurer, @dta, @ahabouel, @dsouth, @zmarshal, @jcatmore, @nstyles