athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:30:34+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70121TileMonitoring: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed.Legacy JO configurations have been removed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70118FTF GPU ITk: Imporve high eta efficiency2024-03-26T17:16:21+01:00Aleksandra PorebaFTF GPU ITk: Imporve high eta efficiency- Include more middle spacepoint layers for high eta
- Revise maximum doublet length cut, discussed at https://indico.cern.ch/event/1387080/#1-status-report
Related to EFTRACK-76
Tagging @demelian- Include more middle spacepoint layers for high eta
- Revise maximum doublet length cut, discussed at https://indico.cern.ch/event/1387080/#1-status-report
Related to EFTRACK-76
Tagging @demelianhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70117Pixel Calibration - adding getters and fixing typos2024-03-26T14:38:22+01:00Sergi Rodriguez BoscaPixel Calibration - adding getters and fixing typosThis MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.This MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70116Fixes for TauAntiTauJetOverlapTool2024-03-27T08:55:47+01:00Thomas StreblerFixes for TauAntiTauJetOverlapToolFollow up to !69115
Basically
```if(!m_decHelper->isSurvivingObject(*tau) || !isSurvivingAntiTau(*tau)) continue;```
should be used instead of
```if(!m_decHelper->isSurvivingObject(*tau) && !isSurvivingAntiTau(*tau)) continue;```
Adde...Follow up to !69115
Basically
```if(!m_decHelper->isSurvivingObject(*tau) || !isSurvivingAntiTau(*tau)) continue;```
should be used instead of
```if(!m_decHelper->isSurvivingObject(*tau) && !isSurvivingAntiTau(*tau)) continue;```
Added extra clean up also to remove taus failing both ID and antiTauID, to have them failing OR for sure
FYI @princke @pbokan @bmoserhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70115LArMonitoring: delete legacy job options2024-03-26T14:38:22+01:00Frank WinklmeierLArMonitoring: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70114main-cppcheck-FakeBkgTools2024-03-26T14:49:18+01:00Shaun Roemain-cppcheck-FakeBkgToolscppcheck performance defect: pass parameters by const ref instead of valuecppcheck performance defect: pass parameters by const ref instead of valuehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70113MuonDQA: remove references to Run-2 monitoring config2024-03-26T14:38:22+01:00Frank WinklmeierMuonDQA: remove references to Run-2 monitoring confighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70112ZdcMonitoring: cleanup references to legacy config2024-03-26T14:38:22+01:00Frank WinklmeierZdcMonitoring: cleanup references to legacy configRemove references to legacy config and updates link dependencies.Remove references to legacy config and updates link dependencies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70111CaloMonitoring: delete legacy job options and ROOT macros2024-03-29T10:56:12+01:00Frank WinklmeierCaloMonitoring: delete legacy job options and ROOT macrosDelete legacy job options, root macros and updates link dependencies.Delete legacy job options, root macros and updates link dependencies.Pavol StrizenecPavol Strizenechttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70109Fix CMake warning in AthSimulation builds.2024-03-26T14:38:22+01:00John Derek ChapmanFix CMake warning in AthSimulation builds.Remove `LArCalorimeter/LArCnv/LArDetMgrDetDescrCnv` from `Projects/AthSimulation/package_filters.txt`
as this package was removed from the branch in !69771.Remove `LArCalorimeter/LArCnv/LArDetMgrDetDescrCnv` from `Projects/AthSimulation/package_filters.txt`
as this package was removed from the branch in !69771.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70108Remove nullptr initialiser that causes a crashing2024-03-26T14:38:23+01:00Rui ZhangRemove nullptr initialiser that causes a crashingRemove nullptr initialiser that causes a crashing when setting SetInterOpNumThreads/SetIntraOpNumThreads Subsequent merge of [!69945 (merged)](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69945 "Prevent ONNX from spawning additio...Remove nullptr initialiser that causes a crashing when setting SetInterOpNumThreads/SetIntraOpNumThreads Subsequent merge of [!69945 (merged)](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69945 "Prevent ONNX from spawning additional threads").
```plaintext
Prevent ONNX from spawning additional threads in the FastCaloSim implementation.
Should fix ATLASSIM-7146 (and potentially ATLASSIM-7031 ?)
```
fyi @zhangr @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70107Removed all remaining references to the InputFilePeeker2024-03-26T14:13:04+01:00Vakhtang TsulaiaRemoved all remaining references to the InputFilePeekerDropped either complete files or individual functions that unconditionally relied on the `InputFilePeeker`.
Also dropped the clients of such files/functions.
Closes ATEAM-716
CC @fwinkl @harkusha @amete @ssnyder (Please feel free to t...Dropped either complete files or individual functions that unconditionally relied on the `InputFilePeeker`.
Also dropped the clients of such files/functions.
Closes ATEAM-716
CC @fwinkl @harkusha @amete @ssnyder (Please feel free to tag more people as needed. Thanks)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70104RNTupleART: Add two new tests that compare RNTuple and TTree DAODs2024-03-26T14:15:06+01:00Alaettin Serhan MeteRNTupleART: Add two new tests that compare RNTuple and TTree DAODsAdd two more tests (one for data and one for MC) to `RNTupleART` that:
1. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `TTree`,
2. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `RNTuple`,
3. Convert ...Add two more tests (one for data and one for MC) to `RNTupleART` that:
1. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `TTree`,
2. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `RNTuple`,
3. Convert 2. into `TTree` by (ab)using `Merge_tf.py`,
4. Compare both formats via `diff-root`.
For some reason `diff-root` doesn't seem to work properly in the `main--dev3LCG` in my local tests but that can be followed up independently.
cc: @gemmeren @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70103Optimization of the Trigger Menu generation: move CA generation after the ali...2024-03-28T11:30:33+01:00Francesca PastoreOptimization of the Trigger Menu generation: move CA generation after the alignment (ATR-29039)Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are ...Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are stored in self.sequenceFunctions, passed via functools.partial
2. the ChainStep has self.create() function to create the CAs when needed, and store them in the self.sequences
3. all loops on self.sequences must be replaced by self.sequenceFucntions
4. in the alignment, use isEmptySequenceCfg to recognise an empty sequence
5. Changes in the emulation tests to use functools.partial
6. Changes in the jet and MET signatures code to handle functools.partial
7. the NoAlg chains that run PEBInfoWriter appears with one step during the sequence generation, so this requires a change in isNoAlg() function
Configuration comparison:
`Run with arguments: confTool.py --diff HLTJobOptions.json ../test_orig/HLTJobOptions.json Step 1: reference file #components: 79030 Step 2: file to check #components: 79030 Legend: Differences in components Settings in 1st file Settings in 2nd file Component PerfMonMTSvc may differ wallTimeOffset = 1711385097450.0 vs 1711129147120.0 << but all are suppressed by renaming/known differences/...`https://gitlab.cern.ch/atlas/athena/-/merge_requests/70102AthenaCommon: refactor --profile-python option2024-03-28T17:16:23+01:00Frank WinklmeierAthenaCommon: refactor --profile-python optionRefactor the code needed to dump python profiles into the `Debugging` module and re-use it in legacy athena and CA. The dump of the temporary profile for `--drop-and-reload` is no longer needed either if we dump the profile before the re...Refactor the code needed to dump python profiles into the `Debugging` module and re-use it in legacy athena and CA. The dump of the temporary profile for `--drop-and-reload` is no longer needed either if we dump the profile before the reload (and the second part of the job has no interesting profile data anyway).
cc @wlampl @smhhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70101Fix FPGASim workflow test to use input RDO from CVMFS2024-03-27T19:37:25+01:00Tomasz BoldFix FPGASim workflow test to use input RDO from CVMFSCloses EFTRACK-504
This MR improves FPGASim testing scriptCloses EFTRACK-504
This MR improves FPGASim testing scripthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70100Added maxParallelismExtra setting to AvalancheSchedulerSvcCfg2024-03-26T14:38:23+01:00Simone Sottocornolasimone.sottocornola@cern.chAdded maxParallelismExtra setting to AvalancheSchedulerSvcCfgIncreased maxParallelismExtra to 1 when the flag Trigger.enableAsyncIO is set in TriggerUnixStandardSetup.py, as\
discussed in [ATR-26285](https://its.cern.ch/jira/browse/ATR-26285).
Tested in TBed, everything is working fine.Increased maxParallelismExtra to 1 when the flag Trigger.enableAsyncIO is set in TriggerUnixStandardSetup.py, as\
discussed in [ATR-26285](https://its.cern.ch/jira/browse/ATR-26285).
Tested in TBed, everything is working fine.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70099Clean-up of MDTSimHit.h2024-03-26T14:12:38+01:00John Derek ChapmanClean-up of MDTSimHit.hWas previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.Was previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70098Extend TRT_HitCollectionCnv unit tests2024-03-26T14:15:27+01:00John Derek ChapmanExtend TRT_HitCollectionCnv unit testsThis merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.This merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70097remove legacy python config files form Calorimeter/CaloCnv2024-03-26T14:38:23+01:00Walter Lamplremove legacy python config files form Calorimeter/CaloCnvThe title says it all ..The title says it all ..