athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-06-08T16:14:42+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/54068Revert "Replacement of InDetTestBLayer with InDetTestPixelLayer"2022-06-08T16:14:42+02:00Benjamin Philip KerridgeRevert "Replacement of InDetTestBLayer with InDetTestPixelLayer"This reverts merge request !53927 (Replacement of InDetTestBLayer with InDetTestPixelLayer)
See ATR-25682This reverts merge request !53927 (Replacement of InDetTestBLayer with InDetTestPixelLayer)
See ATR-25682https://gitlab.cern.ch/atlas/athena/-/merge_requests/53985Adding chains to primary as requested in ATR-256572022-06-06T17:10:21+02:00Debottam Bakshi GuptaAdding chains to primary as requested in ATR-25657As mentioned in ATR-25657 this MR adds required chains in the primary menu. Adding @khoo and @sshawAs mentioned in ATR-25657 this MR adds required chains in the primary menu. Adding @khoo and @sshawhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53576TrigMuonEventTPCnv+TrigTruthEventTPCnv: enable thread-checker and fixes2022-05-24T09:47:23+02:00Frank WinklmeierTrigMuonEventTPCnv+TrigTruthEventTPCnv: enable thread-checker and fixesEnable thread-checker and fix/suppress warnings.Enable thread-checker and fix/suppress warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53377Sweeping !53318 from master to 22.0-mc20.remove default options from objective2022-05-23T17:29:29+02:00Atlas NightlybuildSweeping !53318 from master to 22.0-mc20.remove default options from objectiveremove default options from objective
Closes ATLASRECTS-7035
See merge request atlas/athena!53318remove default options from objective
Closes ATLASRECTS-7035
See merge request atlas/athena!53318https://gitlab.cern.ch/atlas/athena/-/merge_requests/53334README: Remove deleted branches, add 22.02022-05-20T15:08:56+02:00Rafal Bielskirafal.bielski@cern.chREADME: Remove deleted branches, add 22.0Removing deleted branches 21.1 and 21.3 from README list of branches and adding the new branch 22.0.
This is the first MR opened to the new branch 22.0, aimed also at testing the CI and sweep infrastructure, see ATLINFR-4546Removing deleted branches 21.1 and 21.3 from README list of branches and adding the new branch 22.0.
This is the first MR opened to the new branch 22.0, aimed also at testing the CI and sweep infrastructure, see ATLINFR-4546https://gitlab.cern.ch/atlas/athena/-/merge_requests/53340Use GetClassification instead of GetResponse (MVAUtils) for Tau Trigger FTF BDT2022-05-20T12:27:10+02:00Bertrand Martin Dit LatourUse GetClassification instead of GetResponse (MVAUtils) for Tau Trigger FTF BDTHello,
This MR is fixing a regression-vs-classification misconfiguration of a BDT classifier used in tau triggers.
Currently, we evaluate a BDT classifier in "regression mode", with the GetResponse function of MVAUtils being called.
How...Hello,
This MR is fixing a regression-vs-classification misconfiguration of a BDT classifier used in tau triggers.
Currently, we evaluate a BDT classifier in "regression mode", with the GetResponse function of MVAUtils being called.
However, for a classifier, this returns BDT scores that are not within the usual [0,1] range.
And this leads to buggy behaviour in TrigTauTrackRoiUpdater, where we intend to select the track with the highest BDT score, but we assume the BDT score is always positive (BDTMax variable initialised to 0).
As a consequence, unless we are lucky to get a track with a BDT score above 0 in the tauCore ROI of the Fast Track Finder, we fail to update the ROI for the tauIso step.
In particular, the zedMinus and zedPlus of the tauIso ROI are not set to +/-7 mm, but we rather inherit the settings from the tauCore ROI, i.e. we scan again along the whole z axis in the tauIso step, which must waste CPU.
This MR is changing the behaviour to "classification mode", which takes the sigmoid of GetResponse and ensures the output is within [0,1].
The reference file is updated with fixed trigger counts.
A BDT helper method was added to tauRecTools. As the other such methods, all it does is sort the variables in the expected order as defined in the input ROOT file.
Tagging @iriu , @adsalvad , @gipezzul , @ademaria .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53384TileByteStream: Fix test configuration.2022-05-19T19:38:47+02:00Scott SnyderTileByteStream: Fix test configuration.Update for changes in tile configuration: need to disable Geant4 version check.
Update reference files.
Fixes test failure in master.Update for changes in tile configuration: need to disable Geant4 version check.
Update reference files.
Fixes test failure in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53341Add TRT and Pixel PID information when creating track particles (sweep from m...2022-05-18T14:25:16+02:00Goetz GayckenAdd TRT and Pixel PID information when creating track particles (sweep from master).manual sweep of MR !53027 from master to 22.0.
Add TRT and Pixel PID information directly to track particles rather
than first adding the information to the track summary, For statistically
combined muon track particles compute pixel P...manual sweep of MR !53027 from master to 22.0.
Add TRT and Pixel PID information directly to track particles rather
than first adding the information to the track summary, For statistically
combined muon track particles compute pixel PID, but only copy TRT PID
information over from the input track particles (original behaviour).
For the code path not starting from tracks only the default Pixel and
TRT PID values are set (tracks are needed to run the PID).https://gitlab.cern.ch/atlas/athena/-/merge_requests/53273xAOD, clang-tidy related fixes2022-05-16T21:27:42+02:00Christos Anastopouloschristos.anastopoulos@cern.chxAOD, clang-tidy related fixesxAOD, clang-tidy related fixes, another passxAOD, clang-tidy related fixes, another passhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53078ForwardRegionProperties: Enable thread-safety checking.2022-05-10T09:58:26+02:00Scott SnyderForwardRegionProperties: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52602MuonMDTCabling - Do not cout chars2022-04-27T08:02:39+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonMDTCabling - Do not cout charsCloses ATLASRECTS-6998Closes ATLASRECTS-6998https://gitlab.cern.ch/atlas/athena/-/merge_requests/52409TrigInDetAnalysisUser: Suppress clang14 warnings from ROOT headers.2022-04-22T08:43:06+02:00Scott SnyderTrigInDetAnalysisUser: Suppress clang14 warnings from ROOT headers.Suppress clang14 warnings from ROOT headers.Suppress clang14 warnings from ROOT headers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51995Component accumulator in DAODs - part 3a: common physics augmentations2022-04-21T13:47:16+02:00James CatmoreComponent accumulator in DAODs - part 3a: common physics augmentationsThis large merge request is a migration of the tracking, muon and e-gamma common augmentations applied and saved in DAODs, including PHYS and PHYSLITE, to the component accumulator. It also provides a migrated version of PHYS. Since ever...This large merge request is a migration of the tracking, muon and e-gamma common augmentations applied and saved in DAODs, including PHYS and PHYSLITE, to the component accumulator. It also provides a migrated version of PHYS. Since every tool used needs a new configuration fragment it is necessary to create a number of new files containing these config methods. A few packages that didn't previously have python directories now have python configs so this has required adding an extra line to the CMakeFiles so that the modules can be found. However, since this is completely new python and only runs with the new Derivation_tf transform, it does not impact any existing DAODs built using Reco_tf.
Concretely the following has been added:
- new configs for all of the inner detector track augmentation tools
- new configs for all of the muon augmentation tools
- new configs for all of the e-gamma augmentation tools
These are all summoned from the PhysCommonConfig fragment, which itself is called from PHYS/PHYSLITE and any other formats that need to use it. The truth setup is directly in PhysCommonConfig.
As things stand the following are missing:
- migration of jets
- taus/flavour tagging
- trigger matching information
Without these last three items the version of PHYS produced by this MR clearly isn't yet usable for physics, but can be validated for the tracking, muon and e-gamma domains. For this reason the MR is being put in for merging now, to avoid it becoming too large, since the remaining work will probably involve touching at least as many files again.
The following items are marked "TODO" because it isn't clear yet how to deal with them in the component accumulator and/or ConfigFlags:
- `InDetFlags` are being used in the inner detector configuration. With what should these be replaced? Specifically `AddPseudoTracks`, `DecoLRTTTVA` and `MergeLRT`
- How should we handle the `IsoTrackCones` in the muon configuration?
- How should we correctly determine and then flag the simulation flavour?
- TruthMetaDataWriter fails due to missing /TagInfo
Consequently there are blocks of commented python corresponding to these items, which need to remain until we have solution (at which point they can be uncommented and migrated). I'll create JIRAs for these over the coming days.
Finally, the thinning machinery appears to be broken in CA (including in the example `TEST3`). I'll follow this up separately.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50448Test lhe2022-04-12T14:40:31+02:00Danning LiuTest lhesolved the memory leak in TestLHE package and also blocking the functions in the packagesolved the memory leak in TestLHE package and also blocking the functions in the packageEwelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51914Sweeping !51883 from 21.6 to 22.0-mc20.
Make particle gun samples have the co...2022-04-07T14:17:25+02:00Atlas NightlybuildSweeping !51883 from 21.6 to 22.0-mc20.
Make particle gun samples have the correct masses (GeV to MeV change)Make particle gun samples have the correct masses (GeV to MeV change)
See merge request atlas/athena!51883Make particle gun samples have the correct masses (GeV to MeV change)
See merge request atlas/athena!51883https://gitlab.cern.ch/atlas/athena/-/merge_requests/51842TrigHTTSGInput: Adapt for hepmc3.2022-04-04T21:08:45+02:00Scott SnyderTrigHTTSGInput: Adapt for hepmc3.Fixes to compile with hepmc3.Fixes to compile with hepmc3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/5110422.0-cleanup3-PixelDigitization2022-03-14T10:30:14+01:00Shaun Roe22.0-cleanup3-PixelDigitizationfurther refactor of PixelDigitization, pushing common class-independent functions to a separate 'PixelDigitizationUtilities' and introducing unit tests to test them. This is a step in achieving ATLASSIM-5615.further refactor of PixelDigitization, pushing common class-independent functions to a separate 'PixelDigitizationUtilities' and introducing unit tests to test them. This is a step in achieving ATLASSIM-5615.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50714Draft: Implementation of jXE class2022-03-10T15:59:38+01:00Jack HarrisonDraft: Implementation of jXE classChanges implemented:
- Addition of jXE TOB and jXE TOB Array classes
- Changing EnergyInputProviderFEX and Types.cxx to enable jXE TOB.
- Changing TopoInputEvent to use jXE
- Changed the jXE MET to be used within JetInputProviderFEX
- Di...Changes implemented:
- Addition of jXE TOB and jXE TOB Array classes
- Changing EnergyInputProviderFEX and Types.cxx to enable jXE TOB.
- Changing TopoInputEvent to use jXE
- Changed the jXE MET to be used within JetInputProviderFEX
- Disabling MET from EnergyInputProviderFEX (WIP)
Tagging @paulama @orlando @iriu @asonay @cmorenom
ATR-24653https://gitlab.cern.ch/atlas/athena/-/merge_requests/51098TgcRawDataMonitoring: Fix gcc8 warnings.2022-03-10T12:37:12+01:00Scott SnyderTgcRawDataMonitoring: Fix gcc8 warnings.Spurious semicolons.Spurious semicolons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50609Include Tau Reco into RecoSteering2022-03-03T11:25:50+01:00Walter LamplInclude Tau Reco into RecoSteeringFollow-up to !49968: Include the CA-based Tau-Reconstruction to RecoSteering.py
While testing this, I ran into the following error:
`IOVDbFolder 0 0 ERROR Tag CaloH1WeightsCone4Topo-02...Follow-up to !49968: Include the CA-based Tau-Reconstruction to RecoSteering.py
While testing this, I ran into the following error:
`IOVDbFolder 0 0 ERROR Tag CaloH1WeightsCone4Topo-02-000 cannot be resolved for folder /CALO/H1Weights/H1WeightsCone4Topo`
Current RecExCommon-based reco doesn't set a folder-level tag but resolves the folder like
`INFO HVS tag CONDBR2-BLKPA-RUN2-09 resolved to CaloH1WeightsCone4Topo-RUN2-02-000 for folder /CALO/H1Weights/H1WeightsCone4Topo`
Question to @adbailey : Why to we set a folder level tag in the new style tau config?