athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-26T14:38:23+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70074AFP monitoring update code style2024-03-26T14:38:23+01:00Viktoriia LysenkoAFP monitoring update code styleAFP monitoring, dqm algorithms: update code style + bug fixAFP monitoring, dqm algorithms: update code style + bug fixViktoriia LysenkoViktoriia Lysenkohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70073fix StepName2024-03-26T14:38:24+01:00Tatiana Ovsiannikovafix StepNameremove the chain name in the stepName definition for Calratio hypos (ATR-29044)remove the chain name in the stepName definition for Calratio hypos (ATR-29044)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70070Fixed clang warnings2024-03-23T14:35:53+01:00Vakhtang TsulaiaFixed clang warnings1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variable1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variablehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70069Fix for the multi-threaded event service configuration2024-03-26T14:38:23+01:00Vakhtang TsulaiaFix for the multi-threaded event service configurationWith this change, the multi-threaded event service can be activated by
the combination of the `--multithreaded=True` and the `--eventService=True`
command-line arguments of the job transform
The reason why we submit this MR to the ~"24....With this change, the multi-threaded event service can be activated by
the combination of the `--multithreaded=True` and the `--eventService=True`
command-line arguments of the job transform
The reason why we submit this MR to the ~"24.0" branch is because we may need
to run the next round of Event Service / Raythena validations with one of the
upcoming 24.0.X releases.
CC @juesseivhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70068Run the TIDA Tier0 monitoring correctly2024-03-26T14:38:24+01:00Mark SuttonRun the TIDA Tier0 monitoring correctlyWasn't running because the hist service was not being configured correctly
Fixes ATR-28759Wasn't running because the hist service was not being configured correctly
Fixes ATR-28759https://gitlab.cern.ch/atlas/athena/-/merge_requests/70066Inclusion of grid tests for GPUs and fix of build test for GPUCalo2024-03-24T11:20:31+01:00Denis Oliveira DamazioInclusion of grid tests for GPUs and fix of build test for GPUCaloContinuing on the direction of ATR-28790. Inclusion of grid tests for GPUs and fix of build test for GPU Calo.Continuing on the direction of ATR-28790. Inclusion of grid tests for GPUs and fix of build test for GPU Calo.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70065CPAlgorithms: updated experimental OverlapRemoval2024-03-25T14:51:10+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: updated experimental OverlapRemovalNew overlap removal scheme based on the nominal-OR decision, but run also for systematically-varied kinematic selections.
This is for experimental tests only at this stage, tagging @mdubovsk @ekourlit. I tested it locally on a small sam...New overlap removal scheme based on the nominal-OR decision, but run also for systematically-varied kinematic selections.
This is for experimental tests only at this stage, tagging @mdubovsk @ekourlit. I tested it locally on a small sample, and I see the intended behaviour in one electron event: the branch `el_select_or` is set to 1, and at the same time we have `el_select_loose_NOSYS` (the nominal ID+Iso+Pt+Eta cuts) set to 0, and all but one systematic variations also set to 0. Using the previous setup (run nominal-OR only, and only on the nominal kinematic selection), this electron event is not present at all.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70063Extend SiHitCollectionCnv unit tests2024-03-25T14:49:56+01:00John Derek ChapmanExtend SiHitCollectionCnv unit testsThis merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).This merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70062Adding truth labels to HLT Jets2024-03-26T10:28:07+01:00Stefano FranchellucciAdding truth labels to HLT JetsAdding FTag truth labels to HLT jets in the derivation framework. This is going to be needed for tagger calibrations (`FTAG1` and `FTAG2`), for `TLA` analysis studies, and in general for validation `PHYSVAL`.
Tagging some interested peo...Adding FTag truth labels to HLT jets in the derivation framework. This is going to be needed for tagger calibrations (`FTAG1` and `FTAG2`), for `TLA` analysis studies, and in general for validation `PHYSVAL`.
Tagging some interested people @yuchou @mamerl @mmontell @dguest @bdong @ligang @lshi @lbeemstehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70061IDTrig: do not switch on TRT with ITk, deal with InDet/ITk eta dependant cuts2024-03-26T14:38:24+01:00Jiri MasikIDTrig: do not switch on TRT with ITk, deal with InDet/ITk eta dependant cutsfix ATR-29043
signature specific setting/optimization applied also in case of ITk (Xi2Max*,RoadWidth,DoPhiFiltering)
LRT settings may evolve into a separate function once there is a need to differentiate between signaturesfix ATR-29043
signature specific setting/optimization applied also in case of ITk (Xi2Max*,RoadWidth,DoPhiFiltering)
LRT settings may evolve into a separate function once there is a need to differentiate between signatureshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70060Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only...2024-03-26T14:38:23+01:00Will ButtingerUpdate eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only...Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only xtobs have the bcn4 bits in them to identify which slice they are from)Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only xtobs have the bcn4 bits in them to identify which slice they are from)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70059Add unit test for FPGATrackSim and fix workflow for analysis on wrapper file2024-03-23T12:07:13+01:00Jahred Adelmanjahreda@gmail.comAdd unit test for FPGATrackSim and fix workflow for analysis on wrapper fileFix for https://gitlab.cern.ch/atlas/athena/-/merge_requests/69990Fix for https://gitlab.cern.ch/atlas/athena/-/merge_requests/69990https://gitlab.cern.ch/atlas/athena/-/merge_requests/70058PROCTools: warn when updating existing references2024-03-22T17:22:01+01:00Frank WinklmeierPROCTools: warn when updating existing referencesAdd a warning to `update_ci_reference_files.py` in case the user tries to overwrite existing references as happened on ATLASRECTS-7944.
cc @atlas-release-coordinatorsAdd a warning to `update_ci_reference_files.py` in case the user tries to overwrite existing references as happened on ATLASRECTS-7944.
cc @atlas-release-coordinatorshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70057L1calo monitoring improvements2024-03-26T14:38:23+01:00Will ButtingerL1calo monitoring improvementsCleaned up the sim-hw comparison algorithms
added new profile2d (extendable) histogram to monitor average efex tob ets over time.Cleaned up the sim-hw comparison algorithms
added new profile2d (extendable) histogram to monitor average efex tob ets over time.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70053AnalysisTop Main: Move maxCycle vector in parseCutBookkeepers function to be ...2024-03-22T14:18:43+01:00Thomas James StevensonAnalysisTop Main: Move maxCycle vector in parseCutBookkeepers function to be indexed correctlyAnalysisTop: Move maxCycle vector in parseCutBookkeepers function to be indexed correctly. Closes ANALYSISTO-1384AnalysisTop: Move maxCycle vector in parseCutBookkeepers function to be indexed correctly. Closes ANALYSISTO-1384https://gitlab.cern.ch/atlas/athena/-/merge_requests/70052MagicNumbers.h: Adding new HepMC::UNDEFINED_ID constant (ATLASSIM-6906)2024-03-22T14:19:43+01:00John Derek ChapmanMagicNumbers.h: Adding new HepMC::UNDEFINED_ID constant (ATLASSIM-6906)Adding new `HepMC::UNDEFINED_ID` constant to `TruthUtils/MagicNumbers.h` replace `Barcode::fUndefinedBarcode` from `BarcodeEvent/Barcode.h`.
Will migrate clients in a separate merge request.
Part of the work for ATLASSIM-6906.Adding new `HepMC::UNDEFINED_ID` constant to `TruthUtils/MagicNumbers.h` replace `Barcode::fUndefinedBarcode` from `BarcodeEvent/Barcode.h`.
Will migrate clients in a separate merge request.
Part of the work for ATLASSIM-6906.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70051CPAlgorithms: MC-specific containers in the output config2024-03-24T10:59:59+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: MC-specific containers in the output configAs requested by @katharin, this MR enables a new option `containersOnlyForMC` in the Output config block, allowing to schedule the writing out of containers defined only on MC and not on data (e.g. truth particles). A natural follow-up t...As requested by @katharin, this MR enables a new option `containersOnlyForMC` in the Output config block, allowing to schedule the writing out of containers defined only on MC and not on data (e.g. truth particles). A natural follow-up to https://gitlab.cern.ch/atlas/athena/-/merge_requests/69702.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70050TRTProcessingOf(Barrel/Endcap)Hits clean-up of error message2024-03-22T14:20:24+01:00John Derek ChapmanTRTProcessingOf(Barrel/Endcap)Hits clean-up of error messageVery minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.Very minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70049Generators: add missing + operator in Sherpa_i2024-03-22T14:21:21+01:00Christian GutschowGenerators: add missing + operator in Sherpa_i... to fix AGENE-2266
cc @ewelina... to fix AGENE-2266
cc @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70048Adding more test chains for delayed jets2024-03-26T14:38:23+01:00Lucas BezioAdding more test chains for delayed jetsAs discussed on [28836](https://its.cern.ch/jira/browse/ATR-28836), chains requiring 2 delayed jets are added and copies of timing-based chains with upper limit are added.As discussed on [28836](https://its.cern.ch/jira/browse/ATR-28836), chains requiring 2 delayed jets are added and copies of timing-based chains with upper limit are added.