athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-04-11T03:02:21+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20002introduce CaloNoiseCondAlg + Obj2019-04-11T03:02:21+02:00Walter Lamplintroduce CaloNoiseCondAlg + ObjMigrated from MR 15653 in athenaprivate1
Replacement of public AlgTool CaloNoiseToolDbMigrated from MR 15653 in athenaprivate1
Replacement of public AlgTool CaloNoiseToolDbhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20003Updating copyright and private licences2018-12-20T03:02:58+01:00Edward MoyseUpdating copyright and private licencesThis should remove the mistakes that crept back in. Need to compile before accepting.This should remove the mistakes that crept back in. Need to compile before accepting.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20005Propagate xAOD::EventInfo from digitization step onwards2020-10-07T15:12:36+02:00Tadej Novaktadej.novak@cern.chPropagate xAOD::EventInfo from digitization step onwards**Migrated from old repository MR 16270.**
Propagate xAOD::EventInfo from digitization step onwards:
- write it out after digi, overlay and trigger steps
- ensure we do a deep copy when needed so we remove the `const` requirement
I upd...**Migrated from old repository MR 16270.**
Propagate xAOD::EventInfo from digitization step onwards:
- write it out after digi, overlay and trigger steps
- ensure we do a deep copy when needed so we remove the `const` requirement
I updated all job options with the exception of the following:
_Followed-up separately:_
TileCalibAlgs/share/jobOptions_TileInfoDumpOFLP200.py
TileRecEx/share/jobOptions_TileCalibRec.py
_Not updated:_
AthenaPoolTools/EventCount_jobOptions.py — running on EVNT
CaloCondBlobAlgs/CaloNoiseDbExample_read.py
LArCafJobs/skeleton.LArCAF.py — data only
LArCafJobs/skeleton.LArNoise_fromraw.py — data only
LArCalibTools/LArPulseShapeRun.py — data only
LArExample/LArCalib_Delay_OFC_Cali_jobOptions.py — data only
LArExample/LArCalib_PedestalAutoCorr_jobOptions.py — data only
LArExample/LArCalib_Ramp_jobOptions.py — data only
LArROD/LArOFCIter2Ntuple.py — data only
MuonCalibJobTransforms/skeleton.mdt_calib_ntuple.py — data only
MuonCalibJobTransforms/skeleton.mdt_calib_ntuple_tf.py — data only
CaloD3PDMaker/MakeSCLArHitD3PD_topOptions.py — running on HITS
TileCalibAlgs/jobOptions_OFC2DBTest.py — data only
TileCalibAlgs/jobOptions_TileExpertDump.py — data only
TileCalibAlgs/jobOptions_TileInfoDump.py — data only
TileRec/jobOptions_TileEventFilter.py — I do not want to complicate it
TileSimEx/jobOptions_Tile_Dig.py — running on HITS
TileMonitoring/TileRec_topOptions.py — data only
TileMonitoring/jobOptions_TileLasMon.py — data only
TileMonitoring/jobOptions_TileTBMon.py — data only
TileRecAlgs/jobOptions_TileEventSelector.py — data only
TrigCostMonitor/readTrigCost.py — data only
TrigSteering/pureSteering_jobOptions.py — data only
TrigT1CaloCalibUtils/LArL1CaloRampMaker.py — data only
TrigT1CaloCalibUtils/TileL1CaloRampMaker.py — data only
This is slightly ~"frozen-tier0-violating", although it should not affect physics. Disabling sweep as we want to do this differently in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20006Merge branch 'Remove_MA27' into '21.0'2019-01-29T18:13:09+01:00Walter LamplMerge branch 'Remove_MA27' into '21.0'Manual cherry-pick to fix compilation failure in 21.0-mc16a
Remove MA27 and clean up private member variables
See merge request atlas/athenaprivate1!11334Manual cherry-pick to fix compilation failure in 21.0-mc16a
Remove MA27 and clean up private member variables
See merge request atlas/athenaprivate1!11334https://gitlab.cern.ch/atlas/athena/-/merge_requests/20007Merge branch 'Remove_MA27' into '21.0'2019-01-30T03:02:44+01:00Walter LamplMerge branch 'Remove_MA27' into '21.0'Fix compilation faiure in 21.0-mc16d branch
Remove MA27 and clean up private member variables
See merge request atlas/athenaprivate1!11334Fix compilation faiure in 21.0-mc16d branch
Remove MA27 and clean up private member variables
See merge request atlas/athenaprivate1!11334https://gitlab.cern.ch/atlas/athena/-/merge_requests/20008migrate PileUpEventInfo to xAOD::EvenInfo2019-02-13T03:02:35+01:00Marcin Nowakmigrate PileUpEventInfo to xAOD::EvenInfoMigrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633Migrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633https://gitlab.cern.ch/atlas/athena/-/merge_requests/20009Add Tau slice for Physics Validation ART2018-12-20T03:03:36+01:00Alexander MannAdd Tau slice for Physics Validation ARTAdding Tau slice (and Summary) for weekly PhysVal tests in ART.Adding Tau slice (and Summary) for weekly PhysVal tests in ART.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20010ATR-19246 TriggerMT Decision Encoding in ESD Update2019-01-09T17:56:59+01:00Tim MartinATR-19246 TriggerMT Decision Encoding in ESD UpdateThis persists in the trigger output a `HLTSummary`, and then in the ESD a `xAOD::TrigDecision` object the bit-set which corresponds to fired triggers in the new MT prototype. cc @tbold @bwynne
It hacks a short-term hard-coded fudge i...This persists in the trigger output a `HLTSummary`, and then in the ESD a `xAOD::TrigDecision` object the bit-set which corresponds to fired triggers in the new MT prototype. cc @tbold @bwynne
It hacks a short-term hard-coded fudge into the trigger configuration service in order to obtain `ChainCounters`. cc @mark @fwinkl @stelzer
* Remove my recently added extension to the TrigDecision EDM. Disk-space wise, this was not going to work, sadly.
* Update downstream clients of `DecisionSummaryMakerAlg` within the trigger (signatureMoni, streaming, bit-encoding in HLTResult)
* Update `TrigDecisionMakerMT` to read all HLT summaries from one collection, `DecisionSummaryMakerAlg`'s `HLTSummary`
* Update transient HLT seeding information written by `L1Decoder`, call this `L1DecoderSummary` everywhere.
* Copy TrigCost end-of-event trigger fire to `DecisionSummaryMakerAlg`
* Remove the output from the `TriggerSummaryAlg` - this now just prints to terminal
* Hack the TrigConfSvc to allow hard-coded chains to be injected in the short term, for testing.
(note known problem with egamma test, will try and fix that now too - but in its own MR)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20011manual sweep into master of 16464 from athenaprivate12018-12-21T03:03:01+01:00Miha Muskinjamiha.muskinja@cern.chmanual sweep into master of 16464 from athenaprivate1This is a manual sweep of https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16464#note_2176697 from the old repo into master.
The base class of StepHistogramTool needed to be migrated to `UserActionToolBase` from `ActionToolBas...This is a manual sweep of https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16464#note_2176697 from the old repo into master.
The base class of StepHistogramTool needed to be migrated to `UserActionToolBase` from `ActionToolBaseReport`. This had some consequences, namely:
- StepHistogramTool.h has now much less lines of code
- results are accumulated in a different way: https://gitlab.cern.ch/atlas/athena/blob/91ab1c0d7b87e1cae72df085639ee5b1c94592b9/Simulation/G4Utilities/G4DebuggingTools/src/StepHistogramTool.cxx#L58 compared to previously used
`mergeReports();`
- preInclude does not longer specify ['Step']: https://gitlab.cern.ch/atlas/athena/blob/91ab1c0d7b87e1cae72df085639ee5b1c94592b9/Simulation/G4Utilities/G4DebuggingTools/share/preInclude.StepHistogram.py#L11 like in the 21.0 code:
`simFlags.OptionalUserActionList.addAction('G4UA::StepHistogramTool', ['Step'])`https://gitlab.cern.ch/atlas/athena/-/merge_requests/20012Remove athena-app2018-12-20T03:02:53+01:00Stewart Martin-HaughRemove athena-appathena-app appears not to have been used for a while, and it cannot run AthExHelloWorld without crashing.athena-app appears not to have been used for a while, and it cannot run AthExHelloWorld without crashing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20013Adds an option to turn on range cuts for gamma processes (conv, phot, compt)2019-02-15T14:07:13+01:00Miha Muskinjamiha.muskinja@cern.chAdds an option to turn on range cuts for gamma processes (conv, phot, compt)A simple preInclude that turns on range cuts for conv, phot, compt processes:
`--preInclude='SimulationJobOptions/preInclude.GammaRangeCuts.py'`A simple preInclude that turns on range cuts for conv, phot, compt processes:
`--preInclude='SimulationJobOptions/preInclude.GammaRangeCuts.py'`https://gitlab.cern.ch/atlas/athena/-/merge_requests/20014G4 passback working in ISF MT2019-12-11T03:02:02+01:00Benjamin Michael WynneG4 passback working in ISF MTAdded a mechanism for returning secondaries to SimKernelMT, rather than going through particle broker.
Currently returns identical results to the non-MT version, if you modify non-MT with the following postExec command:
```
--postEx...Added a mechanism for returning secondaries to SimKernelMT, rather than going through particle broker.
Currently returns identical results to the non-MT version, if you modify non-MT with the following postExec command:
```
--postExec "svcMgr.ISF_ParticleBrokerSvcNoOrdering.ParticleOrderingTool='ISF__EnergyParticleOrderingTool';svcMgr.ISF_ParticleBrokerSvcNoOrdering.AlwaysUseGeoIDSvc=True"
```
This command orders the particle queue in a predictable way.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20016new AF2 resolution systematics and update of resolution parameterization for ...2019-01-19T00:40:40+01:00Guillaume Unalnew AF2 resolution systematics and update of resolution parameterization for es2017_R21_v1updated consolidated recommendations for egamma calibration for es2017_R21_v1 model
- updated energy resolution parameterization
- added extra pileup related systematics on energy scale (few 10**-4) and energy resolution (up to few 10**-...updated consolidated recommendations for egamma calibration for es2017_R21_v1 model
- updated energy resolution parameterization
- added extra pileup related systematics on energy scale (few 10**-4) and energy resolution (up to few 10**-3)
- new systematics on energy resolution for AF2 to cover approximatively the AF2-FullSim differences that cannot be correctly compensated by change in smearing correctionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20019Fix two problems with thread/slot safety in the CutFlowSvc2018-12-21T03:02:48+01:00Jack CranshawFix two problems with thread/slot safety in the CutFlowSvcFix two problems with thread/slot safety in the CutFlowSvc
- Move the reading of EventInfo weights from the service to the only client
AthFilterAlgorithm
- add a mutex to the addEvent method called by AthFilterAlgorithm
...Fix two problems with thread/slot safety in the CutFlowSvc
- Move the reading of EventInfo weights from the service to the only client
AthFilterAlgorithm
- add a mutex to the addEvent method called by AthFilterAlgorithm
https://its.cern.ch/jira/browse/ATLASRECTS-4693https://gitlab.cern.ch/atlas/athena/-/merge_requests/20020Delete obsolete CMT-related packages2018-12-20T03:02:46+01:00Frank WinklmeierDelete obsolete CMT-related packagesThe following packages were only relevant for CMT-based releases and can be removed:
- LCG_Interfaces/Boost
- LCG_Interfaces/CLHEP
- PackDist
- ReleaseTests
This has been discussed with @obreshko and @akraszna.The following packages were only relevant for CMT-based releases and can be removed:
- LCG_Interfaces/Boost
- LCG_Interfaces/CLHEP
- PackDist
- ReleaseTests
This has been discussed with @obreshko and @akraszna.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20021Moving eta-phi correction for HIJetRec to calibration area (ATLHI-233 and ATL...2019-03-15T15:49:00+01:00Martin RybarMoving eta-phi correction for HIJetRec to calibration area (ATLHI-233 and ATLINFR-2834)- moving eta-phi correction to cvmfs area
- adding a flag to explicitly enable/disable the correction
- disable the correction for HIP mode (pp and pPb)
- no changes in jet performance reconstruction
- tagging also @angerami- moving eta-phi correction to cvmfs area
- adding a flag to explicitly enable/disable the correction
- disable the correction for HIP mode (pp and pPb)
- no changes in jet performance reconstruction
- tagging also @angeramihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20022additional plotting option added2019-02-15T14:07:13+01:00Sanya Solodkovadditional plotting option addedExtra functionality added in standalone python script which plots calibration constants from COOL DBExtra functionality added in standalone python script which plots calibration constants from COOL DBhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20023New map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEff...2019-01-03T11:24:25+01:00Philip SommerNew map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEfficiencyCorrectionChanges related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 diel...Changes related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 dielectron trigger which was accidentally prescaled for a short period in 2017, see discussion in ATR-17746
- a small example how the scale factors for 2e17 can be used in TrigGlobalEfficiencyCorrection
Cheers,
Philip and @jmaurer, @thrynova, @fernandohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20024Adding MM and STGC clusterization packages for the NSW, with interfaces and e...2019-01-09T01:50:13+01:00Stefano RosatiAdding MM and STGC clusterization packages for the NSW, with interfaces and example toolsThis merge request provides a structure to be followed in the future to implement the cluster builders tools, that will have various developers.
We also have a first version of the "simple" cluster builder, right now implemented in th...This merge request provides a structure to be followed in the future to implement the cluster builders tools, that will have various developers.
We also have a first version of the "simple" cluster builder, right now implemented in the converters, this will be added as soon as this merge request is merged. But this will also imply modifying the clients, so a few more packages involved, it is neater to stage the two MR's.
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/CMakeLists.txt
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/MMClusterization/IMMClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/SimpleMMClusterBuilderTool.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/SimpleMMClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/components/MMClusterization_entries.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/components/MMClusterization_load.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/CMakeLists.txt
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/STgcClusterization/ISTgcClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/SimpleSTgcClusterBuilderTool.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/SimpleSTgcClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/components/STgcClusterization_entries.cxxhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20025add dynamic variables for monitoring L2StandAloneMuon2018-12-20T03:02:50+01:00Yohei Yamaguchiadd dynamic variables for monitoring L2StandAloneMuonAdding variables in TrigL2MuonSA for monitoring L2StandAloneMuon as dynamic variables.
Also modifying TriggerEDM config to store them into AODSLIM.Adding variables in TrigL2MuonSA for monitoring L2StandAloneMuon as dynamic variables.
Also modifying TriggerEDM config to store them into AODSLIM.