athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T18:10:14+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70196Valkyrie: delete legacy job options and executable2024-03-28T18:10:14+01:00Frank WinklmeierValkyrie: delete legacy job options and executableDelete the legacy job options to configure `ValgrindSvc`. Also delete
the (hopefully) unused `valkyrie.py` script. Our transforms support
running valgrind so this should no longer be needed.
Update documentation and apply some name chan...Delete the legacy job options to configure `ValgrindSvc`. Also delete
the (hopefully) unused `valkyrie.py` script. Our transforms support
running valgrind so this should no longer be needed.
Update documentation and apply some name changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70186MuonTesterTree - Fix linker error2024-03-28T14:32:54+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonTesterTree - Fix linker errorCloses ATLASRECTS-7946Closes ATLASRECTS-7946https://gitlab.cern.ch/atlas/athena/-/merge_requests/70183Propagate logger for ACTS vertex2024-03-28T14:36:18+01:00Carlo Varnicarlo.varni@cern.chPropagate logger for ACTS vertex@gfrattar noticed we were not properly propagating the logger to the ACTS vertexing tools. This should fix it@gfrattar noticed we were not properly propagating the logger to the ACTS vertexing tools. This should fix ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70181Fix bug in han configuration merging2024-03-28T11:30:32+01:00Peter OnyisiFix bug in han configuration mergingFix issue introduced in !69798 (without this fix offline DQ configurations will not be built properly)Fix issue introduced in !69798 (without this fix offline DQ configurations will not be built properly)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70177Clean up deprecated RobustReco tracking mode2024-03-28T17:48:43+01:00Thomas StreblerClean up deprecated RobustReco tracking modeRelevant for ATLASRECTS-7947Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70173TriggerJobOpts: move HepMcParticleLink silencing to runHLTCfg2024-03-28T10:58:01+01:00Bertrand Martin Dit LatourTriggerJobOpts: move HepMcParticleLink silencing to runHLTCfgHello,
This MR is moving the workaround used to silence "HepMcParticleLink warnings" (ATR-21838) from athenaCfg to runHLTCfg, as the latter is called by RDOtoRDO_TRIG_Skeleton (https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruct...Hello,
This MR is moving the workaround used to silence "HepMcParticleLink warnings" (ATR-21838) from athenaCfg to runHLTCfg, as the latter is called by RDOtoRDO_TRIG_Skeleton (https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/RecJobTransforms/python/RDOtoRDO_TRIG_Skeleton.py#L69). Otherwise, the warning masking is not scheduled, and we get plenty in our log files.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70170Added selection decoration block config for CP algs2024-03-28T15:39:35+01:00Thomas StreblerAdded selection decoration block config for CP algsFollow up to !69110, which moved the `AsgSelectionAlg` run at the end of the object working point configs to schedule them as part of the `OutputAnalysis` config block. In order to allow for analysis-specific algorithms to be inserted be...Follow up to !69110, which moved the `AsgSelectionAlg` run at the end of the object working point configs to schedule them as part of the `OutputAnalysis` config block. In order to allow for analysis-specific algorithms to be inserted before the `OutputAnalysis` config and rely on the decorations saved by those algorithms, a dedicated `SelectionDecoration` block is added, to be run before the analysis-specific algorithms.
FYI @omajersk @krumnack @jolamberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70169Only run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)2024-03-28T14:34:30+01:00Thomas StreblerOnly run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245https://gitlab.cern.ch/atlas/athena/-/merge_requests/70167TileMonitoring: Remove old Tile monitoring tools for physics events2024-03-28T14:48:59+01:00Siarhei HarkushaTileMonitoring: Remove old Tile monitoring tools for physics eventsOld (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.Old (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70166TrigHLTJetHypo - on request of the menu decelopers, make Tool names unique wi...2024-03-28T10:55:45+01:00Peter SherwoodTrigHLTJetHypo - on request of the menu decelopers, make Tool names unique within a chain onlyUntil now, each AlgTool type which was part of the jet hypo system received a unique (for the Tool type)
index to be used in the name of the tool. Now, these indices are set to 0 for each chain. The full name
of each tool is associated ...Until now, each AlgTool type which was part of the jet hypo system received a unique (for the Tool type)
index to be used in the name of the tool. Now, these indices are set to 0 for each chain. The full name
of each tool is associated with a parent tool. The top level tool contains the chain name, so each
fully qualified name is unique.
ATR-29041
@khoo @tbold @fpastore @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70165Update Enhanced Bias menu for 20242024-03-28T10:54:19+01:00Aleksandra PorebaUpdate Enhanced Bias menu for 2024- Move L1_6jJ40 (VeryHigh) to L1_5jJ40p0ETA25 (High) because the 6j item was removed from the menu
- Use L1_eEM18M_2eTAU20M_jXE70 as a replacement for L1_EM15VHI_2TAU12IM_XE35 (previously wrong item)
- Use L1_2eEM18 as a replacement for ...- Move L1_6jJ40 (VeryHigh) to L1_5jJ40p0ETA25 (High) because the 6j item was removed from the menu
- Use L1_eEM18M_2eTAU20M_jXE70 as a replacement for L1_EM15VHI_2TAU12IM_XE35 (previously wrong item)
- Use L1_2eEM18 as a replacement for L1_2EM15 instead of L1_2eEM18L (the rate L1_2eEM18L was too low for medium category)
Tagging @astruebi @lidiaz @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70164Add CA-based configuration for the FastIDKiller2024-03-28T16:41:23+01:00John Derek ChapmanAdd CA-based configuration for the FastIDKillerInitial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.Initial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70162Remove info messages from UTT hypos and L2LayerNumberTool2024-03-28T10:51:03+01:00Benjamin Philip KerridgeRemove info messages from UTT hypos and L2LayerNumberToolMessages were being printed in initialize from hypo tools and TrigL2LayerNumberingTool. Not relevant in normal operation. Converting to debug
ATR-28980 ATR-28978Messages were being printed in initialize from hypo tools and TrigL2LayerNumberingTool. Not relevant in normal operation. Converting to debug
ATR-28980 ATR-28978https://gitlab.cern.ch/atlas/athena/-/merge_requests/70160fix Large R accessor in jet calibration2024-03-28T17:50:11+01:00Frederic Rennerfix Large R accessor in jet calibrationI ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet ca...I ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet calibrations that might need different truth labels. @khoo
https://its.cern.ch/jira/browse/ATLJETMET-1714https://gitlab.cern.ch/atlas/athena/-/merge_requests/70159TileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T14:49:22+01:00Siarhei HarkushaTileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileTBRec package.Legacy JO configurations have been removed from TileTBRec package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70158athena.py: allow --config-only without storing config (legacy)2024-03-28T11:30:32+01:00Frank Winklmeierathena.py: allow --config-only without storing config (legacy)For legacy athena, allow the use of `--config-only` without specifying
a filename to make it compatible with CA-mode.
Also fix a bug introduced in !70102 when using `--config-only`.For legacy athena, allow the use of `--config-only` without specifying
a filename to make it compatible with CA-mode.
Also fix a bug introduced in !70102 when using `--config-only`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70157TileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T13:59:15+01:00Siarhei HarkushaTileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileCosmicAlgs package.Legacy JO configurations have been removed from TileCosmicAlgs package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70155TileMonitoring: Update Tile online monitoring script for cosmics2024-03-28T11:30:33+01:00Siarhei HarkushaTileMonitoring: Update Tile online monitoring script for cosmicsScript to run online Tile monitoring has been modified to
add possibility to monitor onlline events from cosmics streams seperately,
and to increase events buffer sizes of monitoring tasks for online monitoring.Script to run online Tile monitoring has been modified to
add possibility to monitor onlline events from cosmics streams seperately,
and to increase events buffer sizes of monitoring tasks for online monitoring.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70154athena.py: remove defaults for concurrency arguments (legacy)2024-03-28T14:33:43+01:00Frank Winklmeierathena.py: remove defaults for concurrency arguments (legacy)Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job opti...Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job options running.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70153Restored 2016MC15C MMC CalibSet for validation2024-03-27T17:55:12+01:00Thomas StreblerRestored 2016MC15C MMC CalibSet for validationFollow up to !65640
Restore 2016MC15C tuning as 2019 tuning seems to have some unexpected effect in bbtautau analysis (see slide 4 https://indico.cern.ch/event/1397000/contributions/5871927/attachments/2825319/4935154/20240322_HbbHtauta...Follow up to !65640
Restore 2016MC15C tuning as 2019 tuning seems to have some unexpected effect in bbtautau analysis (see slide 4 https://indico.cern.ch/event/1397000/contributions/5871927/attachments/2825319/4935154/20240322_HbbHtautau_FrameworkMeeting.pdf )
Will be used for validation purposes
FYI @ademaria @jdegens @bmoser @pbokan