athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-25T14:01:59+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70082LArByteStrean+LArCondAthenaPool: remove legacy job options2024-03-25T14:01:59+01:00Frank WinklmeierLArByteStrean+LArCondAthenaPool: remove legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70024Draft: RNTuple reading improvements2024-03-22T10:43:14+01:00Marcin NowakDraft: RNTuple reading improvementsRepeating previous RNTuple update (!69909 - rolled back) but without MetaReader changes - they were causing issues with AnalysisBase.
Now this MR should only affect dev3 RNTuple nightlies.
Removed redundant #includes
Cache RNTuple...Repeating previous RNTuple update (!69909 - rolled back) but without MetaReader changes - they were causing issues with AnalysisBase.
Now this MR should only affect dev3 RNTuple nightlies.
Removed redundant #includes
Cache RNTupleView objects so they are not recreated every read
MetaReader update rolled back and postponed for a subsequent MRhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69972TrigEFMissingET CMake Fixes, main branch (2024.03.20.)2024-03-20T15:24:56+01:00Attila KrasznahorkayTrigEFMissingET CMake Fixes, main branch (2024.03.20.)This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the co...This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the component library would see the [LWTNN](https://github.com/lwtnn/lwtnn) headers reliably, `${LWTNN_INCLUDE_DIRS}` also needs to be used.
The reason I noticed these mistakes is because of the "serious warnings" in the latest nightlies.
https://bigpanda.cern.ch/nview/?nightly=main_Athena_x86_64-el9-gcc13-opt
![image](/uploads/e0908bc1f653f0f135c80032b903351c/image.png)
Something that the shifters should've really picked up on... :frowning:https://gitlab.cern.ch/atlas/athena/-/merge_requests/69537Draft: Delete legacy DumpGeo configs2024-03-13T14:51:10+01:00Thomas StreblerDraft: Delete legacy DumpGeo configshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69455Update GenericMonitoringTool.py - default ymin and ymax values when specifyin...2024-03-04T22:46:13+01:00Will ButtingerUpdate GenericMonitoringTool.py - default ymin and ymax values when specifying...Update GenericMonitoringTool.py - default ymin and ymax values when specifying ylabels, if not specifiedUpdate GenericMonitoringTool.py - default ymin and ymax values when specifying ylabels, if not specifiedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69336Fix decoration type clash for isSplit.2024-02-29T10:45:37+01:00Goetz GayckenFix decoration type clash for isSplit.Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDa...Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDataToxAOD, PixelNtupleMaker use the
same type.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68774Remove legacy skeletons for HITtoRDO and RDOMerge2024-02-14T16:10:27+01:00John Derek ChapmanRemove legacy skeletons for HITtoRDO and RDOMergeThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmoreThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68468Fixed clang warnings in two packages2024-01-31T12:18:15+01:00Vakhtang TsulaiaFixed clang warnings in two packages1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variables1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variableshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66971Draft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells2023-11-13T22:55:04+01:00Denis Oliveira DamazioDraft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cellsFor the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.
(I created another one to avoid mixing with LAr changes)For the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.
(I created another one to avoid mixing with LAr changes)https://gitlab.cern.ch/atlas/athena/-/merge_requests/66965ATLINFR-5141 : Let's keep it simple for gcc112023-11-08T15:07:52+01:00Christos Anastopouloschristos.anastopoulos@cern.chATLINFR-5141 : Let's keep it simple for gcc11ATLINFR-5141 : Let's keep it simple for gcc11.
Since we have only 2 special cases lets be explicit.ATLINFR-5141 : Let's keep it simple for gcc11.
Since we have only 2 special cases lets be explicit.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65819Update TableUtils.h:Coverity 19500, trapping divide by zero2023-09-15T14:41:37+02:00Shaun RoeUpdate TableUtils.h:Coverity 19500, trapping divide by zeroTrapping clause was on numerator, should be on denominator to catch divide-by-zeroTrapping clause was on numerator, should be on denominator to catch divide-by-zerohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63952Modified SCT wafer threshold for DQ histogram for run3 in v222023-08-02T13:29:56+02:00Sayuka KitaModified SCT wafer threshold for DQ histogram for run3 in v22Hit requirement for inner silicon tracker was changed 7 to 8 in run3. Because of this, SCT hit requirement for DQ monitoring histogram was changed 3 to 4 in athena v23.0. But v22.0 has not changed yet, so I modified like as v23.0.
@granc...Hit requirement for inner silicon tracker was changed 7 to 8 in run3. Because of this, SCT hit requirement for DQ monitoring histogram was changed 3 to 4 in athena v23.0. But v22.0 has not changed yet, so I modified like as v23.0.
@grancagn @csanderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63948Improve message of the expression parser if type information is missing.2023-08-02T13:27:53+02:00Goetz GayckenImprove message of the expression parser if type information is missing.- Suggest to provide missing type information to property of the top level
algorithm sequence, in case no type information is available for a
certain variable.
- Distinguish between missing type information and missing inheritance
...- Suggest to provide missing type information to property of the top level
algorithm sequence, in case no type information is available for a
certain variable.
- Distinguish between missing type information and missing inheritance
information.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63947Set inheritance information for TrackMeasurementValidation.2023-08-02T11:18:58+02:00Goetz GayckenSet inheritance information for TrackMeasurementValidation.The inheritance information is need to allow using a xAOD::TrackValidationMeasurement container in expressions passed to the ExpressionParser.
This is used by the luminosity determination based on PixelCluster counting.The inheritance information is need to allow using a xAOD::TrackValidationMeasurement container in expressions passed to the ExpressionParser.
This is used by the luminosity determination based on PixelCluster counting.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63857Configure the ACTS geometry tool in legacy trigger via wrapped CA [ATR-27768]2023-06-26T17:51:00+02:00Teng Jian KhooConfigure the ACTS geometry tool in legacy trigger via wrapped CA [ATR-27768]While working on !61235, I encountered a clash between a statically defined tool configuration returned by `ConfiguredActsTrackingGeometry` (building Pixel only) and a full configuration originating from the CA-based HLT jet tracking ins...While working on !61235, I encountered a clash between a statically defined tool configuration returned by `ConfiguredActsTrackingGeometry` (building Pixel only) and a full configuration originating from the CA-based HLT jet tracking instance:
```
AthenaConfiguration.ComponentAccumulator.ConfigurationError: Failed merging new config value (['Pixel', 'SCT']) and old config value (['Pixel']) for the (BuildSubDetectors) property of ActsTrackingGeometrySvc/ActsTrackingGeometrySvc (ActsTrackingGeometrySvc/ActsTrackingGeometrySvc) old (new).
```
This could be resolved by replacing the `ConfiguredActsTrackingGeometry` call with the proper `ActsTrackingGeometryToolCfg` taking the tracking instance `ConfigFlags`. It might be possible to remove this function and the containing file `​ActsTrackingGeometryTool.py` entirely, as it was only called from this one place.
Note: labelled ~"sweep:ignore" because the ACTS packages/files have been renamed in master.
FYI @sutthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63426Update MCTruthClassifierGen.cxx2023-06-02T12:10:59+02:00Andrii VerbytskyiUpdate MCTruthClassifierGen.cxxA small addition to https://gitlab.cern.ch/atlas/athena/-/merge_requests/63393.A small addition to https://gitlab.cern.ch/atlas/athena/-/merge_requests/63393.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63402Draft: Better MetaCont problems detection and reporting in OutputStream2023-06-02T10:01:41+02:00Marcin NowakDraft: Better MetaCont problems detection and reporting in OutputStreamExisting code in the OutputStream was only checking if a MetaCont was found, but not if the object retrieved from it was not null.
Added this check and also error code propagation to the caller.Existing code in the OutputStream was only checking if a MetaCont was found, but not if the object retrieved from it was not null.
Added this check and also error code propagation to the caller.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62146move to git 2.12 in .devcontainer for vscode2023-04-11T23:43:26+02:00Ruggero Turramove to git 2.12 in .devcontainer for vscodeIn the Docker image used by vscode (`.devcontainer/Dockerfile`) we setup git 2.5 which is very old (2015?). This is quite annoying if you are using extensions as gitlens, who require newer version.
Here I am moving to git 2.12, which is,...In the Docker image used by vscode (`.devcontainer/Dockerfile`) we setup git 2.5 which is very old (2015?). This is quite annoying if you are using extensions as gitlens, who require newer version.
Here I am moving to git 2.12, which is, as a far as I know the latest available on SCLo (not sure why we are using that, @akraszna ?). Take into account that `lsetup git` now setup 2.39
This is targeting ~master, an identical MR (!62254) is targeting ~"23.0"https://gitlab.cern.ch/atlas/athena/-/merge_requests/62128Draft: Cleanup printouts in OldSpclMcFilterTool.cxx2023-04-11T19:51:06+02:00Andrii VerbytskyiDraft: Cleanup printouts in OldSpclMcFilterTool.cxxCleanup printouts in OldSpclMcFilterTool.cxx
Tag @jchapmanCleanup printouts in OldSpclMcFilterTool.cxx
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61820RootStorageSvc: cmake fix2023-03-24T16:12:30+01:00Scott SnyderRootStorageSvc: cmake fixUndefined/unneeded macro.Undefined/unneeded macro.