athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:46:18+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70157TileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:46:18+01:00Siarhei HarkushaTileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileCosmicAlgs package.Legacy JO configurations have been removed from TileCosmicAlgs package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70183Propagate logger for ACTS vertex2024-03-28T11:45:53+01:00Carlo Varnicarlo.varni@cern.chPropagate logger for ACTS vertex@gfrattar noticed we were not properly propagating the logger to the ACTS vertexing tools. This should fix it@gfrattar noticed we were not properly propagating the logger to the ACTS vertexing tools. This should fix ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70177Clean up deprecated RobustReco tracking mode2024-03-28T10:53:27+01:00Thomas StreblerClean up deprecated RobustReco tracking modeRelevant for ATLASRECTS-7947Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70169Only run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)2024-03-28T10:51:58+01:00Thomas StreblerOnly run HLTJetFTagDecoration if trigger included (ATLSWUPGR-245)Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245Follow up to !700062
Solves PHYSVAL crashes when no trigger is present as in Run 4 tests ATLSWUPGR-245https://gitlab.cern.ch/atlas/athena/-/merge_requests/70159TileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T10:50:40+01:00Siarhei HarkushaTileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileTBRec package.Legacy JO configurations have been removed from TileTBRec package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70174adding NSW combined offline DQ2024-03-28T10:32:18+01:00Michela Bigliettiadding NSW combined offline DQthis package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.this package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70150PyUtils: Make ##Params storage technology explicit2024-03-28T10:28:42+01:00Grigori RybkinPyUtils: Make ##Params storage technology explicitTools/PyUtils/python/AthFileLite.py: Extract file GUID in a more Pythonic way
Tools/PyUtils/python/MetaReader.py: idem
Related to ATEAM-960Tools/PyUtils/python/AthFileLite.py: Extract file GUID in a more Pythonic way
Tools/PyUtils/python/MetaReader.py: idem
Related to ATEAM-960https://gitlab.cern.ch/atlas/athena/-/merge_requests/70170Added selection decoration block config for CP algs2024-03-28T09:59:16+01:00Thomas StreblerAdded selection decoration block config for CP algsFollow up to !69110, which moved the `AsgSelectionAlg` run at the end of the object working point configs to schedule them as part of the `OutputAnalysis` config block. In order to allow for analysis-specific algorithms to be inserted be...Follow up to !69110, which moved the `AsgSelectionAlg` run at the end of the object working point configs to schedule them as part of the `OutputAnalysis` config block. In order to allow for analysis-specific algorithms to be inserted before the `OutputAnalysis` config and rely on the decorations saved by those algorithms, a dedicated `SelectionDecoration` block is added, to be run before the analysis-specific algorithms.
FYI @omajersk @krumnack @jolamberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70160fix Large R accessor in jet calibration2024-03-28T09:41:26+01:00Frederic Rennerfix Large R accessor in jet calibrationI ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet ca...I ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet calibrations that might need different truth labels. @khoo
https://its.cern.ch/jira/browse/ATLJETMET-1714https://gitlab.cern.ch/atlas/athena/-/merge_requests/70167TileMonitoring: Remove old Tile monitoring tools for physics events2024-03-28T09:16:55+01:00Siarhei HarkushaTileMonitoring: Remove old Tile monitoring tools for physics eventsOld (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.Old (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70144PMGSystematicsTools: migrated from the legacy AthFile to MetaReader2024-03-28T08:53:43+01:00Vakhtang TsulaiaPMGSystematicsTools: migrated from the legacy AthFile to MetaReaderRelated to ATEAM-528Related to ATEAM-528https://gitlab.cern.ch/atlas/athena/-/merge_requests/70154athena.py: remove defaults for concurrency arguments (legacy)2024-03-28T08:35:04+01:00Frank Winklmeierathena.py: remove defaults for concurrency arguments (legacy)Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job opti...Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job options running.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70139Less verbose output from BTaggingEfficiencyTool2024-03-27T17:54:32+01:00Dan GuestLess verbose output from BTaggingEfficiencyToolWe should probably only print a lot of info if the user asks for a lot of info.We should probably only print a lot of info if the user asks for a lot of info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69780Adding SUSY20 derivation format2024-03-26T17:12:03+01:00Alessandro Salaalessandro.sala@cern.chAdding SUSY20 derivation formatSUSY20 derivation format is needed by compressed SUSY analyses aiming to exploit both Run-2 and Run-3 data. The format is obtained by upgrading the one already existing in R21 and makes use of a tool that will be added by the linked merg...SUSY20 derivation format is needed by compressed SUSY analyses aiming to exploit both Run-2 and Run-3 data. The format is obtained by upgrading the one already existing in R21 and makes use of a tool that will be added by the linked merge request (currently pending). Code lines in the python scripts that are commented out refer to variables/tools not needed for the moment but that will be restored once all compressed SUSY analyses will join the effort in R24.
Tagging also @tlarihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69870Cherry-pick 4846494a to 23.02024-03-18T12:26:01+01:00Chad Stephen LantzCherry-pick 4846494a to 23.0Manual sweep of !69676 to 23.0 : ZDC RPD centroid max ADC fixManual sweep of !69676 to 23.0 : ZDC RPD centroid max ADC fixhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69871ZDC Monte Carlo Truth Algorithm2024-03-18T12:02:36+01:00Chad Stephen LantzZDC Monte Carlo Truth AlgorithmAdds MC truth from CaloCalibrationHits to ZdcRec and ZdcNtupleAdds MC truth from CaloCalibrationHits to ZdcRec and ZdcNtuplehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69878Changed ZDC module placement to allow for the RPD foot2024-03-18T10:16:13+01:00Chad Stephen LantzChanged ZDC module placement to allow for the RPD footMoved module placement to within each module to give the RPD information about the mother volume so the RPD foot could extend to the bottom of the volume.Moved module placement to within each module to give the RPD information about the mother volume so the RPD foot could extend to the bottom of the volume.