athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-07T20:51:16+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69498Exclude items without root streamers.2024-03-07T20:51:16+01:00Goetz GayckenExclude items without root streamers.Do not attempt to write decorations for which necessary root
streamers are missing.
The problem may occur when trying to write AODs in the same job which also runs InDetPhysValMonitoring.
(In principle it would be possible to add the n...Do not attempt to write decorations for which necessary root
streamers are missing.
The problem may occur when trying to write AODs in the same job which also runs InDetPhysValMonitoring.
(In principle it would be possible to add the necessary root streamer, but one decoration uses vectors of std::tuple for which root seems to create an incorrect streamer. The latter problem can be worked around, but if there is no need to have these decorations in the AOD, it is rather recommended to not support decorations using non-simple types)https://gitlab.cern.ch/atlas/athena/-/merge_requests/69496AODFix+RecoFix: delete obsolete legacy packages2024-03-07T20:51:17+01:00Frank WinklmeierAODFix+RecoFix: delete obsolete legacy packagesDelete obsolete legacy `AODFix` and `RecoFix` packages that were used in RecExCommon.
Relates to ATLASRECTS-7896.Delete obsolete legacy `AODFix` and `RecoFix` packages that were used in RecExCommon.
Relates to ATLASRECTS-7896.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69495Update FTAG derivation ART branch2024-03-07T20:51:17+01:00Binbin DongUpdate FTAG derivation ART branchNo need to run derivation ART test in 23.0 thus removing.No need to run derivation ART test in 23.0 thus removing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69493DigitizationTests ART: Fix repeated output file names between tests2024-03-07T20:51:17+01:00John Derek ChapmanDigitizationTests ART: Fix repeated output file names between testsThis merge request fixes the issue of matching output file names being used in multiple tests which was causing problems when updating fixed reference files - see ATLASSIM-7095.
Also increased the number of events for Run 2 (2018) tests...This merge request fixes the issue of matching output file names being used in multiple tests which was causing problems when updating fixed reference files - see ATLASSIM-7095.
Also increased the number of events for Run 2 (2018) tests to match the other years.
The changes here are only to ART scripts, so there will be no affect on the CI output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69492xAODTruthCnv: delete legacy job options2024-03-07T20:51:17+01:00Frank WinklmeierxAODTruthCnv: delete legacy job optionsDelete legacy `xAODTruthCnv` configuration.Delete legacy `xAODTruthCnv` configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69491athena.py: remove imports of RecFlags and BeamFlags2024-03-06T19:09:12+01:00Frank Winklmeierathena.py: remove imports of RecFlags and BeamFlagsRemove the import of the deprecated `RecFlags` and `BeamFlags`.Remove the import of the deprecated `RecFlags` and `BeamFlags`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69479InDetSecVtxFinder + DerivationFrameworkHiggs + TrigT1CaloByteStream: Fix xAOD...2024-03-06T00:27:10+01:00Alaettin Serhan MeteInDetSecVtxFinder + DerivationFrameworkHiggs + TrigT1CaloByteStream: Fix xAOD namespace typosFixing a few xAOD namespace typos I found during a random LXR search. I'm pushing this to `24.0` so that it can also get automatically swept into `main`.Fixing a few xAOD namespace typos I found during a random LXR search. I'm pushing this to `24.0` so that it can also get automatically swept into `main`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69475Added Medium12/20/30/35 cTAU isolation WPs2024-03-08T23:01:52+01:00Jean Yves Beaucampjean.yves.beaucamp@cern.chAdded Medium12/20/30/35 cTAU isolation WPsThis MR adds dedicated isolation WPs for the `cTAU12M`, `cTAU20M`, `cTAU30M`, and `cTAU35M` L1 items, in the context of ATR-28641. They're all set to the same value for now; the final tuning will be ready in the next weeks.
Aside from t...This MR adds dedicated isolation WPs for the `cTAU12M`, `cTAU20M`, `cTAU30M`, and `cTAU35M` L1 items, in the context of ATR-28641. They're all set to the same value for now; the final tuning will be ready in the next weeks.
Aside from the implementation of the separate thresholds, two additional pending changes were introduced:
- The check for L <= M <= T in the isolation WPs was removed since the isolation performance is not easily comparable in terms of the cut values for the `isolation` and `jTAUCoreScale` parameters.
- The implementation of the isolation check in the HLT seeding and the L1Topo simulation was replaced with one that's analogous to the current L1Topo firmware implementation, where a specific isolation WP is checked for each item. Previously, an _isolation number_ was set to the _tightest_ isolation that passed for each RoI, similar to how the eTAUs and other eFEX RoIs are treated.
I attached the L1Menu json file to the Jira ticket.
Tagging @astruebi, @lidiaz, @gipezzul, @rgugel.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69468ATR-28412 VBF+Displaced chains for DPJ searches2024-03-06T19:09:12+01:00Zhongyukun Xuzhongyukun.xu@cern.chATR-28412 VBF+Displaced chains for DPJ searchesAdding new msonly muon + VBF jets trigger
Adding new calratio + VBF jets trigger
Adding calratio with different log R cutAdding new msonly muon + VBF jets trigger
Adding new calratio + VBF jets trigger
Adding calratio with different log R cuthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69465Remove legacy Pool TPCnv test job options2024-03-06T00:27:09+01:00Frank WinklmeierRemove legacy Pool TPCnv test job optionsAll TPCnv tests have been migrated to CA. Remove the support for these tests in `AthenaPoolUtilities` and remove all unused legacy job options.
Relates to ATLASRECTS-7896.All TPCnv tests have been migrated to CA. Remove the support for these tests in `AthenaPoolUtilities` and remove all unused legacy job options.
Relates to ATLASRECTS-7896.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69464Asynchronous I/O in HltEventLoopMgr: copy to new class2024-03-28T14:18:14+01:00Stewart Martin-HaughAsynchronous I/O in HltEventLoopMgr: copy to new classCopy of Rafal Bielski's changes from !59680 ATR-26285. Since this is a near-complete rewrite of HltEventLoopMgr, make this a configurable change with the new flag `Trigger.enableAsyncIO`. This should allow easier testing and swapping out...Copy of Rafal Bielski's changes from !59680 ATR-26285. Since this is a near-complete rewrite of HltEventLoopMgr, make this a configurable change with the new flag `Trigger.enableAsyncIO`. This should allow easier testing and swapping out, particularly given the currently unsolved problems with timeouts. Once these are understood, we can rename HltAsyncEventLoopMgr to HltEventLoopMgr and just keep it as the default.
cc @ssottoco @fwinkl
Cheers,
Stewarthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69454post_tpcnvtest.sh: Drop suppression of warnings about failed import of Digiti...2024-03-06T19:09:12+01:00John Derek Chapmanpost_tpcnvtest.sh: Drop suppression of warnings about failed import of DigitizationFlagsDrop suppression of warnings about failed import of DigitizationFlags in `post_tpcnvtest.sh`to find any remaining unit tests which try to import it.
Also remove a number of job options files which import DigitizationFlags, but are not i...Drop suppression of warnings about failed import of DigitizationFlags in `post_tpcnvtest.sh`to find any remaining unit tests which try to import it.
Also remove a number of job options files which import DigitizationFlags, but are not included anywhere else in the repository.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69453ID trigger: simplify and decouple ID and ITk sequence code2024-03-07T20:51:15+01:00Jiri MasikID trigger: simplify and decouple ID and ITk sequence codeuse common base class for the sequence code and ID /ITk specifics in subclasses
ATR-26732use common base class for the sequence code and ID /ITk specifics in subclasses
ATR-26732https://gitlab.cern.ch/atlas/athena/-/merge_requests/69452Adding Scan WP chains to dev2024-03-06T19:09:12+01:00Lucas BezioAdding Scan WP chains to devAs mentionned in [ATR-28870](https://its.cern.ch/jira/browse/ATR-28870). A scan of WP needs to be done to understand the Rate-WP relation for fastDIPS+GN1 & fastGN2+GN2 configuration of the bjet tagging in HLT.
Tagging @lshi @lbeemste @...As mentionned in [ATR-28870](https://its.cern.ch/jira/browse/ATR-28870). A scan of WP needs to be done to understand the Rate-WP relation for fastDIPS+GN1 & fastGN2+GN2 configuration of the bjet tagging in HLT.
Tagging @lshi @lbeemste @cpollardhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69451TrigValSteering: fix adding flags to transform preExec2024-03-04T23:05:02+01:00Frank WinklmeierTrigValSteering: fix adding flags to transform preExecCherry-pick this fix from ~main into ~"24.0" as no problems have been observed there.
See merge request atlas/athena!69371
(cherry picked from commit dcb7d660a6be451d55f19948dccebd3ad2241b33)
0845ae9a TrigValSteering: fix adding flags...Cherry-pick this fix from ~main into ~"24.0" as no problems have been observed there.
See merge request atlas/athena!69371
(cherry picked from commit dcb7d660a6be451d55f19948dccebd3ad2241b33)
0845ae9a TrigValSteering: fix adding flags to transform preExechttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69439Fix histogram plotting config files to be usable for ITk and ID monitoring2024-03-04T23:05:02+01:00Mark SuttonFix histogram plotting config files to be usable for ITk and ID monitoringThe ITk has a wider eta range, and more Si layers, so the histogram ranges
need to be set accordingly.
**NB: THESE FILES ARE NOT READ OR COMPILED BY ATHENA, OR IN ANY CI TEST**
they are used ONLY for the histogram building in the ID Tr...The ITk has a wider eta range, and more Si layers, so the histogram ranges
need to be set accordingly.
**NB: THESE FILES ARE NOT READ OR COMPILED BY ATHENA, OR IN ANY CI TEST**
they are used ONLY for the histogram building in the ID Trigger nightly testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69437Remove LArMonTools and legacy LArCalibProcessing2024-03-04T23:05:02+01:00Pavol StrizenecRemove LArMonTools and legacy LArCalibProcessingas per ATLASRECTS-7924, removing legacy LAr monitoring and calibration data processing jO.as per ATLASRECTS-7924, removing legacy LAr monitoring and calibration data processing jO.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69436LAr DB tools update2024-03-04T23:05:02+01:00Pavol StrizenecLAr DB tools updateThis should bring the updates needed for LAr conditions computation.
Should not affect the standard workflow in any means.This should bring the updates needed for LAr conditions computation.
Should not affect the standard workflow in any means.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69433Modify ITk multiplicity cuts for the ITk analyses2024-03-04T23:05:02+01:00Mark SuttonModify ITk multiplicity cuts for the ITk analysesThe ITk strips have no detector elements beyond |eta|=2.8 so the reuirement
om the number of strip hits has been removed.
In addition, for very long chains, only the first 30 characters of the chain
name will be displayed now, so that w...The ITk strips have no detector elements beyond |eta|=2.8 so the reuirement
om the number of strip hits has been removed.
In addition, for very long chains, only the first 30 characters of the chain
name will be displayed now, so that we can still see th type of the track
collection.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69419ATR-28887: Avoid modifying retrieved CA in JetRecoSequencesConfig2024-03-04T23:05:02+01:00Teng Jian KhooATR-28887: Avoid modifying retrieved CA in JetRecoSequencesConfigSolving the longstanding (and basically harmless) mystery as to how the `jetview_HLT_AntiKt10LCTopoJets_nojcalib_pt10` alg kept going missing between step configuration and full menu configuration.
An ill-conceived modification of the C...Solving the longstanding (and basically harmless) mystery as to how the `jetview_HLT_AntiKt10LCTopoJets_nojcalib_pt10` alg kept going missing between step configuration and full menu configuration.
An ill-conceived modification of the CA returned by `StandardJetBuildSeq` meant that this alg was situationally added to a sequence. The fact that we optimise the global HLT CA construction by selectively merging CAs on the basis of sequence name (assumed to be unique) meant that depending on the HLT menu ordering we could merge the version of the sequence that omitted this alg and then discard the version containing the alg.
Instead we now properly integrate this into a higher level CA, generating `JetRecSeq_a10_nojcalib` that will hold the view sequence, and ensure that `JetBuildSeq_a10_tc_lcw_nojcalib` is uniquely defined.