athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-06-20T18:30:17+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63791Use CxxUtils:: instead of boost:: for starts_with in TileConditions2023-06-20T18:30:17+02:00Andrii VerbytskyiUse CxxUtils:: instead of boost:: for starts_with in TileConditionsUse CxxUtils:: instead of boost:: for starts_with in TileConditions.
Note: CxxUtils are used already.Use CxxUtils:: instead of boost:: for starts_with in TileConditions.
Note: CxxUtils are used already.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63789Use CxxUtils:: instead of boost:: for stats_with in GeoModel2023-06-19T21:15:15+02:00Andrii VerbytskyiUse CxxUtils:: instead of boost:: for stats_with in GeoModelUse CxxUtils:: instrad of boost:: for stats_with in GeoModel.Use CxxUtils:: instrad of boost:: for stats_with in GeoModel.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63788Added PtScale and PtShift parameters to the L1Topo ExclusiveJets algorithm2023-07-13T21:30:49+02:00Jean Yves Beaucampjean.yves.beaucamp@cern.chAdded PtScale and PtShift parameters to the L1Topo ExclusiveJets algorithmAdded PtScale and PtShift parameters to the ExclusiveJets L1 Menu algorithm configuration.
Also added the parameters to the L1Topo simulation algorithm, to pass Trigger Menu build test.
Tagging @jodampAdded PtScale and PtShift parameters to the ExclusiveJets L1 Menu algorithm configuration.
Also added the parameters to the L1Topo simulation algorithm, to pass Trigger Menu build test.
Tagging @jodamphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63786Use CxxUtils:: instead of boost for the only usage of statrs_with() in AthCon...2023-06-19T21:15:15+02:00Andrii VerbytskyiUse CxxUtils:: instead of boost for the only usage of statrs_with() in AthContainersRootUse CxxUtils:: instead of boost for the only usage of statrs_with() in AthContainersRoot
@ssnyderUse CxxUtils:: instead of boost for the only usage of statrs_with() in AthContainersRoot
@ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63785Drop special condition for Herwig++ particle status codes2023-06-23T21:42:31+02:00Andrii VerbytskyiDrop special condition for Herwig++ particle status codesDrop special condition for Herwig++ particle status codes.
The particle status code 11 is not a standard one and Herwig++ is not used.
@jchapmanDrop special condition for Herwig++ particle status codes.
The particle status code 11 is not a standard one and Herwig++ is not used.
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63774turning on useCaloInfoInExtrap2023-06-19T21:15:15+02:00Batool Safarzadeh Samaniturning on useCaloInfoInExtrapafter passing all validation checks here ATR-27725 and ATR-27727, the default value of useCaloInfoInExtrap is set to true. we will do a proper cleaning later to remove the old approach.after passing all validation checks here ATR-27725 and ATR-27727, the default value of useCaloInfoInExtrap is set to true. we will do a proper cleaning later to remove the old approach.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63773Add new flags to disable NSW only for L2 (ATR-27714)2023-06-19T21:15:15+02:00Yasuyuki OkumuraAdd new flags to disable NSW only for L2 (ATR-27714)Dear all,
This MR addresses the issue discussed in ATR-27714, which allows us to disable the NSW only in L2SA reconstruction but enable it in EFSA.
`MuonSpectrometer/MuonConfig/python/MuonConfigFlags.py` was updated to add a new flag...Dear all,
This MR addresses the issue discussed in ATR-27714, which allows us to disable the NSW only in L2SA reconstruction but enable it in EFSA.
`MuonSpectrometer/MuonConfig/python/MuonConfigFlags.py` was updated to add a new flag for trigger `Muon.disableNSWForL2SA`.
`Trigger/TrigAlgorithms/TrigL2MuonSA/python/TrigL2MuonSAConfig.py` was updated to propagate the Muon.disableNSWForL2SA to enable/disable the use of the NSW in L2SA, including Muon.disableNSWForL2SA.
`Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Muon/MuonMenuSequences.py` was updated to propagate the Muon.disableNSWForL2SA and Muon.runCommissioningChain to TrigL2MuonSAConfig.py.
tagging @sshaw @vippolit
Best regards,
Yasu Okumurahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63771BackPort the fix for ATLASRECTS-7560 to 23.02023-06-19T21:15:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chBackPort the fix for ATLASRECTS-7560 to 23.0Closes ATLASRECTS-7560
by backporting
MR !62750
ping @wlamplCloses ATLASRECTS-7560
by backporting
MR !62750
ping @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63768BadLBFilterToolConfig reduce verbosity2023-06-19T21:15:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chBadLBFilterToolConfig reduce verbosityhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63767ATLASRECTS-6783 TRTRawDataProvider: Use DataPool for the offline case2023-07-20T23:34:36+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-6783 TRTRawDataProvider: Use DataPool for the offline caseTRTRawDataProvider: Use DataPool for the offline data case
This is a follow-up of past MRs on using data pools
The more relevant would be
MR !62116 MR !62369 reco on MC and Overlay.
We seem we do many small allocation (Number 1 in m...TRTRawDataProvider: Use DataPool for the offline data case
This is a follow-up of past MRs on using data pools
The more relevant would be
MR !62116 MR !62369 reco on MC and Overlay.
We seem we do many small allocation (Number 1 in my Q442 heaptrack test)
```
MOST CALLS TO ALLOCATION FUNCTIONS
14226185 calls to allocation functions with 5.42M peak consumption from
TRT_RodDecoder::int_fillFullCompress(eformat::ROBFragment<> const*, InDetRawDataContainer<>*, TRT_RodDecoder::t_CompressTable const&, std::vector<> const*) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv/src/TRT_RodDecoder.cxx:1187
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-04-08T2101/Athena/23.0.24/InstallArea/x86_64-centos7-gcc11-opt/lib/libTRT_RawDataByteStreamCnv.so
14226185 calls with 5.42M peak consumption from:
TRT_RodDecoder::fillCollection(eformat::ROBFragment<> const*, InDetRawDataContainer<>*, TRT_BSErrContainer*, std::vector<> const*) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv/src/TRT_RodDecoder.cxx:297
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-04-08T2101/Athena/23.0.24/InstallArea/x86_64-centos7-gcc11-opt/lib/libTRT_RawDataByteStreamCnv.so
TRTRawDataProviderTool::convert(std::vector<> const&, InDetRawDataContainer<>*, TRT_BSErrContainer*, EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv/src/TRTRawDataProviderTool.cxx:121
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-04-08T2101/Athena/23.0.24/InstallArea/x86_64-centos7-gcc11-opt/lib/libTRT_RawDataByteStreamCnv.so
TRTRawDataProvider::execute(EventContext const&) const
at /build/atnight/localbuilds/nightlies/Athena/23.0/athena/InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv/src/TRTRawDataProvider.cxx:129
in /cvmfs/atlas-nightlies.cern.ch/repo/sw/23.0_Athena_x86_64-centos7-gcc11-opt/2023-04-08T2101/Athena/23.0.24/InstallArea/x86_64-centos7-gcc11-opt/lib/libTRT_RawDataByteStreamCnv.so
Gaudi::Algorithm::sysExecute(EventContext const&)
```
In the other cases the improvements on cpu were not only in the producer side, but in access and also for deleting the elements at the end of the event.
Ping @jchapman and @ssnyder
Also ping @abarton , but mainly for the thing that is not happening here i.e I am not touching the online case ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/63766Refactor SCT_ClusterOnTrack ctors. Use them to avoid tmp allocation in SCT_Cl...2023-06-19T21:15:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chRefactor SCT_ClusterOnTrack ctors. Use them to avoid tmp allocation in SCT_ClusterOnTrackToolRefactor SCT_ClusterOnTrack ctors. Use them to avoid tmp allocation in SCT_ClusterOnTrackToolRefactor SCT_ClusterOnTrack ctors. Use them to avoid tmp allocation in SCT_ClusterOnTrackToolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63765Add a reserve() where we know the container size (TrigHLTJetHypoAlg)2023-06-19T21:15:15+02:00Stewart Martin-HaughAdd a reserve() where we know the container size (TrigHLTJetHypoAlg)Small optimisation given that we know the size in advance.
Please squash commits - the first contains a mistake.Small optimisation given that we know the size in advance.
Please squash commits - the first contains a mistake.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63760CA-version of the PixelVALID derivation (ATLASRECTS-7609)2023-07-28T09:41:27+02:00Soshi TsunoCA-version of the PixelVALID derivation (ATLASRECTS-7609)Migrate to CA version of the PixelVALID stream.
In addition, adding several options for this derivation.
For pixel data monitoring, we need it in 23.0.
This shouldn't break T0 tests.Migrate to CA version of the PixelVALID stream.
In addition, adding several options for this derivation.
For pixel data monitoring, we need it in 23.0.
This shouldn't break T0 tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63759minor fixes of histograming in TGC DQ2023-06-19T21:15:15+02:00Masato Aokiminor fixes of histograming in TGC DQThis is to fix minor bugs in TGC DQ histogramming.This is to fix minor bugs in TGC DQ histogramming.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63755Updating jFEX monitoring with updated information2023-06-23T21:42:31+02:00Sergi Rodriguez BoscaUpdating jFEX monitoring with updated informationThis MR is meant to update the jFEX monitoring.
It modifies the existent input data monitoring, now it compares the DataTowers with the EmulatedTowers
It also created a new monitoring algorithm in which it compares the jFEX simulated TOB...This MR is meant to update the jFEX monitoring.
It modifies the existent input data monitoring, now it compares the DataTowers with the EmulatedTowers
It also created a new monitoring algorithm in which it compares the jFEX simulated TOBs with the decoded data TOBshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63749Demote INFO messages in InDetPriVxFinder + InDetConversionTools2023-06-19T21:15:15+02:00Thomas StreblerDemote INFO messages in InDetPriVxFinder + InDetConversionToolsReduce verbosity in initialisation of tools and algorithms in aforementioned packagesReduce verbosity in initialisation of tools and algorithms in aforementioned packageshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63743allow brem specific settings in FTF2023-06-23T21:42:30+02:00Jiri Masikallow brem specific settings in FTFaddresses misconfiguration reported in ATR-27056addresses misconfiguration reported in ATR-27056https://gitlab.cern.ch/atlas/athena/-/merge_requests/63737Remove expressions with Truthparticle::status()%10002023-06-21T21:16:56+02:00Andrii VerbytskyiRemove expressions with Truthparticle::status()%1000- Remove expressions with Truthparticle::status()%1000
- Move classification functions inside the TruthUtils.
- Use isStable() and similar instead of direct comparison of statuses- Remove expressions with Truthparticle::status()%1000
- Move classification functions inside the TruthUtils.
- Use isStable() and similar instead of direct comparison of statuseshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63735Restore previous behaviour removed during refactoring of TrigTauRecMerged2023-06-19T21:15:15+02:00Edson Carquin LopezRestore previous behaviour removed during refactoring of TrigTauRecMergedThis MR reimplement the changes added in !63488 that were reverted later on !63733 due to the issues below, these should be fixed now, apologies for the meesss.
Addresses ATR-27533 while fixing ATR-27748, ATR-27750, ATR-27753This MR reimplement the changes added in !63488 that were reverted later on !63733 due to the issues below, these should be fixed now, apologies for the meesss.
Addresses ATR-27533 while fixing ATR-27748, ATR-27750, ATR-27753https://gitlab.cern.ch/atlas/athena/-/merge_requests/63734TrigCost: Fix Walltime histogram2023-06-19T21:15:15+02:00Aleksandra PorebaTrigCost: Fix Walltime histogram- Fix the Walltime histogram to collect more than 1000 lumiblocks - the maximum value is set to 4500 now, that was a maximum during the longest run last year. It was tested with a 2023 recent run and an entry at lumiblock 1234 is present...- Fix the Walltime histogram to collect more than 1000 lumiblocks - the maximum value is set to 4500 now, that was a maximum during the longest run last year. It was tested with a 2023 recent run and an entry at lumiblock 1234 is present as well as denominator in the post processing:
```
RunTrigCostAnalysis.py --skipEvents=45000 --maxEvents=1 Input.Files='["/eos/atlas/atlastier0/rucio/data23_13p6TeV/calibration_CostMonitoring/00454322/data23_13p6TeV.00454322.calibration_CostMonitoring.daq.RAW/data23_13p6TeV.00454322.calibration_CostMonitoring.daq.RAW._lb0000._SFO-20._0023.data"]'> CostAnalysis.log 2>&1
```
- The deadtime item is chosen based on the run number - for runs after the change of physics deadtime item https://gitlab.cern.ch/atlas-tdaq-oks/p1/tdaq-10-00-00/-/commit/31c7c6e6b9f3c796c97cf4a61e76818d7da410df , `L1_eEM26M--enabled` will be used
- Append maximum pileup instead of mean to the cost details
Tagging @tamartin