athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-07-01T22:30:15+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/64036ATLASRECTS-7672 : Manage the memory ownership via unique_ptr to avoid leaks2023-07-01T22:30:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-7672 : Manage the memory ownership via unique_ptr to avoid leaksATLASRECTS-7672 : Manage the memory ownership via unique_ptr to avoid leaks
We manage ownership using a vector of unique_ptr ``TParamOwner``.
So we know things will be cleaned up on exit. We do not need to remember to do loops deleting...ATLASRECTS-7672 : Manage the memory ownership via unique_ptr to avoid leaks
We manage ownership using a vector of unique_ptr ``TParamOwner``.
So we know things will be cleaned up on exit. We do not need to remember to do loops deleting if an error occurs.
Since the interface called needs a vector of plain ptr we also keep around the ``tmpInputC``
But it does not hold owning ptr anymore just "view" of what is in the owning vector.
ping @ametehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64051Removed Release13like option from PixelClusterOnTrackTool2023-07-01T22:30:15+02:00Thomas StreblerRemoved Release13like option from PixelClusterOnTrackToolRemoved unused option in PixelClusterOnTrackTool + clean-upRemoved unused option in PixelClusterOnTrackTool + clean-uphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64052add trigger filter in TGC DQ for making unbiased histograms2023-07-01T22:30:15+02:00Masato Aokiadd trigger filter in TGC DQ for making unbiased histogramsThs MR is to add a trigger filter in TGC DQ for making unbiased histograms.Ths MR is to add a trigger filter in TGC DQ for making unbiased histograms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64041MuonNSWAsBuilt - Parse JSON payload by const string2023-07-01T16:15:24+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonNSWAsBuilt - Parse JSON payload by const stringhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63988remove unused 'operator std::string()' methods from LArRawEvent2023-07-01T16:15:24+02:00Walter Lamplremove unused 'operator std::string()' methods from LArRawEventAbusing the CI to verify that there is indeed no usage of this operatorAbusing the CI to verify that there is indeed no usage of this operatorhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64032TileMonitoring: Migrate Tile TB pulse shape monitoring for Run32023-07-01T16:15:24+02:00Siarhei HarkushaTileMonitoring: Migrate Tile TB pulse shape monitoring for Run3New TileTBPulseMonitorAlgorithm has been added to monitor Tile TB pulse shape for run 3.
Functionality has been copied from TileTBPulseMonTool.
Configuration of Tile TB pulse shape monitoring algorithm has been added for run 3.
Test o...New TileTBPulseMonitorAlgorithm has been added to monitor Tile TB pulse shape for run 3.
Functionality has been copied from TileTBPulseMonTool.
Configuration of Tile TB pulse shape monitoring algorithm has been added for run 3.
Test of Tile TB pulse shape monitoring has been added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64033rm a possibly misleading ctor for TSOS2023-07-01T16:15:24+02:00Christos Anastopouloschristos.anastopoulos@cern.chrm a possibly misleading ctor for TSOSrm a possibly misleading ctor for TSOS
Its only usages could misled as were part of a copy/move assignment , but the ``atomic hints`` are not copied or moved.rm a possibly misleading ctor for TSOS
Its only usages could misled as were part of a copy/move assignment , but the ``atomic hints`` are not copied or moved.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64005AmdcsimrecAthenaSvc - Do not look into the DetMgr to find Alignment parameters2023-07-01T16:15:24+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chAmdcsimrecAthenaSvc - Do not look into the DetMgr to find Alignment parametersThe version retrieved by the service does not contain any alignment parameter. Hence, the dead code is removed.The version retrieved by the service does not contain any alignment parameter. Hence, the dead code is removed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64007Adding helper transformations2023-07-01T16:15:24+02:00Stylianos AngelidakisAdding helper transformationsModest MR adding a couple of helper function to perform transformations that are useful to the muon alignment group.Modest MR adding a couple of helper function to perform transformations that are useful to the muon alignment group.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64004MuonDetDescrUtils - Remove pointless alignment parameter setters2023-07-01T16:15:24+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonDetDescrUtils - Remove pointless alignment parameter settersThe method is called [before](https://gitlab.cern.ch/atlas/athena/-/blob/master/MuonSpectrometer/MuonGeoModel/src/MuonDetectorCondAlg.cxx#L89) the Muon alignment containers are retrieved from the ConditionsStore.The method is called [before](https://gitlab.cern.ch/atlas/athena/-/blob/master/MuonSpectrometer/MuonGeoModel/src/MuonDetectorCondAlg.cxx#L89) the Muon alignment containers are retrieved from the ConditionsStore.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58061Manual Sweep from 21.0 to 22.0: Run3 developments for FCS Muon Punch Through2023-07-01T00:49:07+02:00John Derek ChapmanManual Sweep from 21.0 to 22.0: Run3 developments for FCS Muon Punch ThroughOriginal changes from @thcarter in !54822 and from @thcarter and @mumohdso in !58060. Plus some minor syntax and configuration clean-up and syncrhonising with clean-up already applied in ~master.
Contains all the developments for the Ru...Original changes from @thcarter in !54822 and from @thcarter and @mumohdso in !58060. Plus some minor syntax and configuration clean-up and syncrhonising with clean-up already applied in ~master.
Contains all the developments for the Run3 developments and improvements made to the FastCaloSim Muon Punch Through tools for AF3.
Contains the following:
- PunchThroughClassifier. Calibrated classifier used to predict if an event should result in a punch through.
- Punch through tool redesign and simplification
- New parameterization of punch through kinematics using PCA.
- Expands the number of punch through particle types to 9.
Validated using single pions. Gives significant improvement in modelling of ghost-associated muon segments (see plot).![Screenshot_2022-07-04_at_15.45.09](/uploads/ab605db7a59c9ec151a853861f9ecabd/Screenshot_2022-07-04_at_15.45.09.jpg)https://gitlab.cern.ch/atlas/athena/-/merge_requests/64001RoiUtil: code cleanup2023-06-30T16:58:43+02:00Frank WinklmeierRoiUtil: code cleanup- remove `_internal` methods from public interface and replace by lambda
- delete legacy `roiContains` methods
- remove `ifdefs` for PI constants
- use range-based loops
cc @sutt- remove `_internal` methods from public interface and replace by lambda
- delete legacy `roiContains` methods
- remove `ifdefs` for PI constants
- use range-based loops
cc @sutthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64002Remove ForceMSConditionsAlgs2023-06-30T16:58:42+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRemove ForceMSConditionsAlgsI cann't see where this algorithm is still needed. Tagging @ponyisi, in cases he disagrees.I cann't see where this algorithm is still needed. Tagging @ponyisi, in cases he disagrees.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63920Wrap CA config on a higher level in makeInDetTrigPrecisionTracking2023-06-30T16:58:42+02:00Jiri MasikWrap CA config on a higher level in makeInDetTrigPrecisionTracking
remove trigger specific flag usePixelNN and steer the configuration by useTIDE_Ambi in the AmbiSolver and Score Cfg method
ATR-26732
remove trigger specific flag usePixelNN and steer the configuration by useTIDE_Ambi in the AmbiSolver and Score Cfg method
ATR-26732https://gitlab.cern.ch/atlas/athena/-/merge_requests/64025jFEX monitoring update, solving ATR-27831 and ATLASRECTS-76622023-06-30T16:58:42+02:00Sergi Rodriguez BoscajFEX monitoring update, solving ATR-27831 and ATLASRECTS-7662This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
sett...This MR is solving few monitoring issues described in:
- ATLASRECTS-7662 - Memory degradation in RAWtoALL
- ATR-27831 - JfexInputMonAlg accessing nonexistent item jtowerEtMeV
It also adds a generic jFEX plot to spot global errors.
setting ~urgent flag since it makes express reconstruction crashhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63979Avoid potentially attempting to alter flags within OverlayMainContentCfg func...2023-06-30T16:58:42+02:00John Derek ChapmanAvoid potentially attempting to alter flags within OverlayMainContentCfg functionIf inconsistent `geometryVersion` values are used on the command-line and in the presampled RDO file (particularly in FastChain where there is no geometryVersion in the other input file as it is an EVNT file), then it is possible that th...If inconsistent `geometryVersion` values are used on the command-line and in the presampled RDO file (particularly in FastChain where there is no geometryVersion in the other input file as it is an EVNT file), then it is possible that the configuration will attempt to modify `flags.GeoModel.AtlasVersion` after it has been locked. This merge request moves the metadata checks out of the `OverlayMainContentCfg` function to locations before the flags are locked.
This opens up another question about what should be done if inconsistent command-line and input file metadata are found this will be tackled in a follow-up MR.
Tagging @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63981Clean up unused vertex collections in JetBTaggingAlg2023-06-30T16:58:42+02:00Thomas StreblerClean up unused vertex collections in JetBTaggingAlgWhile investigating the impact of ACTS on FTAG secondary vertexing, I noticed that the secondary vertex collections were retrieved in the `JetBTaggingAlg` but not used. They are instead used in the [BTagLightSecVertexing](https://gitlab....While investigating the impact of ACTS on FTAG secondary vertexing, I noticed that the secondary vertex collections were retrieved in the `JetBTaggingAlg` but not used. They are instead used in the [BTagLightSecVertexing](https://gitlab.cern.ch/atlas/athena/-/blob/23.0/PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/BTagging/BTagLightSecVertexing.h) tool. They are consequently removed from the `JetBTaggingAlg`. Run 3 derivation outputs have been checked to be unchanged.
FYI @ligang @bdonghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6403123.0-cleanup-PixelConditionsData2023-06-30T16:58:42+02:00Shaun Roe23.0-cleanup-PixelConditionsDataAddressing issues raised by unit tests (see ATLASRECTS-7669); unify exceptions, check validity of hash in set&get methods. Also removed a 'clear()' method declaration which appears unused.Addressing issues raised by unit tests (see ATLASRECTS-7669); unify exceptions, check validity of hash in set&get methods. Also removed a 'clear()' method declaration which appears unused.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64003CscRawDataProvider - Replace conditions dependency on Aline container by DetM...2023-06-30T16:58:42+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chCscRawDataProvider - Replace conditions dependency on Aline container by DetMgr dependencyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64028PyJobTransforms: Add VTune support in the job transform a la Valgrind2023-06-30T16:58:42+02:00Alaettin Serhan MetePyJobTransforms: Add VTune support in the job transform a la ValgrindI see many people get confused about running `VTune`. This MR enables the user to run `VTune` through the job transform infrastructure a la `Valgrind`. In a nutshell, after this MR is merged, the user will be able to run a `hotspots` ana...I see many people get confused about running `VTune`. This MR enables the user to run `VTune` through the job transform infrastructure a la `Valgrind`. In a nutshell, after this MR is merged, the user will be able to run a `hotspots` analysis for their favorite job this way:
```
source /cvmfs/projects.cern.ch/intelsw/oneAPI/linux/x86_64/2023/vtune/latest/env/vars.sh;
lsetup "asetup Athena,23.0,latest";
Reco_tf.py (or any other transform) [...] --vtune "True";
```
It's possible to run any other analysis (or add extra `VTune` options) via the `vtuneExtraOpts` flag, e.g. for running a `threading` analysis the user can do:
```
Reco_tf.py (or any other transform) [...] --vtune "True" --vtuneExtraOpts="-collect=threading";
```
It's also possible to discard the current default options, namely `-run-pass-thru=--no-altstack -mrte-mode=native`, by doing `--vtuneDefaultOpts "False"`.
cc: @tovsiann