athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-05-15T19:23:19+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63037Add AtlasFieldCacheCondAlg to L1 muon simulation config2023-05-15T19:23:19+02:00Savanna ShawAdd AtlasFieldCacheCondAlg to L1 muon simulation configSince the muon RDO to digit algorithm needs the objects created by the AtlasFieldCacheCondAlg, adding this to the configuration used in the L1 muon simulation (otherwise it relies on the HLT muon configuration to be present).
This will ...Since the muon RDO to digit algorithm needs the objects created by the AtlasFieldCacheCondAlg, adding this to the configuration used in the L1 muon simulation (otherwise it relies on the HLT muon configuration to be present).
This will allow to run non-muon HLT chains alone in the new JO tests (cc @damazio and @fpastore for info).https://gitlab.cern.ch/atlas/athena/-/merge_requests/63039Update TTbarWithJpsimumuFilter.cxx -- Fix the bug2023-05-15T19:23:19+02:00Andrii VerbytskyiUpdate TTbarWithJpsimumuFilter.cxx -- Fix the bugUpdate TTbarWithJpsimumuFilter.cxx -- Fix the bug
Tag @ewelinaUpdate TTbarWithJpsimumuFilter.cxx -- Fix the bug
Tag @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62889dqm_algorithms - BinContentComp - Add option to not publish histogram with ba...2023-05-15T19:23:19+02:00Petr Fiedlerdqm_algorithms - BinContentComp - Add option to not publish histogram with bad binsAdd an option to not create a histogram with only bins for publishing. The histogram is created by default for the seamless addition of the feature.Add an option to not create a histogram with only bins for publishing. The histogram is created by default for the seamless addition of the feature.Petr FiedlerPetr Fiedlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63047Fix array referencing problem for Z counting2023-05-15T19:23:19+02:00Peter OnyisiFix array referencing problem for Z countingFix a very-probable Pandas array slicing problem in !62992Fix a very-probable Pandas array slicing problem in !62992https://gitlab.cern.ch/atlas/athena/-/merge_requests/63034xAODtoHepMCTool: fixed a bug where 1e5 used instead of 1e62023-05-15T19:23:19+02:00Philip ClarkxAODtoHepMCTool: fixed a bug where 1e5 used instead of 1e6There was a hardcoded number 100000 instead of 1000000, we think this was to suppress all regenerated Geant4, i.e. >1e6 barcodes, and pileup particles which are currently normally suppresssed (and have barcode = std::numeric_limits<int32...There was a hardcoded number 100000 instead of 1000000, we think this was to suppress all regenerated Geant4, i.e. >1e6 barcodes, and pileup particles which are currently normally suppresssed (and have barcode = std::numeric_limits<int32_t>::max()).
This should now output only particles with barcodes <1e6. We've also used HepMC::SIM_REGENERATION_INCREMENT to help avoid these bugs and help when we phase out MagicNumber usage in barcodes to use origin instead.
@ewelina @jchapman @averbytshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63038Update several IDGlobal DQ axis ranges and labels2023-05-15T19:23:19+02:00Makayla VessellaUpdate several IDGlobal DQ axis ranges and labelsThis MR fixes a very small bug in the axis labels of the PV y and z error distributions, as well as bumps up some of the axis ranges of the nVertices distributions to be better for Run 3 conditions.
FYI @perjohanThis MR fixes a very small bug in the axis labels of the PV y and z error distributions, as well as bumps up some of the axis ranges of the nVertices distributions to be better for Run 3 conditions.
FYI @perjohanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63051ATR-27505 gFEX updates for menu2023-05-15T19:23:19+02:00Zhongyukun Xuzhongyukun.xu@cern.chATR-27505 gFEX updates for menuIncrease gLJ seedThrA, seedThrB and seedThrC from 3 to 20 GeV.
Decrease gXE seedThrA, seedThrB and seedThrC from 25 to 24 GeV.Increase gLJ seedThrA, seedThrB and seedThrC from 3 to 20 GeV.
Decrease gXE seedThrA, seedThrB and seedThrC from 25 to 24 GeV.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63049B-physics trigger: add support chain HLT_mu6_l2io_mu4_l2io_invmDimu_L1BPH-2M9...2023-05-15T19:23:19+02:00Vladimir LyubushkinB-physics trigger: add support chain HLT_mu6_l2io_mu4_l2io_invmDimu_L1BPH-2M9-0DR15-C-MU5VFMU3V to Physics_pp_run3_v1 menuAdd support chain HLT_mu6_l2io_mu4_l2io_invmDimu_L1BPH-2M9-0DR15-C-MU5VFMU3V to Physics_pp_run3_v1 menu
Needed to switch off chains seeded from L1_BPH-2M9-0DR15-MU5VFMU3V
cc @lidiaz @tursomAdd support chain HLT_mu6_l2io_mu4_l2io_invmDimu_L1BPH-2M9-0DR15-C-MU5VFMU3V to Physics_pp_run3_v1 menu
Needed to switch off chains seeded from L1_BPH-2M9-0DR15-MU5VFMU3V
cc @lidiaz @tursomhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63054Trigger ID DQ monitoring fix2023-05-15T19:23:19+02:00Julie KirkTrigger ID DQ monitoring fixPrevent Bphysics "Bidperf" chains appearing in muon monitoring directory
Move "Bidperf" chain to shifter histogramsPrevent Bphysics "Bidperf" chains appearing in muon monitoring directory
Move "Bidperf" chain to shifter histogramshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63043fix a regex for fastGN1 and fix a FPE error2023-05-15T19:23:18+02:00Liaoshan Shifix a regex for fastGN1 and fix a FPE error- The ROI FTF step in the fastGN1 chains wasn't executed. The MR updated the regex to handle fastGN1 properly.
- Fixed a FPE DIVBYZERO error in calculating DIPS likelihood ratio.
Tagging @tmadula @khoo @cpollard @dan-guest @lbeemste- The ROI FTF step in the fastGN1 chains wasn't executed. The MR updated the regex to handle fastGN1 properly.
- Fixed a FPE DIVBYZERO error in calculating DIPS likelihood ratio.
Tagging @tmadula @khoo @cpollard @dan-guest @lbeemstehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62982Remove the barcodes from MCTruthClassifier2023-05-15T19:23:18+02:00Andrii VerbytskyiRemove the barcodes from MCTruthClassifierRemove the barcodes from MCTruthClassifier
Tag @jchapman @christos
See also https://its.cern.ch/jira/browse/ATLASSIM-6562Remove the barcodes from MCTruthClassifier
Tag @jchapman @christos
See also https://its.cern.ch/jira/browse/ATLASSIM-6562https://gitlab.cern.ch/atlas/athena/-/merge_requests/62996assign only sorted sets to properties to ensure a reproducible configuration2023-05-15T11:07:26+02:00Walter Lamplassign only sorted sets to properties to ensure a reproducible configurationThis MR is an alternative proposed to !62968.
Background: The iteration order over python sets is not reproducible (on purpose in recent python versions, see https://docs.python.org/3.4/reference/datamodel.html#object.__hash__) Consequ...This MR is an alternative proposed to !62968.
Background: The iteration order over python sets is not reproducible (on purpose in recent python versions, see https://docs.python.org/3.4/reference/datamodel.html#object.__hash__) Consequently, the order of elements in a vector-property filled from python sets are not reproducible. In none of the cases I found the client cxx-code relies on the order, so this is not a real bug. But its potentially confusing when diff'ing configurations.
This MR works around this issue by sorting the elements of the python set before assigning it to the property.
Aside: `Gaudi::Property<std::set<unsigend> >` is possible and better match for properties that contain an unsorted collection of unique numbers, like DQ-Defects or LAr Frond-End Board identifiers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62950Forgotten EM->eEM chains2023-05-15T00:02:51+02:00Lidija ZivkovicForgotten EM->eEM chainsFew chains don't have eEM partner, added in Physics menu.Few chains don't have eEM partner, added in Physics menu.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62485add FTAG variables to PHYSLITE [ATLASG-2522]2023-05-12T19:14:59+02:00Ligang Xiaadd FTAG variables to PHYSLITE [ATLASG-2522]- Add ftag varibles to PHYSLITE according to https://docs.google.com/spreadsheets/d/1XKdDEvGH2mYPuPm8wwDxo_o75O-rAo4T6P1NrrduIZs/edit#gid=1373413052 here.
- Tested on a data and a MC sample. The event size change is around 3.7%.
tag @wl...- Add ftag varibles to PHYSLITE according to https://docs.google.com/spreadsheets/d/1XKdDEvGH2mYPuPm8wwDxo_o75O-rAo4T6P1NrrduIZs/edit#gid=1373413052 here.
- Tested on a data and a MC sample. The event size change is around 3.7%.
tag @wleinone and @bdonghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62994Adds alg & postInclude fragment to save detailed MBTS info in xAOD2023-05-12T15:55:57+02:00Tomasz BoldAdds alg & postInclude fragment to save detailed MBTS info in xAODThe MR adds a trivial algorithm that copies data from TileCell MBTS collection to an xAOD collection. The latter can then be used in AtanlysiBase.
It is needed for some specialised analyses.
FI @mdyndal @kciesla
Also tagging FI @st...The MR adds a trivial algorithm that copies data from TileCell MBTS collection to an xAOD collection. The latter can then be used in AtanlysiBase.
It is needed for some specialised analyses.
FI @mdyndal @kciesla
Also tagging FI @stapiaar as this is an addition to HI global. We may actually consider scheduling this alg always for UPC and pp reference runs.
There comment for @kciesla - it seems that MBTSFex could be much simpler than it is now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62997LArNoiseCorrelationMonAlg.py: Use logger instead of print statement2023-05-12T15:55:57+02:00Walter LamplLArNoiseCorrelationMonAlg.py: Use logger instead of print statementThe title says it all...The title says it all...https://gitlab.cern.ch/atlas/athena/-/merge_requests/62998Fix import of SetupMetaDataForStreamCfg in AODEventPicking2023-05-12T15:55:57+02:00Maciej Pawel SzymanskiFix import of SetupMetaDataForStreamCfg in AODEventPickingIntroduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/62137 and maintained in https://gitlab.cern.ch/atlas/athena/-/merge_requests/61980
/cc @darioIntroduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/62137 and maintained in https://gitlab.cern.ch/atlas/athena/-/merge_requests/61980
/cc @dariohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62999DQBadLBFilterAlg: Use writeHandle.addDependency instead of manual range-handling2023-05-12T15:55:57+02:00Walter LamplDQBadLBFilterAlg: Use writeHandle.addDependency instead of manual range-handlingThe title says it all ...The title says it all ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/62476Heavy Ion Egamma reconstruction with CA2023-05-12T15:55:57+02:00Petr BalekHeavy Ion Egamma reconstruction with CASetup of egamma reconstruction for heavy ions using component accumulator.
If flag `flags.Reco.EnableHI` is set to true, heavy-ion-like clusters are created and passed to the standard egamma reconstruction in `egammaReconstructionConfig...Setup of egamma reconstruction for heavy ions using component accumulator.
If flag `flags.Reco.EnableHI` is set to true, heavy-ion-like clusters are created and passed to the standard egamma reconstruction in `egammaReconstructionConfig.py`. For a convenience during testing, it's also possible to trigger it via `flags.HeavyIon.Egamma.redoEgamma` and run just `HIRecConfig.py`.
The clusters are created using subtraction from HI jets and it's thus necessary to run HI jet reconstruction before HI egamma.
The setup is equivalent of the legacy HI egamma code and uses the same underlying algorithms.
Closes ATLHI-481
Tagging @stapiaarhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63004Muctpi dq fixes2023-05-12T15:55:57+02:00Lorenzo SanfilippoMuctpi dq fixesFixed some minor bugs affecting the histograms built on Candidate words, from the Muctpi Readout.
@aikoulou
@czodrowsFixed some minor bugs affecting the histograms built on Candidate words, from the Muctpi Readout.
@aikoulou
@czodrows