athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-06-24T18:50:26+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/51625Saving Event-Wide HLT Info of Interest to custom TrigCompositeContainer | ATR...2022-06-24T18:50:26+02:00Marco MontellaSaving Event-Wide HLT Info of Interest to custom TrigCompositeContainer | ATR-25237This WIP MR tracks the implementation of a dedicated algorithm to retrieve a selection of event-wide HLT-level variables and store them to a custom-made TrigCompositeUtils container, to be added to the Run 3 EDM.
[ATR-25237](https://its...This WIP MR tracks the implementation of a dedicated algorithm to retrieve a selection of event-wide HLT-level variables and store them to a custom-made TrigCompositeUtils container, to be added to the Run 3 EDM.
[ATR-25237](https://its.cern.ch/jira/browse/ATR-25237)
General Idea:
- Algorithm to retrieve the variables and store them to a newly create TrigCompositeContainer
- Configure the algorithm from each TLA Menu sequence (or non-TLA menu sequence) and add it to the sequence (how?)
More detailed implementation plans can be found in the JIRA.
**STATUS**
Initial commit with TrigEventInfoRecorderAlg skeleton + retrieval of EventShape density.
---
Tagging @cantel @fpastore @tamartin @Peter
Marcohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51749HLT_mu3vtx_L12MU8F Trigger Improvements2022-07-06T20:03:16+02:00Michael Louis SchottHLT_mu3vtx_L12MU8F Trigger ImprovementsRenamed package TrigL2LongLivedParticles to TrigLongLivedParticles and made additional changes to remove L2 from filenames in this package and the associated Hypothesis package, TrigLongLivedParticlesHypo.
Minor issues being fixed inclu...Renamed package TrigL2LongLivedParticles to TrigLongLivedParticles and made additional changes to remove L2 from filenames in this package and the associated Hypothesis package, TrigLongLivedParticlesHypo.
Minor issues being fixed include violations of the ATLAS style guide & best coding practices, such as using the c++ dynamic_cast and static_cast functions instead of C-style casts; removal of duplicate "include" statements; and others. Changed hard-coded pi in TrigLongLivedParticlesMonitoring.py to math.pi.
All header and source files have been moved into their respective package src/ directories to match the directory structure present in other triggers. Intermediate variables in the the python configuration files have been removed. MuonClusterHypoAlg methods "initialize" and "execute" were changed to virtual, override methods. The SG Key for the TrigCompositeContainer that stores the muon RoI clusters has been updated to "HLT_RoICluster_Container" in preparation to be added to the Run3 EDM configuration so these objects get written to the output file, [!54628](https://gitlab.cern.ch/atlas/athena/-/merge_requests/54628).Michael Louis SchottMichael Louis Schotthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52003CFElements: use isRun3Cfg for legacy support2022-06-01T16:19:14+02:00Frank WinklmeierCFElements: use isRun3Cfg for legacy supportUse `ComponentFactory.isRun3Cfg` to check if we are in legacy
configurable mode. This is more general than `configurableRun3Behavior`
and ensures that the same logic is used as in `CompFactory`.
Also remove the use of the `__future__` m...Use `ComponentFactory.isRun3Cfg` to check if we are in legacy
configurable mode. This is more general than `configurableRun3Behavior`
and ensures that the same logic is used as in `CompFactory`.
Also remove the use of the `__future__` module and cleanup cmake
configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52595Restructure P1 menu and take steps to remove PS:Online2023-02-27T19:34:48+01:00Teng Jian KhooRestructure P1 menu and take steps to remove PS:OnlineAddressing ATR-25107. Tagging @sshaw, @tamartin, @mark, @lidiaz, @astruebi, @qhu for input.
This is aimed at removing the 'PS:Online' group label, potentially replacing it with other labels as needed.
Data-only triggers now primarily ...Addressing ATR-25107. Tagging @sshaw, @tamartin, @mark, @lidiaz, @astruebi, @qhu for input.
This is aimed at removing the 'PS:Online' group label, potentially replacing it with other labels as needed.
Data-only triggers now primarily go in the P1_run3_v1.py menu, which contains different functions:
- `addHighMuP1Signatures`
- `addLowMuP1Signatures`
- `addCosmicP1Signatures`
- `addHeavyIonP1Signatures`
- `addCommonP1Signatures`
which can then be used to add the P1 chains to the physics lists in different menus. I have mostly transplanted anything that had 'PS:Online' from the various menus (mostly in Calib, EnhancedBias and Streaming slices) into their respective `addXP1Signatures` function. Monitoring triggers that are in all menus go to `addCommonP1Signatures`.
With this new file, most of the `PhysicsP1_X_run3_v1` files should be physics triggers only, which then refer to `P1_X_run3_v1` for their data-only items. The exception is `PhysicsP1_pp_run3_v1`, which does the following:
1. Import `Physics_pp_run3_v1` and grab the physics menu, this being shared with `MC_pp_run3_v1`
2. Add streamers that stream to `Main` (those in `P1_pp_run3_v1` should only go to calibration/monitoring streams)
3. Import `P1_run3_v1` and add triggers from the Common + HighMu functions.
Further notes:
- Still need to review the usage of `PS:Online` and ideally remove everywhere. The HI menu in particular uses this very liberally, esp for AFP etc that we cannot simulate(?).
- The CostMon chain is wanted in all menus, so is a good candidate for inclusion `addCommonP1Signatures`, but we would probably then also need to add it to the `MC_pp` menu and take it out of `Physics_pp`.
Also just for convenience, did ATR-26956 by request herehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52708Keep topo selection after full leg specification2022-06-01T18:19:35+02:00Teng Jian KhooKeep topo selection after full leg specificationFollow-up to !52093, we should put the topo cuts at the end of the chain for clarity.Follow-up to !52093, we should put the topo cuts at the end of the chain for clarity.https://gitlab.cern.ch/atlas/athena/-/merge_requests/52914HLTjet improvements to hypothesis timing monitoring plots2022-05-25T10:37:12+02:00Ayana Tamu ArceHLTjet improvements to hypothesis timing monitoring plotsFine binning/narrow range in HLT hypo timing monitoring histograms isn't sensitive to hypothesis timing issues, and is causing occasional ART histogram comparison tests to fail (https://its.cern.ch/jira/browse/ATR-25259). These tweaks (...Fine binning/narrow range in HLT hypo timing monitoring histograms isn't sensitive to hypothesis timing issues, and is causing occasional ART histogram comparison tests to fail (https://its.cern.ch/jira/browse/ATR-25259). These tweaks (bin size x500) should make the tests more stable and informative.
@Peter @cantel fyihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53033TriggerMenuMT Jet: Consistency fixes in jet code (ATR-25449)2022-05-25T21:56:14+02:00Claire AntelTriggerMenuMT Jet: Consistency fixes in jet code (ATR-25449)Some consistency fixes:
* making new shallow copy, `HLT_AntiKt4EMTopoJets_subjesIS_fastftag`, of EMTopo jets for fast jet tagging hypo step, to avoid incomplete EDM for EMTopo jets (ATR-25449)
* moving all track reco sequence getters (ol...Some consistency fixes:
* making new shallow copy, `HLT_AntiKt4EMTopoJets_subjesIS_fastftag`, of EMTopo jets for fast jet tagging hypo step, to avoid incomplete EDM for EMTopo jets (ATR-25449)
* moving all track reco sequence getters (oldJO) from `JetTrackConfig.py` to `JetRecoSequences.py`
* moving imports to top of file
* running `JetViewAlg` also for calo f-tag presel step & nojcalib chains (no more jets < 10 GeV in hypos).
* New `getJetViewAlg` to simplify step.
* renaming `JetRoITracking...` reco/hypo/chainstep getter functions to `JetRoITrackJetTag...` for clarity.
* replacing `doTracking` query with `doFSTracking` query whenever FS tracking meant (not RoI tracking).
Trigger count changes from removing hacky `HLT_j2000` chain introduced for ATR-25449 in interim. Otherwise, no changes in hypo decisions expected.
Tagging @khoo @valentem @ayana @peter @dguest @cpollardhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53185First version of an efex bytestream decoder2022-07-15T14:11:25+02:00Will ButtingerFirst version of an efex bytestream decoderThe slightly unusual source code structure is because this decoder reuses code from the online software to avoid having two versions of code that are designed to do the same thing. For this reason the structure of the source code is deli...The slightly unusual source code structure is because this decoder reuses code from the online software to avoid having two versions of code that are designed to do the same thing. For this reason the structure of the source code is deliberately laid out how it appears in the online software, which will make it easier to maintain as changes to the decoder take place (we will change them in the online sw and then copy over the relevant files to the offline sw).
Jira: ATR-25493https://gitlab.cern.ch/atlas/athena/-/merge_requests/53194Make MC21 standard configuration default for simulation2022-05-25T10:09:09+02:00John Derek ChapmanMake MC21 standard configuration default for simulationOnce Frozen Showers have been validated for MC21 (ATLPHYSVAL-866), then they should be enabled by default.
The values of Birks' constant should also be updated to the values that were tuned for G4 10.6.
Tagging @tlari, @gcallea, @dhayd...Once Frozen Showers have been validated for MC21 (ATLPHYSVAL-866), then they should be enabled by default.
The values of Birks' constant should also be updated to the values that were tuned for G4 10.6.
Tagging @tlari, @gcallea, @dhayden, @tadej, @pavol, @solodkov, @harkushahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53233ATR-25417 Simplify unconvtrk trigger names2022-06-10T12:18:32+02:00Stefanie MorgensternATR-25417 Simplify unconvtrk trigger names- rename UTT chains:
- unconvtrk<threshold>_hitdv -> hitdvjet<threshold>
- unconvtrk<threshold>_distrk -> distrk<threshold>
- unconvtrk<threshold>_dedx -> dedxtrk<threshold>
- unconvtrk<threshold>_isohpttrack -> isotrk<threshold>...- rename UTT chains:
- unconvtrk<threshold>_hitdv -> hitdvjet<threshold>
- unconvtrk<threshold>_distrk -> distrk<threshold>
- unconvtrk<threshold>_dedx -> dedxtrk<threshold>
- unconvtrk<threshold>_isohpttrack -> isotrk<threshold>
- unconvtrk<threshold>_dispj -> dispjet<threshold>
- unconvtrk0_fsvsi -> fsvsi0
- unconvtrk0_fslrt -> fslrt
- introduce list of trigTypes to support renaming
- implement initial attempt to use threshold and multiplicity in dispjet code
- update references
- clean up:
- remove trigTypes from default SignatureDicts
- remove unused code from UTT
- rename some DJ functions to make them more meaningfulhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53262Add online monitoring histograms for RoI updates2022-06-04T20:01:25+02:00Rafal Bielskirafal.bielski@cern.chAdd online monitoring histograms for RoI updatesHLT chains start from regions of interest (RoIs) defined by HLTSeeding based on L1 information, but during execution may refine the RoI based on reconstructed object properties. Add online monitoring histograms which show the position di...HLT chains start from regions of interest (RoIs) defined by HLTSeeding based on L1 information, but during execution may refine the RoI based on reconstructed object properties. Add online monitoring histograms which show the position difference between the initial and the final RoI. Full-scan RoIs are skipped.
This is a re-implementation of similar histograms which we had in Run 2, as discussed in Jira ATR-19667.
The histograms tested on `test_trig_data_v1Dev_build.py` look like these:
<img src="/uploads/f2685cb6a994f502ad2864c31e323089/RoIsDEta.png" width=250 />
<img src="/uploads/9bb5acb2a318ccac667fdaea7ba09f50/RoIsDPhi.png" width=250 />
<img src="/uploads/37d8f6ca0ff5603d22c4561980d031fe/RoIsDZed.png" width=250 />https://gitlab.cern.ch/atlas/athena/-/merge_requests/53290Client changes for NSW calibration conditions2022-06-02T18:09:07+02:00Constantin HeideggerClient changes for NSW calibration conditionsThis MR adds the necessary client changes (and algo updates) for the NSW calibration conditions.
Tagging @jojungge , @chchau , @pscholerThis MR adds the necessary client changes (and algo updates) for the NSW calibration conditions.
Tagging @jojungge , @chchau , @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53292sTGC Strip Trigger: Fixed the scattered point segment finding inefficiencies2022-05-27T12:32:30+02:00Yi YusTGC Strip Trigger: Fixed the scattered point segment finding inefficienciesThere are some scattered point inefficiencies for the strip trigger performance,
due to some trigger candidates are missed, such as:
1. In the stripSegmentTool, the hash_bandid originally couldn't distinguish '1'+'72' and '17' + '2', hen...There are some scattered point inefficiencies for the strip trigger performance,
due to some trigger candidates are missed, such as:
1. In the stripSegmentTool, the hash_bandid originally couldn't distinguish '1'+'72' and '17' + '2', hence the charge centroids in 2 sides only form 1 segment, causing one muon's efficiency lost with dimu samples
1. In the stripClusterTool, the judgement statement for the first time will miss the case if the first several digits with the same channelId but belonging to different bcs (the strategy allows +-1 bc now)
1. The dtheta < 15 mrad sentence caused the loop finished prematurely, resulting in the efficiency in A side get lower by 5% compared to the one of C side, fix it, and adjust its position for a more flexible performance study, without effecting the record for the later trigger logics
Before/After these changes:
![nominal_eff_x_y_strip](/uploads/571188db7af38d10448328cac469c746/nominal_eff_x_y_strip.png)
![nominal_eff_x_y_strip](/uploads/ac0a14f38c3fdf684cc937f0f9dce515/nominal_eff_x_y_strip.png)
./ccing @rosati @iodice @vadamico @fgravilihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53301ATR-25219: implementing trigger for alignment2022-05-25T16:08:07+02:00Federica FabbriATR-25219: implementing trigger for alignmentAdded a new trigger chain to be used for the endcap alignment run.
The trigger should be similar to the Run2: HLT_mu15_mucombTag_noEF_L1MU20
The task is described in [ATR-25219](https://its.cern.ch/jira/browse/ARC-163)
The tests perform...Added a new trigger chain to be used for the endcap alignment run.
The trigger should be similar to the Run2: HLT_mu15_mucombTag_noEF_L1MU20
The task is described in [ATR-25219](https://its.cern.ch/jira/browse/ARC-163)
The tests performed on the new trigger have been presented https://indico.cern.ch/event/1156828/https://gitlab.cern.ch/atlas/athena/-/merge_requests/53303Add possibility to update the RoiDescriptors to the view creation2022-05-25T12:34:30+02:00Mark SuttonAdd possibility to update the RoiDescriptors to the view creationAdds a new RoiUpdaterTool which can be included by the ViewCreator Tools.
This is implemented here in the Jet slice as a test. In principle, the
ToolHandle for the RoiUpdater Tool can be added to the ViewCreator base
class, and just not ...Adds a new RoiUpdaterTool which can be included by the ViewCreator Tools.
This is implemented here in the Jet slice as a test. In principle, the
ToolHandle for the RoiUpdater Tool can be added to the ViewCreator base
class, and just not initialised.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53317Attempt to fix CA-based configuration of TGCCablingDbTool2022-06-16T18:00:22+02:00John Derek ChapmanAttempt to fix CA-based configuration of TGCCablingDbToolThe configuration of `TGCCablingDbTool` seemed to be missing for CA-based digitization jobs.
After adding this I noticed that the same tool is used as a public tool by `TGCCableASDToPP` (not an Athena component) and a
as private tool di...The configuration of `TGCCablingDbTool` seemed to be missing for CA-based digitization jobs.
After adding this I noticed that the same tool is used as a public tool by `TGCCableASDToPP` (not an Athena component) and a
as private tool directly by `MuonTGC_CablingSvc`. (`TGCCableASDtoPP` is owned by `TGCCabing`, which is owned by `MuonTGC_CablingSvc`.)
This isn't ideal. I've tried to make sure that they are both configured consistently now, but it might be better to pass a pointer to `ITGCCablingDbTool` via `TGCCabling` to `TGCCableASDToPP` and not use a ToolHandle in `TGCCableASDtoPP`.
Leaving as a draft until @jojungge, @junpei comment.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53349TriggerJobOpts: schedule L1TopoRawData converter for CA2022-05-18T08:21:10+02:00Frank WinklmeierTriggerJobOpts: schedule L1TopoRawData converter for CASchedule the `L1TopoRawData` bytestream converter when running on RAW
for CA-based job options.
Closes ATR-25503.Schedule the `L1TopoRawData` bytestream converter when running on RAW
for CA-based job options.
Closes ATR-25503.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53417Read Tile sampling Fractions from COOL2022-09-28T18:29:02+02:00John Derek ChapmanRead Tile sampling Fractions from COOLIncorporates !53384, !53387, !53388, !53389 from @ssnyder.
This version allows the Tile Sampling Fraction conditions to be read from COOL, but disables the G4Version comparisons for non-simulation jobs. This combined with Scott's previo...Incorporates !53384, !53387, !53388, !53389 from @ssnyder.
This version allows the Tile Sampling Fraction conditions to be read from COOL, but disables the G4Version comparisons for non-simulation jobs. This combined with Scott's previous fixes allows the previously affected unit tests and CITests to succeed still.
Leaving this one as a draft until I hear back from @harkusha.
Tagging @fwinkl, @tsulaia.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53474jet hypo support changes for the out-of-time jet trigger.2022-05-25T14:37:32+02:00Peter Sherwoodjet hypo support changes for the out-of-time jet trigger.Provides support for out-of-time jet triggers.
This allows simple chains to add the requirtement of (an) out of time jet(s). This is done by adding the
string _<lower limit>timing<supper limit> to the chain part of interest. Limit defa...Provides support for out-of-time jet triggers.
This allows simple chains to add the requirtement of (an) out of time jet(s). This is done by adding the
string _<lower limit>timing<supper limit> to the chain part of interest. Limit defaults are 0, infinity for
lower and upper limits respectively. Known values are 2 for the lower limit. This adding the substring _2timing_
adds the timing cut selection for the appropriate jet(s).
ATR-25567
@ayana @cantel @jmontejo @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53498Updates to L1Menu for CTP commissioning: ATR-25568, ATR-217962022-06-07T13:17:12+02:00Teng Jian KhooUpdates to L1Menu for CTP commissioning: ATR-25568, ATR-21796Fixes, mostly requests from @amarzin:
- Duplicate BMA0 instead of BMA1 input
- Various updates to CTP monitored items
- Addition of ZeroBias trigger driven by eFEX trigger
- Reorders LegacyL1Topo0/1 board and LegacyL1TopoMerger board add...Fixes, mostly requests from @amarzin:
- Duplicate BMA0 instead of BMA1 input
- Various updates to CTP monitored items
- Addition of ZeroBias trigger driven by eFEX trigger
- Reorders LegacyL1Topo0/1 board and LegacyL1TopoMerger board additions in order to provide desired threshold-to-board mapping for CTP
- Fixes to L1Topo group labels, correctly checking all legacy items coming via merger board (FYI @amoreira)
- Improves detail on L1Topo group label messaging, avoids checking multi-seeded L1 items for topo groups
Additional feature:
- Adds NSW monitoring trigger item: ATR-21796