athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-06-21T03:02:10+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/24246Making MuonLayerHoughTool thread-safe2019-06-21T03:02:10+02:00Pascal BoeschotenMaking MuonLayerHoughTool thread-safeNew MR to replace !23553.
Moves recording of HoughDataPerSectorVec to MuonLayerHoughAlg MooSegmentFinderAlg.New MR to replace !23553.
Moves recording of HoughDataPerSectorVec to MuonLayerHoughAlg MooSegmentFinderAlg.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23770Add Pixel and SCT hit number requirements to AsgLeptonTrackSelectionAlg2019-05-30T03:06:19+02:00Paul Gessinger-BefurtAdd Pixel and SCT hit number requirements to AsgLeptonTrackSelectionAlgThis MR adds the ability to cut (min and max) on the number of Pixel and SCT hits to `AsgLeptonTrackSelectionAlg`.
I've tested this locally, but I don't know if there is any place the functionality of these algorithms is tested automat...This MR adds the ability to cut (min and max) on the number of Pixel and SCT hits to `AsgLeptonTrackSelectionAlg`.
I've tested this locally, but I don't know if there is any place the functionality of these algorithms is tested automatically. If there is, I'm happy to update.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22232add a basic test for EventLoop grid driver2019-04-02T03:03:04+02:00Nils Erik Krumnackadd a basic test for EventLoop grid driverSo far we haven't had any "official" test of the grid functionality in EventLoop. Since I am now doing a lot of restructuring of EventLoop, it seemed necessary that we have some sort of test, even if it is run manually.So far we haven't had any "official" test of the grid functionality in EventLoop. Since I am now doing a lot of restructuring of EventLoop, it seemed necessary that we have some sort of test, even if it is run manually.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22154Add method to the MuonTriggerScaleFactor telling the user whether the trigger...2019-03-30T03:03:12+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chAdd method to the MuonTriggerScaleFactor telling the user whether the trigger is supported or not.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21756Updates to HIGG3D1 derivation format2019-04-24T13:34:54+02:00David Richard ShopeUpdates to HIGG3D1 derivation formatThis MR makes the following updates to the HIGG3D1 derivation format (size testing done on dilepton ttbar):
- Loosen the lepton skim requirements slightly, requested by H->aa->bbmumu (increase size by ~10%)
- Add TruthBoson and Truth...This MR makes the following updates to the HIGG3D1 derivation format (size testing done on dilepton ttbar):
- Loosen the lepton skim requirements slightly, requested by H->aa->bbmumu (increase size by ~10%)
- Add TruthBoson and TruthTaus containers to output (increase size by ~3%)
- Remove the preservation of descendants to the selection particle types in TruthParticle container (decrease size by ~24%)
- Add DFCommonMuonsPreselection variable to muon skim requirements (decrease size by ~15%)
- Remove AntiKt4PV0TrackJets and add AntiKt10LCTopoTrimmedPtFrac5SmallR20Jets + AntiKt10TruthTrimmedPtFrac5SmallR20Jets (increase size by ~2%)
- Save AntiKt4TruthDressedWZJets (instead of AntiKt4TruthWZJets) and add TruthWbosonWithDecay containers
All together, these changes amount to an expected 24% further reduction in dilepton ttbar. An even larger size reduction is expected for the overal format size. Supplementary slides were presented in one of the HWW Plenary meetings:
https://indico.cern.ch/event/810750/contributions/3387709/attachments/1826890/2990201/Derivation_Updates_04_08_19.pdfDavid Richard ShopeDavid Richard Shopehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20699(partially) fix LeakChecks unit test2019-01-30T03:02:57+01:00Nils Erik Krumnack(partially) fix LeakChecks unit testThe failure behavior changed, so I updated the test for it. There is
still some issue that it always detects leaks with the batch driver,
not sure if it is real or fake.The failure behavior changed, so I updated the test for it. There is
still some issue that it always detects leaks with the batch driver,
not sure if it is real or fake.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20316Optimization of HI jet reconstruction and HI jet derivations (ATLHI-233)2019-02-14T17:05:53+01:00Martin RybarOptimization of HI jet reconstruction and HI jet derivations (ATLHI-233)- adding all the development of HI jet reconstruction as documented in ATLAS-233 to rel 21.2
- optimization of the AOD fix to produce DF jets in derivation production
- updating HION7,8 and 9 derivations to be able to run production on...- adding all the development of HI jet reconstruction as documented in ATLAS-233 to rel 21.2
- optimization of the AOD fix to produce DF jets in derivation production
- updating HION7,8 and 9 derivations to be able to run production on 2018 PbPb and 2017 5 TeV pp data
- tagging our HI derivation coordinator @jkremer https://gitlab.cern.ch/atlas/athena/-/merge_requests/20282Event-based JVT/fJVT scale factors2019-03-21T03:03:01+01:00Tadej Novaktadej.novak@cern.chEvent-based JVT/fJVT scale factorsAs JVT/fJVT have efficiency and inefficiency scale factors we need to compute them per-event if we want to drop jets not passing the selection. By recommendation this is done after overlap removal.
This MR adds `JetJvtAnalysisSequence...As JVT/fJVT have efficiency and inefficiency scale factors we need to compute them per-event if we want to drop jets not passing the selection. By recommendation this is done after overlap removal.
This MR adds `JetJvtAnalysisSequence`. It is used to compute global event scale factors and select JVT/fJVT jets.
Also adding a helper class `AsgEventScaleFactorAlg`.
When this is accepted I have the same treatment in place for flavour tagging.
/cc @akraszna, @khoo, @krumnack, @ksuruliz, @jburr
(This MR is based on !20222)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20196convenient output file with rucio commands is produced2019-01-10T03:02:55+01:00Ruggero Turraconvenient output file with rucio commands is producedVery small change in the python script used to generate PRW files. The commands to download NTUP files from grid in addition to be shown on the screen as in present case, they are also saved in a `.sh` file which can be executed by the u...Very small change in the python script used to generate PRW files. The commands to download NTUP files from grid in addition to be shown on the screen as in present case, they are also saved in a `.sh` file which can be executed by the user. Presently the user has to copy-and-paste manually the commands which is tedious and error prone (for some reason in my case some dataset names are truncated when doing copy-and-paste on my terminal...)
Not sure: this should be cherry picker to everything >=21.2 and master.
Tagging @willhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/2004422.0-refactor-IOVDbSvc-22019-01-15T15:44:55+01:00Shaun Roe22.0-refactor-IOVDbSvc-2Refactoring IOVDbSvc; work continued after repository change to open source.
Pre-change patch file applied to the new repository (so.. many changes in one commit).
Adding new Cool functions and delegating file metadata reading to a new c...Refactoring IOVDbSvc; work continued after repository change to open source.
Pre-change patch file applied to the new repository (so.. many changes in one commit).
Adding new Cool functions and delegating file metadata reading to a new class