athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-12T09:36:46+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69686athena.py: remove athena-specific history and readline setup2024-03-12T09:36:46+01:00Frank Winklmeierathena.py: remove athena-specific history and readline setupRemove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.Remove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69396Update ThinCAWrapper.sh - also allow scripts to be located in the joboption...2024-03-04T10:07:36+01:00Will ButtingerUpdate ThinCAWrapper.sh - also allow scripts to be located in the joboption...Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65094AtlasCITest - Switch on CA in cosmic test2023-08-28T12:21:10+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chAtlasCITest - Switch on CA in cosmic testWe're running most of the stuff in CA anyway
Tagging: @tadej, @nstyles, @jcatmore, @jmaurer, @wlamplWe're running most of the stuff in CA anyway
Tagging: @tadej, @nstyles, @jcatmore, @jmaurer, @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63554Add asserts for static analyzers2023-06-10T01:14:06+02:00Adam Edward BartonAdd asserts for static analyzersStatic analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.Static analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57583The get methods of the ROBDataProviderSvc can be made const2022-10-17T20:13:24+02:00Christos Anastopouloschristos.anastopoulos@cern.chThe get methods of the ROBDataProviderSvc can be made constThe get methods of the ROBDataProviderSvc can be made const
This seems possible here.
We seem to have ``tbb::concurent_map`` and also a ``lock`` for the hlt implementation,
when doing kind of a lazy init from ``getRobData`` via the int...The get methods of the ROBDataProviderSvc can be made const
This seems possible here.
We seem to have ``tbb::concurent_map`` and also a ``lock`` for the hlt implementation,
when doing kind of a lazy init from ``getRobData`` via the internal ``eventCache_addRobData``
ping @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57333Adding 'icalonocut' WP to Photon Isolation hypo + Adding 'icalonocut' Photon+...2022-10-12T16:02:07+02:00Marco MontellaAdding 'icalonocut' WP to Photon Isolation hypo + Adding 'icalonocut' Photon+Jets TLA chainsAs discussed in: [ATR-26421](https://its.cern.ch/jira/browse/ATR-26421)
This MR adds the 'icalonocut' passthrough working points for the Photon isolation in the relevant TrigEgammaHypo, TrigEgammaMonitoring and TrigEgammaMatchingTool pa...As discussed in: [ATR-26421](https://its.cern.ch/jira/browse/ATR-26421)
This MR adds the 'icalonocut' passthrough working points for the Photon isolation in the relevant TrigEgammaHypo, TrigEgammaMonitoring and TrigEgammaMatchingTool packages.
Furthermore, the corresponding isolation variables are added to the TLA EDM in order for them to be saved to the TLA stream, and three new TLA chains with explicit isolation calculation, differing by the photon threshold.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53440CxxUtils+AthenaCommon+AthenaServices: Add checked_tcmalloc.2022-05-20T09:31:30+02:00Scott SnyderCxxUtils+AthenaCommon+AthenaServices: Add checked_tcmalloc.Build a version of tcmalloc with extra error checking.
The code is taken from gperftools 2.8.1, modified for extra checking
and for building as part of CxxUtils.
It is built into a separate shared library, so won't have any effect
unless...Build a version of tcmalloc with extra error checking.
The code is taken from gperftools 2.8.1, modified for extra checking
and for building as part of CxxUtils.
It is built into a separate shared library, so won't have any effect
unless that library is explicitly loaded.
Only tested for linux/gcc/x86_64, so for now only build for that platform.
To assist in catching errors like double-frees and overwrites.
Adds a --checked-tcmalloc flag to Athena.
Have CoreDumpSvc handle SIGABRT as well.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51356JetMatcherAlg - add protection in case no JFEX L1 jet container is available ...2022-04-12T09:40:36+02:00Peter SherwoodJetMatcherAlg - add protection in case no JFEX L1 jet container is available (ATR-25147) JetMatcherAlg add protection in case no JFEX L1 jet container is available.
@Sawyer @schaarsc @ayana @cantel @peter
Tagging ATR-25147 JetMatcherAlg add protection in case no JFEX L1 jet container is available.
@Sawyer @schaarsc @ayana @cantel @peter
Tagging ATR-25147Peter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51454Hijing_i: Fix fortran compilation warnings.2022-03-22T18:44:24+01:00Scott SnyderHijing_i: Fix fortran compilation warnings.Fix warnings related to deprecated do-loop constructions.
Fixes AGENE-2140 and relates to ATLINFR-4464.Fix warnings related to deprecated do-loop constructions.
Fixes AGENE-2140 and relates to ATLINFR-4464.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916Disable CaloMuonLikelihoodTool2022-02-10T12:30:13+01:00Emma Catherine GoddenDisable CaloMuonLikelihoodToolDisabling old CaloMuonLikelihood tool in the configuration. [ATLASRECTS-6786](https://its.cern.ch/jira/browse/ATLASRECTS-6786).
This means the CaloLRLikelihood variable is no longer set in [MuonCreatorTool.cxx](https://gitlab.cern.ch/at...Disabling old CaloMuonLikelihood tool in the configuration. [ATLASRECTS-6786](https://its.cern.ch/jira/browse/ATLASRECTS-6786).
This means the CaloLRLikelihood variable is no longer set in [MuonCreatorTool.cxx](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs#6d2fc1339eb0922cd081313503966caa70d9e1dd_708_707), so updated the AuxContainer introducing [MuonAuxContainer_v6](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs#diff-content-7155acdd6568c63ec546720199cf1c6a6eccfd8e). The changes wrt to _v5 is the removal of the CaloLRLikelihood variable ( [this line](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs?diff_id=1443663#c8a0cb87305d4166647f3b4b055c047a7f0c78d6_170_170) )https://gitlab.cern.ch/atlas/athena/-/merge_requests/39796Add nopost.sh to 21.2 for standalone unit testing2021-11-26T21:15:26+01:00Maximilian Emanuel Goblirsch-KolbAdd nopost.sh to 21.2 for standalone unit testingThis MR adds the `nopost.sh` post-script found in the `master` branch (https://gitlab.cern.ch/atlas/athena/-/blob/master/AtlasTest/TestTools/share/nopost.sh) to 21.2, in order to allow standalone unit tests without a ref file for package...This MR adds the `nopost.sh` post-script found in the `master` branch (https://gitlab.cern.ch/atlas/athena/-/blob/master/AtlasTest/TestTools/share/nopost.sh) to 21.2, in order to allow standalone unit tests without a ref file for packages built against the 21.2-series analysis releases.
See https://twiki.cern.ch/twiki/bin/view/AtlasComputing/SoftwareDevelopmentWorkBookCMakeInAtlas#atlas_add_test for documentation and intended use.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45053Dressing large-R jet collections with ghost-associated VR track-jets2021-10-25T15:10:47+02:00Giuseppe CalleaDressing large-R jet collections with ghost-associated VR track-jetsThe aim of this MR is to add the links of ghost associated VR track-jets to large-R jet collections (here only for LCTopo). Having these links is crucial for the Hbb analyses, but other groups might be interested in them.
In the past, w...The aim of this MR is to add the links of ghost associated VR track-jets to large-R jet collections (here only for LCTopo). Having these links is crucial for the Hbb analyses, but other groups might be interested in them.
In the past, we noticed that including them will lead to a negligible size increase.
To do this, we are following the examples from r21.2, where some derivation formats add the links in this way:
https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs/share/HIGG5D1.py#L244
using `addVRJets`, which is defined here:
https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag/python/HbbCommon.py#L217
For this reason, `DerivationFrameworkFlavourTag.HbbCommon` has to be imported.
Please let us know if this is not the right place where to put these links. We might open another MR but for r21.2 with the same purpose.
Many thanks for your help.
Tagging @angianni, @ckato, @jcatmore, @lheinric, @alisterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45755MuonCombinedAlg - Reevaluate angular preselection cuts2021-09-21T20:00:47+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonCombinedAlg - Reevaluate angular preselection cutsHi,
the FPE reported in ATLASRECTS-6516 is caused by combining an
ID track:
```
13:04:16 * loc1 : 26.2559471
13:04:16 * loc2 : -449.6217335
13:04:16 * phi : -2.0887670
13:04:16 * Theta : 0.2636617
13:04:16 * q/p : 0.0000428
...Hi,
the FPE reported in ATLASRECTS-6516 is caused by combining an
ID track:
```
13:04:16 * loc1 : 26.2559471
13:04:16 * loc2 : -449.6217335
13:04:16 * phi : -2.0887670
13:04:16 * Theta : 0.2636617
13:04:16 * q/p : 0.0000428
13:04:16 * charge: 1.0000000
13:04:16 * covariance matrix = 0xeb7d28f0
13:04:16 * corresponding global parameters:
13:04:16 * position (x, y, z ) = (22.8118425, -12.9997923, -449.6217335)
13:04:16 * momentum (px, py, pz) = (-3012.6240677, -5286.5079685, 22540.2672344)
13:04:16 associated surface:
```
and the MS track
```
13:04:16 Trk::PerigeeSurface:
13:04:16 Center position (x, y, z) = (0.0000000, 0.0000000, 0.0000000)
13:04:16
13:04:16 * TrackParameters on Surface
13:04:16 * loc1 : 0.0000000
13:04:16 * loc2 : 0.0000000
13:04:16 * phi : -3.0787095
13:04:16 * Theta : 0.5001232
13:04:16 * q/p : -0.0002370
13:04:16 * charge: -1.0000000
13:04:16 * covariance matrix = 0xec83c2b0
13:04:16 * corresponding global parameters:
13:04:16 * position (x, y, z ) = (-363.7110210, -1048.2188476, 6785.0000000)
13:04:16 * momentum (px, py, pz) = (-2019.1807883, -127.1399870, 3702.3208500)
13:04:16 associated surface:
```
resulting in a chi2/nDoF value at the order of `1.e14` due to their large kink and any attempt to kill the track postfit without triggering an FPE failed as any operation on the weight matrix in the fitter leads to a double overflow. However, when we look at the angular separation between MS/MSOE tracks in particle gun MC events, we find that they are typically below 0.2 in eta and phi, respectively. So we can assume that this combination is a fake that should never be brought into existence. The changes, which I propose here are on the first hand to narrow down the deltaEta window from 0.5 -> 0.2 and the phi window from 1. to 0.2 and on the second hand to slightly modify the matching approach by following the ID track to its last measurement in the Inner detector and to find the first measurement of the MS/MSOE track in the MS. Then the angular differences between the two measurements are used to evaluate the cut. Detailed studies based on simulation were presented in the last two MCP meetings [Vol I](https://indico.cern.ch/event/1070988/contributions/4519874/attachments/2305836/3922824/cern-beamer-template.pdf) and [Vol II](https://indico.cern.ch/event/1075944/contributions/4530285/attachments/2310078/3930844/cern-beamer-template.pdf). The summary of the study is that we can bring down the average consumed CPU time of MuonCombinedAlg from 690 ms -> 380ms in the mu=50 pile-up data17 test sample. A test on a single data16 run is currently ongoing.
Tagging @wleight, @rosati for their opinion on my proposal and @sroe, @christos for coding comments. I also tag @amete, @emoyse, @elmsheus to make them aware that we will hopefully observe soon a drop in the SPOT CPUt plot.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42504[ATR-23206] Add additional warning about empty chain groups2021-07-09T13:08:03+02:00Tim Martin[ATR-23206] Add additional warning about empty chain groupsSmall MR to print a WARNING if trigger decision information is asked of a ChainGroup of zero L1 items and/or HLT chains.Small MR to print a WARNING if trigger decision information is asked of a ChainGroup of zero L1 items and/or HLT chains.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44720Make selection read handles systematics aware2021-06-29T00:43:13+02:00Jon BurrMake selection read handles systematics awareThis should allow us to have selections with systematic variations and read them as part of the selection accessors.
As part of this I had to shift the SysDecorationHandle to use a standalone messaging namespace (`ANA_MESSAGE_HEADER`+`A...This should allow us to have selections with systematic variations and read them as part of the selection accessors.
As part of this I had to shift the SysDecorationHandle to use a standalone messaging namespace (`ANA_MESSAGE_HEADER`+`ANA_MESSAGE_SOURCE`) rather than using `AsgMessagingForward`. It would be possible to do this with the older class, but would make a lot of the calls around the selection read handle a lot uglier.
I also forgot to turn my code formatter off so there are quite a lot of changes which are only formatting. On balance I prefer to keep these but if makes the review too hard I can also try and revert the changes which are pure formatting.
Note that this only changes the read handle class, not any of the places that use it - they also need to be updated to pass in the correct systematic and to call `preExecute` where necessary. If it's preferred I can also do that in this MR.
Tagging @krumnack and @tadej for info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44663Set MuonErrorOptimizer to null by default, so as not to retrieve an unconfigu...2021-06-24T17:03:37+02:00Edward MoyseSet MuonErrorOptimizer to null by default, so as not to retrieve an unconfigured tool.Should fix ATLASRECTS-6433
Tested locally that this fixes the issue with an unconfigured tool being loaded, by making the tool fail if not explicitly configured (see a followup MR).Should fix ATLASRECTS-6433
Tested locally that this fixes the issue with an unconfigured tool being loaded, by making the tool fail if not explicitly configured (see a followup MR).https://gitlab.cern.ch/atlas/athena/-/merge_requests/43076[ATR-22994] Allow ConfigFlags.Trigger to be imported in AthAnalysis. Requires...2021-06-17T16:42:33+02:00Tim Martin[ATR-22994] Allow ConfigFlags.Trigger to be imported in AthAnalysis. Requires three additional packages in AthAnalysis.Bring three (python) packages into AthAnalysis.
These are required to import the `ConfigFlags.Trigger`
With this (and the complimentary MR !43072), the Component Accumulator based `TrigDecisionToolConfig.py` can be used in AthAnalysis....Bring three (python) packages into AthAnalysis.
These are required to import the `ConfigFlags.Trigger`
With this (and the complimentary MR !43072), the Component Accumulator based `TrigDecisionToolConfig.py` can be used in AthAnalysis.
cc @fwinkl: I had to exclude the `--extend-extensions` CMake here, it isn't recognised in AthAnalysis.
Adding expert review labels as adds packages to the build.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42027Use FSNOSEED for jet chains2021-06-08T12:29:42+02:00Tomasz BoldUse FSNOSEED for jet chainsThis MR changes L1 seeding for jet chains from L1J to FSNOSEED.
However the counts change significantly:
```
chainComp INFO HLT_j85_pf_ftf_L1J20:
chainComp INFO stepCounts:
chainComp INFO 0: 5 -> 20
chainComp INF...This MR changes L1 seeding for jet chains from L1J to FSNOSEED.
However the counts change significantly:
```
chainComp INFO HLT_j85_pf_ftf_L1J20:
chainComp INFO stepCounts:
chainComp INFO 0: 5 -> 20
chainComp INFO stepFeatures:
chainComp INFO 0: 5 -> 20
```
That may sound wrong, however it is in agreement with the counts of:
HLT_noalg_L1J20
(and similarly for other threshold).
I believe the reason is that FSNOSEED seeding takes into account only CPT items whereas for HLTNav_L1J and even the "forceEnableAllChains" is not realy activating them.
Now, what do we want?
Tagging @hrussell @khoo @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43205Connect egamma emulator and monitoring2021-05-29T05:44:35+02:00Joao Victor Da Fonseca PintoConnect egamma emulator and monitoringThis MR just connect the e/g emulator into the e/g offline monitoring. The e/g emulator today is turn-off (emulator=False into the egamma python offline mon code).
- tidy up matching tool and include necessary features to emulate;
- cha...This MR just connect the e/g emulator into the e/g offline monitoring. The e/g emulator today is turn-off (emulator=False into the egamma python offline mon code).
- tidy up matching tool and include necessary features to emulate;
- change keys (harmonisation);
- include steps into the emulator;
Ping: @mverissi, @eegidiopJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42139WIP:Looser InDetVKalVxInJetTool2021-04-07T12:40:57+02:00Vadim KostyukhinWIP:Looser InDetVKalVxInJetTool1) Change default jobO CutBVrtScore 0.015->0.005 to increase efficiency for the price of bigger fake rate
2) Correct N2Tpair calculation AFT-549
3) Remove wrong cut on radial error and correct Sig3D cut, non-working previously
4) Code cl...1) Change default jobO CutBVrtScore 0.015->0.005 to increase efficiency for the price of bigger fake rate
2) Correct N2Tpair calculation AFT-549
3) Remove wrong cut on radial error and correct Sig3D cut, non-working previously
4) Code cleaning - commented lines and tabs
5) A bit more information in debugging ntuples