athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T10:35:24+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70140distinguish two steps with different name in muComb (ATR-29040)2024-03-28T10:35:24+01:00Francesca Pastoredistinguish two steps with different name in muComb (ATR-29040)https://gitlab.cern.ch/atlas/athena/-/merge_requests/69686athena.py: remove athena-specific history and readline setup2024-03-12T09:36:46+01:00Frank Winklmeierathena.py: remove athena-specific history and readline setupRemove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.Remove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69396Update ThinCAWrapper.sh - also allow scripts to be located in the joboption...2024-03-04T10:07:36+01:00Will ButtingerUpdate ThinCAWrapper.sh - also allow scripts to be located in the joboption...Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66212Fix possible deadlock between AddressRemappingSvc and SGImplSvc.2023-10-11T03:59:28+02:00Goetz GayckenFix possible deadlock between AddressRemappingSvc and SGImplSvc.A deadlock may occur between the SGImplSvc and the AddressRemappingSvc. One of such situations may arise if VarHandleBase::typeless_dataPointer calls AddressRemappingSvc::updateAddress without passing through SGImplSvc and
and a differe...A deadlock may occur between the SGImplSvc and the AddressRemappingSvc. One of such situations may arise if VarHandleBase::typeless_dataPointer calls AddressRemappingSvc::updateAddress without passing through SGImplSvc and
and a different thread calls VarHandleBase::record_impl which calls SGImplSvc::record_impl which calls AddressRemappingSvc::updateAddress. So, two threads may try to lock the same two locks but in different order, which may lead to a deadlock.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65094AtlasCITest - Switch on CA in cosmic test2023-08-28T12:21:10+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chAtlasCITest - Switch on CA in cosmic testWe're running most of the stuff in CA anyway
Tagging: @tadej, @nstyles, @jcatmore, @jmaurer, @wlamplWe're running most of the stuff in CA anyway
Tagging: @tadej, @nstyles, @jcatmore, @jmaurer, @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63554Add asserts for static analyzers2023-06-10T01:14:06+02:00Adam Edward BartonAdd asserts for static analyzersStatic analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.Static analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58327refactor HTT flag to use ActivePass2022-11-25T10:38:19+01:00Katarzyna Suchrefactor HTT flag to use ActivePassThis MR changes `HTTConfigFlags` in order to dynamically load flags (e.g. "Hough" flags) and refactors `HTTLogicalHistProcessAlg` to use `cloneAndReplace`This MR changes `HTTConfigFlags` in order to dynamically load flags (e.g. "Hough" flags) and refactors `HTTLogicalHistProcessAlg` to use `cloneAndReplace`https://gitlab.cern.ch/atlas/athena/-/merge_requests/57583The get methods of the ROBDataProviderSvc can be made const2022-10-17T20:13:24+02:00Christos Anastopouloschristos.anastopoulos@cern.chThe get methods of the ROBDataProviderSvc can be made constThe get methods of the ROBDataProviderSvc can be made const
This seems possible here.
We seem to have ``tbb::concurent_map`` and also a ``lock`` for the hlt implementation,
when doing kind of a lazy init from ``getRobData`` via the int...The get methods of the ROBDataProviderSvc can be made const
This seems possible here.
We seem to have ``tbb::concurent_map`` and also a ``lock`` for the hlt implementation,
when doing kind of a lazy init from ``getRobData`` via the internal ``eventCache_addRobData``
ping @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57333Adding 'icalonocut' WP to Photon Isolation hypo + Adding 'icalonocut' Photon+...2022-10-12T16:02:07+02:00Marco MontellaAdding 'icalonocut' WP to Photon Isolation hypo + Adding 'icalonocut' Photon+Jets TLA chainsAs discussed in: [ATR-26421](https://its.cern.ch/jira/browse/ATR-26421)
This MR adds the 'icalonocut' passthrough working points for the Photon isolation in the relevant TrigEgammaHypo, TrigEgammaMonitoring and TrigEgammaMatchingTool pa...As discussed in: [ATR-26421](https://its.cern.ch/jira/browse/ATR-26421)
This MR adds the 'icalonocut' passthrough working points for the Photon isolation in the relevant TrigEgammaHypo, TrigEgammaMonitoring and TrigEgammaMatchingTool packages.
Furthermore, the corresponding isolation variables are added to the TLA EDM in order for them to be saved to the TLA stream, and three new TLA chains with explicit isolation calculation, differing by the photon threshold.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53440CxxUtils+AthenaCommon+AthenaServices: Add checked_tcmalloc.2022-05-20T09:31:30+02:00Scott SnyderCxxUtils+AthenaCommon+AthenaServices: Add checked_tcmalloc.Build a version of tcmalloc with extra error checking.
The code is taken from gperftools 2.8.1, modified for extra checking
and for building as part of CxxUtils.
It is built into a separate shared library, so won't have any effect
unless...Build a version of tcmalloc with extra error checking.
The code is taken from gperftools 2.8.1, modified for extra checking
and for building as part of CxxUtils.
It is built into a separate shared library, so won't have any effect
unless that library is explicitly loaded.
Only tested for linux/gcc/x86_64, so for now only build for that platform.
To assist in catching errors like double-frees and overwrites.
Adds a --checked-tcmalloc flag to Athena.
Have CoreDumpSvc handle SIGABRT as well.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51469Fortran Warning Fixes, master branch (2022.03.22.)2022-03-22T21:43:56+01:00Attila KrasznahorkayFortran Warning Fixes, master branch (2022.03.22.)Made sure that all `DO`-loops would end in a `CONTINUE` statement, and that nested `DO`-loops would not share the same `CONTINUE` statement. Which apparently are both removed as a possibility from Fortran 2018.
Note that there are a num...Made sure that all `DO`-loops would end in a `CONTINUE` statement, and that nested `DO`-loops would not share the same `CONTINUE` statement. Which apparently are both removed as a possibility from Fortran 2018.
Note that there are a number of places in the code that used to look like the following:
```fortran
DO 10 I=1,10
DO 10 J=1,10
...
IF (<SOMETHING>) GOTO 10
...
10 CONTINUE
```
I have no idea how this should be fixed. :frowning: Should it be
```fortran
DO 10 I=1,10
DO 20 J=1,10
...
IF (<SOMETHING>) GOTO 10
...
20 CONTINUE
10 CONTINUE
```
or
```fortran
DO 10 I=1,10
DO 20 J=1,10
...
IF (<SOMETHING>) GOTO 20
...
20 CONTINUE
10 CONTINUE
```
??? I went with the latter one in this MR. But somebody more versed in Fortran should really speak up... :thinking: @ssnyder, are you sure about this part? (After some tests, as shown in the MR's discussion, the latter one turned out to be the correct solution.)
This is meant as a replacement for !51454, fixing/addressing AGENE-2140 and ATLINFR-4464.
Pinging @fwinkl as well, just for good measure. :stuck_out_tongue:https://gitlab.cern.ch/atlas/athena/-/merge_requests/51454Hijing_i: Fix fortran compilation warnings.2022-03-22T18:44:24+01:00Scott SnyderHijing_i: Fix fortran compilation warnings.Fix warnings related to deprecated do-loop constructions.
Fixes AGENE-2140 and relates to ATLINFR-4464.Fix warnings related to deprecated do-loop constructions.
Fixes AGENE-2140 and relates to ATLINFR-4464.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51356JetMatcherAlg - add protection in case no JFEX L1 jet container is available ...2022-04-12T09:40:36+02:00Peter SherwoodJetMatcherAlg - add protection in case no JFEX L1 jet container is available (ATR-25147) JetMatcherAlg add protection in case no JFEX L1 jet container is available.
@Sawyer @schaarsc @ayana @cantel @peter
Tagging ATR-25147 JetMatcherAlg add protection in case no JFEX L1 jet container is available.
@Sawyer @schaarsc @ayana @cantel @peter
Tagging ATR-25147Peter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50541RungeKuttaPropagator - Introduce limit on back & forth extrapolations on the ...2022-03-02T10:22:04+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRungeKuttaPropagator - Introduce limit on back & forth extrapolations on the same surfaceCloses ATLASRECTS-6829
Tagging: @sroe, @goblirsc,@christos for ~"review-pending-expert"Closes ATLASRECTS-6829
Tagging: @sroe, @goblirsc,@christos for ~"review-pending-expert"https://gitlab.cern.ch/atlas/athena/-/merge_requests/50439AnalysisTop: Update config files to use new central PRW files2022-02-15T03:44:12+01:00Oliver MajerskyAnalysisTop: Update config files to use new central PRW filesThis updates the example AnalysisTop tutorial config file to read new location in cvmfs for pileup reweighting files, used by the top phys group.This updates the example AnalysisTop tutorial config file to read new location in cvmfs for pileup reweighting files, used by the top phys group.https://gitlab.cern.ch/atlas/athena/-/merge_requests/5001622.0-cleanup-PixelConditionsData2022-05-02T13:29:05+02:00Shaun Roe22.0-cleanup-PixelConditionsDataThis MR addresses ATLASRECTS-4509 by deleting copy and assignment on the PixelOfflineCalibData object. Additional small cleanup also performed (change bare pointer members to unique_ptr). *However* while doing this I spotted that a 'resi...This MR addresses ATLASRECTS-4509 by deleting copy and assignment on the PixelOfflineCalibData object. Additional small cleanup also performed (change bare pointer members to unique_ptr). *However* while doing this I spotted that a 'resize' on the constants vector was used, when I'm (fairly) sure that reserve was intended. The result of the original code would have doubled the size of the constants vector and placed all zeroes in the first half. Thus, if this is ever used, the output of the 'constants' (on file?) will have changed with this MR. For this reason, a Pixel expert (@stsuno, @tlari , @battagl) should take a look at the code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916Disable CaloMuonLikelihoodTool2022-02-10T12:30:13+01:00Emma Catherine GoddenDisable CaloMuonLikelihoodToolDisabling old CaloMuonLikelihood tool in the configuration. [ATLASRECTS-6786](https://its.cern.ch/jira/browse/ATLASRECTS-6786).
This means the CaloLRLikelihood variable is no longer set in [MuonCreatorTool.cxx](https://gitlab.cern.ch/at...Disabling old CaloMuonLikelihood tool in the configuration. [ATLASRECTS-6786](https://its.cern.ch/jira/browse/ATLASRECTS-6786).
This means the CaloLRLikelihood variable is no longer set in [MuonCreatorTool.cxx](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs#6d2fc1339eb0922cd081313503966caa70d9e1dd_708_707), so updated the AuxContainer introducing [MuonAuxContainer_v6](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs#diff-content-7155acdd6568c63ec546720199cf1c6a6eccfd8e). The changes wrt to _v5 is the removal of the CaloLRLikelihood variable ( [this line](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49916/diffs?diff_id=1443663#c8a0cb87305d4166647f3b4b055c047a7f0c78d6_170_170) )https://gitlab.cern.ch/atlas/athena/-/merge_requests/49351Port DataQualityUtils and DataQualityConfigurations over from master to 22.0-...2022-01-08T11:45:43+01:00Sara StrandbergPort DataQualityUtils and DataQualityConfigurations over from master to 22.0-mc20Move the content of DataQualityUtils and DataQualityConfigurations from the master branch to 22.0-mc20. The pixel configs in DataQualityConfigurations/config/Pixel/ stay as in 22.0-mc20 since those in master are not compatible with the H...Move the content of DataQualityUtils and DataQualityConfigurations from the master branch to 22.0-mc20. The pixel configs in DataQualityConfigurations/config/Pixel/ stay as in 22.0-mc20 since those in master are not compatible with the HIST files from the reprocessing. The MR is needed since the 22.0-mc20 branch will be used to make the DQ Web Displays for the release 22 reprocessing campaign while the master branch will be used for development towards Run 3.
When running the RunTier0Tests.py script there are errors from the q221 Frozen Tier0 Policy Test, see [RunTier0Tests.log](/uploads/ca7b86c7b5e2ff1831370c00598a3538/RunTier0Tests.log), but they seem unrelated to my changes so I am not sure what to do.Peter BertaPeter Bertahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46408Sweeping !46387 from master to 22.0-mc20.
Fix for hit sorting issueCloses ATL...2021-09-15T15:45:24+02:00Atlas NightlybuildSweeping !46387 from master to 22.0-mc20.
Fix for hit sorting issueCloses ATLASRECTS-6410Fix for hit sorting issue
Closes ATLASRECTS-6410
See merge request atlas/athena!46387Fix for hit sorting issue
Closes ATLASRECTS-6410
See merge request atlas/athena!46387