athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T14:11:48+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70055Fix q454 references2024-03-22T14:11:48+01:00Frank WinklmeierFix q454 referencesFix references for q454. See ATLASRECTS-7944.Fix references for q454. See ATLASRECTS-7944.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69911TrigT2CaloEgamma: fix FPE2024-03-20T08:15:46+01:00Bertrand Martin Dit LatourTrigT2CaloEgamma: fix FPEHello,
This MR is fixing a FPE introduced in !67310 (ATR-28988).
Marking as urgent as the FPE is showing up in many trigger ART tests.
Cheers,
BertrandHello,
This MR is fixing a FPE introduced in !67310 (ATR-28988).
Marking as urgent as the FPE is showing up in many trigger ART tests.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69376Allow DigitizationTests ART jobs to find 24.0-specific reference files (ATLAS...2024-03-01T20:36:13+01:00John Derek ChapmanAllow DigitizationTests ART jobs to find 24.0-specific reference files (ATLASSIM-7095)This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68718Nightly Trigger Update, 21.2 branch (2024.02.08.)2024-02-08T21:52:52+01:00Attila KrasznahorkayNightly Trigger Update, 21.2 branch (2024.02.08.)Synchronized `Athena/version.txt` with `AnalysisBase/version.txt`. Purely to trigger a new nightly build for @robouque for Friday, as discussed on ATLINFR-5242. :wink:
@aundrus, I only saw your message on JIRA now. :frowning: I'll just ...Synchronized `Athena/version.txt` with `AnalysisBase/version.txt`. Purely to trigger a new nightly build for @robouque for Friday, as discussed on ATLINFR-5242. :wink:
@aundrus, I only saw your message on JIRA now. :frowning: I'll just merge this in quickly, now that I already set everything up...https://gitlab.cern.ch/atlas/athena/-/merge_requests/68698Fixes for DigitizationTests ART jobs (ATLASSIM-7076)2024-02-08T19:42:48+01:00John Derek ChapmanFixes for DigitizationTests ART jobs (ATLASSIM-7076)Some variables in the DigitizationTests scripts had not been renamed properly. This caused ATLASSIM-7076.
Fixed this instance, plus a few other non-serious ones.
Tagging @zhubacekSome variables in the DigitizationTests scripts had not been renamed properly. This caused ATLASSIM-7076.
Fixed this instance, plus a few other non-serious ones.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68651Fix mc23 presampling ART tests2024-02-07T16:30:33+01:00Tadej Novaktadej.novak@cern.chFix mc23 presampling ART testsFix MC23 presampling ART tests - there was a typo in file paths.
/cc @jchapman @zhubacekFix MC23 presampling ART tests - there was a typo in file paths.
/cc @jchapman @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68265ATR-28678 - L1 Jet items legacy removal2024-02-06T22:42:30+01:00Marco RimoldiATR-28678 - L1 Jet items legacy removalThis MR is removing the some L1 Jet items legacy and replacing by the new Phase 1 trigger.
https://its.cern.ch/jira/browse/ATR-28678
- Follow-up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/68248. Moving the multi-b-jet TL...This MR is removing the some L1 Jet items legacy and replacing by the new Phase 1 trigger.
https://its.cern.ch/jira/browse/ATR-28678
- Follow-up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/68248. Moving the multi-b-jet TLA dev chain (https://its.cern.ch/jira/browse/ATR-23002) to Phase1 Items. cc @cantelMarco RimoldiMarco Rimoldihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67671MuonTrackingGeometry material updates2024-01-22T15:06:55+01:00Sarka TodorovaMuonTrackingGeometry material updatesCollects updates and bugfixes in the handling of the detector material.
Targets: ATLASRECTS-7840Collects updates and bugfixes in the handling of the detector material.
Targets: ATLASRECTS-7840Sarka TodorovaSarka Todorovahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67454Update version.txt2023-11-29T11:48:03+01:00Emma Torro PastorUpdate version.txtUpdating R21 derivation cacheUpdating R21 derivation cachehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67132PyDumper: Fix null pointer check.2023-11-15T20:59:37+01:00Scott SnyderPyDumper: Fix null pointer check.Fix check for null pointer in dump_auxdata.
See ATLASRECTS-7808.Fix check for null pointer in dump_auxdata.
See ATLASRECTS-7808.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67088Revert "Merge branch 'main-tp-separate-larttl1' into 'main'"2023-11-14T07:02:16+01:00Alaettin Serhan MeteRevert "Merge branch 'main-tp-separate-larttl1' into 'main'"This reverts merge request !66964This reverts merge request !66964https://gitlab.cern.ch/atlas/athena/-/merge_requests/66775Bump Acts Tag to v30.3.22023-10-28T09:42:05+02:00Carlo Varnicarlo.varni@cern.chBump Acts Tag to v30.3.2This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.ce...This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.cern.ch/atlas/athena/-/merge_requests/66290https://gitlab.cern.ch/atlas/athena/-/merge_requests/66429Sweeping !66424 from main to 21.2.
EventLoop: fix gcc13 compilation2023-10-12T03:43:24+02:00Atlas NightlybuildSweeping !66424 from main to 21.2.
EventLoop: fix gcc13 compilationEventLoop: fix gcc13 compilation
See merge request atlas/athena!66424EventLoop: fix gcc13 compilation
See merge request atlas/athena!66424https://gitlab.cern.ch/atlas/athena/-/merge_requests/66331StorageSvc: Fix for gcc13 builds2023-10-08T15:43:04+02:00Johannes ElmsheuserStorageSvc: Fix for gcc13 buildsMR https://gitlab.cern.ch/atlas/athena/-/merge_requests/66093 broke the gcc13 builds.
Add missing `#include <cstdint>` in 2 `StorageSvc` header files for LCG104 and dev4LCG gcc13 builds.
Tag for info @mnowakMR https://gitlab.cern.ch/atlas/athena/-/merge_requests/66093 broke the gcc13 builds.
Add missing `#include <cstdint>` in 2 `StorageSvc` header files for LCG104 and dev4LCG gcc13 builds.
Tag for info @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66187ATLASRECTS-7761: DecorHandles lock when going out of scope2023-10-06T15:58:53+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-7761: DecorHandles lock when going out of scopeATLASRECTS-7761:
WriteDecorHandles lock when going out of scope.
So we can not have them created inside a for loop(given a condition)
Should help with failing SPOT testsATLASRECTS-7761:
WriteDecorHandles lock when going out of scope.
So we can not have them created inside a for loop(given a condition)
Should help with failing SPOT testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66113Adding chains seeded off TAU1_TRT items to HI menu2023-10-04T02:42:08+02:00Jakub KremerAdding chains seeded off TAU1_TRT items to HI menuFollowing some optimizations of the TRT FastOr trigger and the request made by @mdyndal and @derendar in [ATR-22067](https://its.cern.ch/jira/browse/ATR-22067?focusedId=4952674&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomme...Following some optimizations of the TRT FastOr trigger and the request made by @mdyndal and @derendar in [ATR-22067](https://its.cern.ch/jira/browse/ATR-22067?focusedId=4952674&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-4952674), this MR adds three new L1 items using the TAU1_TRT combination and corresponding HLT chains to the HI menu.
Also adding HLT_2mu4_bDimu_L12MU3V to express stream following request from @tursom in ATR-24367.
Tagging @asmaga for HI trigger, @shanisch and @tnobe for trigger operation, @lidiaz, @astruebi and @fgiuli for trigger menu.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65958Update heavyions_run.config with new DQ references for the express, physics_M...2023-09-24T16:52:49+02:00Sara StrandbergUpdate heavyions_run.config with new DQ references for the express, physics_Main and UPC streamsMerge request to change the DQ reference HIST files to reprocessed versions of the 2022 HI and 2017 5 TeV pp reference runs. Needed for offline DQ monitoring of Heavy Ion data.
The info in CentrallyManagedReferences, CentrallyManagedRef...Merge request to change the DQ reference HIST files to reprocessed versions of the 2022 HI and 2017 5 TeV pp reference runs. Needed for offline DQ monitoring of Heavy Ion data.
The info in CentrallyManagedReferences, CentrallyManagedReferences_Main and CentrallyManagedReferences_UPC in DataQuality/DataQualityConfigurations/config/common/heavyions_run.config has been updated. And the corresponding root files have been copied to /eos/atlas/atlascerngroupdisk/data-dqm/references/
The RunWorkflowTests_Run3.py has been run and the summary is pasted below. The test fails, but I get the same test even if I run it directly on the latest nightly, without making any modifications. I attach both log files, Run3Tests.log for the modified code corresponding to this MR, and Run3Tests_noChanges.log for the unmodified code from the latest nightly (2023-09-20T2101).
*******************************'
09-21 16:28 INFO -----------------------------------------------------
09-21 16:28 ERROR DQHistogramMerge reference test step failed
09-21 16:28 ERROR One or more q449 Athena steps failed. Please investigate the cause.
09-21 16:28 INFO -----------------------------------------------------
09-21 16:28 INFO ---------------------- Summary ----------------------
09-21 16:28 ERROR ALL TESTS: FAILED (10)
[Run3Tests.log](/uploads/58a09bf3b81f1b9c86c5e066d0f13940/Run3Tests.log)
[Run3Tests_noChanges.log](/uploads/4746c623921ecb509e243e213bf260a2/Run3Tests_noChanges.log)
Tagging @ytakubo and @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65950Add `pixCLnoToT` to `HLT_SpacePointCounts` container2023-09-24T16:52:49+02:00Krzysztof Cieslakrzysztof.marcin.ciesla@cern.chAdd `pixCLnoToT` to `HLT_SpacePointCounts` container!64190 added new counter in `TrigCountSpacePoints` tool -- `pixCLnoToT`. However, the new counter was not propagated further into `HLT_SpacePointCounts` container (i.e. for DQ monitoring). This MR fixes this.
CC: @tbold!64190 added new counter in `TrigCountSpacePoints` tool -- `pixCLnoToT`. However, the new counter was not propagated further into `HLT_SpacePointCounts` container (i.e. for DQ monitoring). This MR fixes this.
CC: @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65931ZDC: implement EventInfo flags in case of LUCROD decoding failure, and update...2023-09-24T16:52:50+02:00Peter Alan SteinbergZDC: implement EventInfo flags in case of LUCROD decoding failure, and update to ZdcRecConfigTwo major changes:
- Implemented check on LUCROD decoding (at the moment just a check on the number of successfully decoded fragments), and reconstruction is skipped if so. A specific bit in the EventInfo (ForwardDet flags, position spe...Two major changes:
- Implemented check on LUCROD decoding (at the moment just a check on the number of successfully decoded fragments), and reconstruction is skipped if so. A specific bit in the EventInfo (ForwardDet flags, position specified in ZdcUtils/ZdcEventInfo.h) is set in this case. This should resolve (https://its.cern.ch/jira/browse/ATR-28155)
- Major update to ZdcRec/python/ZdcRecConfig.py including support for new MC RDOs and LED ntuple production, as needed by Tier0https://gitlab.cern.ch/atlas/athena/-/merge_requests/65881Heavy Ion : Disable out-of-time pileup topo cluster cut2023-09-24T16:52:50+02:00Christos Anastopouloschristos.anastopoulos@cern.chHeavy Ion : Disable out-of-time pileup topo cluster cutHeavy Ion : Disable out-of-time pileup topo cluster cut
Following discussion in ATLHI-501 and chat with @gunal
>Indeed there is ~ no out of time pileup in HI collisions.
@angerami @stapiaar @igrabows .
The p-p ref will use the ``H...Heavy Ion : Disable out-of-time pileup topo cluster cut
Following discussion in ATLHI-501 and chat with @gunal
>Indeed there is ~ no out of time pileup in HI collisions.
@angerami @stapiaar @igrabows .
The p-p ref will use the ``HIP`` setup or something else?
As we need to be sure this is set for this also .
>I guess the main point would be to then have the pp reference run with the same setup