athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-15T16:13:17+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67854Fix two cppcheck warnings2023-12-14T18:53:06+01:00Andrii VerbytskyiFix two cppcheck warningsFix two cppcheck warnings:
```
athena/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData/src/NswErrorCalibData.cxx
parameter 'pars' should be passed by const reference.
```
and
```
athena/Control/xAODRootAccess/Root/TEven...Fix two cppcheck warnings:
```
athena/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData/src/NswErrorCalibData.cxx
parameter 'pars' should be passed by const reference.
```
and
```
athena/Control/xAODRootAccess/Root/TEvent.cxx or there is possible null pointer dereference: tmpMetaTree.
```
@sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67772MuonReadoutGeometry: fix compilation problems in debug.2023-12-12T11:50:41+01:00Edward MoyseMuonReadoutGeometry: fix compilation problems in debug.The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(...The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(gasGap, gang));
return 0.05 * CLHEP::mm;
}
```
const was removed in opt but not dbg. But we cannot remove const here too because `validGang` is const, and changing this will have knock-on consequences in all the other const methods.
Reverting the static change for this function.
Fixes ATLASRECTS-7858https://gitlab.cern.ch/atlas/athena/-/merge_requests/67673[ATR-24829] Switch on ERROR mode for HLT seeding validation2023-12-07T14:05:06+01:00Tim Martin[ATR-24829] Switch on ERROR mode for HLT seeding validationWas not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.Was not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67513Ensure release-specific compatibility for HepMC2 and HepMC32023-12-01T00:25:35+01:00Kartik Deepak Bhidekartik.deepak.bhide@cern.chEnsure release-specific compatibility for HepMC2 and HepMC3Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Kartik Deepak Bhidekartik.deepak.bhide@cern.chKartik Deepak Bhidekartik.deepak.bhide@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67393TrigValSteering: increase timeout for build tests2023-11-27T15:41:19+01:00Bertrand Martin Dit LatourTrigValSteering: increase timeout for build testsHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
BertrandHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67357Drop barcodes from test hepmc2023-11-24T11:38:36+01:00Andrii VerbytskyiDrop barcodes from test hepmcDrop barcodes from test hepmc
@jchapman @pclarkDrop barcodes from test hepmc
@jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67131attempt to work around ATLASRECTS-78082023-11-15T20:59:37+01:00Walter Lamplattempt to work around ATLASRECTS-7808comment out problematic lines in Dumpers.py to get the CI going again.
ping @ssnyder, @akrasznacomment out problematic lines in Dumpers.py to get the CI going again.
ping @ssnyder, @akrasznahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67127test chains for DPJ trigger ATR-284122023-11-15T15:15:50+01:00Zhongyukun Xuzhongyukun.xu@cern.chtest chains for DPJ trigger ATR-28412New trigger into Dev chains
test VBF inclusive low threshold
test VBF+msonly
test VBF+nscanNew trigger into Dev chains
test VBF inclusive low threshold
test VBF+msonly
test VBF+nscanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67010Revert "Merge branch 'Lar_tidy_III' into 'main'"2023-11-09T22:32:05+01:00Christos Anastopouloschristos.anastopoulos@cern.chRevert "Merge branch 'Lar_tidy_III' into 'main'"This reverts merge request !66978
Tag ATLINFR-5144.
This actually touch the identifier parts.This reverts merge request !66978
Tag ATLINFR-5144.
This actually touch the identifier parts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67003Working with 422 clusters2023-11-09T19:26:36+01:00Dylan Sheldon RankinWorking with 422 clustershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66970Draft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells2023-11-08T16:11:46+01:00Denis Oliveira DamazioDraft: Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cellsFor the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.For the appreciation of @solodkov.
Fix TileROD_Decoder to enable TPCnv for HLTCalo unpacked cells.
Discussed in ATR-27663.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66957Make minbias setup the same in CA and legacy (ATR-28356)2023-11-08T10:03:27+01:00Stewart Martin-HaughMake minbias setup the same in CA and legacy (ATR-28356)Use the same configuration in CA and legacy.
I actually don't see any minbias chains being enabled here. Have yet to figure out why.Use the same configuration in CA and legacy.
I actually don't see any minbias chains being enabled here. Have yet to figure out why.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66944InDetByteStreamErrors+TrigSteeringEvent+TrkEventUtils: Add some missing dicti...2023-11-06T21:12:27+01:00Scott SnyderInDetByteStreamErrors+TrigSteeringEvent+TrkEventUtils: Add some missing dictionary entries..For use by PyDumper.For use by PyDumper.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66896Yinmiao23.02023-11-03T10:52:48+01:00Yinmiao WangYinmiao23.0Add a flip strategy SIMPLE_FLIP, which flip the sign of detector signed IPs (d0, z0SinTheta) and lifetime-signed IPs(IP3D_signed_d0_significance, IP3D_signed_z0_significance).Add a flip strategy SIMPLE_FLIP, which flip the sign of detector signed IPs (d0, z0SinTheta) and lifetime-signed IPs(IP3D_signed_d0_significance, IP3D_signed_z0_significance).https://gitlab.cern.ch/atlas/athena/-/merge_requests/66847fix legacy q449 CI tests2023-11-01T20:58:08+01:00Julien Maurerfix legacy q449 CI testsThis should in principle fix the currently-failing CI tests if the recent modifications to the q449 tag are kept.
FYI @christos @wlamplThis should in principle fix the currently-failing CI tests if the recent modifications to the q449 tag are kept.
FYI @christos @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66808Add logger to Navigators2023-10-29T14:43:52+01:00Carlo Varnicarlo.varni@cern.chAdd logger to Navigatorsself explainingself explaininghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66506ATLINFR-5105: Disable h5ls test for Athena2023-10-16T16:08:22+02:00Dan GuestATLINFR-5105: Disable h5ls test for AthenaThis is stop-gap solution while we sort out all the issues in ATLINFR-5105. Disable the checks that use `h5ls` in Athena builds.This is stop-gap solution while we sort out all the issues in ATLINFR-5105. Disable the checks that use `h5ls` in Athena builds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66504ATLINFR-5105: Remove versioning for hdf5utils2023-10-16T13:49:39+02:00Dan GuestATLINFR-5105: Remove versioning for hdf5utilsI think we were being overly strict about the version of HDF5 we require to build this library.I think we were being overly strict about the version of HDF5 we require to build this library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66408Bump Acts Tag to v30.1.12023-10-11T16:09:45+02:00Carlo Varnicarlo.varni@cern.chBump Acts Tag to v30.1.1This bumps ACTS from v30.1.0 to v30.1.1
Release notes of in-between versions:
* [v30.1.1](https://github.com/acts-project/acts/releases/tag/v30.1.1)This bumps ACTS from v30.1.0 to v30.1.1
Release notes of in-between versions:
* [v30.1.1](https://github.com/acts-project/acts/releases/tag/v30.1.1)