athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-01-23T03:02:54+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20533TileByteStream: Test BS converters in MT mode.2019-01-23T03:02:54+01:00Scott SnyderTileByteStream: Test BS converters in MT mode.Run BS converter tests in both sequential and MT modes and ensure
that the results are identical.Run BS converter tests in both sequential and MT modes and ensure
that the results are identical.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20534FastCaloSim: Making FastShowerCellBuilderTool const.2019-01-23T03:03:26+01:00Scott SnyderFastCaloSim: Making FastShowerCellBuilderTool const.TH1::GetRandom() and TH2::GetRandom2() are not MT-safe, since they're
non-const and also use gRandom. These are used from
ParticleEnergyParametrization. Rewrite so as to be const and to allow
passing in a random generator rather than h...TH1::GetRandom() and TH2::GetRandom2() are not MT-safe, since they're
non-const and also use gRandom. These are used from
ParticleEnergyParametrization. Rewrite so as to be const and to allow
passing in a random generator rather than having to use gRandom.
(We currently still pass in gRandom. Changing that would change rng seeding,
so that will be fixed in a subsequent change.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20535TrigCostRootAnalysis: Fix gcc9 warnings.2019-01-23T03:03:37+01:00Scott SnyderTrigCostRootAnalysis: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20536TileTripReader: TAccept->AcceptData2019-01-23T03:02:46+01:00Scott SnyderTileTripReader: TAccept->AcceptDataMigrate from using TAccept to AcceptData.
Needed for MT compatibility.Migrate from using TAccept to AcceptData.
Needed for MT compatibility.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20537D2PDMaker: TAccept->AcceptData2019-01-23T03:02:51+01:00Scott SnyderD2PDMaker: TAccept->AcceptDataRemove from D2PDSelectorBase references to IAthSelectorTool.
This interface uses TAccept but is implemented in master by only one tool,
AthTileTripReader. Further, there seem to be no configurations which actually
configure D2PDSelector...Remove from D2PDSelectorBase references to IAthSelectorTool.
This interface uses TAccept but is implemented in master by only one tool,
AthTileTripReader. Further, there seem to be no configurations which actually
configure D2PDSelectorBase to use AthTileTripReader.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20526AthenaConfiguration: Factor out AppMgr creation in ComponentAccumulator.2019-01-23T03:02:39+01:00Scott SnyderAthenaConfiguration: Factor out AppMgr creation in ComponentAccumulator.Factor the code to create the AppMgr out of ComponentAccumulator.run
into a separate function. This then allows one to call the event
loop functions interactively. Mostly for debugging purposes.Factor the code to create the AppMgr out of ComponentAccumulator.run
into a separate function. This then allows one to call the event
loop functions interactively. Mostly for debugging purposes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20538JetSelectorTools: TAccept->AcceptData2019-01-23T03:02:36+01:00Scott SnyderJetSelectorTools: TAccept->AcceptDataMigrate from TAccept to AcceptData, for MT compatibility.Migrate from TAccept to AcceptData, for MT compatibility.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20540TrigTauEmulation: TAccept->AcceptData2019-01-23T03:03:40+01:00Scott SnyderTrigTauEmulation: TAccept->AcceptDataMigrate from TAccept to AcceptData, for MT compatibility.Migrate from TAccept to AcceptData, for MT compatibility.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20505In VP1EventProd use EventContext instead of EventInfo2019-01-23T03:02:50+01:00Vakhtang TsulaiaIn VP1EventProd use EventContext instead of EventInfohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20524Fix naming of muon systematics for RCJet processor2019-02-14T13:48:17+01:00Mark Andrew OwenFix naming of muon systematics for RCJet processorThis should fix a bug in the assumed name of the muon systematics in the RC jet processor (see ANALYSISTO-744).This should fix a bug in the assumed name of the muon systematics in the RC jet processor (see ANALYSISTO-744).https://gitlab.cern.ch/atlas/athena/-/merge_requests/20572fix an unchecked StatusCode and some broken asserts2019-01-25T03:03:52+01:00Nils Erik Krumnackfix an unchecked StatusCode and some broken assertsApparently that bug was introduced with the last change. We should probably hold off on building the release until this goes in.Apparently that bug was introduced with the last change. We should probably hold off on building the release until this goes in.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20604TDAQ Finding Updates, master branch (2019.01.24.)2019-01-25T11:37:54+01:00Attila KrasznahorkayTDAQ Finding Updates, master branch (2019.01.24.)Updated the PostConfig files of the projects to set up tdaq releases correctly...
After the update in the naming convention for the variables specifying where to pick up tdaq releases from (!20525), I forgot to update the `PostConfig.cm...Updated the PostConfig files of the projects to set up tdaq releases correctly...
After the update in the naming convention for the variables specifying where to pick up tdaq releases from (!20525), I forgot to update the `PostConfig.cmake` files generated by the releases to use this same convention. :frowning2: This is fixing that.
At the same time I made the variables into cache variables, so it would be easier to override these defaults while building a project (like [WorkDir](https://gitlab.cern.ch/atlas/athena/tree/master/Projects/WorkDir)) on top of a release.
@ssnyder, @tsulaia, this is the MR which should fix the issue with the nightly...https://gitlab.cern.ch/atlas/athena/-/merge_requests/20595Bugfix importing tools in RunTier0Test.py2019-02-15T14:07:12+01:00Alaettin Serhan MeteBugfix importing tools in RunTier0Test.pyIn !20514 we started importing a new module in RunTier0Test.py. When running locally (also on the CI) everything is fine since the new module is in the same directory and the executable for RunTier0Test.py is simply a symlink to the file...In !20514 we started importing a new module in RunTier0Test.py. When running locally (also on the CI) everything is fine since the new module is in the same directory and the executable for RunTier0Test.py is simply a symlink to the file in that folder. However, this doesn't fly, obviously, in the nightly as the executable is copied under the appropriate bin/ folder so the new module cannot be found. This MR fixes that issue.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20599TrigEgammaEmulationTool+TrigEgammaAnalysisTools: TAccept->AcceptData.2019-01-25T03:02:24+01:00Scott SnyderTrigEgammaEmulationTool+TrigEgammaAnalysisTools: TAccept->AcceptData.Migrate from TAccept to AcceptData for MT compatibility.Migrate from TAccept to AcceptData for MT compatibility.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20523Upgrade python code style ckecker to flake8 3.6.02019-01-25T03:02:46+01:00Frank WinklmeierUpgrade python code style ckecker to flake8 3.6.0* Upgrade the python code style ckecker `flake8` to its latest version (3.6.0) and all required dependencies as well
* Fix a few additional code issues for the packages were the flake8 unit tests is used
* catching bare exceptions
...* Upgrade the python code style ckecker `flake8` to its latest version (3.6.0) and all required dependencies as well
* Fix a few additional code issues for the packages were the flake8 unit tests is used
* catching bare exceptions
* use double-backslash to print backslashhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20594Master vp1 arbitraryline guideline2019-01-25T03:02:45+01:00Edward MoyseMaster vp1 arbitraryline guidelineAdds the ability to draw a line from the origin with a configurable eta/phi/lengthAdds the ability to draw a line from the origin with a configurable eta/phi/lengthhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20622TrigCostRootAnalysis: Comply with ATLAS naming conventions.2019-01-26T03:02:43+01:00Scott SnyderTrigCostRootAnalysis: Comply with ATLAS naming conventions.Update some comments containing identifiers that were renamed earlier.Update some comments containing identifiers that were renamed earlier.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20612Sweeping !20595 from master to 21.9.
Bugfix importing tools in RunTier0Test.py2019-04-25T13:11:53+02:00Atlas NightlybuildSweeping !20595 from master to 21.9.
Bugfix importing tools in RunTier0Test.pyBugfix importing tools in RunTier0Test.py
See merge request atlas/athena!20595Bugfix importing tools in RunTier0Test.py
See merge request atlas/athena!20595https://gitlab.cern.ch/atlas/athena/-/merge_requests/20640Update InDetJobProperties.py so that we don't do SLHC conversion finding2019-01-25T20:02:19+01:00Nicholas StylesUpdate InDetJobProperties.py so that we don't do SLHC conversion findingUpdate InDetJobProperties.py so that we don't do SLHC conversion finding by default (not currently working). Already disabled explicitly in RAWtoESD, so this will make the settings consistent also for the RAWtoALL we run in ART tests.
@...Update InDetJobProperties.py so that we don't do SLHC conversion finding by default (not currently working). Already disabled explicitly in RAWtoESD, so this will make the settings consistent also for the RAWtoALL we run in ART tests.
@ncalace @swaban @npetters @asalzburhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20649EventUtils: Remove use of IAsgSelection interfaces.2019-01-28T03:02:05+01:00Scott SnyderEventUtils: Remove use of IAsgSelection interfaces.For ParticleSelectionAlg, the SelectionToolList and SelectionWithPVTooList
properties are not used anywhere in the repository; furthermore, they rely
on interfaces marked as deprecated. Remove them.For ParticleSelectionAlg, the SelectionToolList and SelectionWithPVTooList
properties are not used anywhere in the repository; furthermore, they rely
on interfaces marked as deprecated. Remove them.