athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-19T10:01:46+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20015Add new support for bool/flag user settings, with corresponding processing2018-12-19T10:01:46+01:00Andy BuckleyAdd new support for bool/flag user settings, with corresponding processingAdd new support for bool/flag user settings, with corresponding processing by the Pythia8_i core class. Used these to add a new GravFlat:FlatPt flag to the GravFlat user hook, to enable flat pT sampling at 13 TeV as supplied by Francesco...Add new support for bool/flag user settings, with corresponding processing by the Pythia8_i core class. Used these to add a new GravFlat:FlatPt flag to the GravFlat user hook, to enable flat pT sampling at 13 TeV as supplied by Francesco Di Bello at https://its.cern.ch/jira/browse/ATLMCPROD-6561Ewelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20004Update version.txt2018-12-19T11:16:14+01:00Ewelina Maria LobodzinskaUpdate version.txtupdate to version 21.6.2update to version 21.6.2https://gitlab.cern.ch/atlas/athena/-/merge_requests/20072fix xrdcp in 21.62018-12-20T14:40:12+01:00Tulay Cuhadar Donszelmannfix xrdcp in 21.6xrdcp version in 21.6 is different than other branches and copy command works differently. Use xrdcp from /usr/bin/xrdcp.xrdcp version in 21.6 is different than other branches and copy command works differently. Use xrdcp from /usr/bin/xrdcp.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20088add print statements and use art from the nightly2018-12-21T11:10:00+01:00Tulay Cuhadar Donszelmannadd print statements and use art from the nightlyadd print statements and use art from the nightlyadd print statements and use art from the nightlyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20083CLIDSvc: Delete this obsolete package.2018-12-24T03:02:14+01:00Scott SnyderCLIDSvc: Delete this obsolete package.Should no longer be used from anywhere.Should no longer be used from anywhere.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20094SUSYTools: Update to autoconfigPRWTool2019-01-28T13:52:40+01:00Keisuke YoshiharaSUSYTools: Update to autoconfigPRWTooladditional options to autoconfigPRWTool for users
- RPV mode for special r-tags (r11036-r11038)
- Combined mode (for full-run2 dataset)
- Patch for Znunu metadata (MC16e)
@oabouzeiadditional options to autoconfigPRWTool for users
- RPV mode for special r-tags (r11036-r11038)
- Combined mode (for full-run2 dataset)
- Patch for Znunu metadata (MC16e)
@oabouzeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/2017021.9: Fix typo in IDPVM input2019-01-04T18:37:30+01:00Nicholas Styles21.9: Fix typo in IDPVM inputFix typo in IDPVM input file definition that was causing dcube step to fail
cc @swaban Fix typo in IDPVM input file definition that was causing dcube step to fail
cc @swaban https://gitlab.cern.ch/atlas/athena/-/merge_requests/2019421.6 jetrec2019-01-07T16:52:09+01:00Ewelina Maria Lobodzinska21.6 jetrecdefine version number as environmental variable
add file for environment configuration to most important Generator packagesdefine version number as environmental variable
add file for environment configuration to most important Generator packageshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/2023521.6 jetrec2019-01-08T22:44:26+01:00Ewelina Maria Lobodzinska21.6 jetrecadd share/common directory for generator packages for common fragments and share/file directory for parameter filesadd share/common directory for generator packages for common fragments and share/file directory for parameter fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20226TrigT1NSWSimTools cleanup2019-01-09T06:09:02+01:00William Axel LeightTrigT1NSWSimTools cleanupSweep of https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16714 to 21.9; remove unneeded includes and unused data members, fix naming issues, migrate to ATH_MSG logging, etc.Sweep of https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16714 to 21.9; remove unneeded includes and unused data members, fix naming issues, migrate to ATH_MSG logging, etc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20251Fix for ATLASRECTS-48152019-01-10T03:02:29+01:00William Axel LeightFix for ATLASRECTS-4815MdtCalibrationT0ShiftSvc and MdtCalibrationTMaxShiftSvc use the updated version of MuonMDT_Cabling->getCabling() that returns a pointer rather than a DataHandle.
Closes ATLASRECTS-4815MdtCalibrationT0ShiftSvc and MdtCalibrationTMaxShiftSvc use the updated version of MuonMDT_Cabling->getCabling() that returns a pointer rather than a DataHandle.
Closes ATLASRECTS-4815https://gitlab.cern.ch/atlas/athena/-/merge_requests/20246Identifier: Fix gcc9 warnings.2019-01-10T03:02:22+01:00Scott SnyderIdentifier: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20245RecTPCnv: Fix clang warnings.2019-01-10T03:02:18+01:00Scott SnyderRecTPCnv: Fix clang warnings.clang warnings: unused private class members.clang warnings: unused private class members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20265Update externals.txt2019-01-10T11:53:10+01:00Ewelina Maria LobodzinskaUpdate externals.txtupdate externals to tag 1.0.44update externals to tag 1.0.44https://gitlab.cern.ch/atlas/athena/-/merge_requests/2027921.6 jetrec2019-01-10T12:33:55+01:00Ewelina Maria Lobodzinska21.6 jetrecupdate crmc to 1.5.6
define MCUTILSVER and HEPUTILSVER
create share/common and share/file directories for some generators
move there JO commons and steering filesupdate crmc to 1.5.6
define MCUTILSVER and HEPUTILSVER
create share/common and share/file directories for some generators
move there JO commons and steering fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20258Correcting filling of TrackSummary information for ITk track reconstruction2019-01-12T17:17:00+01:00Noemi CalaceCorrecting filling of TrackSummary information for ITk track reconstructionThis MR contributes to correctly fill the `TrackSummary` information for ITk reconstruction, evaluating the numbers of hits and contributing layers for the different regions (inclined modules or barrel ring modules [step3] are counted as...This MR contributes to correctly fill the `TrackSummary` information for ITk reconstruction, evaluating the numbers of hits and contributing layers for the different regions (inclined modules or barrel ring modules [step3] are counted as a separate layers).
I have implemented a new object, called `PrecisionHitInfo`, that is filled by the with the measurement information (detector region, layer, eta module) when the `InDetTrackSummaryHelperTool` loops on the `TrackStateOnSurface` and analyses them. Therefore, the `PrecisionHitInfo` keep trace of the number of measurements in their information and is then used to correct the number of contributing layers and hits for the different detector regions, i.e. `pixelBarrelFlat`, `pixelBarrelInclined`, `pixelBarrelRing` and `pixelEndcap`. It contains also the possibility of counting the strip quantities which is currently not used. It is defined in the `TrkTrackSummary` package since `TrkTrackSummaryTool`, `TrkToolInterfaces` and `InDetTrackSummaryHelperTool` will depend on it.
NB: The `TrackSummary` information is expanded and some additional variables are added. Anyhow the `hitpattern` stays unchanged.
@nstyles, @asalzbur, @xai, @npetters, @lmijovic, @goblirsc, @swabanNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20222Update jet analysis sequence2019-01-11T03:03:07+01:00Tadej Novaktadej.novak@cern.chUpdate jet analysis sequenceJet analysis sequence updates:
- Add `JetGhostMuonAssociationAlg` - needed for MET. Probably not the best place, but fits better in this package and sequence than in MET. SUSYTools also runs this on base Jets.
- Do not run jet cleaning...Jet analysis sequence updates:
- Add `JetGhostMuonAssociationAlg` - needed for MET. Probably not the best place, but fits better in this package and sequence than in MET. SUSYTools also runs this on base Jets.
- Do not run jet cleaning - now recommended to run event-based selection after OR (will open a separate MR for this, but needs discussion).
- Update systematics support - separate jet smearing no longer needed, all done while applying uncertainties (keeping the algorithm for now)
- The default MET prefers tight forward JVT.
- Do not apply JVT selection by default (just decorate). More improvements on this coming in a follow-up MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20224Use FJVT in MET analysis sequence2019-01-11T03:03:05+01:00Tadej Novaktadej.novak@cern.chUse FJVT in MET analysis sequenceAs we use forward jets by default in the analysis sequences we should also use FJVT at MET calculation.
Tagging @krumnack if he wants to review already as we should wait for !20222.As we use forward jets by default in the analysis sequences we should also use FJVT at MET calculation.
Tagging @krumnack if he wants to review already as we should wait for !20222.https://gitlab.cern.ch/atlas/athena/-/merge_requests/2030421.6 jetrec2019-01-11T16:02:28+01:00Ewelina Maria Lobodzinska21.6 jetreccreate share/common directory for generator interfaces and place there common fragment from MC15JobOptionscreate share/common directory for generator interfaces and place there common fragment from MC15JobOptionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20310TrigTruthEventTPCnv: Fix gcc9 warnings.2019-01-12T03:02:43+01:00Scott SnyderTrigTruthEventTPCnv: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.