athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-10-24T21:35:09+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/57714Egamma add flags on topo related thresholds. Allow to easily override things ...2022-10-24T21:35:09+02:00Christos Anastopouloschristos.anastopoulos@cern.chEgamma add flags on topo related thresholds. Allow to easily override things e.g for UPCEgamma add flags on topo related thresholds. Allow to easily override things e.g for UPC
Let me ping @igrabows and @yvolkotr
1. ) I added the ``thresholds`` one might want to modify for UPC as flags. The ones here should be the curren...Egamma add flags on topo related thresholds. Allow to easily override things e.g for UPC
Let me ping @igrabows and @yvolkotr
1. ) I added the ``thresholds`` one might want to modify for UPC as flags. The ones here should be the current p-p defaults
2. ) @tbold @tadej might know more on how is best to set it up for a custom reco . Depends on how is planned
but in principle in UPC reco you prb want to run egamma per se with these set in some other/lower values.
3. ) As an aside the egamma CI tests are here
https://gitlab.cern.ch/atlas/athena/-/blob/master/AtlasTest/CITest/Athena.cmake#L149
new and old style.
4. ) There is a catch if you run old style, in that although egamma is fully new style , inner detector is not.
But did not want to invent an new old style flag for this
[https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/InnerDetector/InDetExample/InDetRecExample/share/InDetRecCaloSeededROISelection.py#0019]. So you will need prb something manual in old style still ....
In new style InDet would pick up the flag as it calls the same ``egamma ... Cfg``
Now I assume I did the defaults correctly. But the ``CI`` will tell us ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/55037Revert "Merge branch '22.0-dq-merge-memory' into '22.0'"2022-07-13T14:51:23+02:00Peter BertaRevert "Merge branch '22.0-dq-merge-memory' into '22.0'"This reverts merge request !54913
@jmaurer , creating this revert MR to be ready, in case we decide to really revert.This reverts merge request !54913
@jmaurer , creating this revert MR to be ready, in case we decide to really revert.Peter BertaPeter Bertahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50797Update of the han-config for Run 32022-06-07T05:01:50+02:00Moe WakidaUpdate of the han-config for Run 3I want to merge this change into master.
I updated the han-config for the Run 3 muon monitoring.
Based on the discussion at the Muon trigger meeting, I have set up the histograms similar to the one that existed in Run 2. (We plan to add...I want to merge this change into master.
I updated the han-config for the Run 3 muon monitoring.
Based on the discussion at the Muon trigger meeting, I have set up the histograms similar to the one that existed in Run 2. (We plan to add new histograms from Run 3 in the future.)
I tested using below command and had no error.
`han-config-check.sh DataQuality/DataQualityConfigurations/CMakeFiles/collisions_run.config`
The test webdisplay is here (The HIST file used was created with weekly HLT reprocessing, [ATR-24840](https://its.cern.ch/jira/browse/ATR-24840).):
[https://atlasdqm.cern.ch/webdisplay/test/32/physics_Main/run_360026/run/HLT/Run3/TRMUO/](https://atlasdqm.cern.ch/webdisplay/test/32/physics_Main/run_360026/run/HLT/Run3/TRMUO/)
tagging @cdiez , @anventur , and @nakahama for info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53685fix AFP digitization setup with CA2022-05-26T13:54:26+02:00Petr Balekfix AFP digitization setup with CAFixing some unfortunate changes introduced by atlas/athena!53558: changed errors back to fatals; fix possible double initialization; put testing macro to a separate file.Fixing some unfortunate changes introduced by atlas/athena!53558: changed errors back to fatals; fix possible double initialization; put testing macro to a separate file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51490Test lhe2022-04-12T15:07:40+02:00Danning LiuTest lheThis updates help to solve memory leak problem in TestLHE package.
TestLHE tool can be used to check parton level information recorded in Les Houches Events (LHE) files and perform some format and physical checkings. This tool will only ...This updates help to solve memory leak problem in TestLHE package.
TestLHE tool can be used to check parton level information recorded in Les Houches Events (LHE) files and perform some format and physical checkings. This tool will only throw some warnings when detecting some abnormal information and will not stop the generation.Ewelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51574Sweeping !51572 from 21.6 to master.
LHE file filtering: handling the case of...2022-03-25T17:33:04+01:00Atlas NightlybuildSweeping !51572 from 21.6 to master.
LHE file filtering: handling the case of outputTXTFileLHE file filtering: handling the case of outputTXTFile
See merge request atlas/athena!51572LHE file filtering: handling the case of outputTXTFile
See merge request atlas/athena!51572https://gitlab.cern.ch/atlas/athena/-/merge_requests/46577Updating setting of isolation variables working points due to use of firmwar...2021-09-20T15:40:27+02:00Antonio Manuel Mendes Jacques Da CostaUpdating setting of isolation variables working points due to use of firmware thresholdsFirmware threshold values are being used when setting the working points for the isolation variables (Reta, Rhad and Wstot).
Example here: [getting fw thrs](https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigT1/L1CaloFEX/L1Ca...Firmware threshold values are being used when setting the working points for the isolation variables (Reta, Rhad and Wstot).
Example here: [getting fw thrs](https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXFPGA.cxx#L138) and firmware threshold values set here: [setting of fw thrs](https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/TypeWideThresholdConfig.py#L63)
This required changes in how the comparisons in the setting of the working points are done, namely introducing a bitshift factor.
In addition a fix of the Wstot output (necessary for setting the WPs) was implemented.
The trigger counts in the reference file are updated as well, following discussion in [Previous MR](https://gitlab.cern.ch/atlas/athena/-/merge_requests/46521)
@afaulkneAlison ElliotAlison Elliothttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46376Egammaperformance24082021 - URGENT2021-09-09T11:03:52+02:00Bertrand LaforgeEgammaperformance24082021 - URGENThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43229Master ready, at least, to manage 8.3042021-05-07T11:41:21+02:00Giancarlo PanizzoMaster ready, at least, to manage 8.304This MR makes Pythia8_i in master able to manage Pythia > 8.303 versions. It also starts to reduce differences between master and 21.6, hoping to converge somewhere in the close future.
FIX SPI-1881This MR makes Pythia8_i in master able to manage Pythia > 8.303 versions. It also starts to reduce differences between master and 21.6, hoping to converge somewhere in the close future.
FIX SPI-1881Ewelina Maria LobodzinskaEwelina Maria Lobodzinskahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29505Split TrigBphysHypo package into legacy and MT packages (ATR-17404)2020-01-21T17:12:59+01:00Vladimir LyubushkinSplit TrigBphysHypo package into legacy and MT packages (ATR-17404)TrigBphysHypoUtilsTool is successor of TrigBphysHelperUtilsTool; this tool is supposed to be removed later.
BphysicsSequenceSetup.py from TriggerMenuMT now uses TrigBphysHypoMT algorithms.
cc @jakoubek , @abarton
TrigBphysHypoUtilsTool is successor of TrigBphysHelperUtilsTool; this tool is supposed to be removed later.
BphysicsSequenceSetup.py from TriggerMenuMT now uses TrigBphysHypoMT algorithms.
cc @jakoubek , @abarton
https://gitlab.cern.ch/atlas/athena/-/merge_requests/26373Test blm sensor sd2019-11-12T16:39:46+01:00Liangliang HanTest blm sensor sdIn this branch, I tested the class `BLMSensorSD` in the package `InnerDetector/InDetG4/BLM_G4_SD`. Here is how I did.
1. I place my test code `BLMSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `BLMSensorSD`.
...In this branch, I tested the class `BLMSensorSD` in the package `InnerDetector/InDetG4/BLM_G4_SD`. Here is how I did.
1. I place my test code `BLMSensorSD_gtest.cxx` in the `test` folder. And it is for testing the class `BLMSensorSD`.
2. I created the jobOption file `optionForTest.txt`, which is placed in the share folder.
3. In oder to add my test classes as friends of the tested classes, I add several lines for that.
4. Of course, I add some lines in the CMakeLists.txt for compiling my test code, using google test frame work, and so on.
5. I create 3 files and put them into the folder `Simulation/G4Atlas/G4AtlasTools/G4AtlasTools`. The 1st file is `DerivedG4SensitiveDetectorTestSetting.h`, where I define a function for setting G4-objects to G4Step object. The 2nd file is `G4MyPhysicalVolume.h`, where I define a class called `G4MyPhysicalVolume` that is derived from `G4VPhysicalVolume`. The 3rd file is `G4MyProcess.h`, where I define a class called `G4MyProcess` that is derived from `G4VProcess`.
6. It is worth mentioning that I use different TEST_F to test different member functions of the tested class.