athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-11-10T17:11:30+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/58222Fix phi conversion for gTowers2022-11-10T17:11:30+01:00Cecilia TosciriFix phi conversion for gTowersWith this MR, the method that converts the gTower phi indices to float values has been updated in the BS decoder.With this MR, the method that converts the gTower phi indices to float values has been updated in the BS decoder.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58265rm unused legacy expressPerigeeToBeamSpot option2022-11-10T15:42:21+01:00Christos Anastopouloschristos.anastopoulos@cern.chrm unused legacy expressPerigeeToBeamSpot optionrm unused legacy expressPerigeeToBeamSpot optionrm unused legacy expressPerigeeToBeamSpot optionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58200use AccumulatorCache for LuminosityCondAlgCfg2022-11-09T19:25:11+01:00Walter Lampluse AccumulatorCache for LuminosityCondAlgCfgThe LuminosityCondAlgCfg has many clients. Cache it.The LuminosityCondAlgCfg has many clients. Cache it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58135TrackingGeometrySvc is to be deprecated. We use the cond Alg, add a WARNING.2022-11-09T19:24:56+01:00Christos Anastopouloschristos.anastopoulos@cern.chTrackingGeometrySvc is to be deprecated. We use the cond Alg, add a WARNING.TrackingGeometrySvc is to be deprecated.
We use the cond Alg, add a WARNING to try and catch remaining config instances
Note that we already warn during the svc init
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/Tr...TrackingGeometrySvc is to be deprecated.
We use the cond Alg, add a WARNING to try and catch remaining config instances
Note that we already warn during the svc init
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/TrkDetDescr/TrkDetDescrSvc/src/TrackingGeometrySvc.cxx#0053
```
0045 ATH_MSG_WARNING(
0046 "!!! Initialization of TrackingGeometrySvc !!! The Service it to be "
0047 "deprecated in favour of the relevant Condition Algorithm. !!!");
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/58195Ensure barcodes are set properly in McEventCollectionFilter in HepMC3-based b...2022-11-09T17:36:07+01:00John Derek ChapmanEnsure barcodes are set properly in McEventCollectionFilter in HepMC3-based buildsTagging @tadej and @averbytsTagging @tadej and @averbytshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48202separate out UnitTestFixture into separate library ATLASG-16112022-11-08T16:36:04+01:00Nils Erik Krumnackseparate out UnitTestFixture into separate library ATLASG-1611This follows a change in GoogleTest that requires the unit test
fixture to be a separate library that is only linked against tests
that use it, and that is defined as an object library.This follows a change in GoogleTest that requires the unit test
fixture to be a separate library that is only linked against tests
that use it, and that is defined as an object library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20396move unit test helpers from AsgTools into new package AsgTesting2022-11-08T16:34:49+01:00Nils Erik Krumnackmove unit test helpers from AsgTools into new package AsgTestingThis may not be the right thing to worry about and may end up to be somewhat controversial, but it has also been bugging me for a while: So far the `AsgTools` library links directly against the google-test libraries, meaning that even i...This may not be the right thing to worry about and may end up to be somewhat controversial, but it has also been bugging me for a while: So far the `AsgTools` library links directly against the google-test libraries, meaning that even in production code any package depending on `AsgTools` (which are a lot) will pull in the unit test library as a dependency. Admittedly that is pretty lightweight, but as a dependency it is completely unnecessary for anything except unit tests.
So what I did was split the unit test helpers into a separate package `AsgTesting`, and move unit tests from `AsgTools` into `AsgExampleTools`, which already holds some of the `AsgTools` unit tests. And then I also fixed up all the packages I broke with that update. Or at least fixed everything up for `AnalysisBase`, if there are any more dependencies in the other projects I wouldn't know.
cc @akraszna @ksurulizhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43095introduce AsgToolConfig::makePrivateTool()2022-11-08T16:34:36+01:00Nils Erik Krumnackintroduce AsgToolConfig::makePrivateTool()The goal is to ensure there is a proper cleanup of the tool created
(within AnalysisBase), so that the AsgToolConfig-based approach can be
used to replace AnaToolHandle.The goal is to ensure there is a proper cleanup of the tool created
(within AnalysisBase), so that the AsgToolConfig-based approach can be
used to replace AnaToolHandle.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58130ATLASRECTS-7350,ATLASRECTS-7351 Fix mem leak and WARNING->DEBUG2022-11-08T14:30:19+01:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-7350,ATLASRECTS-7351 Fix mem leak and WARNING->DEBUGATLASRECTS-7350,ATLASRECTS-7351
Fix mem leak and WARNING->DEBUG
ping @tamartin , @amete , @sroeATLASRECTS-7350,ATLASRECTS-7351
Fix mem leak and WARNING->DEBUG
ping @tamartin , @amete , @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57676introduce configuration blocks various analysis algorithms2022-11-07T14:51:37+01:00Nils Erik Krumnackintroduce configuration blocks various analysis algorithmsI think I now managed to include almost everything, except for MET and OR (which need to have multi-object preselection) and GRL (which isn't in my test sequence yet).
Adding ~"alsoTargeting:21.2", though that will probably fail and I'l...I think I now managed to include almost everything, except for MET and OR (which need to have multi-object preselection) and GRL (which isn't in my test sequence yet).
Adding ~"alsoTargeting:21.2", though that will probably fail and I'll have to do it manually. Still this will be a reminder to do so.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57994Allow setting container selections directly in the MET maker2022-11-07T14:51:33+01:00Jon BurrAllow setting container selections directly in the MET makerI noticed that the MET maker doesn't do its own selection of objects, requiring the sequencing of several extra algorithms and the creation of several superfluous shallow copies. This MR introduces those selections so all that logic can ...I noticed that the MET maker doesn't do its own selection of objects, requiring the sequencing of several extra algorithms and the creation of several superfluous shallow copies. This MR introduces those selections so all that logic can be done internally to the MET algorithm.
This change should be backwards compatible: if a user provides a preselected container and no selection decoration the tool will behave in exactly the same way as before.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56155add tests for running CP algorithms on PHYSLITE2022-11-07T14:51:29+01:00Nils Erik Krumnackadd tests for running CP algorithms on PHYSLITESo far only muons, since that is all the global tests do so far, but
it makes sure that we can at least do that on PHYSLITE as well.
This is likely conflicting with my other CP algorithm MR in flight, but it also doesn't seem to work ri...So far only muons, since that is all the global tests do so far, but
it makes sure that we can at least do that on PHYSLITE as well.
This is likely conflicting with my other CP algorithm MR in flight, but it also doesn't seem to work right now anyways, and hopefully somebody has some great insight as to what is going on here.
The specific error message I get points to a missing variable (`CaloMuonScore`):
```
MuonSelectionAlg_mediu...FATAL /build1/atnight/localbuilds/nightlies/AnalysisBase/master/athena/PhysicsAnalysis/MuonID/MuonSelectorTools/Root/MuonSelectionTool.cxx:1394 (void CP::MuonSelectionTool::retrieveParam(const Muon&, float&, xAOD::Muon_v1::ParamDef) const): /build1/atnight/localbuilds/nightlies/AnalysisBase/master/athena/PhysicsAnalysis/MuonID/MuonSelectorTools/Root/MuonSelectionTool.cxx:1394 Failed to retrieve parameter 28 for muon with pT:27.4491, eta:-0.0548586, phi: 1.56738, q:1, author: 8
Package.EventLoop ERROR /build1/atnight/localbuilds/nightlies/AnalysisBase/master/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/MessageCheck.cxx:35 (void EL::Detail::report_exception()): caught exception: Failed to retrieve Parameter
```
I don't know if this means we need to update the test input files, or there is some special setting for the `MuonSelectorTool` when running PHYSLITE, or something else. Maybe it also just disappears when running in CI.
Tagging the usual suspects: @schaarsc @jcatmore @jojungge @yoyamagu @jburr @tadejNils Erik KrumnackNils Erik Krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57294tweaks for making n-tuples from the full CP algorithm sequence2022-11-07T14:51:26+01:00Nils Erik Krumnacktweaks for making n-tuples from the full CP algorithm sequenceThis adds some tweaks to improve the performance of the sequence, some
extra variables commonly used, and allow running trigger selection
without filtering.This adds some tweaks to improve the performance of the sequence, some
extra variables commonly used, and allow running trigger selection
without filtering.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56285add "proper" views and thinning for full CP algorithm test sequence2022-11-07T14:51:11+01:00Nils Erik Krumnackadd "proper" views and thinning for full CP algorithm test sequenceThis removes all the implicit views created by the various sequences,
and instead creates explicit views as inputs for MET. And it
adds actual consistent thinning for all containers for the output.
And it adds pt/eta cuts for some of th...This removes all the implicit views created by the various sequences,
and instead creates explicit views as inputs for MET. And it
adds actual consistent thinning for all containers for the output.
And it adds pt/eta cuts for some of the objects, which are probably way
off from what they should be...
I also had to add some extra configuration options/decorations to some
of the sequences to make it all consistent.Nils Erik KrumnackNils Erik Krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56201add a full sequence of CP algorithms to the Full CP Algorithms test2022-11-07T14:51:08+01:00Nils Erik Krumnackadd a full sequence of CP algorithms to the Full CP Algorithms testThis is mostly a collection of all the algorithms tests from the
various CP algorithm packages loosely stitched together. It probably
will need some more cleanup at some point, but it at least provides a
baseline to test the configurati...This is mostly a collection of all the algorithms tests from the
various CP algorithm packages loosely stitched together. It probably
will need some more cleanup at some point, but it at least provides a
baseline to test the configuration blocks against as I develop them.Nils Erik KrumnackNils Erik Krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/55979Fail on ROOT write Error.2022-11-07T12:41:55+01:00Peter Van GemmerenFail on ROOT write Error.This MR will ensure that ROOT failures of writing a file are propagated through all Athena/APR layers all the way to Gaudi.This MR will ensure that ROOT failures of writing a file are propagated through all Athena/APR layers all the way to Gaudi.Peter Van GemmerenPeter Van Gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57844TriggerOutputHandling: Fix schema evolution warning check.2022-11-07T08:27:53+01:00Scott SnyderTriggerOutputHandling: Fix schema evolution warning check.In TriggerEDMDeserialiserAlg::deserialiseDynAux, when we check for missing
schema evolution, if the type names don't match, then try again after
expanding typedefs in the transient name (which comes from the CLID database).
See ATR-26539.In TriggerEDMDeserialiserAlg::deserialiseDynAux, when we check for missing
schema evolution, if the type names don't match, then try again after
expanding typedefs in the transient name (which comes from the CLID database).
See ATR-26539.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58078Make JetDecoratorAlg use a const pointer.2022-11-05T21:41:59+01:00Jon BurrMake JetDecoratorAlg use a const pointer.This is to match the tool interface and avoid making unnecessary copies.This is to match the tool interface and avoid making unnecessary copies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57979CalibrationDataInterface+BTaggingEfficiencyTool: remove mutables and const fixes2022-11-04T18:17:03+01:00Frank WinklmeierCalibrationDataInterface+BTaggingEfficiencyTool: remove mutables and const fixesMost of the classes use internal caching by modifying mutables in const
functions. Remove the mutables in favor of making the interfaces
non-const to make it clear that these methods are not thread-safe.
Enable thread-checker.Most of the classes use internal caching by modifying mutables in const
functions. Remove the mutables in favor of making the interfaces
non-const to make it clear that these methods are not thread-safe.
Enable thread-checker.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58019ATLASRECTS-7334: check if the matrix is invertiable before inverting it2022-11-04T18:15:59+01:00Ke LiATLASRECTS-7334: check if the matrix is invertiable before inverting itAs discussed in https://its.cern.ch/jira/browse/ATLASRECTS-7334, this MR will fix the FPEs in the KalmanVertexTrackUpdator by checking if the matrix is invertiable before inversing it.
Ping @kostyuk and @jburzyns .As discussed in https://its.cern.ch/jira/browse/ATLASRECTS-7334, this MR will fix the FPEs in the KalmanVertexTrackUpdator by checking if the matrix is invertiable before inversing it.
Ping @kostyuk and @jburzyns .