athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-10-26T21:43:12+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66720Fix condor driver without shared filesystem2023-10-26T21:43:12+02:00Ruggero TurraFix condor driver without shared filesystemThis closes ATLASG-2563 fixing the problem when running without a shared filesystem (see jira).
* Don't use /tmp: there is no reason to use /tmp when running condor, actually, it is quite bad. Condor guarantees that the working director...This closes ATLASG-2563 fixing the problem when running without a shared filesystem (see jira).
* Don't use /tmp: there is no reason to use /tmp when running condor, actually, it is quite bad. Condor guarantees that the working directory on the worker node has the specified requirement (this is not true for /tmp). This also fix the bug explained in the jira, due to inconsistent paths.
* Move to cpack to create the tarball. I guess this was suggested by @akraszna (email to hn-atlas-PATHelp@cern.ch Sep 6, 2021). I am not an expert, I tried to get a tarball identical to the previous one. I am using
```
pack -D CPACK_INSTALL_PREFIX=. -G TGZ --config $TestArea/CPackConfig.cmake
```
To make the same filename as before (and to make it easily predictable) I am renaming it with
```
mv_command << "mv WorkDir_" << std::getenv("WorkDir_VERSION") << "_" << std::getenv("WorkDir_PLATFORM") << ".tar.gz " << tarballName;
```
Probably there is a better way to do it. I have noticed cpack is quite slower than tar
Unfortunately, I have to modify `BatchDriver.cxx` which is in common with many other batch drivers, but I have no access to any of them, so I can't test if this change affects others. I guess @krumnack has an opinion.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66266fix warning in Pythia8B_i2023-10-18T21:43:32+02:00Ewelina Maria Lobodzinskafix warning in Pythia8B_iThis MR is supposed to fix a warning reported in AGENE-2202This MR is supposed to fix a warning reported in AGENE-2202https://gitlab.cern.ch/atlas/athena/-/merge_requests/63648Powheg: few changes in parameters2023-06-14T09:41:48+02:00Timothee Theveneaux-PelzerPowheg: few changes in parametersThis makes two changes:
- remove the freezing of the `smartsig` parameter (for all processes) which made it impossible to be changed by users - this is needed for the Drell-Yan LQ processes
- set `pdfreweight` to 0 by default in `W_EW` a...This makes two changes:
- remove the freezing of the `smartsig` parameter (for all processes) which made it impossible to be changed by users - this is needed for the Drell-Yan LQ processes
- set `pdfreweight` to 0 by default in `W_EW` and `Z_EW` - this will remove the old-style pdf reweighting infos by default for these two processes, which was causing problemshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63609Analysis-Top: Implement JetUncertainties signed gluon fraction eta option for...2023-06-13T19:20:06+02:00Chris ScheulenAnalysis-Top: Implement JetUncertainties signed gluon fraction eta option for pPb/PbpThis MR implements in AnalysisTop the new change-over from absolute to signed gluon fraction etas for the small-R JetUncertaintiesTool recently developed by JetMET in !63355 for the asymmetric pPb/Pbp HI analysis. As a change, the signed...This MR implements in AnalysisTop the new change-over from absolute to signed gluon fraction etas for the small-R JetUncertaintiesTool recently developed by JetMET in !63355 for the asymmetric pPb/Pbp HI analysis. As a change, the signed etas are now automatically used for pPb/Pbp samples, while the absolute etas are retained for other setups.
The MR addresses a follow-up request in the discussion of ANALYSISTO-1320.Chris ScheulenChris Scheulenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63407TileSimAlgs: Fix merging Tile E1 and MBTS cells (ATLASSIM-6580)2023-06-01T15:42:31+02:00Siarhei HarkushaTileSimAlgs: Fix merging Tile E1 and MBTS cells (ATLASSIM-6580)Tile Hit vector to container tool has been updated to fix merging hits
corresponding to some E1 and MBTS cells (which are really merged in used geometry).
Firstly, old hits are removed using the corresponding collection iterators
and on...Tile Hit vector to container tool has been updated to fix merging hits
corresponding to some E1 and MBTS cells (which are really merged in used geometry).
Firstly, old hits are removed using the corresponding collection iterators
and only then new ones (merged) are added to the collection if it is needed,
since addition of new hits to the same collection can invalidate the iterators.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63035switch all TCT comparisons to fixed references + discard POOL outputs2023-05-15T11:52:07+02:00Julien Maurerswitch all TCT comparisons to fixed references + discard POOL outputsTo save space on eos.
:flag_fi: @strichteTo save space on eos.
:flag_fi: @strichtehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62926add --nan-equal option for ART2023-05-10T03:42:25+02:00Julien Maureradd --nan-equal option for ARTManual cherry-pick of 5e5a5c97 in order to fix Tier0ChainTest ART comparisons in this branch which are broken since... a few years I guess.Manual cherry-pick of 5e5a5c97 in order to fix Tier0ChainTest ART comparisons in this branch which are broken since... a few years I guess.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62908lighter TCT ART output2023-06-14T15:54:17+02:00Julien Maurerlighter TCT ART outputSame as !62857 but for branch 21.0-mc16d.Same as !62857 but for branch 21.0-mc16d.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62857lighter TCT ART output2023-05-08T11:07:31+02:00Julien Maurerlighter TCT ART outputOnly store log files in the output + compare against a fixed reference since the output files of the previous nightly won't be available anymore.
ATLINFR-4929Only store log files in the output + compare against a fixed reference since the output files of the previous nightly won't be available anymore.
ATLINFR-4929https://gitlab.cern.ch/atlas/athena/-/merge_requests/62660[AGENE-2186] Parameter stage 21.62023-07-05T14:43:54+02:00Andrej Saibel[AGENE-2186] Parameter stage 21.6Dear all,
this MR adds a functionality to PowhegControl to change settings on the fly during the production in each of the parallelstages.
An example config is provided. The config changes fakevirt to 1 for parallelstage 1. Then the par...Dear all,
this MR adds a functionality to PowhegControl to change settings on the fly during the production in each of the parallelstages.
An example config is provided. The config changes fakevirt to 1 for parallelstage 1. Then the parameter is changed back to 0 for the following stages.
Kind regards,
Andrejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62428Harmonise the tZq and ttZ parton histories2023-06-12T17:12:33+02:00Baptiste Ravinabaptiste.ravina@cern.chHarmonise the tZq and ttZ parton historiesChanges are made to two TopPartonHistories within AnalysisTop:
- for the ttZ topology: the decay products of the Z boson are taken immediately after the decay of the Z boson, instead of going down the radiation chain with `findAfterFSR`....Changes are made to two TopPartonHistories within AnalysisTop:
- for the ttZ topology: the decay products of the Z boson are taken immediately after the decay of the Z boson, instead of going down the radiation chain with `findAfterFSR`. This changes the definition of these decay products from "bare" to "Born/ME", similarly to what is done in the ttbar topology.
- for the tZq topology: do the same, except the radiation method there is called `findAfterGamma`. Also remove calls to `findAfterGamma` in the arguments of `TauIsHadronic`, since it itself calls `findAfterFSR` internally.
Tagging @mdubovsk @thsteven @dellasta @alhroob for the ttZ and tZq analyses.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62295remove duplicated line2023-04-19T15:42:47+02:00Ewelina Maria Lobodzinskaremove duplicated lineremove duplicated lineremove duplicated linehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61505LLP stau to neutralino G4 options2023-03-28T10:38:16+02:00Nathan Dale YoungLLP stau to neutralino G4 optionsMerge request to to make new S-tag for simulation of LLP stau to neutralino. Samples are being requested on JIRA found [https://its.cern.ch/jira/browse/ATLMCPROD-10493](https://its.cern.ch/jira/browse/ATLMCPROD-10493).
Modified the confi...Merge request to to make new S-tag for simulation of LLP stau to neutralino. Samples are being requested on JIRA found [https://its.cern.ch/jira/browse/ATLMCPROD-10493](https://its.cern.ch/jira/browse/ATLMCPROD-10493).
Modified the configuration files for the Sleptons and Gauginos in the simulation to properly decay stau into neutralino plus decay products for non-prompt decays. This was done to target to the coannihilation strip for neutralino and stau. The coannihilation strip has signature that can be targeted by disappearing tracks.
Motivation and kinematic plots presented to the RPV/LL group on Feb 21, 2023 [https://indico.cern.ch/event/1254066/contributions/5270695/attachments/2596823/4484011/DT_MC_Sample_Requests.pdf](https://indico.cern.ch/event/1254066/contributions/5270695/attachments/2596823/4484011/DT_MC_Sample_Requests.pdf). A more in depth presentation of the kinematics and tests of other samples that use the same files was given to the disappearing track team on Jan 27 [https://indico.cern.ch/event/1247785/contributions/5242473/attachments/2583589/4456577/CoannihilationSampleUpdate.pdf](https://indico.cern.ch/event/1247785/contributions/5242473/attachments/2583589/4456577/CoannihilationSampleUpdate.pdf)https://gitlab.cern.ch/atlas/athena/-/merge_requests/61007PRW With Zero Lumi Run, master branch (2023.02.24.)2023-02-27T15:43:20+01:00Attila KrasznahorkayPRW With Zero Lumi Run, master branch (2023.02.24.)Protected pileup re-weighting against runs with zero luminosity. Since this is something that can apparently happen, as long as the run is short enough, and the data readout is 100% busy. (As is the case in run 430488 with the current la...Protected pileup re-weighting against runs with zero luminosity. Since this is something that can apparently happen, as long as the run is short enough, and the data readout is 100% busy. (As is the case in run 430488 with the current latest GRL.)
This was discovered by @hsut, and discussed to some extend on PATHelp.
Pinging @ponyisi, @torrence, @sara, @gunal and @zmarshal.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60992EventInfoCnvTool add filling of channel and event numbers if not done on EVGE...2023-02-28T21:43:57+01:00Ewelina Maria LobodzinskaEventInfoCnvTool add filling of channel and event numbers if not done on EVGEN leveladd filling of channel and event numbers if not done on EVGEN level (similar fix is already working for 21.2)add filling of channel and event numbers if not done on EVGEN level (similar fix is already working for 21.2)https://gitlab.cern.ch/atlas/athena/-/merge_requests/60899AsgComponentConfig Re-Design, master branch (2023.02.21.)2023-02-23T10:21:41+01:00Attila KrasznahorkayAsgComponentConfig Re-Design, master branch (2023.02.21.)Changed one of the internal variables of `asg::AsgComponentConfig`. The type used so far is just not sitting well with ROOT I/O. (See: https://github.com/root-project/root/issues/12358) So rather than using an [std::tuple](https://en.cpp...Changed one of the internal variables of `asg::AsgComponentConfig`. The type used so far is just not sitting well with ROOT I/O. (See: https://github.com/root-project/root/issues/12358) So rather than using an [std::tuple](https://en.cppreference.com/w/cpp/utility/tuple) type, switched to using a simple struct instead.
Also added a unit test that would test the type of I/O which would fail with the previous implementation of `asg::AsgComponentConfig`, but would succeed with this re-designed setup.
This is a follow-up from !60343, which unfortunately did not manage to fix ATLASG-2456 in the end. :frowning: But this one should. :fingers_crossed:
Pinging @krumnack.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60576RadiationMapsMaker: added high E neutrons weights for NIEL2023-02-10T21:44:49+01:00Sven MenkeRadiationMapsMaker: added high E neutrons weights for NIELThe high energetic neutron NIEL weights (for 800 MeV < E_kin < 9 GeV) were missing. This MR adds the data points and the code for it. The impact in instrumented areas of ATLAS is minimal since the overwhelming majority of neutrons has lo...The high energetic neutron NIEL weights (for 800 MeV < E_kin < 9 GeV) were missing. This MR adds the data points and the code for it. The impact in instrumented areas of ATLAS is minimal since the overwhelming majority of neutrons has lower energies and the extrapolation of the lower energetic data points to high energies still accounted for most of the missing ones.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60390Fixing Z jet truth label2023-02-06T17:42:29+01:00Jason Robert VeatchFixing Z jet truth labelAdding a split12 requirement to the R10TruthLabel_R21Precision_2022v1 Z jet truth label definition.
Tagging @jcantero and @brle for their information.Adding a split12 requirement to the R10TruthLabel_R21Precision_2022v1 Z jet truth label definition.
Tagging @jcantero and @brle for their information.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60178Use cached AMI tag request in job transforms, 22.0-mc20 edition2023-01-27T21:44:27+01:00Tadej Novaktadej.novak@cern.chUse cached AMI tag request in job transforms, 22.0-mc20 editionUse cached AMI tag request in job transforms
See merge request atlas/athena!59882
(cherry picked from commit 245b1f1af7578bd28ad3b29d3c56250e2762d919)
e655f281 Use cached AMI tag request in job transformsUse cached AMI tag request in job transforms
See merge request atlas/athena!59882
(cherry picked from commit 245b1f1af7578bd28ad3b29d3c56250e2762d919)
e655f281 Use cached AMI tag request in job transformshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60098AthenaPoolCnvSvc: Make dataHeaderID file-aware to fix DHForm in multi-stream ...2023-01-29T15:43:21+01:00Alaettin Serhan MeteAthenaPoolCnvSvc: Make dataHeaderID file-aware to fix DHForm in multi-stream legacy SharedWriter jobsThis needs to be independently checked/verified but at least it seems to work in my local tests. In a nutshell, by making the `dataHeaderID` file-aware, we avoid corrupting the DHForm when producing multiple streams with the legacy Share...This needs to be independently checked/verified but at least it seems to work in my local tests. In a nutshell, by making the `dataHeaderID` file-aware, we avoid corrupting the DHForm when producing multiple streams with the legacy SharedWriter.Marcin NowakPeter Van GemmerenMarcin Nowak