athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-13T12:00:23+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69705Manual sweep of !69641 from main to 24.0: Obtain smallest run which has not y...2024-03-13T12:00:23+01:00John Derek ChapmanManual sweep of !69641 from main to 24.0: Obtain smallest run which has not yet been released for Tier-0 bulk and current online run from web serviceManual sweep of !69641 from main to 24.0: Obtain smallest run which has not yet been released for Tier-0 bulk and current online run from web service
See merge request atlas/athena!69641
(cherry picked from commit cd5c691043cf18cdcfd00...Manual sweep of !69641 from main to 24.0: Obtain smallest run which has not yet been released for Tier-0 bulk and current online run from web service
See merge request atlas/athena!69641
(cherry picked from commit cd5c691043cf18cdcfd003f8ae4a3604db4f426d)
7aa8d7f6 Obtain smallest run which has not yet been released for Tier-0 bulk and...
81276b13 fixed warning in compilationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69688Decouple 24.0 and main references2024-03-13T12:00:23+01:00Tadej Novaktadej.novak@cern.chDecouple 24.0 and main referencesDecouple ~24.0 and ~main references.
It is important this is NOT swept into ~main (/cc @wlampl).
/cc @ahabouel @dtaDecouple ~24.0 and ~main references.
It is important this is NOT swept into ~main (/cc @wlampl).
/cc @ahabouel @dtahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69049MuonPhaseII -- Remove unit tests2024-02-22T10:49:24+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonPhaseII -- Remove unit testsThe unit tests will soon stop working as we're changing the layout files in ~main. To avoid a sweeping of the phase II developments from ~"24.0" , I just remove the unit tests here
Tagging: @jchapman, @emoyse, @jcatmore, @nstylesThe unit tests will soon stop working as we're changing the layout files in ~main. To avoid a sweeping of the phase II developments from ~"24.0" , I just remove the unit tests here
Tagging: @jchapman, @emoyse, @jcatmore, @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69014Deactivate Run2 Digitization and Overlay ART jobs for 23.0 branch2024-02-21T13:18:07+01:00John Derek ChapmanDeactivate Run2 Digitization and Overlay ART jobs for 23.0 branchRun2 Digitization and Overlay will not be run in 23.0.X releases in production at this point, so disabling the corresponding ART tests for this branch to save CPU.
NB No need to sweep these changes to other branches.
Tagging @tadejRun2 Digitization and Overlay will not be run in 23.0.X releases in production at this point, so disabling the corresponding ART tests for this branch to save CPU.
NB No need to sweep these changes to other branches.
Tagging @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68079Revert bug in charge mirror AF3 code, and add missing copywrite statements2024-01-16T15:35:07+01:00Christopher YoungRevert bug in charge mirror AF3 code, and add missing copywrite statementsIn https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 a bug was accidentally introduced that changed the mirroring behavior for particles of different charge. This MR reverts this change. It also adds some missing Copywrite state...In https://gitlab.cern.ch/atlas/athena/-/merge_requests/63562 a bug was accidentally introduced that changed the mirroring behavior for particles of different charge. This MR reverts this change. It also adds some missing Copywrite statements from that previous MR. (For files changed in the previous request 2023 is used, while for the file fixed in this MR 2024 is used).
NOTE: this bug is in 23.0 and therefore this MR targets this release. The bug is not present in main. THIS MR SHOULD NOT BE SWEPT TO MAIN.
Many thanks to @tstreble and @jbeirer for finding this bug.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67715B-physics trigger: add several HLT_*_bBmux_BdmuDstarX chains to Dev_pp_run3_v...2023-12-11T15:49:43+01:00Vladimir LyubushkinB-physics trigger: add several HLT_*_bBmux_BdmuDstarX chains to Dev_pp_run3_v1 menu (ATR-27341)Add several new chains:
* 'HLT_2mu6_bBmux_BdmuDstarX_L12MU5VF'
* 'HLT_mu6_mu4_bBmux_BdmuDstarX_L1MU5VF_2MU3V'
* 'HLT_mu6_mu4_bBmux_BdmuDstarX_L1MU5VF_2MU3VF'
* 'HLT_2mu4_bBmux_BdmuDstarX_L12MU3V'
* 'HLT_2mu4_bBmux_BdmuDstarX_L12MU3VF'
* ...Add several new chains:
* 'HLT_2mu6_bBmux_BdmuDstarX_L12MU5VF'
* 'HLT_mu6_mu4_bBmux_BdmuDstarX_L1MU5VF_2MU3V'
* 'HLT_mu6_mu4_bBmux_BdmuDstarX_L1MU5VF_2MU3VF'
* 'HLT_2mu4_bBmux_BdmuDstarX_L12MU3V'
* 'HLT_2mu4_bBmux_BdmuDstarX_L12MU3VF'
* 'HLT_mu20_mu4_bBmux_BdmuDstarX_L1MU14FCH'
* 'HLT_mu23_mu4_bBmux_BdmuDstarX_L1MU18VFCH'
I've tested all these chains with RDO mc23c created from part of mc16_13TeV.801686.P8BEG_A14_NNPDF23LO_bb_mu2p5_Dstar4p5.merge.EVNT.e8536_e7400 sample,
see /eos/user/l/lyubushk/trigger/RDO/mc23_13p6TeV.801686.P8BEG_A14_NNPDF23LO_bb_mu2p5_Dstar4p5.recon.RDO.e8536_s4159_r14799/RDO.BSignalFilter.pool.root
Counts look reasonable.
CC @abarton @gladilinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67203Enable pixel dEdX for pixel tracks in UPC mode (23.0)2023-11-22T10:39:52+01:00Thomas StreblerEnable pixel dEdX for pixel tracks in UPC mode (23.0)Closes ATLIDTRKCP-511
Separate MR to ~main to come, as structure of config has a bit evolved thereCloses ATLIDTRKCP-511
Separate MR to ~main to come, as structure of config has a bit evolved therehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67197B-physics trigger: remove noGSF and noringer versions of bBeeM6000 chains (AT...2023-11-20T16:22:52+01:00Vladimir LyubushkinB-physics trigger: remove noGSF and noringer versions of bBeeM6000 chains (ATR-28162)Remove noGSF and noringer versions of bBeeM6000 chains from Dev_pp_run3_v1 Menu.
Also enable CA version of bBeeM6000 chains: the ComboHypo is ready to be used in CA.Remove noGSF and noringer versions of bBeeM6000 chains from Dev_pp_run3_v1 Menu.
Also enable CA version of bBeeM6000 chains: the ComboHypo is ready to be used in CA.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67104B-physics trigger: explicitly init AtlasExtrapolator in muComb/MuComb_FTF alg...2023-11-14T18:09:13+01:00Vladimir LyubushkinB-physics trigger: explicitly init AtlasExtrapolator in muComb/MuComb_FTF algorithm (ATR-26749)This is a straightforward fix for muComb/MuComb_FTF alg from mul2IOOvlpRmSequenceCfg, needed to run Bphysics chains with --CA option.
It works fine for 'HLT_mu4_l2io_L1MU3V' chain but fails for 'HLT_2mu4_bJpsimumu_L12MU3V'
Dear @sshaw ...This is a straightforward fix for muComb/MuComb_FTF alg from mul2IOOvlpRmSequenceCfg, needed to run Bphysics chains with --CA option.
It works fine for 'HLT_mu4_l2io_L1MU3V' chain but fails for 'HLT_2mu4_bJpsimumu_L12MU3V'
Dear @sshaw , could you please check whether this fix is fine with you?
Many thanks in advance,
Vladimirhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66933B-physics trigger: remove BPhys filter at FastElectron step for bBeeM6000 cha...2023-11-07T15:08:56+01:00Vladimir LyubushkinB-physics trigger: remove BPhys filter at FastElectron step for bBeeM6000 chains (ATR-28162)This MR removes the additional TrigMultiTrkComboHypo filter at FastElectron step for all HLT_2e5_lhvloose_bBeeM6000 chains, needed for R(K*) analysis.
These chains are intended to find all well-separated electrons, i.e. HLT electrons whi...This MR removes the additional TrigMultiTrkComboHypo filter at FastElectron step for all HLT_2e5_lhvloose_bBeeM6000 chains, needed for R(K*) analysis.
These chains are intended to find all well-separated electrons, i.e. HLT electrons which come from different RoIs.
But these chains are always executed with the chains for the close-by electrons, HLT_e5_lhvloose_bBeeM6000, (same 'RATE:CPS_BKeePrimary' group).
So that, we cannot gain any real CPU savings since all FastElectrons will be transfered to the next steps as required by HLT_e5_lhvloose_bBeeM6000 algs.
I've also removed the cut for GSF track pT. The ET requirement for HLT_e5_lhvloose electron seems to be enough.
CC @abarton @jakoubek @dmankadhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66908Manual sweep of !66830 from main to 23.0: Fix for slow finalize in ATLFAST3MT...2023-11-07T14:52:16+01:00John Derek ChapmanManual sweep of !66830 from main to 23.0: Fix for slow finalize in ATLFAST3MT jobs with large numbers of threadsFix for slow finalize in ATLFAST3MT jobs with large numbers of threads
See merge request atlas/athena!66830
(cherry picked from commit d58806ee808e812feb6b913524eb5e6a287e92be)
2b8ca473 Fix for slow finalize in ATLFAST3MT jobs with la...Fix for slow finalize in ATLFAST3MT jobs with large numbers of threads
See merge request atlas/athena!66830
(cherry picked from commit d58806ee808e812feb6b913524eb5e6a287e92be)
2b8ca473 Fix for slow finalize in ATLFAST3MT jobs with large numbers of threadshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66873B-physics trigger: add additional selection for the close-by electron in R(K...2024-01-24T13:50:11+01:00Vladimir LyubushkinB-physics trigger: add additional selection for the close-by electron in R(K*) bBeeM6000 chains (ATR-28162)This MR will reduce the rate of the following bBeeM6000 chains, needed for R(K*) analysis:
* HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (rate from 115Hz -> ~40Hz, 65% reduction)
* HLT_e5_lhvloose_bBeeM6000_L1BKeePrescaled (rate from 1.4Hz -...This MR will reduce the rate of the following bBeeM6000 chains, needed for R(K*) analysis:
* HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (rate from 115Hz -> ~40Hz, 65% reduction)
* HLT_e5_lhvloose_bBeeM6000_L1BKeePrescaled (rate from 1.4Hz -> 0.4Hz, 70% reduction)
The close-by electron should pass the same ET requirement as HLT_e5_lhvloose.
This will harmonize the HLT dielectron selection and subsequent offline analysis.
CC @abarton @jakoubek @dmankadhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66816Yet another FPE protection2023-10-30T15:43:22+01:00Vadim KostyukhinYet another FPE protectionAdd protection against possible FPE what presumably should solve ATR-28243.Add protection against possible FPE what presumably should solve ATR-28243.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66804Tgc digitization introduce conditions algorithms to load the tgc calibration ...2023-10-30T15:42:33+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chTgc digitization introduce conditions algorithms to load the tgc calibration dataHi everybody,
in while cleaning the `TgcDigitMaker`, I noticed that there's quite some external data loaded that should be uploaded to COOL or a central place on cvmfs.
***dead chamber data***
The `TgcCondDbAlg` is revived to load the...Hi everybody,
in while cleaning the `TgcDigitMaker`, I noticed that there's quite some external data loaded that should be uploaded to COOL or a central place on cvmfs.
***dead chamber data***
The `TgcCondDbAlg` is revived to load the gas gaps that are declared as dead. Instead of a blank ASCII file, the payload is now in the JSON format:
```python
{
"station" : "T1F",
"eta" : "1",
"phi" : "4",
"gasGap" : "3",
"comment" : " A03 M1 f0 F L3 broken chamber since Run-1"
},
```
The script `MuonCondDump.dumpTgcDigiDeadChambers` translates the legacy format into the new JSON style.
```bash
python -m MuonCondDump.dumpTgcDigiDeadChambers --inFile TGC_Digitization_deadChamber.dat --outFile TGC_Digitization_deadChamber.json
python -m MuonCondDump.dumpTgcDigiDeadChambers --inFile TGC_Digitization_2016deadChamber.dat --outFile TGC_Digitization_2016deadChamber.json
python -m MuonCondDump.dumpTgcDigiDeadChambers --inFile TGC_Digitization_NOdeadChamber.dat --outFile TGC_Digitization_NOdeadChamber.json
```
***energy threshold data***
Today, this information is written into the `TGC_Digitization_energyThreshold.dat` file. The `TgcDigitEnergyThreshCondAlg` wil retrieve the data from COOL. As for the dead-chamber data, the payload is in the JSON format and the script `dumpTgcDigiThreshold` translates the legacy file format.
```python
{
"station" : "T4F",
"eta" : "-1",
"phi" : "23",
"gasGap" : "2",
"isStrip" : "1",
"threshold": "0.000798"
},
```
```bash
python -m MuonCondDump.dumpTgcDigiThreshold
```
*** TgcDigitJitterData ***
The time jitter is parsed via the `TgcDigitJitterData`. Despite of holding the jitter bins, the class also draws the random jitter using the CLHEP::RandomEngine. The JSON payload is of the form
```python
{
"angle" : "0",
"nBins" : "41",
"values" : ["0.0805","0.1412","0.0998","0.0782","0.0687","0.0646","0.0638","0.0623","0.0519","0.0447","0.0395","0.0348","0.0311","0.0231","0.0215","0.0194","0.0142","0.0139","0.0091","0.0075","0.0050","0.0045","0.0038","0.0034","0.0025","0.0024","0.0012","0.0015","0.0012","0.0010","0.0005","0.0005","0.0008","0.0009","0.0003","0.0002","0.0004","0.0001","0.0000","0.0000","0.0000"]
},
```
The `dumpTgcDigiJitter` converts the legacy format into the new format
```bash
python -m MuonCondDump.dumpTgcDigiJitter
```
Corresponding unit tests are added to the `MuonCondTest` package.
For the moment, the algorithms are not yet in the production workflow because the folders in COOL are missing. Tagging @formica, @cheidegg, @masato, @junpei, @toshi for information and for the request to create the corresponding folders in COOL and to populate them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66801AthLinks: Add overloads for initializing an EL from DL+index.2023-10-29T03:43:07+01:00Scott SnyderAthLinks: Add overloads for initializing an EL from DL+index.Add an ElementLink constructor taking a DataLink and an index.
Allows to avoid the SG lookup when we already have a DL to the container.Add an ElementLink constructor taking a DataLink and an index.
Allows to avoid the SG lookup when we already have a DL to the container.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66800DataQualityUtils: Fix cppcheck warnings.2023-10-29T03:42:37+01:00Scott SnyderDataQualityUtils: Fix cppcheck warnings.Pass containers by const reference, not by value.
Ignored function return value.Pass containers by const reference, not by value.
Ignored function return value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66799TrigServices: Fix cppcheck warning.2023-10-29T03:42:20+01:00Scott SnyderTrigServices: Fix cppcheck warning.Clean up memory management.Clean up memory management.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66798TrigEgammaMonitoring+TrigMuonMonitoring+TrigMuonHypo: Fix cppcheck warning.2023-10-29T03:43:16+01:00Scott SnyderTrigEgammaMonitoring+TrigMuonMonitoring+TrigMuonHypo: Fix cppcheck warning.Pass containers by const reference, not by value.Pass containers by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66792MuonPrdTest - Add bcId to the Tester N-tuples2023-10-30T15:42:57+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonPrdTest - Add bcId to the Tester N-tuplesAdds extra information to the tester N-tuple.Adds extra information to the tester N-tuple.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66787Param estimation tool properties2023-10-30T15:42:19+01:00Carlo Varnicarlo.varni@cern.chParam estimation tool propertiesSmall change in default parameter following suggestion from @astefl
/cc @adyeSmall change in default parameter following suggestion from @astefl
/cc @adye