athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-20T15:30:36+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69956Cleanup in MCTruthClassifier outside of the main code2024-03-20T15:30:36+01:00Andrii VerbytskyiCleanup in MCTruthClassifier outside of the main codeCleanup in MCTruthClassifier outside of the main code
- Use C++11 range loops
- FormattingCleanup in MCTruthClassifier outside of the main code
- Use C++11 range loops
- Formattinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69955CPAlgorithms: an easier way to disable global trigger matching and efficiency2024-03-20T15:31:52+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: an easier way to disable global trigger matching and efficiencyIntroduce an option `noGlobalTriggerEff` to skip setting up the global trigger efficiency tool (including matching), which crucially does not run on Jet/MET triggers. This should make life easier for such users, who otherwise have to pas...Introduce an option `noGlobalTriggerEff` to skip setting up the global trigger efficiency tool (including matching), which crucially does not run on Jet/MET triggers. This should make life easier for such users, who otherwise have to pass their triggers as a list under `triggerChainsForSelection`, instead of the (nicer) dictionary `triggerChainsPerYear`.
I'm also removing the make-method for trigger configuration, as it's becoming deprecated.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69953New efficiency DQ criteria for HLTmuon hanconfig2024-03-26T14:38:24+01:00Valerio IppolitoNew efficiency DQ criteria for HLTmuon hanconfigThis MR addresses https://its.cern.ch/jira/browse/ATR-28965 by adding a new DQ monitoring algorithm able to perform Fermi fits to TEfficiency input (based on the TGraph contained in the TEfficiency). The code is effectively a copy of [Ro...This MR addresses https://its.cern.ch/jira/browse/ATR-28965 by adding a new DQ monitoring algorithm able to perform Fermi fits to TEfficiency input (based on the TGraph contained in the TEfficiency). The code is effectively a copy of [RootFitGraph](https://gitlab.cern.ch/atlas/athena/-/blob/24.0/DataQuality/dqm_algorithms/dqm_algorithms/RootFitGraph.h), adapted for the changed input.
The thresholds for muons are also tuned based on the [webdisplay](https://atlasdqm.cern.ch/webdisplay/test/2403151/express_express/run_456729/run/HLT/TRMUO/Expert/Efficiency/muChainMSonly/L1MU18VFCH/wrtUpstream/EffL2SA_muPt_wrt_Upstream) produced from the same input as https://its.cern.ch/jira/browse/ATR-28651.
The expert folder is now more conservative than before, i.e. it is not anymore always marked as green, but rather is coloured depending on the worst case - as for the shifter folder. In other words: efficiency matters again.
The effect of the new thresholds and other changes can be seen comparing [old](https://atlasdqm.cern.ch/webdisplay/test/2403151/express_express/run_456729/run/) and [new](https://atlasdqm.cern.ch/webdisplay/test/2403191/express_express/run_456729/run/) webdisplays.
Tagging @yoyamaguhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69952delete unused CaloCellWeightCorrection tool2024-03-20T15:25:40+01:00Walter Lampldelete unused CaloCellWeightCorrection toolThe title says it all ...The title says it all ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/69951CPAlgorithms: add ability to select events based on global trigger matching i...2024-03-20T15:31:30+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: add ability to select events based on global trigger matching in the EventSelection blockAs requested by @katharin, this MR adds a keyword "GLOBALTRIGMATCH" to the `EventSelection` block, to request trigger matching at event-level. One can also ask for any event-level selection flag with `EVENTFLAG someSelection_%SYS%`.
We ...As requested by @katharin, this MR adds a keyword "GLOBALTRIGMATCH" to the `EventSelection` block, to request trigger matching at event-level. One can also ask for any event-level selection flag with `EVENTFLAG someSelection_%SYS%`.
We also make the global-trigger-matching output branch systematics-dependent, which is formally more correct (even though it's a small effect). Since the trigger matching can now be fully integrated into an event selection, the user can rely on the event selection flag and filter out the global-trigger-matching branches.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69950GNNTracking: add overlap SP in dump2024-03-20T15:27:22+01:00Alexis VallierGNNTracking: add overlap SP in dumpAdd Overlap Space Points in the GNNTracking RDO->root dumperAdd Overlap Space Points in the GNNTracking RDO->root dumperhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69949Protect possible rare FPEs in trigger2024-03-21T15:21:42+01:00Vadim KostyukhinProtect possible rare FPEs in triggerAdd some protection in attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69948InDetTrackPerfMon package: Adding extra output stream + bug fixes2024-03-19T17:50:35+01:00Marco AparoInDetTrackPerfMon package: Adding extra output stream + bug fixes- Added functionality to write out, other than the histogram file, a dedicated "slimmed" AOD file for reprocessing studies. The dedicated output stream name is `AOD_IDTPM` (working name). The definitive content of the `AOD_IDTPM` file is...- Added functionality to write out, other than the histogram file, a dedicated "slimmed" AOD file for reprocessing studies. The dedicated output stream name is `AOD_IDTPM` (working name). The definitive content of the `AOD_IDTPM` file is yet to be determined and will be addressed in later MRs.
- Bug fixes in the configuration of the IDTPM packagehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69946CaloRecGPU: Multiprocessing and Cleanup2024-03-21T15:17:57+01:00Nuno Dos Santos FernandesCaloRecGPU: Multiprocessing and CleanupTo ensure we can run with multi-processing, we need to ensure all CUDA-related calls only take place after the `fork`, which means that we must separate the initialization into non-CUDA and CUDA parts. We ensure each is called at the cor...To ensure we can run with multi-processing, we need to ensure all CUDA-related calls only take place after the `fork`, which means that we must separate the initialization into non-CUDA and CUDA parts. We ensure each is called at the correct point in a new `CaloGPUCUDAInitialization.h` base class, though it is a temporary and rather inelegant design to be replaced once/if more comprehensive support for accelerators exists natively in the Athena classes.
Since I was changing things in the classes and initialization, I took the opportunity to also implement the changes that were discussed in !69434 in regards to the non-defaulted destructors and `RECOVERABLE` status codes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69945Prevent ONNX from spawning additional threads2024-03-26T08:53:26+01:00Joshua Falco Beirerjoshua.beirer@cern.chPrevent ONNX from spawning additional threadsPrevent ONNX from spawning additional threads in the FastCaloSim implementation.
Should fix ATLASSIM-7146 (and potentially ATLASSIM-7031 ?)
fyi @zhangr @jchapmanPrevent ONNX from spawning additional threads in the FastCaloSim implementation.
Should fix ATLASSIM-7146 (and potentially ATLASSIM-7031 ?)
fyi @zhangr @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69943Do not hardcode pixel charge for ITk2024-03-23T08:12:54+01:00Tadej Novaktadej.novak@cern.chDo not hardcode pixel charge for ITkDo not hardcode pixel charge for ITk. This seems to originate from DBM that we do not really support anymore so we may as well want to remove this.
/cc @stsuno @tstreble @cvarni @kbai @sroe @goetz @avallier @ncalaceDo not hardcode pixel charge for ITk. This seems to originate from DBM that we do not really support anymore so we may as well want to remove this.
/cc @stsuno @tstreble @cvarni @kbai @sroe @goetz @avallier @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69942Mitigating GPU Moments Calculation Differences2024-03-19T17:41:44+01:00Nuno Dos Santos FernandesMitigating GPU Moments Calculation DifferencesBy changing the algorithm that is used to calculate the eigenvalues and eigenvectors of the 3×3 matrix that gives the shower axis, we can improve the GPU-CPU differences, especially for Δα, Δφ and Δθ.
The new algorithm matches the non-i...By changing the algorithm that is used to calculate the eigenvalues and eigenvectors of the 3×3 matrix that gives the shower axis, we can improve the GPU-CPU differences, especially for Δα, Δφ and Δθ.
The new algorithm matches the non-iterative version used by Eigen, leveraging GPU intrinsics for better precision and performance.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69941Ci test for seed persistification2024-03-19T18:38:54+01:00Carlo Varnicarlo.varni@cern.chCi test for seed persistificationThis is a follow up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/69932
Adds CI test to make sure we can run this configuration and persistify (to ESD specifically) the track seeds
/cc @tstreble @spagan @fcastill @ncalaceThis is a follow up from https://gitlab.cern.ch/atlas/athena/-/merge_requests/69932
Adds CI test to make sure we can run this configuration and persistify (to ESD specifically) the track seeds
/cc @tstreble @spagan @fcastill @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69940main-cppcheck-TrigInDetTrackFitter2024-03-19T17:45:24+01:00Shaun Roemain-cppcheck-TrigInDetTrackFittersolve cppcheck defects (uninitialised variable) introduced in the last week, tidy headerssolve cppcheck defects (uninitialised variable) introduced in the last week, tidy headershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69939ATR-28870: add hh4b GN2 80% chain to physics2024-03-21T15:21:43+01:00Liaoshan ShiATR-28870: add hh4b GN2 80% chain to physicsAdd a looser option for the hh4b asymmetric 2b2j chain, relaxing GN2 from 77% to 80% if rate allows.
Tagging @lidiaz @astruebi @gipezzul for menu, @cpollard @kleney for HDBS, @lbezio @lbeemste for b-jet triggerAdd a looser option for the hh4b asymmetric 2b2j chain, relaxing GN2 from 77% to 80% if rate allows.
Tagging @lidiaz @astruebi @gipezzul for menu, @cpollard @kleney for HDBS, @lbezio @lbeemste for b-jet triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69938Fix ElectronAnalysisConfig BLayer working points2024-03-19T18:38:35+01:00Thomas StreblerFix ElectronAnalysisConfig BLayer working pointsNeeded to match https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/EGSelectorConfigurationMapping.h#L41
Otherwise configurations with `recomputeLikelihood=True` are crashing...Needed to match https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/EGSelectorConfigurationMapping.h#L41
Otherwise configurations with `recomputeLikelihood=True` are crashing.
There's unfortunately some inconsistency between the maps used for the selection tool https://atlas-groupdata.web.cern.ch/atlas-groupdata/ElectronEfficiencyCorrection/2015_2025/rel22.2/2022_Summer_Prerecom_v1/map4.txt and the ones for the scale factor.
FYI @turra @krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69937AFT-721: Fix FTAG derivations and AntiKt4UFOCSSKJets2024-03-21T11:53:28+01:00Samuel Van StroudAFT-721: Fix FTAG derivations and AntiKt4UFOCSSKJetsFixing derivation bugs in FTAG formats introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/69459.
This should also fix the ghost labels for the `AntiKt4UFOCSSKJets` by adding these to the `JetRecConfig`
cc @tstreble @dgu...Fixing derivation bugs in FTAG formats introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/69459.
This should also fix the ghost labels for the `AntiKt4UFOCSSKJets` by adding these to the `JetRecConfig`
cc @tstreble @dguest @bdong @liganghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69936Adding some more info for JSON dumping towards Phoenix2024-03-19T17:45:34+01:00Zach MarshallAdding some more info for JSON dumping towards PhoenixAdding cluster and track links for electrons and cluster links for
photons.
Also updating the options so that this config works out of the box for
both PHYS and PHYSLITE.Adding cluster and track links for electrons and cluster links for
photons.
Also updating the options so that this config works out of the box for
both PHYS and PHYSLITE.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69934Add vertex time plots to monitoring2024-03-22T09:40:47+01:00Jernej DebevcAdd vertex time plots to monitoringThis MR adds plots for HGTD timing information of vertices to physics validation monitoring and CampaignsARTTests.
Follow up to !69290 and !69404.
/cc @aleopold @dshope @tstrebleThis MR adds plots for HGTD timing information of vertices to physics validation monitoring and CampaignsARTTests.
Follow up to !69290 and !69404.
/cc @aleopold @dshope @tstrebleJernej DebevcJernej Debevchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69933Compare app2024-03-19T18:18:13+01:00Evgeny AlexandrovCompare appCreate application for compare CREST and COOL data for selected folder and timestampCreate application for compare CREST and COOL data for selected folder and timestamp