athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-27T16:36:31+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/65154Draft: Fix ATR-280842023-12-27T16:36:31+01:00Edson Carquin LopezDraft: Fix ATR-28084Closes ATR-28084Closes ATR-28084https://gitlab.cern.ch/atlas/athena/-/merge_requests/67922Draft: Added ComponentParameters constructor (ATLASRECTS-7864)2023-12-19T12:59:17+01:00Thomas StreblerDraft: Added ComponentParameters constructor (ATLASRECTS-7864)Follow up to !67894
Solves gcc11 compilation failure ATLASRECTS-7864
FYI @christosFollow up to !67894
Solves gcc11 compilation failure ATLASRECTS-7864
FYI @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67889Draft: Fix ZDC Trigger Simulation Energy Scale for Run 3 Trigger Reprocessing2023-12-18T21:07:19+01:00Matthew Caleb HoppeschDraft: Fix ZDC Trigger Simulation Energy Scale for Run 3 Trigger Reprocessingsupports ATR-26821
Auto configure Zdc Trigger Simulation Energy Scale based on the Run Yearsupports ATR-26821
Auto configure Zdc Trigger Simulation Energy Scale based on the Run Yearhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67911MuonGeoModel: Fix clang warning.2023-12-18T20:11:27+01:00Scott SnyderMuonGeoModel: Fix clang warning.Function with side effects in typeid().Function with side effects in typeid().https://gitlab.cern.ch/atlas/athena/-/merge_requests/67275Draft: Implementing ML based reconstruction configurations and workflows2023-12-18T09:39:49+01:00Fang-Ying TsaiDraft: Implementing ML based reconstruction configurations and workflowsThis MR implements ML-based event filtering to dynamically route events to either track-overlay or MC-overlay workflows.
The RecoEventFilter involves preprocessing data, calculating event scores, and applying a configurable filter based...This MR implements ML-based event filtering to dynamically route events to either track-overlay or MC-overlay workflows.
The RecoEventFilter involves preprocessing data, calculating event scores, and applying a configurable filter based on ML predictions.
The package is intended to be used in conjunction with the merge request !67246
Tagging @jchapmanFang-Ying TsaiFang-Ying Tsaihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67854Fix two cppcheck warnings2023-12-14T18:53:06+01:00Andrii VerbytskyiFix two cppcheck warningsFix two cppcheck warnings:
```
athena/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData/src/NswErrorCalibData.cxx
parameter 'pars' should be passed by const reference.
```
and
```
athena/Control/xAODRootAccess/Root/TEven...Fix two cppcheck warnings:
```
athena/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondData/src/NswErrorCalibData.cxx
parameter 'pars' should be passed by const reference.
```
and
```
athena/Control/xAODRootAccess/Root/TEvent.cxx or there is possible null pointer dereference: tmpMetaTree.
```
@sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67512Draft: Add a dummy sandbox for EF tracking tests2023-12-14T16:51:53+01:00Maximilian Emanuel Goblirsch-KolbDraft: Add a dummy sandbox for EF tracking tests@sabidi @jojungge @ncalace@sabidi @jojungge @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67752decoder compatibility with stgc l1av2 and l1av12023-12-14T16:48:48+01:00Enrique Kajomovitz Mustdecoder compatibility with stgc l1av2 and l1av1There is a new version of the l1a module for the trigger processor.
This version of the decoder includes a workaround that makes it compatible with the two versions without configuration.
There may be changes needed downstream with re...There is a new version of the l1a module for the trigger processor.
This version of the decoder includes a workaround that makes it compatible with the two versions without configuration.
There may be changes needed downstream with respect to the container. since some fields have updated names in the decoder (which are in line with the two versions)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67345Draft: Domain flag for the track-overlay2023-12-14T16:03:07+01:00Fang-Ying TsaiDraft: Domain flag for the track-overlayTrack-overlay workflow introduces a new domain, TrackOverlay, designed to enhance the track-overlay workflow with ML decisions in the reconstruction step.
The MR goes with !67246 and !67275Track-overlay workflow introduces a new domain, TrackOverlay, designed to enhance the track-overlay workflow with ML decisions in the reconstruction step.
The MR goes with !67246 and !67275https://gitlab.cern.ch/atlas/athena/-/merge_requests/67290Draft: (partial) revert of 0f18b1bec43712b3882959513394bc7e3931630b2023-12-14T13:10:44+01:00Maciej Pawel SzymanskiDraft: (partial) revert of 0f18b1bec43712b3882959513394bc7e3931630bSee https://gitlab.cern.ch/atlas/athena/-/merge_requests/64530#note_7325220 for context.
/cc @gemmerenSee https://gitlab.cern.ch/atlas/athena/-/merge_requests/64530#note_7325220 for context.
/cc @gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67794gFEX JetAlgo: fix blkOutAB2023-12-13T19:01:29+01:00Cecilia ToscirigFEX JetAlgo: fix blkOutABThe MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.The MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67021Put the 11.1 cm shift in the default position not as an alignment. No change...2023-12-13T09:15:18+01:00Joseph BoudreauPut the 11.1 cm shift in the default position not as an alignment. No change...Put the 11.1 cm shift in the default position not as an alignment. No change in overall position. Affects BEE1,BEE2 stations only.
Background:
\
@todorova discovered recently a mismatch between the SQLite position of the BEE chambers a...Put the 11.1 cm shift in the default position not as an alignment. No change in overall position. Affects BEE1,BEE2 stations only.
Background:
\
@todorova discovered recently a mismatch between the SQLite position of the BEE chambers and their position in Athena. This was finally traced to a very strange use of alignment constants to fix an apparent bug in positioning of the BEE detectors which sit on the cogs of the endocap toroids. Maybe someone mentioned here knows why or when this was done. It is not specifically related to the SQLite scenario, though it will make the transition easier and more transparent.
Looking in the Geometry database, one fines the table below. The "TRAZ" column is an 11.1 cm shift that affects all of the BEE chambers and nothing else. The entry is the same for all of the BEE chambers (apart from the A Side/C Side minus sign) and it is the same in the last 31 versions of this database table in the Oracle database.
This quantity is currently being injected as a shift in the BEE positions as an _alignment_ correction. It should be obvious that this is improper.
This MR is meant to move the 11.1 cm shift from an alignment correction into the default position of the chambers. The changes produced an identical final position of the chambers, as was tested using a program from @jojungge .
The history of repeated attempts to get this right comes from the following issue. Since the large shift was implemented as an alignment correction, the alignment constants in the _conditions_ database are numbers like (11.1+delta) cm where "delta" is an actual alignment. These alignment constants are applied in data, not in Monte Carlo. So if one adds 11.1 cm into the default position of the chamber, then when alignment corrections are applied (in the reconstruction of data), one gets approximately a 22.2 cm shift rather than an 11.1 cm shift. To fix that, the default position is only adjusted in MC, not in data.
I think in the future we can completely resolve this, because @jojungge plans anyway to migrate information in the conditions database to a friendlier format, and in so doing can remove the 11.1 mm shift from conditions data leaving only the actual "delta".
So that is the story.
![image](/uploads/7f8f28a8f1dea3b91e1c002f98fdaf93/image.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67797Draft: GNN4ITk main dumper2023-12-12T22:30:57+01:00Jackson Carl BurzynskiDraft: GNN4ITk main dumperhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67772MuonReadoutGeometry: fix compilation problems in debug.2023-12-12T11:50:41+01:00Edward MoyseMuonReadoutGeometry: fix compilation problems in debug.The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(...The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(gasGap, gang));
return 0.05 * CLHEP::mm;
}
```
const was removed in opt but not dbg. But we cannot remove const here too because `validGang` is const, and changing this will have knock-on consequences in all the other const methods.
Reverting the static change for this function.
Fixes ATLASRECTS-7858https://gitlab.cern.ch/atlas/athena/-/merge_requests/61174Draft: job property for magnetic field scale2023-12-12T09:12:38+01:00Sarka TodorovaDraft: job property for magnetic field scaleA suggestion of how to propagate the scaled Bfield setup into tracking pT limits.
Not to be merged until low B-field data available ( of importance for tracking with pT<100 MeV only ).
An implementation of a global switch ( doMagFieldSc...A suggestion of how to propagate the scaled Bfield setup into tracking pT limits.
Not to be merged until low B-field data available ( of importance for tracking with pT<100 MeV only ).
An implementation of a global switch ( doMagFieldScaling? ) may be considered, as well as optimization
of hit/holes track selection.
Redirected to 23.0 ( intended for the analysis of special runs in 2023 datataking )https://gitlab.cern.ch/atlas/athena/-/merge_requests/67760TrigInDetTrackFitter: Fix clang warnings.2023-12-11T21:01:40+01:00Scott SnyderTrigInDetTrackFitter: Fix clang warnings.Braces in initializers.
Unused variables.Braces in initializers.
Unused variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67748Remove unused test file2023-12-11T14:47:27+01:00Stewart Martin-HaughRemove unused test fileUnused test script not migrated to CA (ATR-28619). Can just remove this.Unused test script not migrated to CA (ATR-28619). Can just remove this.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67641BPHY22: added container with two-tracks candidates2023-12-11T09:18:50+01:00Laily SultanaliyevaBPHY22: added container with two-tracks candidatesNow container BPHY22DiTrkCandidates is stored in the output DAODs.Now container BPHY22DiTrkCandidates is stored in the output DAODs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67609Draft: Use more DecayProducts in MCTruthClassifier2023-12-11T07:28:04+01:00Andrii VerbytskyiDraft: Use more DecayProducts in MCTruthClassifierUse more DecayProducts in MCTruthClassifierUse more DecayProducts in MCTruthClassifier