athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-10T23:03:39+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67734Fix rpcHashId in NRPC for consistency with legacy RPCs2023-12-10T23:03:39+01:00Matteo NegriniFix rpcHashId in NRPC for consistency with legacy RPCsFix the definition of rpcHashId in NRPC for consistency with legacy RPCs as can be seen here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonCnv/MuonRPC_CnvTools/src/RpcRdoToPrepDataToolMT.cxx?ref_type=heads#L962Fix the definition of rpcHashId in NRPC for consistency with legacy RPCs as can be seen here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonCnv/MuonRPC_CnvTools/src/RpcRdoToPrepDataToolMT.cxx?ref_type=heads#L962https://gitlab.cern.ch/atlas/athena/-/merge_requests/67719DerivationFrameworkMCTruth: Fix clang warning.2023-12-10T18:55:38+01:00Scott SnyderDerivationFrameworkMCTruth: Fix clang warning.Unused variable.Unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67673[ATR-24829] Switch on ERROR mode for HLT seeding validation2023-12-07T14:05:06+01:00Tim Martin[ATR-24829] Switch on ERROR mode for HLT seeding validationWas not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.Was not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65126Externals Update, main branch (2023.08.18.)2023-12-05T17:46:20+01:00Attila KrasznahorkayExternals Update, main branch (2023.08.18.)Updated all projects to use [atlasexternals-2.0.166](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.166). The list of changes wrt. [atlasexternals-2.0.165](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.165) is the follow...Updated all projects to use [atlasexternals-2.0.166](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.166). The list of changes wrt. [atlasexternals-2.0.165](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.165) is the following (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.165...2.0.166):
- Updated to [GeoModel](https://gitlab.cern.ch/GeoModelDev/GeoModel) version `4.5.0` (part of the C\+\+20 migration, thanks to @tsulaia);
- Updated [COOL](https://gitlab.cern.ch/lcgcool/cool) and [CORAL](https://gitlab.cern.ch/lcgcoral/coral) to version `3.3.14` (part of the C\+\+20 migration, thanks to @elmsheus);
- Updated [Coin3D](https://www.coin3d.org/) to hash `5297f6c` (part of the C\+\+20 migration, thanks to @rbianchi);
- Made the [Gaudi](https://gitlab.cern.ch/gaudi/Gaudi) build itself set up [Vc](https://github.com/VcDevel/Vc) for the build/runtime environment (part of the [LCG_104](https://lcginfo.cern.ch/release/104/) migration, thanks to @elmsheus);
- Made `AtlasCompilerSettings.cmake` explicitly check whether the compiler understands `-march=x86-64-v2` before it would set it up;
* Making it possible to still use GCC <11 with our code, for instance for building [AnalysisBase](Projects/AnalysisBase).
I also took a patch from @tsulaia's repository for making [StripGeoModelXml](InnerDetector/InDetDetDescr/StripGeoModelXml) compatible with the GeoModel updates.
Since a lot of externals changed versions, let's do a full suite of tests. But hopefully no reference files will need to be changed.
For the RC: Merging this should **not** require a cleanup of the nodes. :thinking:https://gitlab.cern.ch/atlas/athena/-/merge_requests/67428Draft: tauRecoTools additional cleanup2023-12-05T14:10:46+01:00Antonio De MariaDraft: tauRecoTools additional cleanuphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67441Draft: PoorMansIpAugmenterAlg - get dummy vertex2023-12-05T13:19:08+01:00Stefano FranchellucciDraft: PoorMansIpAugmenterAlg - get dummy vertexChanging the return to dummy vertex instead of `nullptr` when no PV is found, and set tracks to not valid.
This should make it easier to handle for algorithms downstream.
Tagging @dguest and @lbezioChanging the return to dummy vertex instead of `nullptr` when no PV is found, and set tracks to not valid.
This should make it easier to handle for algorithms downstream.
Tagging @dguest and @lbezioStefano FranchellucciStefano Franchelluccihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67331Draft: triggermenu - correct the condition / dead code2023-12-04T09:02:55+01:00Jiri MasikDraft: triggermenu - correct the condition / dead codetry to fix a suspicious condition in the code which evaluates always to True and skips the rest of the sequenceScanner as a consequence.
Maybe the intention was different - leaving to menu experts to commenttry to fix a suspicious condition in the code which evaluates always to True and skips the rest of the sequenceScanner as a consequence.
Maybe the intention was different - leaving to menu experts to commenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67513Ensure release-specific compatibility for HepMC2 and HepMC32023-12-01T00:25:35+01:00Kartik Deepak Bhidekartik.deepak.bhide@cern.chEnsure release-specific compatibility for HepMC2 and HepMC3Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Kartik Deepak Bhidekartik.deepak.bhide@cern.chKartik Deepak Bhidekartik.deepak.bhide@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67340Correcting for a factor in the outputs of the DIPZ regression in Athena2023-11-30T21:57:36+01:00Mohammed Aboelelamo.abdellrazekk@cern.chCorrecting for a factor in the outputs of the DIPZ regression in AthenaThe original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the...The original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the network with a new timestamp. Here, we modified the files that use DIPZ with the new timestamped variable name, and also pointed athena to the location of the new json file.
These changes passed the `test_trigAna_RDOtoAOD_v1Dev_build.py` tests and the new timestamped output variables were inspected in the output AOD from the test.Dan GuestInes OchoaChris PollardKatharine LeneyMohammed Aboelelamo.abdellrazekk@cern.chDan Guesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67468Draft: Switch MTJ dynamic content to work with Aux containers2023-11-29T15:54:10+01:00Tomasz BoldDraft: Switch MTJ dynamic content to work with Aux containersstart of moving MTJ decorations to talk to Aux
@imaznasstart of moving MTJ decorations to talk to Aux
@imaznashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64530Draft: AthenaServices: Avoid leaking IOpaqueAddresses in AthenaOutputStreamTool2023-11-29T15:19:29+01:00Alaettin Serhan MeteDraft: AthenaServices: Avoid leaking IOpaqueAddresses in AthenaOutputStreamToolIn the trigger step of an MC21a ttbar full-chain job `valgrind` complains that we're leaking `IOpaqueAddress` es:
```
41,222 (34,048 direct, 7,174 indirect) bytes in 133 blocks are definitely lost in loss record 96,303 of 97,826
at 0x...In the trigger step of an MC21a ttbar full-chain job `valgrind` complains that we're leaking `IOpaqueAddress` es:
```
41,222 (34,048 direct, 7,174 indirect) bytes in 133 blocks are definitely lost in loss record 96,303 of 97,826
at 0x4033F11: operator new(unsigned long) (vg_replace_malloc.c:422)
by 0x47D556EB: AthenaOutputStreamTool::streamObjects(std::vector<DataObject*, std::allocator<DataObject*> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (AthenaOutputStreamTool.cxx:448)
by 0x47D3E838: AthenaOutputStream::write() (AthenaOutputStream.cxx:641)
by 0x47D32FAE: AthenaOutputStream::execute() (AthenaOutputStream.cxx:532)
by 0x2F9637C6: Gaudi::Algorithm::sysExecute(EventContext const&) (Algorithm.cpp:366)
```
We are doing a by-hand cleanup of the `IOpaqueAddress` es but we might be conditionally skipping some of them. With this MR we are dropping the by-hand memory management of these guys in favor of unique pointers.
This should be a benign change but you never know. Therefore, I'll run the full suit of tests, just in case.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67235Draft: 24.0.4 add groomed truth large-R jet information to derivation production2023-11-28T15:26:30+01:00Andrius VaitkusDraft: 24.0.4 add groomed truth large-R jet information to derivation productionWORK IN PROGRESS
Adds the ability to save groomed truth jet mass and pt to jets with the `R10TruthLabel_R22v1` label.
(ignore the new label `R10TruthLabel_R22v1Groomed`, it will be deleted)WORK IN PROGRESS
Adds the ability to save groomed truth jet mass and pt to jets with the `R10TruthLabel_R22v1` label.
(ignore the new label `R10TruthLabel_R22v1Groomed`, it will be deleted)https://gitlab.cern.ch/atlas/athena/-/merge_requests/64375[DRAFT] Identifying spoiled muon clusters2023-11-27T17:22:09+01:00Andreas Psallidas[DRAFT] Identifying spoiled muon clustersThis MR is marked as draft in order to discuss and correct a [tool](https://indico.cern.ch/event/1241496/contributions/5468728/attachments/2673609/4635425/ClustersAndRadiation_QT.pdf) on identifying spoiled muon clusters.
@jojungge @psc...This MR is marked as draft in order to discuss and correct a [tool](https://indico.cern.ch/event/1241496/contributions/5468728/attachments/2673609/4635425/ClustersAndRadiation_QT.pdf) on identifying spoiled muon clusters.
@jojungge @pscholer @stavrophttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65878[DRAFT] sTGC cluster position uncertainty2023-11-27T17:20:16+01:00Andreas Psallidas[DRAFT] sTGC cluster position uncertaintyThis MR tries to implement JIRA Ticket: ATLASRECTS-7742This MR tries to implement JIRA Ticket: ATLASRECTS-7742https://gitlab.cern.ch/atlas/athena/-/merge_requests/67393TrigValSteering: increase timeout for build tests2023-11-27T15:41:19+01:00Bertrand Martin Dit LatourTrigValSteering: increase timeout for build testsHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
BertrandHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65203Draft: MuonCalibStream2023-11-27T13:26:04+01:00Zhen YanDraft: MuonCalibStreamPut back the bytestream converter for Muon Calibration Stream data.
The converter config snippet is located at https://gitlab.cern.ch/zyan/athena/-/tree/master/MuonSpectrometer/MuonCalib/MuonCalibStream/MuonCalibStreamCnv/python/MuonCali...Put back the bytestream converter for Muon Calibration Stream data.
The converter config snippet is located at https://gitlab.cern.ch/zyan/athena/-/tree/master/MuonSpectrometer/MuonCalib/MuonCalibStream/MuonCalibStreamCnv/python/MuonCalibStreamCnvConfig.py
Also, you can find one test job under the link https://gitlab.cern.ch/atlas-mcp/MdtCalib/mdtcalibframework/-/blob/master/test/MuonCalibStreamTest.pyEdward MoyseJohannes Junggeburthjohannes.josef.junggeburth@cern.chEdward Moysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66360Draft: add DiTau BDT score to TauCP list of variables available for derivations2023-11-27T13:16:14+01:00Antonio De MariaDraft: add DiTau BDT score to TauCP list of variables available for derivationsTagging @martindlTagging @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66018Draft: Issue with Calib Chain2023-11-27T12:14:14+01:00Debottam Bakshi GuptaDraft: Issue with Calib ChainAs mentioned in ATR-28177 this MR tries to rectify `unmet INPUT dependencies`As mentioned in ATR-28177 this MR tries to rectify `unmet INPUT dependencies`https://gitlab.cern.ch/atlas/athena/-/merge_requests/64943Draft: helpers to compare geomodel subtrees, material validation2023-11-27T10:57:51+01:00Sarka TodorovaDraft: helpers to compare geomodel subtrees, material validationTentative implementation of algorithm to compare subsets of a GeoModel tree, or separate GM trees.
Importing generic code for mass evaluation and printout from MuonTrackingGeometry.
TODO : a) find out which part of the functionality is,...Tentative implementation of algorithm to compare subsets of a GeoModel tree, or separate GM trees.
Importing generic code for mass evaluation and printout from MuonTrackingGeometry.
TODO : a) find out which part of the functionality is, or should be, handled by the GeoModel
b) resolve crashes occuring in the readout of GeoFullPhysVol subtree from the database
b) turn helpers into AlgTools for proper initialization ?Sarka TodorovaSarka Todorovahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66646Draft: Initial commit adding eEM9M as a new 2-bit threshold in physics menu, ...2023-11-27T10:53:15+01:00Marco MontellaDraft: Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and...Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and copies of the DiPhoton TLA chain with eEM9M and eEM10L. DPHI version also amended to range from 0.2 to 2.0.
Tagging @khoo for review.
Current status: Running, no...Initial commit adding eEM9M as a new 2-bit threshold in physics menu, and copies of the DiPhoton TLA chain with eEM9M and eEM10L. DPHI version also amended to range from 0.2 to 2.0.
Tagging @khoo for review.
Current status: Running, no counts (will have to re-run on larger stats)