athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-03-23T04:53:37+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/41806Tony qt art2021-03-23T04:53:37+01:00Luzhan YueTony qt artCompleted the art tests for some Pythia8 JOsCompleted the art tests for some Pythia8 JOsLuzhan YueLuzhan Yuehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41845add LHE filters from MC15JobOptions/topcontrol2021-03-22T22:20:23+01:00Ewelina Maria Lobodzinskaadd LHE filters from MC15JobOptions/topcontroladd LHE filters from MC15JobOptions/topcontroladd LHE filters from MC15JobOptions/topcontrolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41343WIP: Saving TruthParticles in 21.6 for MinBias2021-03-22T20:08:22+01:00Christian GutschowWIP: Saving TruthParticles in 21.6 for MinBiasHi @jdandoy - so with this you could put a `evgenConfig.saveTruthAOD = True` in the JOs which should save both the `TruthParticles` collection as well as any truth-jet collection specified in the JOs.
If you wanted to do more complicate...Hi @jdandoy - so with this you could put a `evgenConfig.saveTruthAOD = True` in the JOs which should save both the `TruthParticles` collection as well as any truth-jet collection specified in the JOs.
If you wanted to do more complicated things like thinning etc., then this will need a bit more work.
Needed for ATLASSIM-3837
cc @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/25091WIP: Dropping SignalState features from xAOD::CaloCluster2021-03-22T18:45:32+01:00Walter LamplWIP: Dropping SignalState features from xAOD::CaloClusterThe ability of xAOD::CaloCluster to present itself in various signal states is a threading problem. To first order, the issue has been solved by @christos in https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/14465 by disallowing...The ability of xAOD::CaloCluster to present itself in various signal states is a threading problem. To first order, the issue has been solved by @christos in https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/14465 by disallowing state-changes for const clusters. This defeats the initial purpose of signal-states and the fact that it works suggests that the feature is not used in practice.
Grep'ing through the repository, I find indeed (almost) no uses of signal-state functionality. I did find includes-without-usage, debug-level printouts and HLT-monitoring of the signal-state of clusters. All that is practically meaningless and I deleted these lines with this MR.
On the cluster object itself, I remove the transient variable storing the signal state and its setters and getters. The methods implementing the IParticle interface will always return the calibrated state. The un-calibrated kinematics is still accessible by calling eg `cluster->eta(xAOD::CaloCluster::UNCALIBRATED)`. To allow passing un-calibrated clusters as IParticle to tools, I wrote a thread-safe wrapper object that implements the IParticle interface and forwards calls to cluster with a given signal state (xAODCaloCluster/CaloClusterSignalstate). But since I havn't found any use-case, I might remove that before un-wip'ing this MR.
Remaining problem: METReconstruction/METJetAssocTool
This tools compares the signal state of the jet and the clusters the jet was made of and behaves differently depending on the result. I don't quite understand what is going on here and I suspect it makes no sense: In the old scheme, the signal state might have been changes between the jet-finding and the MET-Association. With Christos' MR, it can't change and in real life it will never be anything but CALIBRATED. I hope @khoo can help here (git blame says you wrote that).
Possible problem: I deleted TrigHLTJetRec/src/ClusterToPseudoJetConverter. In the current HEAD of master, all uses of this helper are commented out (by @peter, afaik). A different implementation would be necessary achieve the same functionality w/o the signal-states.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26192WIP: Implementing the HGTD geometry visualization in 'master'2021-03-22T18:45:25+01:00Riccardo Maria Bianchiriccardo.maria.bianchi@cern.chWIP: Implementing the HGTD geometry visualization in 'master'This MR implements the visualization of the GeoTorus GeoModel shape, which had not been implemented so far (HGTD is the first client of the GeoTorus shape).
Also, it adds switches and filters to better visualize the HGTD geo.
It also def...This MR implements the visualization of the GeoTorus GeoModel shape, which had not been implemented so far (HGTD is the first client of the GeoTorus shape).
Also, it adds switches and filters to better visualize the HGTD geo.
It also defines a color schema for the HGTD volumes and materials.
Also, it fixes several minor issues.
*Note:* the code has been developed for the HGTD TDR studies and tested in 20.20.14.2. It's now part of the 20.20.14.3 release. I'm now porting those changes to `master`.
----
Details:
- ATLSWUPGR-71
- ATLASVPONE-470
----
Cc: @cohmhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26193WIP: updating the VP1Light Project to "master" on CC72021-03-22T18:45:16+01:00Riccardo Maria Bianchiriccardo.maria.bianchi@cern.chWIP: updating the VP1Light Project to "master" on CC7The VP1Light project has to compile on CC7, macOS, and Ubuntu.
This MR implements and tests the compilation of the VP1Light project on macOS 10.14.5, CC7, SLC6, and Ubuntu 18.0.4
Mostly VP1-related or minor changes here, apart from som...The VP1Light project has to compile on CC7, macOS, and Ubuntu.
This MR implements and tests the compilation of the VP1Light project on macOS 10.14.5, CC7, SLC6, and Ubuntu 18.0.4
Mostly VP1-related or minor changes here, apart from some explicitly linked library needed for macOS compilation and the `#ifndef XAOD_STANDALONE` guards to get `xAODTrigger/Root/TrigComposite_v1.cxx` compiled in standalone mode. For that, I would ping @akraszna, because the `AnalysisBase` release could be affected by the changes to the `xAODTrigger` package.
----
*NOTE*
This MR requires the new Externals packages GeoModelCore (https://gitlab.cern.ch/GeoModelDev/GeoModelCore) and GeoModelIO (https://gitlab.cern.ch/GeoModelDev/GeoModelIO) from the new standalone GeoModel.
Therefore, this MR will be a WIP until the new Externals MR containing the new packages will be merged: https://gitlab.cern.ch/atlas/atlasexternals/merge_requests/536https://gitlab.cern.ch/atlas/athena/-/merge_requests/28062WIP: Fix FastSiDigitizationConfig.py and PixelDigitization_jobOptions.py, two...2021-03-22T18:45:06+01:00Tulay Cuhadar DonszelmannWIP: Fix FastSiDigitizationConfig.py and PixelDigitization_jobOptions.py, two ART tests- PixelRecoDbTool tool removed in master. Replace the tool in FastSiDigitizationConfig.py and PixelDigitization_jobOptions.py as recommended.
Adding @stsuno, @tlari, @vpascuzz, @ffabbri and @jchapman
- Fix typo in two FastChain ART tests- PixelRecoDbTool tool removed in master. Replace the tool in FastSiDigitizationConfig.py and PixelDigitization_jobOptions.py as recommended.
Adding @stsuno, @tlari, @vpascuzz, @ffabbri and @jchapman
- Fix typo in two FastChain ART testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/32625WIP: update default FTag CDI2021-03-22T18:44:32+01:00Yichen LiWIP: update default FTag CDIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/32975WIP: Double to float conversion2021-03-22T18:44:26+01:00Sanmay GangulyWIP: Double to float conversionThis is a work in progress for implementing double to float compression for FTAG software. This version compiles but still has some crash from HbbtaggerThis is a work in progress for implementing double to float compression for FTAG software. This version compiles but still has some crash from HbbtaggerSanmay GangulySanmay Gangulyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/33033WIP: support to produce EGAM1 derivations for heavy ion MC with "data overlay...2021-03-22T18:44:16+01:00Prabhakar PalniWIP: support to produce EGAM1 derivations for heavy ion MC with "data overlay" samplessupport to process heavy ion MC with "data overlay" samples by enabling and tagging as a MC using Conditions From MetaData (related to HI) to save TruthContainerssupport to process heavy ion MC with "data overlay" samples by enabling and tagging as a MC using Conditions From MetaData (related to HI) to save TruthContainershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35393WIP:Test full-unit-tests with an MR that makes no changes: whitespace only2021-03-22T18:43:26+01:00Stewart Martin-HaughWIP:Test full-unit-tests with an MR that makes no changes: whitespace onlyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35615WIP: Modify JetSubStructureMomentTools to use DecorHandles2021-03-22T18:42:54+01:00Jason Robert VeatchWIP: Modify JetSubStructureMomentTools to use DecorHandlesModify `JetSubStructureMomentTools` to use DecorHandles. `ShowerDeconstructionTool`, `BosonTagTool`, and `BoostedXbbTagTool` are removed. Other bits of cleaning up and improving comments have also been done.
This is still WIP with 3 pr...Modify `JetSubStructureMomentTools` to use DecorHandles. `ShowerDeconstructionTool`, `BosonTagTool`, and `BoostedXbbTagTool` are removed. Other bits of cleaning up and improving comments have also been done.
This is still WIP with 3 primary pieces missing:
- [ ] Implement DecorHandles in the NSubjettiness and ECF tools since the moments structures add complications
- [ ] Modify SubjetRecorder to use `const` jets
- [ ] Validate output
These changes ended up being more involved than anticipated and were delayed due to several complications. I will continue resolving the three outstanding issues. In the meantime, I'm tagging @sschramm, @cdelitzs, @mswiatlo, @wbalunas, @sawyer for comments.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36144WIP: Migration of HLT ID monitoring2021-03-22T18:42:39+01:00Fabrizio TrovatoWIP: Migration of HLT ID monitoringMerge request for the migration of ID monitoring to newest tools. At the moment following the guidelines for integration of a basic algorithm for retrieving chains and tracks.Merge request for the migration of ID monitoring to newest tools. At the moment following the guidelines for integration of a basic algorithm for retrieving chains and tracks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36576WIP: Development of a SuperCell ByteStream Converter2021-03-22T18:42:33+01:00Jochen Jens HeinrichWIP: Development of a SuperCell ByteStream ConverterMerge request for the development of the LATOME ByteStream Converter. The current implementation is not yet final and some elements are still missing (error codes, more debug printouts, etc.)
Tagging @pavol @aad @damazioMerge request for the development of the LATOME ByteStream Converter. The current implementation is not yet final and some elements are still missing (error codes, more debug printouts, etc.)
Tagging @pavol @aad @damaziohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/37223WIP:Remove TrackingGeometrySvc use: ATR-221732021-03-22T18:42:25+01:00Stewart Martin-HaughWIP:Remove TrackingGeometrySvc use: ATR-22173Remove use of TrackingGeometrySvc in TrigEgammaRec and TrigMuonEF. For TrigEgammaRec, this just meant deleting an unused python module. For TrigMuonEF the changes are slightly more involved, so tagging @sshaw
Cheers,
StewartRemove use of TrackingGeometrySvc in TrigEgammaRec and TrigMuonEF. For TrigEgammaRec, this just meant deleting an unused python module. For TrigMuonEF the changes are slightly more involved, so tagging @sshaw
Cheers,
Stewarthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/37873WIP: SUSYTools for r222021-03-22T18:41:51+01:00Sara AlderweireldtWIP: SUSYTools for r22First check-in of running ST for r22
- electrons/photons/muons in
- jets in but no calibration / no JVT / no uncertainties
- bjets in (use BTag.KeyOverride for DAOD_PHYS)
- no tau/met yet
- one line disabled in `PhysicsAnalysis/ElectronP...First check-in of running ST for r22
- electrons/photons/muons in
- jets in but no calibration / no JVT / no uncertainties
- bjets in (use BTag.KeyOverride for DAOD_PHYS)
- no tau/met yet
- one line disabled in `PhysicsAnalysis/ElectronPhotonID/egammaMVACalibAnalysis` to avoid ROOT crash
Everything configured with (very) old recommendations, since up-to-date ones aren't quite compatible with the available CP tools yet
- See `data/SUSYTools_Default.conf` for working config
tagging: @janders , @alopezso , @lheinrichttps://gitlab.cern.ch/atlas/athena/-/merge_requests/37913WIP: add radiation damage effects in fast pixel digitization2021-03-22T18:41:43+01:00Tommaso LariWIP: add radiation damage effects in fast pixel digitizationAdd radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or mea...Add radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or measurements, values for end of 2017, end of run2, and a couple end of run3 scenarios are available. The default is no radiation damage though, it can be changed from job option. Also revising the charge to TOT conversion and the amount of energy loss fluctuations. The default position smearing is changed so that cluster size and other observable are very close to previous output.
I previously opened [this merge request](https://gitlab.cern.ch/atlas/athena/-/merge_requests/28731) but somehow messed up when implementing the comments from the reviewers - I got errors in pushing to git and could not figure out why. So I started from scratch. All comments in the previous MR are addressed in this version, so I hope it will get through relatively easily. Sorry for the mess.https://gitlab.cern.ch/atlas/athena/-/merge_requests/37975WIP: Trig id mon migration2021-03-22T18:41:32+01:00Fabrizio TrovatoWIP: Trig id mon migrationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38703[WIP] integration/physlite2021-03-22T18:41:07+01:00Lukas Alexander Heinrich[WIP] integration/physlitehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41774MuonPRDTest: Add CSC/TGCRDOVariables.cxx/.h2021-03-22T10:49:34+01:00Minlin WuMuonPRDTest: Add CSC/TGCRDOVariables.cxx/.hNSWPRDValAlg.cxx/.h are modified in order to use the TGC cabling service to retrieve the identifier.NSWPRDValAlg.cxx/.h are modified in order to use the TGC cabling service to retrieve the identifier.