athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-30T21:42:55+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46783topoEgammaBuilder rename to xAODEgammaBuilder.2021-09-30T21:42:55+02:00Christos Anastopouloschristos.anastopoulos@cern.chtopoEgammaBuilder rename to xAODEgammaBuilder.topoEgammaBuilder rename to xAODEgammaBuilder.
The algorithm per se can take any egammaRecs and produce xAOD Egamma objects. So xAODEgammaBuilder is more exact on what the alg does. Take some egammaRec
[https://acode-browser1.usatlas....topoEgammaBuilder rename to xAODEgammaBuilder.
The algorithm per se can take any egammaRecs and produce xAOD Egamma objects. So xAODEgammaBuilder is more exact on what the alg does. Take some egammaRec
[https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/egamma/egammaRecEvent/egammaRecEvent/egammaRec.h]
and turns them to xAOD objects.
Now , indeed the default is to have instances that take take topo cluster seeded e/gamma super clusters so the name of the instances being topo make sense.
The reason to rename things is to make clean that this alg really just takes egammaRec and produces xAOD objects. It does not do much in the way of "core" reconstruction. All clusters ,cluster - track pairs, class vertex pairs forming what not steps are already done before we reach this one.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46832TrfTestsART: update conditions tags and introduce ESDMerge test2021-09-30T21:54:40+02:00Johannes ElmsheuserTrfTestsART: update conditions tags and introduce ESDMerge testManual cherry-pick of MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/46797 into 22.0-mc20 branch
* Introduce a new ESDMerge_tf regression test `test_trf_esdmerge_serial.sh`
* Update the conditionsTag to CONDBR2-BLKPA-RUN2-08 in...Manual cherry-pick of MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/46797 into 22.0-mc20 branch
* Introduce a new ESDMerge_tf regression test `test_trf_esdmerge_serial.sh`
* Update the conditionsTag to CONDBR2-BLKPA-RUN2-08 in all data testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46849EvgenJobTransforms: correct new Verbose argument2021-10-01T03:45:08+02:00Ewelina Maria LobodzinskaEvgenJobTransforms: correct new Verbose argumentEvgenJobTransforms: correct new Verbose argumentEvgenJobTransforms: correct new Verbose argumenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46855Going back to EMTopo pre-selection2021-10-01T06:42:06+02:00Michael Donald HankGoing back to EMTopo pre-selectionIt was decided that keeping the EMTopo jet pre-selection is permissible as it should be a small effect and apply the same to data and MC.It was decided that keeping the EMTopo jet pre-selection is permissible as it should be a small effect and apply the same to data and MC.Oana Vickey BoeriuMichael Donald HankOana Vickey Boeriuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46836Add documentation for muon trigger menu sequences2021-10-01T09:43:32+02:00Savanna ShawAdd documentation for muon trigger menu sequencesAdding some documentation for the muon trigger to describe the various menu sequences and variations.Adding some documentation for the muon trigger to describe the various menu sequences and variations.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46851AGDDKernel: Fix cppcheck warnings.2021-10-01T09:44:43+02:00Scott SnyderAGDDKernel: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46852AGDDModel+AGDDControl+AGDDHandlers+MuonAGDDBase: Thread-safety fixes for AGDD...2021-10-01T09:43:11+02:00Scott SnyderAGDDModel+AGDDControl+AGDDHandlers+MuonAGDDBase: Thread-safety fixes for AGDDModel.Enable thread-safety checking in AGDDModel.
Handle the static singletons by moving them into AGDDController.Enable thread-safety checking in AGDDModel.
Handle the static singletons by moving them into AGDDController.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46833fix eEM isolation (ATR-24182)2021-10-01T09:44:01+02:00Daniele Zanzifix eEM isolation (ATR-24182)The isolation cuts have been removed by mistake in !46717
Tagging @amoreira, @afaulkneThe isolation cuts have been removed by mistake in !46717
Tagging @amoreira, @afaulknehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46840CaloCellNeighborsAverageCorr: Remove unnecessary include of CaloDetDescrManager2021-10-01T09:43:19+02:00Walter LamplCaloCellNeighborsAverageCorr: Remove unnecessary include of CaloDetDescrManagerWhile working on the migration of `CaloDetDescrManager` to the `CondStore`, I discovered that some file include `CaloDetDescManager.h` without actually using it. Most likely a copy-paste artifact.
This MR removes the unnecessary include...While working on the migration of `CaloDetDescrManager` to the `CondStore`, I discovered that some file include `CaloDetDescManager.h` without actually using it. Most likely a copy-paste artifact.
This MR removes the unnecessary include statements and forward-declarations.
cc @tsulaia for info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46831Do not leave empty strings for histogram definitions2021-10-01T09:43:52+02:00Peter OnyisiDo not leave empty strings for histogram definitionsInvalid JSON was being left when improper histogram definitions were made. Closes ATLASRECTS-6583Invalid JSON was being left when improper histogram definitions were made. Closes ATLASRECTS-6583https://gitlab.cern.ch/atlas/athena/-/merge_requests/46780Updated RDO files in egammaValidation test scripts as well as specified condi...2021-10-01T09:45:12+02:00Frued Erik BrarenUpdated RDO files in egammaValidation test scripts as well as specified conditions tagUpdate input RDO files in egammaValidation ART test scripts to those corresponding to the section 'Second Round, "crucial"' in https://twiki.cern.ch/twiki/bin/view/AtlasProtected/EgammaMC16Rel22 . With that change, it is currently necess...Update input RDO files in egammaValidation ART test scripts to those corresponding to the section 'Second Round, "crucial"' in https://twiki.cern.ch/twiki/bin/view/AtlasProtected/EgammaMC16Rel22 . With that change, it is currently necessary to explicitly give a conditions tag in the Reco_tf.py command.
@turra @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46847ITk conversion reconstruction 2/22021-10-01T09:43:42+02:00Thomas StreblerITk conversion reconstruction 2/2Final changes needed to run ITk photon conversion tracking reconstruction. Follow up of !46759
FYI @nstyles @ncalace @pagessin @lgagnon @lpascualFinal changes needed to run ITk photon conversion tracking reconstruction. Follow up of !46759
FYI @nstyles @ncalace @pagessin @lgagnon @lpascualhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46842Looking at the CaloDetDescrMgr migration to ReadHandles rm 2 un-needed...2021-10-01T09:43:54+02:00Christos Anastopouloschristos.anastopoulos@cern.chLooking at the CaloDetDescrMgr migration to ReadHandles rm 2 un-needed...Looking at the CaloDetDescrMgr migration to ReadHandles rm 2 un-needed includes from CaloCluster_OnTrackBuilder
Mentioning @turra and @tsulaiaLooking at the CaloDetDescrMgr migration to ReadHandles rm 2 un-needed includes from CaloCluster_OnTrackBuilder
Mentioning @turra and @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46864EvgenJobTransforms/Generate_debug_level.py fix generators name2021-10-01T15:46:18+02:00Ewelina Maria LobodzinskaEvgenJobTransforms/Generate_debug_level.py fix generators nameEvgenJobTransforms/Generate_debug_level.py: fix generators nameEvgenJobTransforms/Generate_debug_level.py: fix generators namehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46854EvgenJobTransform : correct bug in setting of debug mode, fixing hepMC3 issue...2021-10-01T15:42:47+02:00Ewelina Maria LobodzinskaEvgenJobTransform : correct bug in setting of debug mode, fixing hepMC3 issue...EvgenJobTransform : correct bug in setting the debug mode,
fix HepMC3 issue in Tauolapp,
signall HepMC3 problem in EvtGen_iEvgenJobTransform : correct bug in setting the debug mode,
fix HepMC3 issue in Tauolapp,
signall HepMC3 problem in EvtGen_ihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45921Filling the configConsistency check histogram with information from TrigConfK...2021-10-15T00:05:31+02:00Elin Bergeaas KuutmannFilling the configConsistency check histogram with information from TrigConfKeys and TrigConfKeysOnlineIn the overall HLT DQ monitoring, one important histogram is the ConfigConsistency check, which compares SMK and HLTPSK from different sources, ensuring that they are the same.
In Run3, as per the advice from @tamartin , these values ar...In the overall HLT DQ monitoring, one important histogram is the ConfigConsistency check, which compares SMK and HLTPSK from different sources, ensuring that they are the same.
In Run3, as per the advice from @tamartin , these values are picked from
` SG::ReadHandleKey<xAOD::TrigConfKeys> m_eventKey{this, "EventObjectName", "TrigConfKeys", "Key for the event-level configuration identifier object"};`
` SG::ReadHandleKey<xAOD::TrigConfKeys> m_onlineKey{this, "EventObjectName", "TrigConfKeysOnline", "Key for the online configuration identifier object"};`
`
To run the code, compile as usual and run
`Run3DQTestingDriver.py --dqOffByDefault Input.Files="['../../build_output_in_eos/2021-08-17T2101/TrigP1Test/test_trigP1_v1PhysP1_T0Mon_build/AOD.pool.root']" Concurrency.NumThreads=1 DQ.Steering.doHLTMon=True DQ.Steering.HLT.doEgamma=False DQ.Steering.HLT.doMET=False DQ.Steering.HLT.doJet=False DQ.Steering.HLT.doBjet=False DQ.Steering.HLT.doCalo=False DQ.Steering.HLT.doMuon=False DQ.Steering.HLT.doBphys=False DQ.Steering.HLT.doMinBias=False DQ.Steering.HLT.doTau=False > mylog.txt &`
(or a more recent nightly)
Right now all SMK and HLTPSK from both sources are 0. According to Tim, this is because the AODs are created from python, not executed using keys from the database. This needs testing on an AOD with the correct keys. I have not managed to locate any AODs with the right keys (ATR-24160). I want to commit this code so that it can be tested in the pilot beam.
Ping @astruebi , @palacino , @stelzer , @fwinkl
Related to ATR-19453 ATR-19441 ATR-19976 ATR-21172https://gitlab.cern.ch/atlas/athena/-/merge_requests/46738ATR-24105: LAr/Tile menu implementation for Oct 2021 Pilot Beam2021-10-01T16:45:21+02:00Stefanie MorgensternATR-24105: LAr/Tile menu implementation for Oct 2021 Pilot Beam* LArPEB chains:
* change L1EM20VHI seed to L1EM22VHI
* move to PhysicsP1 menu
* add streamers for L1EX/JX in Cosmic and PhysicsP1 menu (CalibSlice) -> as LArPEBCalib (temporarily! should be LArPEB, investigations ongoing)
* ~~a...* LArPEB chains:
* change L1EM20VHI seed to L1EM22VHI
* move to PhysicsP1 menu
* add streamers for L1EX/JX in Cosmic and PhysicsP1 menu (CalibSlice) -> as LArPEBCalib (temporarily! should be LArPEB, investigations ongoing)
* ~~add LArPEB to EDM~~
* update references
* MBTS triggers:
* add MBTS_A/C items to L1 menu
* add streamers to PhysicsP1 menu
* move all HLT_noalg_MBTS* chains to MinBias stream
* update references
* LArDigitalTrigger:
* add streamers with and without LArPEB output for L1_J400_LAR and L1_LAR-ZEE-eEM to PhysicsP1 menu
* fully add L1_BGRP7 in L1 menu
* clean up L1_RD0_BGRPX items in L1 menu (clear naming convention + remove duplications)
* add add LArPEB with LATOME-only configuration
* add LArPEBDigitalTrigger stream
* add streamers with and without ~~LArPEBDigitalTrigger~~LATOMEPEB output for FILLED, FIRSTEMPTY, EMPTY, and BGRP7 to PhysicsP1 menu
* update references
@Lily, I've moved all LArPEB chains from the LS2_v1 menu to the PhysicsP1 menu; ~~they are now in both, the PhysicsP1 and the Cosmic menu~~ (sorry this was a mistake). Could you please confirm if you are happy with that?https://gitlab.cern.ch/atlas/athena/-/merge_requests/46633Add a deltaR max and min cut to TrigMultiTrkComboHypo2021-10-01T15:44:41+02:00Adam Edward BartonAdd a deltaR max and min cut to TrigMultiTrkComboHypoNeed chain names to configure algorithm
cc @lyubushkNeed chain names to configure algorithm
cc @lyubushkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46862MuonLRT ART test fixes2021-10-01T21:44:08+02:00Benjamin Philip KerridgeMuonLRT ART test fixesThe muon ART tests are broken due to the chain names changing. This change corrects the AODtoTrkNtuple.py to fix the issue.
This MR replaces atlas/athena!46837The muon ART tests are broken due to the chain names changing. This change corrects the AODtoTrkNtuple.py to fix the issue.
This MR replaces atlas/athena!46837https://gitlab.cern.ch/atlas/athena/-/merge_requests/46412Adding MinBias settings to tracking cuts2021-10-03T17:24:06+02:00Alexander Kevin GilbertAdding MinBias settings to tracking cutsThis merge request is a follow up of the issue in [ATR-24090](https://its.cern.ch/jira/browse/ATR-24090). The tracking cuts config settings added here are adapted to Run 2 settings.
cc: @tbold, @suttThis merge request is a follow up of the issue in [ATR-24090](https://its.cern.ch/jira/browse/ATR-24090). The tracking cuts config settings added here are adapted to Run 2 settings.
cc: @tbold, @sutt