athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-01T21:44:19+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46856Switched LArCaf components to getting CaloDetDescrManager from the Condition ...2021-10-01T21:44:19+02:00Vakhtang TsulaiaSwitched LArCaf components to getting CaloDetDescrManager from the Condition StorePart of the ongoing migration of all CaloDetDescrManager clients.Part of the ongoing migration of all CaloDetDescrManager clients.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46858Switched CaloClusterROI_Selector to getting CaloDetDescrManager from the Cond...2021-10-01T21:43:34+02:00Vakhtang TsulaiaSwitched CaloClusterROI_Selector to getting CaloDetDescrManager from the Condition StorePart of the ongoing migration of allclients of the `CaloDetDescrManager`Part of the ongoing migration of allclients of the `CaloDetDescrManager`https://gitlab.cern.ch/atlas/athena/-/merge_requests/46416Initial Run3 configuration added2021-10-01T21:43:04+02:00Edson Carquin LopezInitial Run3 configuration addedAdding han config file configuration for Run3 tau trigger monitoring tagging @ademaria @ebergeasAdding han config file configuration for Run3 tau trigger monitoring tagging @ademaria @ebergeashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46853TrkTrack+TrkEventTPCnv: Hold TSOS vector by pointer rather than by value.2023-08-19T23:10:04+02:00Scott SnyderTrkTrack+TrkEventTPCnv: Hold TSOS vector by pointer rather than by value.Allows giving track something derived from DataVector<TSOS>, rather than that class
exactly.
Temporary(?) change to try to track down ATLASRECTS-6331.Allows giving track something derived from DataVector<TSOS>, rather than that class
exactly.
Temporary(?) change to try to track down ATLASRECTS-6331.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46868Make pflow reco ART test from ESD script executable2021-10-01T21:43:36+02:00Mark HodgkinsonMake pflow reco ART test from ESD script executableMake the pflow from ESD test script executable. This hopefully prevents the test failing in some master builds due to a permissions error. Other tests do not have that problem,
and all of those have executable test scripts.Make the pflow from ESD test script executable. This hopefully prevents the test failing in some master builds due to a permissions error. Other tests do not have that problem,
and all of those have executable test scripts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46769adding Phase-I triggers to the tau monitoring chains2021-10-01T21:43:30+02:00Antonio De Mariaadding Phase-I triggers to the tau monitoring chainstagging @iriu, @carquin, @dzanzi and @okumuratagging @iriu, @carquin, @dzanzi and @okumurahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46835Fix nightly test failures after 468012021-10-01T21:42:44+02:00Walter LamplFix nightly test failures after 46801This is supposed to fix the fallout of !46801
- Update reference files in CaloAthenaPool
- do not schedule the alignment cond-algs if we are in AthSimulation
(I havn't yet verified if this change actually fixes the problems in AthSimula...This is supposed to fix the fallout of !46801
- Update reference files in CaloAthenaPool
- do not schedule the alignment cond-algs if we are in AthSimulation
(I havn't yet verified if this change actually fixes the problems in AthSimulation, I'll do that later)https://gitlab.cern.ch/atlas/athena/-/merge_requests/46724AthContainers: Make DataVector::m_ownPolicy transient.2022-08-15T16:20:49+02:00Scott SnyderAthContainers: Make DataVector::m_ownPolicy transient.Ownership policy should be decided by the P->T converter, so don't
save this member.
Most of the time, this doesn't matter. But past converter infrastructure
changes meant that non-xAOD DV classes that were saved directly (without
TP c...Ownership policy should be decided by the P->T converter, so don't
save this member.
Most of the time, this doesn't matter. But past converter infrastructure
changes meant that non-xAOD DV classes that were saved directly (without
TP conversion) could leak their contents on read.
See ATEAM-780.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46800TriggerMenuMT: remove usage of TriggerFlags for menu generation2021-10-04T15:30:29+02:00Frank WinklmeierTriggerMenuMT: remove usage of TriggerFlags for menu generationRemove the usage of `TriggerFlags.XYZSlice.signatures` in the menu
generation. The only hook to modify the list of signatures externally is
the `setChainFilter` method. So there is no need to even expose the list
of signatures outside th...Remove the usage of `TriggerFlags.XYZSlice.signatures` in the menu
generation. The only hook to modify the list of signatures externally is
the `setChainFilter` method. So there is no need to even expose the list
of signatures outside the `TriggerMenuMT` package via flags:
- Introduce `ChainStore` class/dict that holds the list of chains per
signature. Also takes care of only allowing a fixed set of signature
names.
- `setupMenu()` return a `ChainStore` that is used in `GenerateMenuMT`.
- Adapt `runHLT_standalone.py` to the chain filter changes.
Closes ATR-24201.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46834Update externals to version 2.0.1152021-10-01T21:43:10+02:00Johannes ElmsheuserUpdate externals to version 2.0.115Upgraded all projects to [atlasexternals-2.0.115](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.115). The updates wrt. [atlasexternals-2.0.114](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.114) are the following (https...Upgraded all projects to [atlasexternals-2.0.115](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.115). The updates wrt. [atlasexternals-2.0.114](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.114) are the following (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.114...2.0.115):
* CORAL/COOL Fixes for ARM64, master branch (2021.09.16.)
* Update Geant4 version to geant4.10.6.patch03.atlas03 (ATLASSIM-5409)
Tagging @jchapman, @emoyse, @akraszna for infohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46896Fix egamma path in the tier 0 validation test2021-10-02T23:08:21+02:00Mark SuttonFix egamma path in the tier 0 validation testThe Tier 0 histograms use Egamma as a path, rather than Electron,
so this corrects the mistaken use of Electron, such that the histograms
will be foundThe Tier 0 histograms use Egamma as a path, rather than Electron,
so this corrects the mistaken use of Electron, such that the histograms
will be foundhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46869Fix trigger filter for data overlay2021-10-02T21:42:44+02:00Frank WinklmeierFix trigger filter for data overlayRewrite the `BSFilter` algorithm to use the `TrigDecisionTool` for
trigger-based event filtering on RAW. This ensure compatibility with
past and future data. Change the `--triggerBit` transform argument from
the CTP ID (240) to the CTP i...Rewrite the `BSFilter` algorithm to use the `TrigDecisionTool` for
trigger-based event filtering on RAW. This ensure compatibility with
past and future data. Change the `--triggerBit` transform argument from
the CTP ID (240) to the CTP item name ("L1_ZB"), which is guaranteed to
work also if the item ID changes.
Also apply some general code cleanups.
Closes ATLASSIM-5419.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46845Modify the TrigInDetConfig README files2021-10-02T21:42:51+02:00Mark SuttonModify the TrigInDetConfig README filesUpdate the README files as a first step in improving the documentation as discussed in the code reviewUpdate the README files as a first step in improving the documentation as discussed in the code reviewhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46876Correct error in vertex covariance matrix2021-10-02T21:44:49+02:00Vadim KostyukhinCorrect error in vertex covariance matrixCorrect error in propagation of covariance matrix from VKalCore via VKalFitter to the created xAOD::VertexCorrect error in propagation of covariance matrix from VKalCore via VKalFitter to the created xAOD::Vertexhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46860PDM: Reduce Temporary strings2021-10-02T21:43:54+02:00Adam Edward BartonPDM: Reduce Temporary stringshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46870CaloCellList & clients: Adjust for CaloDetDescrManger moved from DetectorStor...2021-10-05T08:56:50+02:00Walter LamplCaloCellList & clients: Adjust for CaloDetDescrManger moved from DetectorStore to ConditionStoreThe `CaloCellList` object used the singleton-feature (static instance method) of `CaloDetDescrManager`. This is not compatible with the new, MT-safe approach where `CaloDetDescrManager` lives in the `ConditionStore`.
With this MR, a co...The `CaloCellList` object used the singleton-feature (static instance method) of `CaloDetDescrManager`. This is not compatible with the new, MT-safe approach where `CaloDetDescrManager` lives in the `ConditionStore`.
With this MR, a const-pointer to the `CaloDetDescrManager` is passed to the constructor of the `CaloCellList` object. This interface change requires updates for many clients, therefore this MR is quite big.
cc @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46865Add new hardware constants for Phase-1 Topo2021-10-02T21:44:11+02:00Johannes Frederic DampAdd new hardware constants for Phase-1 TopoAdd constants for the input widths of the Phase-1 L1Calo TOB inputs into Phase-1 Topo algorithms.
In addition, add constants for the OutputWidth of the sort/select algorithms.
This is required to correctly configure the firmware and simu...Add constants for the input widths of the Phase-1 L1Calo TOB inputs into Phase-1 Topo algorithms.
In addition, add constants for the OutputWidth of the sort/select algorithms.
This is required to correctly configure the firmware and simulation of the new sort/select algorithms.
See [ATR-23196](https://its.cern.ch/jira/browse/ATR-23196)https://gitlab.cern.ch/atlas/athena/-/merge_requests/46813CaloTowerGeometryCondAlg: Retrieve CaloDetDescrManager from CondStore2021-10-02T21:43:43+02:00Walter LamplCaloTowerGeometryCondAlg: Retrieve CaloDetDescrManager from CondStoreThis is part of the migration of all clients of the CaloDetDescrManager, initiated by @tsulaia.This is part of the migration of all clients of the CaloDetDescrManager, initiated by @tsulaia.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46857Formatted strings in histogram aliases2021-10-02T21:43:35+02:00Charles BurtonFormatted strings in histogram aliasesThis extends the existing functionality of the GenericMonitoringArray class to allow for string.format within histogram aliases. Tests have been updated accordingly.
Resolves ATLASDQ-885.
@ponyisi @fwinkl @tboldThis extends the existing functionality of the GenericMonitoringArray class to allow for string.format within histogram aliases. Tests have been updated accordingly.
Resolves ATLASDQ-885.
@ponyisi @fwinkl @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46843Bootstrap of refactored Run2ToRun3 conversion alg2021-10-02T21:42:32+02:00Tomasz BoldBootstrap of refactored Run2ToRun3 conversion algThis a second version of Run 2 to Run 3 navigation conversion alg.
The approach is a bit different. There are well defined steps that should make it easier to debug.
There is a build in validation infrastructure.
It is a bootstrap of ac...This a second version of Run 2 to Run 3 navigation conversion alg.
The approach is a bit different. There are well defined steps that should make it easier to debug.
There is a build in validation infrastructure.
It is a bootstrap of actually code. Most of the implementation is missing and needs to be copied over from earlier version.
Tagging @wprzygod & @tamartin