athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-17T21:44:08+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46547Fix for TRTSensitiveDetector when using the G4GammaGeneralProcess2021-09-17T21:44:08+02:00John Derek ChapmanFix for TRTSensitiveDetector when using the G4GammaGeneralProcesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46524Refactor of nav conversion for easier code analysis2021-09-17T21:44:12+02:00Tomasz BoldRefactor of nav conversion for easier code analysisThese changes are not fixing any bug.
Two things were done:
- auto-formatter was run to get consistent indenting (makes life easier with long function body)
- some variables are renamed (because we learned that one TE maps to IM and H no...These changes are not fixing any bug.
Two things were done:
- auto-formatter was run to get consistent indenting (makes life easier with long function body)
- some variables are renamed (because we learned that one TE maps to IM and H node pairs)
I was hoping that via this mechanical trick I will be able to spot the issue (i.e. bi-directional link between IM and H nodes). No luck.
Tagging @tamartin @wprzygodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46576One step of egamma reco in CA JO2021-09-17T21:44:19+02:00Tomasz BoldOne step of egamma reco in CA JOThis MR integrates one bit of egamma reco (egammaSelectedTrackCopy) and starts a bit of Brem building.
Tagging @christos @mhodgkin @goetzThis MR integrates one bit of egamma reco (egammaSelectedTrackCopy) and starts a bit of Brem building.
Tagging @christos @mhodgkin @goetzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40107Vectorized sincos calculation in LArWheelCalculator2021-09-17T21:44:21+02:00Miha Muskinjamiha.muskinja@cern.chVectorized sincos calculation in LArWheelCalculatorVectorized sincos implementation, already discussed in ATLASSIM-4753 and presented at a sim meeting: https://indico.cern.ch/event/954598/contributions/4019246/attachments/2111256/3551451/miham_2020_09_29.Sim.pdf.
Both stand-alone and At...Vectorized sincos implementation, already discussed in ATLASSIM-4753 and presented at a sim meeting: https://indico.cern.ch/event/954598/contributions/4019246/attachments/2111256/3551451/miham_2020_09_29.Sim.pdf.
Both stand-alone and Athena timing tests show a ~20% speedup of the sincos calculation in LArWheelCalculator.
There are a couple of caveats though:
- pre-vectorized parameterization needs to be saved in LArWheelCalculator.h, which does not compile with CLING --> `#if !defined(__CLING__)` lines are added because of this
- this implementation was found to perform a bit worse than the previous sincos implementation on KNL platforms, likely due to extra instructions caused by the FMV
tagging @christos @mbandier @jchapman @mduehrsshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46569TrigCost: Retrieve database details during initialisation2021-09-17T21:44:24+02:00Aleksandra PorebaTrigCost: Retrieve database details during initialisationMove retrieving smk and database alias to an earlier stage (from HLTMenu configuration), so they can be also passed (by args) to retrieving JobOptions file.
Tagging @mark @tamartinMove retrieving smk and database alias to an earlier stage (from HLTMenu configuration), so they can be also passed (by args) to retrieving JobOptions file.
Tagging @mark @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46424Add monitoring tool for Zee, Jpsiee and Heg chains2021-09-17T21:44:28+02:00Joao Victor Da Fonseca PintoAdd monitoring tool for Zee, Jpsiee and Heg chainsInclude TrigEgammaMonitorTopoAlgorithm to plot the efficiency w.r.t the mass/dphi for all topo dielectric/photon chains.
This version is more generic and accept these combinations: ee, eg, ge, gg to make the leg pairs
The efficiency wil...Include TrigEgammaMonitorTopoAlgorithm to plot the efficiency w.r.t the mass/dphi for all topo dielectric/photon chains.
This version is more generic and accept these combinations: ee, eg, ge, gg to make the leg pairs
The efficiency will be calculated as discussed in ATR-23485.
ping: @cjmeyer , @eegidiop , @dbakshig , @Fernando and @safarzadJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/4653622.0-cppcheck-final-InnerDetector2021-09-17T21:44:36+02:00Shaun Roe22.0-cppcheck-final-InnerDetectorThis MR is a mixed bag of packages, in a final push to address _all_ remaining cppcheck defects in the 'InnerDetector' path and categories of warning, portability, performance. Most are simply fixing postfix->prefix increment/decrement.This MR is a mixed bag of packages, in a final push to address _all_ remaining cppcheck defects in the 'InnerDetector' path and categories of warning, portability, performance. Most are simply fixing postfix->prefix increment/decrement.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4653922.0-TSoS_unique_ptr-AthenaPoolTest2021-09-17T21:44:44+02:00Shaun Roe22.0-TSoS_unique_ptr-AthenaPoolTestWork undertaken in context of ATLASRECTS-6384; convert to all-unique_ptr c'tor for TSoS.Work undertaken in context of ATLASRECTS-6384; convert to all-unique_ptr c'tor for TSoS.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46546MVAUtils: Drop BDT tree caches to avoid unnecessary memory allocations2021-09-17T21:44:54+02:00Alaettin Serhan MeteMVAUtils: Drop BDT tree caches to avoid unnecessary memory allocationsI don't think there is any compelling argument for caching BDT trees. This change should avoid some redundant memory allocations, such as:
![malloc](/uploads/957466462d65d9d342eac7f4910fa039/malloc.png)
which I bumped into while lookin...I don't think there is any compelling argument for caching BDT trees. This change should avoid some redundant memory allocations, such as:
![malloc](/uploads/957466462d65d9d342eac7f4910fa039/malloc.png)
which I bumped into while looking at the derivation production jobs.
cc: @gemmeren @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46550Harmonisation of usage of RecoFragmentsPool in FastPhotonMenuSequences2021-09-17T21:45:14+02:00Marco MontellaHarmonisation of usage of RecoFragmentsPool in FastPhotonMenuSequencesMinor modification of the structure of FastPhotonMenuSequences.py to retrieve the reconstruction sequence and the ViewMaker through RecoFragmentsPool, which is the standard procedure adopted throughout the Run3 HLT code.
This fix was in...Minor modification of the structure of FastPhotonMenuSequences.py to retrieve the reconstruction sequence and the ViewMaker through RecoFragmentsPool, which is the standard procedure adopted throughout the Run3 HLT code.
This fix was instigated by the following error(s) observed when testing multiple photon TLA chains simultaneously:
```
ERROR attempt to add a duplicate (photonInViewAlgs.FastPhotonViewDataVerifier) ... dupe ignored
ERROR attempt to add a duplicate (photonInViewAlgs.TrigEgammaFastPhoton_ReFastAlgo) ... dupe ignored
ERROR attempt to add a duplicate (photonAthSequence.IMl2Photon) ... dupe ignored
ERROR attempt to add a duplicate (photonAthSequence.photonInViewAlgs) ... dupe ignored
```
Tagging @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46541Sweeping !46488 from 22.0-mc20 to master.
Urgent - Master dqegamma 07092021 f...2021-09-17T21:45:30+02:00Atlas NightlybuildSweeping !46488 from 22.0-mc20 to master.
Urgent - Master dqegamma 07092021 for22.0 mc20Urgent - Master dqegamma 07092021 for22.0 mc20
See merge request atlas/athena!46488Urgent - Master dqegamma 07092021 for22.0 mc20
See merge request atlas/athena!46488https://gitlab.cern.ch/atlas/athena/-/merge_requests/46549Expanded defaults elimination in confTool diff functionality2021-09-17T21:45:49+02:00Tomasz BoldExpanded defaults elimination in confTool diff functionalityThis MR is improving the diffng in the confTool when used for old vs new configurations.
The default value of property that is a handle has form: A in the old config and Type/A in the new system.
Wiht the new option `--ignoreDefaultName...This MR is improving the diffng in the confTool when used for old vs new configurations.
The default value of property that is a handle has form: A in the old config and Type/A in the new system.
Wiht the new option `--ignoreDefaultNamedComps` the tool assumes that if the default is A and the actual value is Type/A then it is in fact the default and eliminates it.
This can be very wrong, i.e. one can imagine that another implementation Type2/A is used and thus the diff will not catch it.
Addition of a new option followed the discussion with @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46552Remove the timeJitter method in sTgcDigitMaker2021-09-17T21:45:55+02:00Chav Chhiv Chauchav.chhiv.chau@cern.chRemove the timeJitter method in sTgcDigitMakertimeJitter provides an incorrect description of the sTGC time
response. It is replaced by a more detailed model that parametrizes
the time as a function of the distance between a track and the nearest
wire, see merge request !46472. So t...timeJitter provides an incorrect description of the sTGC time
response. It is replaced by a more detailed model that parametrizes
the time as a function of the distance between a track and the nearest
wire, see merge request !46472. So timeJitter is not used anymore.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46568restoring gfex bitwise simulation in trigger tests since blocker FPE error is...2021-09-17T21:46:00+02:00Alison Elliotrestoring gfex bitwise simulation in trigger tests since blocker FPE error is solvedThe error from ATR-24142 has been solved for gFEX (which was a blocker on the CI). The solution has been merged (see !46491). Therefore, the gFEX bitwise simulation for L1Calo can be turned back on in the trigger tests.
tagging @ctosci...The error from ATR-24142 has been solved for gFEX (which was a blocker on the CI). The solution has been merged (see !46491). Therefore, the gFEX bitwise simulation for L1Calo can be turned back on in the trigger tests.
tagging @ctosciri @smh @dzanzihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46572Add a helper postInclude to disable file size limit (MC16d)2021-09-17T21:46:38+02:00Tadej Novaktadej.novak@cern.chAdd a helper postInclude to disable file size limit (MC16d)Add a helper `postInclude` to disable file size limit in production. The motivation are overlay+trigger+reco jobs which can run just fine with 10k events/job but hit the file size limit for the temporary files. As it seems to be impossib...Add a helper `postInclude` to disable file size limit in production. The motivation are overlay+trigger+reco jobs which can run just fine with 10k events/job but hit the file size limit for the temporary files. As it seems to be impossible to just disable the limit, this file sets it to 150 GB.
Not urgent for reprocessing, but nice to have if we build another release.
/cc @pberta @rmazinihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46460Fixing supercell emulation to use data2021-09-17T21:47:43+02:00Lisa Marie BaltesFixing supercell emulation to use dataChanging the supercell emulation code such that the right version of the algorithm runs automatically depending whether the input file is MC or data. The sampling histograms are recreated and the cell timings are now sampled in slices of...Changing the supercell emulation code such that the right version of the algorithm runs automatically depending whether the input file is MC or data. The sampling histograms are recreated and the cell timings are now sampled in slices of energy instead of ET and based on the cellnoise rather than the fixed 256 MeV cut.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46553Sweeping !46528 from master to 22.0-mc20.
GeneratorObjects: Fix potential race.2021-09-17T21:49:08+02:00Atlas NightlybuildSweeping !46528 from master to 22.0-mc20.
GeneratorObjects: Fix potential race.GeneratorObjects: Fix potential race.
See merge request atlas/athena!46528GeneratorObjects: Fix potential race.
See merge request atlas/athena!46528https://gitlab.cern.ch/atlas/athena/-/merge_requests/46573Add a helper postInclude to disable file size limit (MC16e)2021-09-17T22:05:10+02:00Tadej Novaktadej.novak@cern.chAdd a helper postInclude to disable file size limit (MC16e)Add a helper `postInclude` to disable file size limit in production. The motivation are overlay+trigger+reco jobs which can run just fine with 10k events/job but hit the file size limit for the temporary files. As it seems to be impossib...Add a helper `postInclude` to disable file size limit in production. The motivation are overlay+trigger+reco jobs which can run just fine with 10k events/job but hit the file size limit for the temporary files. As it seems to be impossible to just disable the limit, this file sets it to 150 GB.
Not urgent for reprocessing, but nice to have if we build another release.
/cc @pberta @rmazinihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40442Minor tidying of SimEventFilter2021-09-17T23:51:59+02:00John Derek ChapmanMinor tidying of SimEventFilterMove setting updating of `m_pass` after possible inversion of `pass` variable,
so that the final total of passing events is consistent.
Also some minor style/whitespace updates.
FYI @mduehrss.Move setting updating of `m_pass` after possible inversion of `pass` variable,
so that the final total of passing events is consistent.
Also some minor style/whitespace updates.
FYI @mduehrss.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39019Quasi stable particle sim on the fly2021-09-17T23:55:26+02:00Michael Duehrssen-DeblingQuasi stable particle sim on the flyMR to enable a new workflow: existing simulation HIT files are read in, only events that match certain conditions are re-simulated, while all other events are just copied into the output. The initial filter will look for events that woul...MR to enable a new workflow: existing simulation HIT files are read in, only events that match certain conditions are re-simulated, while all other events are just copied into the output. The initial filter will look for events that would pass the selection conditions for quasi-stable particles to enable a re-simulation of only those events as part of the MC16 re-processing
Test with ART test test_ReSimulation.sh