athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-06T15:44:24+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46926RDOAnalysis: cmake fix2021-10-06T15:44:24+02:00Scott SnyderRDOAnalysis: cmake fixRemove reference to nonexistent root library Table.Remove reference to nonexistent root library Table.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46920AGDDModel: Fix cppcheck warnings.2021-10-06T15:43:20+02:00Scott SnyderAGDDModel: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46934Add egammaMon job GRID2021-10-06T15:43:36+02:00Joao Victor Da Fonseca PintoAdd egammaMon job GRIDThis MR is responsible to include a python job helper to launch the egamma offline monitoring on GRID (AODtoHIST).
something like:
`RunTrigEgammaMonitoringOnGrid.py --inDS valid1.361106.PowhegPythia8EvtGen_AZNLOCTEQ6L1_Zee.recon.AOD.e51...This MR is responsible to include a python job helper to launch the egamma offline monitoring on GRID (AODtoHIST).
something like:
`RunTrigEgammaMonitoringOnGrid.py --inDS valid1.361106.PowhegPythia8EvtGen_AZNLOCTEQ6L1_Zee.recon.AOD.e5112_s3214_d1709_r13044_tid26720967_00 --outDS user.jodafons.test11`
See README for more instructions.
Ping: @safarzad , @cjmeyer , @dbakshig , @Fernando , @eegidiop and @jliebermJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46942[ByteStreamEmonSvc] New config for ByteStream reading from EMon2021-10-06T15:43:40+02:00Rafal Bielskirafal.bielski@cern.ch[ByteStreamEmonSvc] New config for ByteStream reading from EMonTwo changes:
1. Implement new (ComponentAccumulator) configuration for EMon ByteStream reading. Make the old JO a trivial wrapper around the new JO for now, until the clients are migrated to new JO.
2. Integrate the EMon BS case as the...Two changes:
1. Implement new (ComponentAccumulator) configuration for EMon ByteStream reading. Make the old JO a trivial wrapper around the new JO for now, until the clients are migrated to new JO.
2. Integrate the EMon BS case as the third possibility of BS configuration in `TriggerByteStreamConfig.py`. We don't have a specific config flag identifying this case so I went with "isOnline && no input file && not running HLT or L1Sim" which should be robust enough.
This fixes ATR-24092
cc @lshi, @kwhalenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46662Allowing jet trigger preselection for large-R jets2021-10-06T15:45:59+02:00Marco ValenteAllowing jet trigger preselection for large-R jetsThis MR enables emtopo preselections to be applied on large-R pflow jet chains. Right now, the code is structured in a way that uncalibrated R=1.0 antikt jets are used the the calo-only preselection. Numberous test chains are added to th...This MR enables emtopo preselections to be applied on large-R pflow jet chains. Right now, the code is structured in a way that uncalibrated R=1.0 antikt jets are used the the calo-only preselection. Numberous test chains are added to the LS2_v1 menu.
Tagging @ayana, @khoo @cantelMarco ValenteMarco Valentehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46965TriggerJobOpts: only print full menu in DEBUG2021-10-06T15:44:59+02:00Frank WinklmeierTriggerJobOpts: only print full menu in DEBUGFull menu printout was accidentally left enabled for all log levels.Full menu printout was accidentally left enabled for all log levels.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46948bug fix IsMoreCand bit2021-10-06T15:44:36+02:00Masato Aokibug fix IsMoreCand bitThis is to fix a bug with the bit assignment for IsMoreCandRoi.
ATR-24127This is to fix a bug with the bit assignment for IsMoreCandRoi.
ATR-24127https://gitlab.cern.ch/atlas/athena/-/merge_requests/46954MagFieldElements+MagFieldServices: Fix cppcheck warnings.2021-10-06T15:42:39+02:00Scott SnyderMagFieldElements+MagFieldServices: Fix cppcheck warnings.Prefer to initialize members in an initializer list rather than in a ctor
body.
Remove unneeded c_str() calls.
Protect against potential null pointer dereference.Prefer to initialize members in an initializer list rather than in a ctor
body.
Remove unneeded c_str() calls.
Protect against potential null pointer dereference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46957Sweeping !46909 from 21.2 to master.
AnalysisTop: Add radiationhigh/low weigh...2021-10-06T15:43:57+02:00Atlas NightlybuildSweeping !46909 from 21.2 to master.
AnalysisTop: Add radiationhigh/low weights for new ttZ samples to jet flavor plots codeAnalysisTop: Add radiationhigh/low weights for new ttZ samples to jet flavor plots code
See merge request atlas/athena!46909AnalysisTop: Add radiationhigh/low weights for new ttZ samples to jet flavor plots code
See merge request atlas/athena!46909https://gitlab.cern.ch/atlas/athena/-/merge_requests/46953TRT_ConditionsData: Fix cppcheck warning.2021-10-06T15:42:55+02:00Scott SnyderTRT_ConditionsData: Fix cppcheck warning.Pass std::string by const reference, not by value.Pass std::string by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46950OverlayByteStreamUtils: Fix clang warning.2021-10-06T15:44:33+02:00Scott SnyderOverlayByteStreamUtils: Fix clang warning.Unused private data member.Unused private data member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46949AGDDKernel: Enable thread-safety checking.2021-10-06T15:44:58+02:00Scott SnyderAGDDKernel: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46923AthContainers: Thread-safety check fix for rule5_test.2021-10-06T15:44:31+02:00Scott SnyderAthContainers: Thread-safety check fix for rule5_test.Leakcheck is not thread-safe, so disable checking where it's used
in rule5_test.Leakcheck is not thread-safe, so disable checking where it's used
in rule5_test.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46967ATR-24237: Include bs-streamerinfos from 21.1.56 and master2022-08-15T16:21:01+02:00Oleg KuprashATR-24237: Include bs-streamerinfos from 21.1.56 and masterUpdating bs-streamerinfos.root with the following classes/checksums:
- from 21.1.56,AthenaP1 - needed to fix ATR-24237:
```
< DataVector<xAOD::TrigTrackCounts_v1> 1ae4719c
```
- from master,Athena,2021-10-01T2101 - to be able to read the...Updating bs-streamerinfos.root with the following classes/checksums:
- from 21.1.56,AthenaP1 - needed to fix ATR-24237:
```
< DataVector<xAOD::TrigTrackCounts_v1> 1ae4719c
```
- from master,Athena,2021-10-01T2101 - to be able to read the BS HLT data stored with these class versions, if they evolve in the future:
```
< DataVector<xAOD::TrigTrackCounts_v1> 5eefc10c
< DataLink<SG::IConstAuxStore> 3ad5a692
< DataLinkBase 815f02e
< DataVector<TrigRoiDescriptor> a111c600
< DataVector<xAOD::AFPSiHitsCluster_v1> 2e79bbf4
< DataVector<xAOD::AFPTrack_v2> c9288200
< DataVector<xAOD::BTagVertex_v1> 18c49d9e
< DataVector<xAOD::BTagging_v1> bbe78550
< DataVector<xAOD::EmTauRoI_v2> fddd21a0
< DataVector<xAOD::HIEventShape_v2> 26d96ee0
< DataVector<xAOD::IParticle> 84326f44
< DataVector<xAOD::JetRoI_v2> 43ea9f2
< DataVector<xAOD::MuonRoI_v1> b2379834
< DataVector<xAOD::MuonSegment_v1> bed7cb10
< DataVector<xAOD::TrigBphys_v1> ca22a8c8
< DataVector<xAOD::TrigComposite_v1> c3965b9c
< DataVector<xAOD::TrigEMCluster_v1> 909d6540
< DataVector<xAOD::TrigMissingET_v1> d97a6374
< DataVector<xAOD::TrigPassBits_v1> c96f120
< DataVector<xAOD::TrigRNNOutput_v1> af6c962c
< DataVector<xAOD::TrigRNNOutput_v2> 67cc8e40
< DataVector<xAOD::TrigRingerRings_v1> dcd61c18
< DataVector<xAOD::TrigRingerRings_v2> 5835d484
< DataVector<xAOD::TrigSpacePointCounts_v1> be6d56e2
< DataVector<xAOD::TrigT2MbtsBits_v1> e8095cde
< DataVector<xAOD::TrigT2ZdcSignals_v1> 1a6ff0ce
< DataVector<xAOD::TrigVertexCounts_v1> 7e4f7ad6
< DataVector<xAOD::Vertex_v1> 47ba6a16
< DataVector<xAOD::eFexEMRoI_v1> 61bb31c8
< DataVector<xAOD::eFexTauRoI_v1> 3a46dc36
< DataVector<xAOD::jFexTauRoI_v1> 2160d258
< ILockable ba36e
< SG::AuxElement c350b3ac
< SG::AuxVectorBase 426ccfcc
< SG::AuxVectorData 9518fb35
< SG::IAuxElement 21424289
< SG::IAuxStore 20255372
< SG::IAuxStoreHolder 86072792
< SG::IAuxStoreIO 2142751c
< SG::IConstAuxStore 82019207
< TrigRoiDescriptorCollection 63c05f33
< xAOD::AuxContainerBase efb26e74
< xAOD::ShallowAuxContainer 53878368
< xAOD::eFexEMRoIAuxContainer_v1 6af6230b
< xAOD::eFexEMRoI_v1 eebc3348
< xAOD::eFexTauRoIAuxContainer_v1 456d3f89
< xAOD::eFexTauRoI_v1 180b9f6c
< xAOD::jFexTauRoIAuxContainer_v1 f33a891a
< xAOD::jFexTauRoI_v1 75311e13
```
Tagging @ssnyder, @fwinkl.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46958TileMonitoring: Add post-processing for Tile digits monitoring in calibration...2021-10-06T15:44:39+02:00Siarhei HarkushaTileMonitoring: Add post-processing for Tile digits monitoring in calibration runsNew functions have been added to produce summary monitoring plots per Tile module
with Pedestal, LFN, HFN, Correlation, Covariance, CRC and BCID errors, stuck bits, and etc.
from the corresponding monitoring histograms per channel/gain p...New functions have been added to produce summary monitoring plots per Tile module
with Pedestal, LFN, HFN, Correlation, Covariance, CRC and BCID errors, stuck bits, and etc.
from the corresponding monitoring histograms per channel/gain produced from calibration runs.
Configuration has been added also to run post-processing
for Tile digits monitoring plots produced from calibration runs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46960Simplify muon trigger step dictionary2021-10-06T15:44:28+02:00Savanna ShawSimplify muon trigger step dictionaryCleanup of the muon trigger chain step dictionary (ATR-24222):
- Flatten the structure of the steps, since the [[L2 steps],[EF steps]] structure isn't actually needed
- Remove unused chain step definitions
- Consolidate the definitions w...Cleanup of the muon trigger chain step dictionary (ATR-24222):
- Flatten the structure of the steps, since the [[L2 steps],[EF steps]] structure isn't actually needed
- Remove unused chain step definitions
- Consolidate the definitions with similar steps (mostly by moving the setup of the muFast/muComb steps to the getmuFast/getmuComb functions)https://gitlab.cern.ch/atlas/athena/-/merge_requests/46914Fixes for legacy trigger DQ monitoring (disable L1Calo/CTP)2021-10-06T15:45:49+02:00Frank WinklmeierFixes for legacy trigger DQ monitoring (disable L1Calo/CTP)CTP/L1Calo monitoring is currently not supported when running on old data. Disable them both for DQ.
Also use the `xAODConfigSvc` by default in `TrigBunchCrossingTool`. This should allow legacy use-cases to still function. All new code ...CTP/L1Calo monitoring is currently not supported when running on old data. Disable them both for DQ.
Also use the `xAODConfigSvc` by default in `TrigBunchCrossingTool`. This should allow legacy use-cases to still function. All new code is supposed to use `BunchCrossingCondData` anyway.
Closes ATR-24181, ATR-24262.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46903Update the timing of sTGC strip channel2021-10-06T15:43:34+02:00Chav Chhiv Chauchav.chhiv.chau@cern.chUpdate the timing of sTGC strip channelThis commit replaces the constant 25-ns time offset of sTGC strips
by a look-up table. In a strip cluster, the middle strip has the same
timing as the wire channel, and the adjacent strips has a time offset
ranging from 10ns to 45ns de...This commit replaces the constant 25-ns time offset of sTGC strips
by a look-up table. In a strip cluster, the middle strip has the same
timing as the wire channel, and the adjacent strips has a time offset
ranging from 10ns to 45ns depending on its position (in units of strip)
relative to the middle strip.
Also many strip digits are created per energy deposited. This commit also
creates strip digits without assuming a fixed number of strips per energy
deposited as it is done previously. So the commit starts creating digit
for the strip nearest the energy deposited and, then, loops over the
neighbour strips until the charge integrated over the strip width is zero.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4694122.0-TSoS_unique_ptr-SeedToTrackConversion2021-10-06T15:44:02+02:00Shaun Roe22.0-TSoS_unique_ptr-SeedToTrackConversionWork undertaken in context of ATLASRECTS-6384. Convert to using all unique_ptr constructor for the TrackStateOnSurface.Work undertaken in context of ATLASRECTS-6384. Convert to using all unique_ptr constructor for the TrackStateOnSurface.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4696422.0-TSoS_unique_ptr-TRT_SegmentToTrackTool2021-10-06T15:44:16+02:00Shaun Roe22.0-TSoS_unique_ptr-TRT_SegmentToTrackToolconvert to all-unique_ptr constructor for TSoS. Work undertaken in context of ATLASRECTS-6384.convert to all-unique_ptr constructor for TSoS. Work undertaken in context of ATLASRECTS-6384.