athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-01-04T15:42:27+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/49406MuonCombinedBaseTools: Reproducibility fix.2022-01-04T15:42:27+01:00Scott SnyderMuonCombinedBaseTools: Reproducibility fix.The resolvedInDetCandidates vector is filled in part by iterating over a map
with pointer keys. This means that the order of entries in this vector
can vary from run to run. This was observed to lead to ordering differences
in the reco...The resolvedInDetCandidates vector is filled in part by iterating over a map
with pointer keys. This means that the order of entries in this vector
can vary from run to run. This was observed to lead to ordering differences
in the reconstruction output. Add an additional sorting step to ensure
that results are identical from run to run.
The additional sort is keyed on track pt. The ordering provided
by the existing SortInDetCandidates is too weak to help here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49405TrkiPatFitterUtils: Update for thread-safety checker const changes.2022-01-04T15:41:59+01:00Scott SnyderTrkiPatFitterUtils: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49404MuonTGC_Cabling: Update for thread-safety checker const changes.2022-01-04T15:41:55+01:00Scott SnyderMuonTGC_Cabling: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49403MuonSelectorTools+egammaLayerRecalibTool: Update for thread-safety checker co...2022-01-04T15:42:28+01:00Scott SnyderMuonSelectorTools+egammaLayerRecalibTool: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49402egammaMVACalib: Update for thread-safety checker const changes.2022-01-04T15:42:33+01:00Scott SnyderegammaMVACalib: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.
Normally, we'd just use FindFixBin here. But TH2Poly overrides FindBin
to handle its special bin defintions, but it doesn't also override
FindFix...The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.
Normally, we'd just use FindFixBin here. But TH2Poly overrides FindBin
to handle its special bin defintions, but it doesn't also override
FindFixBin. But TH2Poly::FindBin (unlike TH1::FindBin) doesn't actually
do anything non-const, so just suppress the warning here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49401PyDumper: Fix dumping of Layer.2022-01-05T09:42:18+01:00Scott SnyderPyDumper: Fix dumping of Layer.Don't dump a pointer value.Don't dump a pointer value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49400TrigHLTMonitoring, MuonHoughPatternEvent, TrkG4UserActions: Fix clang13 warni...2022-01-04T15:42:18+01:00Scott SnyderTrigHLTMonitoring, MuonHoughPatternEvent, TrkG4UserActions: Fix clang13 warnings.Unused variables.Unused variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49399TrigT1NSWSimTools: Fix clang13 warnings.2022-01-04T15:42:16+01:00Scott SnyderTrigT1NSWSimTools: Fix clang13 warnings.Unused variables.
(One instance which was referenced from commented-out code left commented-out.)Unused variables.
(One instance which was referenced from commented-out code left commented-out.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/49398TrigFastTrackFinder: Fix clang13 warnings.2022-01-04T15:42:19+01:00Scott SnyderTrigFastTrackFinder: Fix clang13 warnings.Erroneously shadowed variable.Erroneously shadowed variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49397Run3AFPMonitoring: Fix use of static data.2022-01-04T15:42:37+01:00Scott SnyderRun3AFPMonitoring: Fix use of static data.Remove use of static data.
Some general cleanup.
See ATLASRECTS-6586.Remove use of static data.
Some general cleanup.
See ATLASRECTS-6586.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49396Sweeping !49387 from master to 22.0-mc20.
TrfTestsART: Change FPE parsing and...2022-01-05T15:43:18+01:00Atlas NightlybuildSweeping !49387 from master to 22.0-mc20.
TrfTestsART: Change FPE parsing and add FPE stack trace option to more testsTrfTestsART: Change FPE parsing and add FPE stack trace option to more tests
See merge request atlas/athena!49387TrfTestsART: Change FPE parsing and add FPE stack trace option to more tests
See merge request atlas/athena!49387https://gitlab.cern.ch/atlas/athena/-/merge_requests/49395AthenaMonitoringKernel, IOVDbSvc: Fix compilation with gcc12 / c++23.2022-01-04T15:42:14+01:00Scott SnyderAthenaMonitoringKernel, IOVDbSvc: Fix compilation with gcc12 / c++23.Need explicit conversion from json strings.Need explicit conversion from json strings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49394TrigCaloEvent, TrigMuonEvent: Fix gcc12 warnings.2022-01-04T15:42:34+01:00Scott SnyderTrigCaloEvent, TrigMuonEvent: Fix gcc12 warnings.Make sprintf buffer larger.
vector::size() is now [[nodiscard]]. Don't use it to force instantiation;
use explicit instantiation syntax instead.Make sprintf buffer larger.
vector::size() is now [[nodiscard]]. Don't use it to force instantiation;
use explicit instantiation syntax instead.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49393Set gTower energy from SuperCells and Tile towers and convert it to digit scale2022-01-04T15:41:58+01:00Cecilia TosciriSet gTower energy from SuperCells and Tile towers and convert it to digit scaleWith this MR, the procedure to set the energy of the gTowers from SC and Tile towers is changed as follows:
- The Tile energy retrieved from the TriggerTowerContainer is added up in the corresponding gTower
- The SC energy is added up in...With this MR, the procedure to set the energy of the gTowers from SC and Tile towers is changed as follows:
- The Tile energy retrieved from the TriggerTowerContainer is added up in the corresponding gTower
- The SC energy is added up in the corresponding gTower (separately from Tile energy)
- The total EM energy (from SuperCells) of each gTower is encoded+decoded according to the LATOME encoding scheme for gFEX
- The Tile energy is summed up to the decoded EM energy for each gTower
- The total energy of each gTower is converted to the gFEX digit scale (200 MeV resolution)
Additionally, the underflow and overflow for the jets built in the JetFinder algorithm are handled according to the firmware behavior.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49391small cosmetic corrections to AtlasFieldCache2022-01-04T15:42:23+01:00R D Schaffersmall cosmetic corrections to AtlasFieldCacheSmall cosmetic improvements to the changes in the previous MR: [!49357 ](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49357). Shouldn't change any results...Small cosmetic improvements to the changes in the previous MR: [!49357 ](https://gitlab.cern.ch/atlas/athena/-/merge_requests/49357). Shouldn't change any results...R D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49390ITk material rejection for SV1 + JetFitter2022-01-05T15:42:19+01:00Thomas StreblerITk material rejection for SV1 + JetFitterThis merge request ports some 21.9 developments related to the implementation of a material veto for secondary-vertex based FTAG algorithms, optimised for the ITk geometry, without impact for the Run 1-3 configurations. The requirement o...This merge request ports some 21.9 developments related to the implementation of a material veto for secondary-vertex based FTAG algorithms, optimised for the ITk geometry, without impact for the Run 1-3 configurations. The requirement on the number of SCT/Strip hits is also relaxed for JetFitter to allow for the reconstruction of vertices for forward jets out of the ITk Strip acceptance.
FYI @duperrin @thuffmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49387TrfTestsART: Change FPE parsing and add FPE stack trace option to more tests2022-01-05T14:54:41+01:00Johannes ElmsheuserTrfTestsART: Change FPE parsing and add FPE stack trace option to more testsUpdates to TrfTestsART:
* Change FPE parsing command to correctly catch FPEs also in non-execute phase
* Add FPE stack trace jobOption to all non-data reprocessing testsUpdates to TrfTestsART:
* Change FPE parsing command to correctly catch FPEs also in non-execute phase
* Add FPE stack trace jobOption to all non-data reprocessing testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49386TauTrig : update in the list of monitored triggers2022-01-04T09:42:13+01:00Antonio De MariaTauTrig : update in the list of monitored triggersPinging @iriu and @gipezzulPinging @iriu and @gipezzulhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49384KL Gaussian Mixture Reduction : Reduce by around half the loop iterations fo...2022-01-04T15:42:11+01:00Christos Anastopouloschristos.anastopoulos@cern.chKL Gaussian Mixture Reduction : Reduce by around half the loop iterations for finding the minimum index distanceKLGaussianMitrureReductions : Reduce by around half the loop iterations for finding the minimum index distance
- What we have typically is a ``2556 (71*70/2)`` pairwise distance array (details on "triangular arrays"
representation exis...KLGaussianMitrureReductions : Reduce by around half the loop iterations for finding the minimum index distance
- What we have typically is a ``2556 (71*70/2)`` pairwise distance array (details on "triangular arrays"
representation exist in the header file) since we start with 72 components.
- We find the pair with the minimum distance. We merge the 2 components we recalculate distances
with the new component
- and then we loop over the 2556 distance array (we set the merged to a large number)
With this MR what we try to do is bookeep the fact that a component got merged so we have one less component.
So the iterations will be over
```
0. 2556
1. 2556 -71 (71 distances to the other elements)
2. 2556 - (71+70)
3. 2556 - (71+70+69)
//until we reach the the components we want typically 12
```
i.e the elements we need to loop over get reduced each time a component is merged.
We need to add some bookeeping code in reset distances so to "swap" elements to the end,
but seems that we still can gain quite a bit of time.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49383TauAnalysisTools: update EfficiencyCorrectionTool/TauSelectionTool and move t...2022-01-04T21:14:58+01:00Antonio De MariaTauAnalysisTools: update EfficiencyCorrectionTool/TauSelectionTool and move to RNN eVetoThis MR will :
* move to RNN eVeto in instead of BDT eVeto
* clean TauSelectionTool and TauEfficiencyCorrectionTool from old eBDT WPs and change to new eRNN wPS
* update TauSelectionTool and TauEfficiencyCorrectionTool documentation
No...This MR will :
* move to RNN eVeto in instead of BDT eVeto
* clean TauSelectionTool and TauEfficiencyCorrectionTool from old eBDT WPs and change to new eRNN wPS
* update TauSelectionTool and TauEfficiencyCorrectionTool documentation
Note: since RNN eVeto SFs are not available, TauEfficiencyCorrectionTool has been instructed to skip them and output a WARNING message
Note: first tests passed using new TauAnalysisTools version in xTauFW and R22 validation samples
pinging @qbuat, @dta, @martindl and @ghamity