athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-07-02T03:06:03+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/44843Python xAOD Robustness Update, master branch (2021.06.30.)2021-07-02T03:06:03+02:00Attila KrasznahorkayPython xAOD Robustness Update, master branch (2021.06.30.)Similar to what `xAOD::Init()` does, I now updated `xAODRootAccess.GenerateDVIterators` to access the xAOD types in a specific order explicitly. This is meant to work around the issue described in ATLASG-1602, but not strictly speaking f...Similar to what `xAOD::Init()` does, I now updated `xAODRootAccess.GenerateDVIterators` to access the xAOD types in a specific order explicitly. This is meant to work around the issue described in ATLASG-1602, but not strictly speaking fix it unfortunately. :frowning:
Still, a workaround should be better than nothing for now...https://gitlab.cern.ch/atlas/athena/-/merge_requests/44842Save the number of unfiltered trigger tracks per Roi2021-07-02T03:05:27+02:00Mark SuttonSave the number of unfiltered trigger tracks per RoiTo see whether changes to the trigger affect the tigger track counts before any filtering, or matching tp the offline tracksTo see whether changes to the trigger affect the tigger track counts before any filtering, or matching tp the offline trackshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44841Simplify frames used for ITkStrips2021-09-29T15:58:37+02:00Nicholas StylesSimplify frames used for ITkStripsRemove an extra coordinate transformation that was previously required to give expected positions for the ```ITkStrip```. This is replaced by defining the mapping of ```x/y/z``` to ```eta/phi/depth``` in the necessary way in dedicated IT...Remove an extra coordinate transformation that was previously required to give expected positions for the ```ITkStrip```. This is replaced by defining the mapping of ```x/y/z``` to ```eta/phi/depth``` in the necessary way in dedicated ITkStrip Digitization.
This also moves to using a hit coordinate definition consistent with the ```SCT``` for the ```ITkStrip``` G4 sensitive detector classes.
The removed transformation was the Identity for all cases aside from ```ITkStrip``` so should not have any impact beyond that.
FYI @hhaywardhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44839fix typos in LArCalib_Delay_OFC_Cali_jobOptions.py and LArCalib_Ramp_jobOptio...2021-07-02T03:03:53+02:00Walter Lamplfix typos in LArCalib_Delay_OFC_Cali_jobOptions.py and LArCalib_Ramp_jobOptions.pyThe title says it all. More work needed to fix the failing test_larcalib_ramp.shThe title says it all. More work needed to fix the failing test_larcalib_ramp.shhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44838CA-based campaign config should have separate functions for pile-up and non-p...2021-07-02T03:03:45+02:00Tadej Novaktadej.novak@cern.chCA-based campaign config should have separate functions for pile-up and non-pile-up casesCA-based campaign config should have separate functions for pile-up and non-pile-up cases. In this case we do not need to depend on the digi pile-up flag, which is not set downstream.
/cc @jchapman @pavolCA-based campaign config should have separate functions for pile-up and non-pile-up cases. In this case we do not need to depend on the digi pile-up flag, which is not set downstream.
/cc @jchapman @pavolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44837TriggerD3PDMaker: delete package2021-07-02T12:39:16+02:00Frank WinklmeierTriggerD3PDMaker: delete packageDelete obsolete TriggerD3PDMaker and references to it. If those who
still use D3PDs really need trigger information we could bring back some
limited information. But for the moment we delete it all to avoid having
to migrate the code for...Delete obsolete TriggerD3PDMaker and references to it. If those who
still use D3PDs really need trigger information we could bring back some
limited information. But for the moment we delete it all to avoid having
to migrate the code for Run-3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44836Reduce HepMcParticleLink verbosity in production jobs2021-07-02T03:02:59+02:00Tadej Novaktadej.novak@cern.chReduce HepMcParticleLink verbosity in production jobsReduce `HepMcParticleLink` verbosity in production jobs. Integrate with campaign configuration to reduce the amount of `postExec`s.
Related to ATLPHYSVAL-715.
/cc @jchapman @jferrandReduce `HepMcParticleLink` verbosity in production jobs. Integrate with campaign configuration to reduce the amount of `postExec`s.
Related to ATLPHYSVAL-715.
/cc @jchapman @jferrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44835TrigCostMonitorMT: drop "MT" from package name2021-07-02T03:05:02+02:00Frank WinklmeierTrigCostMonitorMT: drop "MT" from package nameRename package from TrigCostMonitorMT to TrigCostMonitor.
Relates to ATR-22795.
cc @tamartin @aporebaRename package from TrigCostMonitorMT to TrigCostMonitor.
Relates to ATR-22795.
cc @tamartin @aporebahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/4483422.0-TSoS-unique_ptr-MuidTrackBuilder2021-07-03T03:03:53+02:00Shaun Roe22.0-TSoS-unique_ptr-MuidTrackBuilderContinuing the ATLASRECTS-6384 work, converting clients to the new TSoS unique_ptr constructors.Continuing the ATLASRECTS-6384 work, converting clients to the new TSoS unique_ptr constructors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44833Rename electronLRT TrackCollections ElecLRT2021-07-01T03:02:47+02:00Benjamin Philip KerridgeRename electronLRT TrackCollections ElecLRTDue to a hash collision (detailed in )see ATR-23729 for details) the collection needs to be renamed. This MR changes the name of the track collections from `ElectronLRT` to `ElecLRT` Monitoring is also changed so no external impact shoul...Due to a hash collision (detailed in )see ATR-23729 for details) the collection needs to be renamed. This MR changes the name of the track collections from `ElectronLRT` to `ElecLRT` Monitoring is also changed so no external impact should be noticed.
Should have no impact on counts
JIRA: ATR-23729https://gitlab.cern.ch/atlas/athena/-/merge_requests/44832TrigT1Result: remove cout from CTP_RDO2021-07-01T03:03:00+02:00Frank WinklmeierTrigT1Result: remove cout from CTP_RDOReplace `std::cout` with `MsgStream` in `CTP_RDO` and apply some general
code cleanups.
Fixes ATR-14655.Replace `std::cout` with `MsgStream` in `CTP_RDO` and apply some general
code cleanups.
Fixes ATR-14655.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44831Fix Muon validation TTVA decoration behaviour with derivation input, and avoi...2021-07-17T03:03:20+02:00James FerrandoFix Muon validation TTVA decoration behaviour with derivation input, and avoid crashes due to missing containers in latest AODsUse file metadata to check whether Phys validation running on DAOD_PHYSVAL, if so then do not add TTVA decorations. Also adding fixes to avoid crashes on latest AODs reported in ATR-23806Use file metadata to check whether Phys validation running on DAOD_PHYSVAL, if so then do not add TTVA decorations. Also adding fixes to avoid crashes on latest AODs reported in ATR-23806https://gitlab.cern.ch/atlas/athena/-/merge_requests/44829Numerous trigger menu changes for July 15 signoff and menu cleanup2021-07-01T03:03:28+02:00Teng Jian KhooNumerous trigger menu changes for July 15 signoff and menu cleanupVarious changes towards July 15 menu signoff and menu cleanup
* Removed/corrected several testing variations of HH4b asymmetric triggers
* Relabeled B-physics triggers for `BphysDelayed` stream and fixed some EOF/Primary mislabelling
* C...Various changes towards July 15 menu signoff and menu cleanup
* Removed/corrected several testing variations of HH4b asymmetric triggers
* Relabeled B-physics triggers for `BphysDelayed` stream and fixed some EOF/Primary mislabelling
* Corrected low-pt diphoton chains to use `dphi25` rather than `dphi15` and removed unwanted low-pt diphoton with jet seed
* Added photon, muon, jet+MET triggers for late stream LLP background estimates
* Promoted primary single-threshold jet chains with loose (but non-trivial) preselection
* Added MVABDT versions of lep+tau+XE, ditau+XE combined chains as primary, MVA as backup
* Alias DIJET -> DJMASS for primary photon VBF chains
* Relabel CEP triggers to PrimaryPhI
* Other Primary/Support label and ChainGroup corrections
* Added calo-only MET primary trigger as backup for tracking chains c.f. ATR-23740https://gitlab.cern.ch/atlas/athena/-/merge_requests/44828AthenaMonitoring: Fix clang warnings.2021-07-02T03:06:11+02:00Scott SnyderAthenaMonitoring: Fix clang warnings.Unused StatusCode variables.Unused StatusCode variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44827JetSelectorTools+PrimaryDPDMaker+MuonSTGC_CnvTools: Fix clang warnings.2021-07-02T03:04:46+02:00Scott SnyderJetSelectorTools+PrimaryDPDMaker+MuonSTGC_CnvTools: Fix clang warnings.Unchecked / unused StatusCodes.Unchecked / unused StatusCodes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44826McParticleEventTPCnv+SiClusterizationTool: Fix clang warnings.2021-07-02T03:03:10+02:00Scott SnyderMcParticleEventTPCnv+SiClusterizationTool: Fix clang warnings.Missing override keywords.Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44825DetDescrCondTPCnv: Add TPCNV declarations.2021-07-02T03:06:19+02:00Scott SnyderDetDescrCondTPCnv: Add TPCNV declarations.Add TPCNV declaration for DetCondCFloat.
See ATEAM-495.Add TPCNV declaration for DetCondCFloat.
See ATEAM-495.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44824removed the part of the code that was renaming the l1item + clean up in the M...2021-07-02T03:02:52+02:00Gianantonio Pezzullog.pezzullo@yale.eduremoved the part of the code that was renaming the l1item + clean up in the Menu files ATR-23479https://gitlab.cern.ch/atlas/athena/-/merge_requests/44823another fix for FPE in ATR-234562021-07-02T03:04:58+02:00Dmitry Emeliyanovanother fix for FPE in ATR-23456provides fixes for two more DIVBYZERO FPEs reported in ATR-23456provides fixes for two more DIVBYZERO FPEs reported in ATR-23456https://gitlab.cern.ch/atlas/athena/-/merge_requests/44822Fix multiplicity words computed in L1Topo simulation2021-07-02T03:05:20+02:00Paula Martinez SuarezFix multiplicity words computed in L1Topo simulationFix the 128-bit word containing the output from the eEm multiplicity algorithms.
ATR-22314
@orlando @iriu @asonay @cmorenom
Also tagging @czodrows in relation to ATR-23671Fix the 128-bit word containing the output from the eEm multiplicity algorithms.
ATR-22314
@orlando @iriu @asonay @cmorenom
Also tagging @czodrows in relation to ATR-23671