athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-23T11:20:02+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46337Implementing tracking geometry for ITk2021-09-23T11:20:02+02:00Noemi CalaceImplementing tracking geometry for ITkThis MR includes the implementation of the tracking geometry for ITk and small updates for the overlap descriptors
No changes are expected as the behaviour is left unchanged for the ID.
As mentioned in previous MR, the implementation i...This MR includes the implementation of the tracking geometry for ITk and small updates for the overlap descriptors
No changes are expected as the behaviour is left unchanged for the ID.
As mentioned in previous MR, the implementation is still ongoing and will be migrated soon to the condition algorithms.Noemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46270Change seeds for FS LRT test chain [ATR-24083]2021-09-23T11:55:37+02:00Teng Jian KhooChange seeds for FS LRT test chain [ATR-24083]Limit FS LRT tracking test chain to lowest unprescaled J100 and 4J15 chains to cut excessive CPU usage.Limit FS LRT tracking test chain to lowest unprescaled J100 and 4J15 chains to cut excessive CPU usage.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45894Switching TCC algorithm to use DetectorEta in r222021-09-23T15:43:08+02:00Steven SchrammSwitching TCC algorithm to use DetectorEta in r22The current TCC matching procedure uses the cluster eta directly,
without checking if it is the detector coordinate or origin-corrected
coordinate. This commit changes the code to use the detector eta
when matching clusters to tracks for...The current TCC matching procedure uses the cluster eta directly,
without checking if it is the detector coordinate or origin-corrected
coordinate. This commit changes the code to use the detector eta
when matching clusters to tracks for TCC reconstruction. Unlike the
choice made for R21, this is a straight fix (not hidden behind a flag)
in R22 as this should be the baseline going forward.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46634Revert "Merge branch 'gaudi82.DetDescrCnvSvc-20210917' into 'master'"2021-09-23T15:43:23+02:00Scott SnyderRevert "Merge branch 'gaudi82.DetDescrCnvSvc-20210917' into 'master'"This reverts merge request !46585
This causes a deadlock in LArConditionsTest.
Need to study this further.This reverts merge request !46585
This causes a deadlock in LArConditionsTest.
Need to study this further.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46657MuonPRDTest: Update the digit and reco DCube histograms2021-09-23T15:44:15+02:00Minlin WuMuonPRDTest: Update the digit and reco DCube histogramsTry to update the scripts for the digit and reco DCube histograms with eta and phi selections. Tests of the scripts are passed.
Fix the TGC PRD validation.Try to update the scripts for the digit and reco DCube histograms with eta and phi selections. Tests of the scripts are passed.
Fix the TGC PRD validation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46620Modify the gFEX Sim and SysSim Tools to save TOBs in different output containers2021-09-23T15:44:19+02:00Cecilia TosciriModify the gFEX Sim and SysSim Tools to save TOBs in different output containersWith this MR the Sim and SysSim Tools are modified to save the gFEX output TOBs in different containers, according to the TOB types. For the Jet TOBs, we save the energy density Rho, the small-R jets, and large-R jets in different contai...With this MR the Sim and SysSim Tools are modified to save the gFEX output TOBs in different containers, according to the TOB types. For the Jet TOBs, we save the energy density Rho, the small-R jets, and large-R jets in different containers (instances of the gFEXJetRoI class). For the Global TOBs, we have one container for each of the following pairs of quantities: MET/SumET, MET_x/MET_y, MHT_x/MHT_y, MST_x/MST_y (instances of the gFEXGlobalRoI class).https://gitlab.cern.ch/atlas/athena/-/merge_requests/46656CA-base configuration of LAr Ramp Run processing2021-09-23T15:44:40+02:00Walter LamplCA-base configuration of LAr Ramp Run processing- Initial version of new style config of LAr Ramp Run processing
- Few fixes at related places- Initial version of new style config of LAr Ramp Run processing
- Few fixes at related placeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46649AthContainers: Allow customizing DV object deletion.2021-09-23T15:44:48+02:00Scott SnyderAthContainers: Allow customizing DV object deletion.Add a mechanism to DataVector to customize how objects are deleted.
This is done by a polymorphic Deleter interface.
The goal here is to be able to use an alternate memory allocator
for the objects in a DV. But for compatibility and ot...Add a mechanism to DataVector to customize how objects are deleted.
This is done by a polymorphic Deleter interface.
The goal here is to be able to use an alternate memory allocator
for the objects in a DV. But for compatibility and other reasons,
we don't want to change the DV types themselves, which is why this
is done via a polymorphic interface.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44325Implement track observer tool2021-09-23T15:45:03+02:00Sebastien RettieImplement track observer toolThe track observer tool allows the detailed study of tracks and their progression through the ambiguity solver.
It was used in `r21` for CTIDE studies, and would be very useful in `r22` as well.
This tool, when enabled, will create an o...The track observer tool allows the detailed study of tracks and their progression through the ambiguity solver.
It was used in `r21` for CTIDE studies, and would be very useful in `r22` as well.
This tool, when enabled, will create an output track collection, `InDetObservedTrackParticles`, with the truth information of the observed particles and info generated by the tool (parentID, numShared, rejection reason, etc.).
Each track is uniquely identified using a thread-safe `std::atomic<std::uint32_t>` (defined in `AmbiguityProcessorUtility.cxx`), which serves as Id for the tool. If a track has a parent, the unique Id of the parent is also saved by the tool. As the ambiguity processor tools delete tracks, all tracks (including temporary tracks) are saved to the tool's cache entry, i.e. an `ObservedTracksMap` object. The `TrackPtr.h` class is also augmented with a unique Id.
Two instances of the TrkObserverTool must be instantiated in order to avoid data handle conflicts:
- Instance that does not initialize the data handles and is used throughout the ambiguity solving
- Instance that initializes the data handles and is only used to write out the observed tracks after the ambiguity solving is done
The track uid defaults to -1 when required and the observer tool is not enabled.
To run with the observer tool enabled, set `InDetFlags.doTIDE_AmbiTrackMonitoring` to `True` in the relevant job options.
Tagging @goblirsc @vcairo @gfacini @battagl @dmclaugh @svanstrohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46679MuonTrackMonitoring: Fix clang warning.2021-09-23T21:42:42+02:00Scott SnyderMuonTrackMonitoring: Fix clang warning.Spurious copy in range-for.Spurious copy in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46684TrigT1CTMonitoring: remove online monitoring config and cleanup2021-09-23T21:42:55+02:00Frank WinklmeierTrigT1CTMonitoring: remove online monitoring config and cleanupThe `isOnline` specific CTP monitoring configuration is definitely
broken and likely not used. Just remove all code and print an error
message. Also delete some other obsolete files.
cc @czodrowsThe `isOnline` specific CTP monitoring configuration is definitely
broken and likely not used. Just remove all code and print an error
message. Also delete some other obsolete files.
cc @czodrowshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46663Pixel Monitoring: change naming of pixel barrel layers2021-09-23T21:42:59+02:00Iskander IbragimovPixel Monitoring: change naming of pixel barrel layers* B0 -> BLayer
* B1 -> Layer1
* B2 -> Layer2
histogram labels as well as their internal names are adjusted in a coherent way.* B0 -> BLayer
* B1 -> Layer1
* B2 -> Layer2
histogram labels as well as their internal names are adjusted in a coherent way.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46677CrestApi: Fix cppcheck warnings.2021-09-23T21:43:22+02:00Scott SnyderCrestApi: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46653InDetReadoutGeometry+SCT_ConditionsAlgorithms: SiDetectorElementCollection sh...2021-09-23T21:43:37+02:00Scott SnyderInDetReadoutGeometry+SCT_ConditionsAlgorithms: SiDetectorElementCollection should have mixed conditions.PixelDetectorElementCondAlg produces SiDetectorElementCollection but with
mixed runlbn / timestamp IOVs. So we need to declare that this type uses
mixed conditions.
Force SCT_DetectorElementCondAlg to produce a mixed IOV as output, in ...PixelDetectorElementCondAlg produces SiDetectorElementCollection but with
mixed runlbn / timestamp IOVs. So we need to declare that this type uses
mixed conditions.
Force SCT_DetectorElementCondAlg to produce a mixed IOV as output, in order
to be compatible with PixelDetectorElementCondAlg. They both produce the
same type, SiDetectorElementCollection, which the pixel algorithm requires
to be mixed.
See ATEAM-778.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46676DumpGeo: add an example TileCal jobOptions2021-09-23T21:43:41+02:00Riccardo Maria Bianchiriccardo.maria.bianchi@cern.chDumpGeo: add an example TileCal jobOptionsThis MR adds to `DetectorDescription/DumpGeo` an example jobOptions file to dump a custom TileCal geometry tag.
---
Cc: @solodkov , @alancast , @boudreau , @tsulaiaThis MR adds to `DetectorDescription/DumpGeo` an example jobOptions file to dump a custom TileCal geometry tag.
---
Cc: @solodkov , @alancast , @boudreau , @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46465adjust minbias histogram ranges2021-09-23T21:43:43+02:00Sarka Todorovaadjust minbias histogram rangesUpdate of range in minbias monitoring histograms.
Trivial changes done to generic monitoring histograms (i.e. polar angle between 0 and pi ).Update of range in minbias monitoring histograms.
Trivial changes done to generic monitoring histograms (i.e. polar angle between 0 and pi ).https://gitlab.cern.ch/atlas/athena/-/merge_requests/46668Element links to data in ancestor views2021-09-23T21:43:48+02:00Benjamin Michael WynneElement links to data in ancestor viewsPrompted by ATR-24052
The `makeLink()` helper function for views assumes that a piece of data accessed through viewX is actually associated with that view, when in fact it could be from an ancestor viewY or the main event-level store.
...Prompted by ATR-24052
The `makeLink()` helper function for views assumes that a piece of data accessed through viewX is actually associated with that view, when in fact it could be from an ancestor viewY or the main event-level store.
Changed the behaviour of `makeLink()` and the corresponding link remapping in the view merger helper to use the real location of the data.
Added a test for this, and tidied up the test script a little as well.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46659TrigSimTransforms: delete legacy trigger simulation transform2021-09-23T21:43:52+02:00Frank WinklmeierTrigSimTransforms: delete legacy trigger simulation transformThis transform (simulating the trigger on old bytestream, [TWiki doc](https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerSimulationWithPastReleases)) is currently not
used to simulate the trigger. Instead we are using `RDOtoRDOTrigger` to...This transform (simulating the trigger on old bytestream, [TWiki doc](https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerSimulationWithPastReleases)) is currently not
used to simulate the trigger. Instead we are using `RDOtoRDOTrigger` to
simulate past data-taking periods.
Deleting this package in master to avoid confusion and avoid people spending time trying to migrate code in it. If we decide to resurrect the "legacy simulation project" it can be restored from git history.
@bernius @salnikov @wiedenma @mark @smh, please object if I have overlooked a use-case.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46678DecisionHandling: Fix clang warnings.2021-09-23T21:43:59+02:00Scott SnyderDecisionHandling: Fix clang warnings.Spurious copies in range-for.Spurious copies in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46681remove LArPedestalBuilder and LArAutoCorrBuilder. Superseeded by LArPedestalA...2021-09-23T21:44:02+02:00Walter Lamplremove LArPedestalBuilder and LArAutoCorrBuilder. Superseeded by LArPedestalAutoCorrBuilderTh two algorithms LArPedestalBuilder and LArAutoCorrBuilder are essentially unused since 2008. Finally removing them.Th two algorithms LArPedestalBuilder and LArAutoCorrBuilder are essentially unused since 2008. Finally removing them.