athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-20T03:03:04+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43622LRT electrons - Ensure that they are written to the AODs in any case2021-05-20T03:03:04+02:00Giuliano GustavinoLRT electrons - Ensure that they are written to the AODs in any caseHi,
similarly to the case of LRT muons:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43455
LRT electron containers are not added in the AODs because the flag doR3LargeD0() is reset to false in the ESDToAOD step.
This merge reques...Hi,
similarly to the case of LRT muons:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43455
LRT electron containers are not added in the AODs because the flag doR3LargeD0() is reset to false in the ESDToAOD step.
This merge request removes that condition in order to fix the issue in that workflow.
Adding @goblirsc, @christos, @mdanninghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43621Reduction of egammaValidation histograms related to TruthElectronHistograms w...2021-05-20T20:43:47+02:00Frued Erik BrarenReduction of egammaValidation histograms related to TruthElectronHistograms which were empty.Avoiding the creation of unneccessary empty truth-electron histograms in TruthElectronHistograms and EfficiencyPlot in egammaValidation. The histogram-filling code is adjusted accordingly.
@dboernerAvoiding the creation of unneccessary empty truth-electron histograms in TruthElectronHistograms and EfficiencyPlot in egammaValidation. The histogram-filling code is adjusted accordingly.
@dboernerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43620switch to MG default version 2.8.1p3.atlas102021-05-19T03:06:48+02:00Ewelina Maria Lobodzinskaswitch to MG default version 2.8.1p3.atlas10switch to MG default version 2.8.1p3.atlas10switch to MG default version 2.8.1p3.atlas10https://gitlab.cern.ch/atlas/athena/-/merge_requests/43619ITk seed configuration for staging scenarios2021-05-20T11:18:17+02:00Thomas StreblerITk seed configuration for staging scenariosThis MR updates the configuration of the ITk seed maker to avoid any inefficiency with high-pT muons in the scenario with no L4.
A minor consistency update of some postInclude is also included.
FYI @ncalace @nstylesThis MR updates the configuration of the ITk seed maker to avoid any inefficiency with high-pT muons in the scenario with no L4.
A minor consistency update of some postInclude is also included.
FYI @ncalace @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43618Update the beam spot code to make it Run in Release 222021-05-25T03:04:43+02:00Anthony MorleyUpdate the beam spot code to make it Run in Release 22A series of small updates to get the beams pot code running in Release 22.
The changes include:
- required for Python3 migration
- No longer use AthenaROOTAccessA series of small updates to get the beams pot code running in Release 22.
The changes include:
- required for Python3 migration
- No longer use AthenaROOTAccesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43617eflowRec : Remove a const_cast, make a few more things that could actually be...2021-05-19T03:03:36+02:00Christos Anastopouloschristos.anastopoulos@cern.cheflowRec : Remove a const_cast, make a few more things that could actually be const consteflowRec continue on MT checker and const-correctness.
- Remove a const_cast,
- make a few more things that could actually const be.
- Tidy a bit at large the relevant code
Still this leave a couple of ``const_cast`` in the packageeflowRec continue on MT checker and const-correctness.
- Remove a const_cast,
- make a few more things that could actually const be.
- Tidy a bit at large the relevant code
Still this leave a couple of ``const_cast`` in the packagehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43616L1Calo efex thresholds now from the menu, finer granularity tob eta range, an...2021-05-22T03:03:13+02:00Alison ElliotL1Calo efex thresholds now from the menu, finer granularity tob eta range, and code cleanupSeveral updates for the L1Calo eFEX bitwise simulation:
-- the thresholds are now taken from the L1Menu, and set the reta rhad and wstot working points in the tob, and EDM.
-- the TOB words in the EDM now use the eta seed as well, mean...Several updates for the L1Calo eFEX bitwise simulation:
-- the thresholds are now taken from the L1Menu, and set the reta rhad and wstot working points in the tob, and EDM.
-- the TOB words in the EDM now use the eta seed as well, meaning they should have the finer granularity from 0.1 to 0.025
-- several bugs fixed:
---- TOB sorting and resizing no longer requires 6 tobs (can have fewer).
---- code requiring TOBs to have a seed was commented out for debugging - and is now reinstated.
-- some deprecated histogram testing code removedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43615InDetTestBLayer : Try to remove seemingly unused methods2021-05-19T03:02:42+02:00Christos Anastopouloschristos.anastopoulos@cern.chInDetTestBLayer : Try to remove seemingly unused methodsInDetTestBLayer : Try to remove seemingly unused methods
Mentiong @sroeInDetTestBLayer : Try to remove seemingly unused methods
Mentiong @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43614AthContainers: Fix cppcheck warnings.2021-05-19T03:02:28+02:00Scott SnyderAthContainers: Fix cppcheck warnings.Fix/suppress cppcheck warnings.Fix/suppress cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43613Modified JetMonitoringStandard.py for expected Run3 DQ configuraiton2021-05-22T03:06:02+02:00Lee SawyerModified JetMonitoringStandard.py for expected Run3 DQ configuraitonUpdate mainly to JetMonitoringStandard.py to include standard plots used in Run 2 DQ and modify collections being used. Number of collections significantly reduced compared to Run 2. Small changes made to JetStandardHistoSpecs.py adding ...Update mainly to JetMonitoringStandard.py to include standard plots used in Run 2 DQ and modify collections being used. Number of collections significantly reduced compared to Run 2. Small changes made to JetStandardHistoSpecs.py adding a nconstit histogram and changing binning on some calorimeter quality plots.Jannik GeisenWilliam Keaton BalunasLee SawyerJannik Geisenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43612AthLinks: Fix cppcheck warnings.2021-05-19T03:04:41+02:00Scott SnyderAthLinks: Fix cppcheck warnings.Don't pass large objects by value.
Prefer using preincrement for iterator classes.Don't pass large objects by value.
Prefer using preincrement for iterator classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43611AFP_Geometry+AFP_ByteStream2RawCnv: cmake fixes2021-05-19T03:03:01+02:00Scott SnyderAFP_Geometry+AFP_ByteStream2RawCnv: cmake fixesUnused/undefined ROOT macros.
Don't build the same source into more than one library.Unused/undefined ROOT macros.
Don't build the same source into more than one library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43610MuonCablingTools: Enable thread-safety checking.2021-05-19T03:05:04+02:00Scott SnyderMuonCablingTools: Enable thread-safety checking.Enable thread-safety checking.Enable thread-safety checking.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43609TrkPatternParameters+TrkEventTPCnv: Fix gcc11 warnings.2021-05-19T03:05:11+02:00Scott SnyderTrkPatternParameters+TrkEventTPCnv: Fix gcc11 warnings.Avoid warnings about copying uninitialized Eigen objects to std::optional
by using emplace instead of assignment.Avoid warnings about copying uninitialized Eigen objects to std::optional
by using emplace instead of assignment.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43608TrigMuonHypoMT: drop "MT" in package and component names2021-05-19T03:04:43+02:00Frank WinklmeierTrigMuonHypoMT: drop "MT" in package and component namesRename the package to `TrigMuonHypo` and drop the "MT" from all
component and files names.
cc @yoyamagu @sshawRename the package to `TrigMuonHypo` and drop the "MT" from all
component and files names.
cc @yoyamagu @sshawhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43607LArElecCalib: Remove ILArMCSymTool.2021-05-19T03:03:02+02:00Scott SnyderLArElecCalib: Remove ILArMCSymTool.Remove obsolete/unused ILArMCSymTool.Remove obsolete/unused ILArMCSymTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43606IOVSvc: Load conditions dictionaries during initialize().2021-05-19T03:02:45+02:00Scott SnyderIOVSvc: Load conditions dictionaries during initialize().Make sure that root dictionaries for the objects we manage are loaded
during initialize(). Leaving them to be loaded until after event processing
starts is unreliable, as root sometimes has problems loading dictionaries
when multiple th...Make sure that root dictionaries for the objects we manage are loaded
during initialize(). Leaving them to be loaded until after event processing
starts is unreliable, as root sometimes has problems loading dictionaries
when multiple threads are running.
See ATLASRECTS-6347.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43605Merging histograms for invariant histograms2021-05-19T03:02:59+02:00Peter OnyisiMerging histograms for invariant histogramsAdd algorithm to merge identical histograms: A+A = AAdd algorithm to merge identical histograms: A+A = Ahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43604HLT Met mon update 202105142021-05-19T03:05:31+02:00Kenji HamanoHLT Met mon update 20210514The axis label of 3 offline HLT MET monitoring histograms were changed to list specified names.
ATR-19971The axis label of 3 offline HLT MET monitoring histograms were changed to list specified names.
ATR-19971https://gitlab.cern.ch/atlas/athena/-/merge_requests/43603TrigValidation: Enable FPEAuditor by default in Trigger ART tests2021-05-28T03:02:31+02:00Rafal Bielskirafal.bielski@cern.chTrigValidation: Enable FPEAuditor by default in Trigger ART testsAdd an option `fpe_auditor` in `TrigValSteering.ExecStep` with default setting to `True`. The new option modifies the command line arguments to enable the `fpeAuditor` [Modifier](https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/Tr...Add an option `fpe_auditor` in `TrigValSteering.ExecStep` with default setting to `True`. The new option modifies the command line arguments to enable the `fpeAuditor` [Modifier](https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TriggerCommon/TriggerJobOpts/python/Modifiers.py) where applicable.
"Where applicable" means all athena / athenaHLT jobs using the runHLT_standalone.py job options and all transforms running the Trigger step, i.e. BSRDOtoRAW or RDOtoRDOTrigger.
The explicit addition of the modifier is removed from the few tests which had it, because it's now the default. The option is explicitly disabled in the two "dumpConfig" tests in TrigP1Test as we don't want FPEAuditor in the configuration to be uploaded for P1 operation (we only want to run it in ART).
Additionally, the corresponding message patterns are added in `check_log.py` to make sure we catch the FPEs and that the Trigger Validation Shifters can report them to developers.
cc @okumura, @vmartin, @smh, @fwinkl, @dzanzi, @hartj