athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-28T03:02:28+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43872Add FTF LRT tracks to the ITrig plots2021-05-28T03:02:28+02:00Mark SuttonAdd FTF LRT tracks to the ITrig plotsUsually we include one FTF collection on the IDTrig plots for reference purposes.Usually we include one FTF collection on the IDTrig plots for reference purposes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43887MuIdCaloTrackStateOnSurface - CleanUp Vol I2021-05-28T03:02:25+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuIdCaloTrackStateOnSurface - CleanUp Vol IHi,
this is a preparatory MR to augment the interface of the `IMuIdCaloTrackStateOnSurface`tools as outlined in ATLASRECTS-6350.Hi,
this is a preparatory MR to augment the interface of the `IMuIdCaloTrackStateOnSurface`tools as outlined in ATLASRECTS-6350.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43840Added postInclude fragmetn to enable trigger navigation conversionin ESDtoAOD...2021-05-28T03:02:21+02:00Tomasz BoldAdded postInclude fragmetn to enable trigger navigation conversionin ESDtoAOD jobThis script allows to a simplification of a complete conversion fo the ESD to AOD with trigger navigation conversion.
Taggign @tamartin @wprzygod
followup: drop the RunNavDump.py once acustomed to this new script.This script allows to a simplification of a complete conversion fo the ESD to AOD with trigger navigation conversion.
Taggign @tamartin @wprzygod
followup: drop the RunNavDump.py once acustomed to this new script.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43866Disable navigation conversion in RAW to ESD2021-05-27T20:09:28+02:00Tomasz BoldDisable navigation conversion in RAW to ESDFixes errors in RAWto* jobs.
Expected to solve:
ATR-23488
ATR-23489
Tagging @bernius @fwinkl @emoyseFixes errors in RAWto* jobs.
Expected to solve:
ATR-23488
ATR-23489
Tagging @bernius @fwinkl @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43593Update of delayed stream candidates2021-05-27T12:53:55+02:00Teng Jian KhooUpdate of delayed stream candidates* Removes some less relevant chains
* Updates b-tagging for HH->4b 2b,3b chain candidates -- still not final
* Adds more chains starting from the baseline L1 seeds* Removes some less relevant chains
* Updates b-tagging for HH->4b 2b,3b chain candidates -- still not final
* Adds more chains starting from the baseline L1 seedshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43669IDPVM vertex efficiency update2021-05-27T12:18:37+02:00Thomas StreblerIDPVM vertex efficiency updateThis MR updates the definition of the vertex efficiency plots used in IDPVM.
FYI @ncalace @haoranThis MR updates the definition of the vertex efficiency plots used in IDPVM.
FYI @ncalace @haoranhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43850Sweeping !43759 from 21.3 to 21.9.
Fixes for reco eff in eta>2.32021-05-27T03:06:09+02:00Atlas NightlybuildSweeping !43759 from 21.3 to 21.9.
Fixes for reco eff in eta>2.3Fixes for reco eff in eta>2.3
See merge request atlas/athena!43759Fixes for reco eff in eta>2.3
See merge request atlas/athena!43759https://gitlab.cern.ch/atlas/athena/-/merge_requests/43809MuonIdHelpers: Thread-safety fix.2021-05-27T03:05:04+02:00Scott SnyderMuonIdHelpers: Thread-safety fix.Use of MsgStream was not thread-safe. Cleaned up.Use of MsgStream was not thread-safe. Cleaned up.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43852RootCollection+ImplicitCollection+CollectionBase: Enable thread-safety checking.2021-05-27T03:04:58+02:00Scott SnyderRootCollection+ImplicitCollection+CollectionBase: Enable thread-safety checking.Enable thread-safety checking and fix identified issues.
Make methods of ICollectionMetadata non-const.Enable thread-safety checking and fix identified issues.
Make methods of ICollectionMetadata non-const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43847ATLASRECTS-6366 : egammaMVACalib try to take directly ownership of the TH2Poly2021-05-27T03:04:54+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-6366 : egammaMVACalib try to take directly ownership of the TH2PolyATLASRECTS-6366 : egammaMVACalib try to take directly ownership of the TH2Poly to avoid
relying on "ROOT" autocleaning as this can lead to memory leaks .ATLASRECTS-6366 : egammaMVACalib try to take directly ownership of the TH2Poly to avoid
relying on "ROOT" autocleaning as this can lead to memory leaks .https://gitlab.cern.ch/atlas/athena/-/merge_requests/43808CaloCalibHitRec: Fix cppcheck warnings.2021-05-27T03:04:47+02:00Scott SnyderCaloCalibHitRec: Fix cppcheck warnings.Avoid postincrement of iterator classes.Avoid postincrement of iterator classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43848Fix key locations (hopefully for the last time) add new utility2021-05-27T03:04:41+02:00Mark SuttonFix key locations (hopefully for the last time) add new utilityHopefully this will be tha last time the code around the positions of the keys needs to change
In addition, add a new piece of utility code to read from multiple root files, and
plot composite histograms with varying parametersHopefully this will be tha last time the code around the positions of the keys needs to change
In addition, add a new piece of utility code to read from multiple root files, and
plot composite histograms with varying parametershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43367SiDetElementsRoadMaker update for ITk [ATLIDTRKCP-338]2021-05-27T03:04:28+02:00Thomas StreblerSiDetElementsRoadMaker update for ITk [ATLIDTRKCP-338]Porting of the 21.9 ITk developments in the SiDetElementsRoadMaker. Run 3 reconstruction is unaffected.
FYI @ncalace @nstylesPorting of the 21.9 ITk developments in the SiDetElementsRoadMaker. Run 3 reconstruction is unaffected.
FYI @ncalace @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43623TLA chain name changes (ATR-20395, ATR-21594) and bug-fix for TLA photon (ATR...2021-05-27T03:04:04+02:00Caterina DoglioniTLA chain name changes (ATR-20395, ATR-21594) and bug-fix for TLA photon (ATR-23448)In the current MR we:
- changed JetDS position in jet chains (ATR-20395)
- added low-threshold L1Topo chain for potential end-of-fill / low lumi / early menu (ATR-20395)
- added test chain for TLA multijet from HH4b seed (ATR-21594)
- ...In the current MR we:
- changed JetDS position in jet chains (ATR-20395)
- added low-threshold L1Topo chain for potential end-of-fill / low lumi / early menu (ATR-20395)
- added test chain for TLA multijet from HH4b seed (ATR-21594)
- fixed issue on photon container threshold to be lower wrt the photon chain threshold to avoid problem in ATR-23448 (with @mmontell). This is a temporary fix for the chain we're testing, but will need a check that this does not happen when parsing the chain name, which will happen in a subsequent MR.
Update 23/05/2021: Fixing the multijet test chain, but also testing a single TLA stream for jets and photons.
Update 23/05/2021: testing of a single TLA stream in its own branch, fixed multijet test chain
Update 25/05/2021: fixing reference for multijet test chain, more edge cases for photon TLAhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43854egammaMVACalibAnalysis+ElectronPhotonFourMomentumCorrection+LArCellRec: Fix c...2021-05-27T03:03:55+02:00Scott SnyderegammaMVACalibAnalysis+ElectronPhotonFourMomentumCorrection+LArCellRec: Fix cppcheck warnings.Redundant pointer comparison.
Pass large objects by const reference, not by value.
Avoid postincrement for iterator classes.Redundant pointer comparison.
Pass large objects by const reference, not by value.
Avoid postincrement for iterator classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43846TrigT1Muctpi+TrigT1TGC: Fix missing data handle migration in L1Muctpi and LVL...2021-05-27T03:03:48+02:00Rafal Bielskirafal.bielski@cern.chTrigT1Muctpi+TrigT1TGC: Fix missing data handle migration in L1Muctpi and LVL1TGCTriggerFix missing migrations from direct SG retrieve/record to Read/Write Handles in two L1Muon simulation algorithms: `L1Muctpi` and `LVL1TGCTrigger`.
Fixes warnings discussed in ATR-22942:
```
StoreGateSvc ...Fix missing migrations from direct SG retrieve/record to Read/Write Handles in two L1Muon simulation algorithms: `L1Muctpi` and `LVL1TGCTrigger`.
Fixes warnings discussed in ATR-22942:
```
StoreGateSvc WARNING Called retrieve() on these objects in a MT store
StoreGateSvc WARNING TgcRdoContainer/TGCRDO [LVL1TGCTrigger::LVL1TGCTrigger/LVL1TGCTrigger]
```
```
StoreGateSvc WARNING Called record() on these objects in a MT store
StoreGateSvc WARNING LVL1::MuCTPIL1Topo/L1MuCTPItoL1TopoLocation [LVL1MUCTPI::L1Muctpi/L1Muctpi]
StoreGateSvc WARNING LVL1::MuCTPIL1Topo/L1MuCTPItoL1TopoLocation-1 [LVL1MUCTPI::L1Muctpi/L1Muctpi]
StoreGateSvc WARNING LVL1::MuCTPIL1Topo/L1MuCTPItoL1TopoLocation1 [LVL1MUCTPI::L1Muctpi/L1Muctpi]
StoreGateSvc WARNING LVL1::NimCTP/L1NIMtoCTPLocation [LVL1MUCTPI::L1Muctpi/L1Muctpi]
```
cc @armbrust, @masato
**RC:** please do not squash the commitshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43843CaloTrkMuIdTools - clang format2021-05-27T03:03:40+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chCaloTrkMuIdTools - clang formatSimple clang-format MR of the files not touched in !43841 & !43842.Simple clang-format MR of the files not touched in !43841 & !43842.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43830add new potential top-level logvol2021-05-27T03:03:31+02:00Nicholas Stylesadd new potential top-level logvolAdd new option for top-level pixel volume to allow more meaningful naming when moving to geometries with a common volume for all PP1 material.
@tlariAdd new option for top-level pixel volume to allow more meaningful naming when moving to geometries with a common volume for all PP1 material.
@tlarihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43823Add nightly test to disable the electron PID in the precisicion tracking2021-05-27T03:03:27+02:00Mark SuttonAdd nightly test to disable the electron PID in the precisicion trackingAllows the use of the ElectronPidTool in the TrackSummaryTool based on a configurable flag so that this can be enabled or disabled in the trigger using a python preinclude.
Adds a new test for the electron slice where this tool is disabledAllows the use of the ElectronPidTool in the TrackSummaryTool based on a configurable flag so that this can be enabled or disabled in the trigger using a python preinclude.
Adds a new test for the electron slice where this tool is disabledhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43468Adding LLP tau trigger RNN chain2021-05-27T03:03:14+02:00Guillermo Nicolas HamityAdding LLP tau trigger RNN chainAdding displaced tau trigger chain discussed in ATR-21754 file options with placeholder configuration files
- configs for LLP tau RNN (network and flattening files) have been added to eos and updated in algorithm
- implementation of LLP...Adding displaced tau trigger chain discussed in ATR-21754 file options with placeholder configuration files
- configs for LLP tau RNN (network and flattening files) have been added to eos and updated in algorithm
- implementation of LLP RNN chain into menu (tau25, tau160, tau200 and ditau chains with tracktwoLLP sequence)
- chain will be used for sampleT studiesGuillermo Nicolas HamityGuillermo Nicolas Hamity