athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-11T15:44:10+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/47060Dropped the access to CaloDetDescrManager as singleton from GeoCaloCalibHit2021-10-11T15:44:10+02:00Vakhtang TsulaiaDropped the access to CaloDetDescrManager as singleton from GeoCaloCalibHitA pointer to the manager is passed now to the constructor of `GeoCaloCalibHit`.
The clients have been adapted to this change.
Also implemented some formatting and stylistic changes in `GeoCaloCalibHit.icc`.A pointer to the manager is passed now to the constructor of `GeoCaloCalibHit`.
The clients have been adapted to this change.
Also implemented some formatting and stylistic changes in `GeoCaloCalibHit.icc`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46977EMVertesBuilderConfig in newJO2021-10-11T15:43:48+02:00Tomasz BoldEMVertesBuilderConfig in newJOThis MR is meant to add the next step of electron reco in new JO.
Since it will take some more time to fix it publishing this draft FI, tagging @christos
One thing that I did, inspired by:
InnerDetector/InDetExample/InDetRecExample/py...This MR is meant to add the next step of electron reco in new JO.
Since it will take some more time to fix it publishing this draft FI, tagging @christos
One thing that I did, inspired by:
InnerDetector/InDetExample/InDetRecExample/python/ConfiguredSecondaryVertexCuts.py
I have defined Vertexing flags that essentially fully configure relevant algorithms.
Not sure how it fits our strategy which was to avoid a proliferation of flags. And these flags literally configure one peroperty.
Not working yet.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47061G4AtlasTests: Fix clang warning.2021-10-11T15:43:17+02:00Scott SnyderG4AtlasTests: Fix clang warning.Missing override keyword.Missing override keyword.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47062Fix threading issues in HLT prescale loading but for real2021-10-11T15:43:30+02:00Rafal Bielskirafal.bielski@cern.chFix threading issues in HLT prescale loading but for realThis MR is doing what !44936 claimed to do but missed the change in the most important two lines. :face_palm: Namely:
> `[L1|HLT]PrescaleCondAlg`: Use thread-safe `insert` to add elements to `tbb::concurrent_unordered_map` instead of `o...This MR is doing what !44936 claimed to do but missed the change in the most important two lines. :face_palm: Namely:
> `[L1|HLT]PrescaleCondAlg`: Use thread-safe `insert` to add elements to `tbb::concurrent_unordered_map` instead of `operator[]` + assignment which is unsafe.
!44936 did this only in two calls in `initialize()` of each algorithm, but missed the one that was actually causing crashes/errors which was in `execute()`.
Fixes ATR-23670 though it's unfortunately impossible to test this due to how rare this race condition is. We'll deploy this at P1 ASAP and hope we don't see the errors ever again.
cc @mark, @astruebi, @palacinohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43640Update TDT config to use consistent CA setup2021-10-11T21:44:11+02:00Tim MartinUpdate TDT config to use consistent CA setupTo assist with !42871
Seeing one strange test result in `test_trigP1_v1Dev_build.py` which I cannot see how it is related, so trying with full CI.To assist with !42871
Seeing one strange test result in `test_trigP1_v1Dev_build.py` which I cannot see how it is related, so trying with full CI.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47075TCT and TrfTestsART: Updated conditions tag and comparison options2021-10-11T21:46:09+02:00Peter BertaTCT and TrfTestsART: Updated conditions tag and comparison optionsThis MR updates the conditions tag for data to CONDBR2-BLKPA-RUN2-09 and also updated the options for the comparison step for some tests.This MR updates the conditions tag for data to CONDBR2-BLKPA-RUN2-09 and also updated the options for the comparison step for some tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47101update Sherpa to 3.0.0alpha1.py2452021-10-11T21:45:40+02:00Ewelina Maria Lobodzinskaupdate Sherpa to 3.0.0alpha1.py245update Sherpa to 3.0.0alpha1.py245update Sherpa to 3.0.0alpha1.py245https://gitlab.cern.ch/atlas/athena/-/merge_requests/47072Asymmetric uncertainties in ElectronEfficiencyCorrection2021-10-11T21:45:25+02:00Philip SommerAsymmetric uncertainties in ElectronEfficiencyCorrectionHello,
for the final run-2 recommendations for isolation scale factors we need the possibility to run asymmetric uncertainties.
This functionality is to be used together with the files discussed in ATLINFR-4266.
Cheers, Philip
fyi @h...Hello,
for the final run-2 recommendations for isolation scale factors we need the possibility to run asymmetric uncertainties.
This functionality is to be used together with the files discussed in ATLINFR-4266.
Cheers, Philip
fyi @htorres, @turra, @jpovedahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47079remove other tracks links/calls for DiTau2021-10-11T21:45:30+02:00Antonio De Mariaremove other tracks links/calls for DiTauThis MR will remove the call to "other" tracks for DiTau objects since they were not used for ID tuning
and "other" tracks are also not provided in the TauCP smart slimming list
Tagging @martindl, @qbuat and @dtaThis MR will remove the call to "other" tracks for DiTau objects since they were not used for ID tuning
and "other" tracks are also not provided in the TauCP smart slimming list
Tagging @martindl, @qbuat and @dtahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46922Rpc dq 3.12021-10-27T10:41:01+02:00Shixiang SuRpc dq 3.1Hello,
Here are the RPC DQ algorithms in RpcRawDataMonitoring.
These algorithms include
- RPC prepare data counting
- RPC hit multiplicity and clusters counting
- Muon track extrapolation and RPC detection efficiency
- L1 trigger
Th...Hello,
Here are the RPC DQ algorithms in RpcRawDataMonitoring.
These algorithms include
- RPC prepare data counting
- RPC hit multiplicity and clusters counting
- Muon track extrapolation and RPC detection efficiency
- L1 trigger
The post-processing functions include
- reading luminosity block information, calculating hit rate in individual panel, then plotting summary the results
- calculating muon detection effciency in indidual panel, then plotting summary the results
- other summary plots for hit multiplicity and clusters.
These algorithms have been sucessfully tested by Run3DQTestingDriver.py script.
Changes also contains the editing on DQ web display configurations, which is tested by DQWebDisplay.py.
best,
Shixianghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47083Electron recommendations for ID and iso2021-10-11T21:45:23+02:00Philip SommerElectron recommendations for ID and isoHello,
we're updating e/y recommendations. This MR provides:
- a new map file containing the recommended SFs
- an update to the CI test (because the SFs changed)
- the test script had to be updated to hold a finite run number (because t...Hello,
we're updating e/y recommendations. This MR provides:
- a new map file containing the recommended SFs
- an update to the CI test (because the SFs changed)
- the test script had to be updated to hold a finite run number (because the new files limit the run number range to run-2)
Cheers,
Philip, @jpoveda, @turra, @jmaurer, @ahadef, @htorreshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46943A few methods implemented in version 2 of Run2ToRun3 code2021-10-11T21:44:05+02:00Witold Wojciech PrzygodaA few methods implemented in version 2 of Run2ToRun3 codeNew (version 2): associateChainsToProxies and extractTECtoChainMapping implemented
Old version: optional code selector for various approach.\
Test unit: temporarliy disabled (commented out).New (version 2): associateChainsToProxies and extractTECtoChainMapping implemented
Old version: optional code selector for various approach.\
Test unit: temporarliy disabled (commented out).https://gitlab.cern.ch/atlas/athena/-/merge_requests/46963Add beek-subset of L1All as a composite L1 item ATR-241682021-10-11T21:44:59+02:00Gianantonio Pezzullog.pezzullo@yale.eduAdd beek-subset of L1All as a composite L1 item ATR-24168Add beek-subset of L1All as a composite L1 itemAdd beek-subset of L1All as a composite L1 itemhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46979Changed unnecessary FATAL messages to match messaging in other systems2021-10-11T21:43:38+02:00Stylianos AngelidakisChanged unnecessary FATAL messages to match messaging in other systemshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47040Properly define ITk volumes to G42021-10-11T21:43:36+02:00Tadej Novaktadej.novak@cern.chProperly define ITk volumes to G4ITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47053Cleanup the usage of (InDet)GeometryDBSvc2021-10-11T21:44:20+02:00Tadej Novaktadej.novak@cern.chCleanup the usage of (InDet)GeometryDBSvcCleanup the usage of `InDetGeometryDBSvc` in the CA-based configuration and remove it from Phase-II projects as they do not seem to use it.
/cc @jchapman @nstyles @dshope @janovak @tsulaiaCleanup the usage of `InDetGeometryDBSvc` in the CA-based configuration and remove it from Phase-II projects as they do not seem to use it.
/cc @jchapman @nstyles @dshope @janovak @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47056Update derivation PHYS and PHYSVAL with new FTAG release 22 b-taggers trainin...2021-12-10T15:22:23+01:00Arnaud DuperrinUpdate derivation PHYS and PHYSVAL with new FTAG release 22 b-taggers trainings (DL1dv00, ...)This MR update the Flavour Tagging content in derivation PHYS and PHYSVAL with new release 22 b-taggers trainings.
In PHYSVAL:
----------
- 3 DL1r: 1 rel 21, 2 rel 22 trainings
- 4 DIPS: rel 22 dips,dipsLoose
- 3 DL1d: rel 22, among the...This MR update the Flavour Tagging content in derivation PHYS and PHYSVAL with new release 22 b-taggers trainings.
In PHYSVAL:
----------
- 3 DL1r: 1 rel 21, 2 rel 22 trainings
- 4 DIPS: rel 22 dips,dipsLoose
- 3 DL1d: rel 22, among them the “recommended tagger” which is DL1dLoose20210824r22 named DL1dv00 in EDM
In PHYS:
--------
- DL1r: 1 rel 21 trainings
- 1 DISP: rel 22 dipsLoose20210729
- DL1dv00: rel 22 “recommended tagger”
Tested both derivation reductionConf using as input valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.recon.AOD.e4993_s3227_r12986_tid26563903_00
Tagging few people: @vdao @biliu @cschiavi @mguth @pgadow @fdibello @dguest @thuffman for FTAGhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47064ReadoutGeometryBase+InDetReadoutGeometry+HGTD_ReadoutGeometry: Thread-safety ...2021-10-11T21:42:57+02:00Scott SnyderReadoutGeometryBase+InDetReadoutGeometry+HGTD_ReadoutGeometry: Thread-safety cleanups.Use CachedValue rather than mutable values and locks.Use CachedValue rather than mutable values and locks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47071TrackDepositInCaloTool retrieve Calo Det Descr Mgr from store, pass it as arg...2021-10-11T21:44:13+02:00Christos Anastopouloschristos.anastopoulos@cern.chTrackDepositInCaloTool retrieve Calo Det Descr Mgr from store, pass it as arg to the methodsTrackDepositInCaloTool retrieve Calo Det Descr Mgr from store, pass it as arg to the methods
work undertaken under ATLASRECTS-5012
ping @tsulaiaTrackDepositInCaloTool retrieve Calo Det Descr Mgr from store, pass it as arg to the methods
work undertaken under ATLASRECTS-5012
ping @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47067TileTPCnv+TileByteStream+TileRecAlgs: const fixes2021-10-11T21:44:42+02:00Scott SnyderTileTPCnv+TileByteStream+TileRecAlgs: const fixesSeparate const and non-const access to TileCablingService.
Non-const accesses should use getInstance_nc and be marked as not thread-safe.Separate const and non-const access to TileCablingService.
Non-const accesses should use getInstance_nc and be marked as not thread-safe.