athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-09-01T03:04:49+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46166bug fix in L1 muon overlap removal2021-09-01T03:04:49+02:00Masato Aokibug fix in L1 muon overlap removalThis is to fix a bug in the L1 muon overlap removal algorithm. ATR-23288
We are expecting count changes with the L1 muon, especially for multi-muon items.This is to fix a bug in the L1 muon overlap removal algorithm. ATR-23288
We are expecting count changes with the L1 muon, especially for multi-muon items.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46165TrigSignatureMoni: do not destroy AlgorithmTimer2021-09-01T03:04:20+02:00Frank WinklmeierTrigSignatureMoni: do not destroy AlgorithmTimerStop instead of destroying the `AlgorithmTimer`. This may fix rare
crashes during the stop transition, when there might be a race condition
between destroying the timer and pending callbacks.
Relates to ATR-24079.Stop instead of destroying the `AlgorithmTimer`. This may fix rare
crashes during the stop transition, when there might be a race condition
between destroying the timer and pending callbacks.
Relates to ATR-24079.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46184EventTPCnv: Enable thread-safety checking.2021-09-01T03:04:02+02:00Scott SnyderEventTPCnv: Enable thread-safety checking.Fix thread-safety warnings in tests.Fix thread-safety warnings in tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46181Sweeping !46146 from 21.2 to master.
Fix missing import in ELG_prun2021-09-01T03:03:59+02:00Atlas NightlybuildSweeping !46146 from 21.2 to master.
Fix missing import in ELG_prunFix missing import in ELG_prun
See merge request atlas/athena!46146Fix missing import in ELG_prun
See merge request atlas/athena!46146https://gitlab.cern.ch/atlas/athena/-/merge_requests/46171TrkParametersBase: Avoid cppcheck false positives.2021-09-01T03:03:46+02:00Scott SnyderTrkParametersBase: Avoid cppcheck false positives.cppcheck gets confused by operator<< used to initialize Eigen objects.cppcheck gets confused by operator<< used to initialize Eigen objects.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46126Small Modification to the Caruana sTGC Reco Tool2021-09-01T03:03:16+02:00Michael SloanSmall Modification to the Caruana sTGC Reco ToolStrip clusters with a multiplicity of 1 or 2 will cause the matrix made during the reconstruction to be singular, which causes problems for the reco method. Currently, when the matrix is found to be singular the Caruana method is abandon...Strip clusters with a multiplicity of 1 or 2 will cause the matrix made during the reconstruction to be singular, which causes problems for the reco method. Currently, when the matrix is found to be singular the Caruana method is abandoned and we revert back to the default weighted mean method. This small modification identifies if a cluster has multiplicity 1 or 2 before starting the position reconstruction saving CPU resources.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46101Redesign of disappearing and large dEdx track trigger hypos (ATR-21591 and AT...2021-09-01T03:03:14+02:00Kunihiro NaganoRedesign of disappearing and large dEdx track trigger hypos (ATR-21591 and ATR-21590) and fix for disappering track hypo thread safety- Redesign of disappearing track and large dE/dx trigger hypos (Alg/Tool) as needed for hit-based DV (discussed at ATR-23923, ATR-23688)
- Fix for thread safety for disappearing track trigger hypo as needed for hit-based DV (discussed at...- Redesign of disappearing track and large dE/dx trigger hypos (Alg/Tool) as needed for hit-based DV (discussed at ATR-23923, ATR-23688)
- Fix for thread safety for disappearing track trigger hypo as needed for hit-based DV (discussed at ATR-24022)https://gitlab.cern.ch/atlas/athena/-/merge_requests/46187EventCommonTPCnv: Enable thread-safety checking.2021-09-01T03:03:12+02:00Scott SnyderEventCommonTPCnv: Enable thread-safety checking.Enable thread-safety checking. Fix warnings in tests.Enable thread-safety checking. Fix warnings in tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46172VP1AODSystems: Fix qt warnings.2021-09-01T03:03:03+02:00Scott SnyderVP1AODSystems: Fix qt warnings.Updates for newer qt versions.Updates for newer qt versions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46186LArTPCnv: Enable thread-safety checking.2021-09-01T03:03:01+02:00Scott SnyderLArTPCnv: Enable thread-safety checking.Enable thread-safety checking and fix warnings in tests.Enable thread-safety checking and fix warnings in tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46185McParticleEvent: Enable thread-safety checking.2021-09-01T03:02:54+02:00Scott SnyderMcParticleEvent: Enable thread-safety checking.Enable thread-safety checking and fix warnings.Enable thread-safety checking and fix warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45973SameParticleHardScatteringFilter2021-09-01T03:02:51+02:00Andrii VerbytskyiSameParticleHardScatteringFilterIn this MR:
- addopted SameParticleHardScatteringFilter from 21.6 for master
- remove stray code in ParentTwoChildrenFilter.cxx
Tag @ewelinaIn this MR:
- addopted SameParticleHardScatteringFilter from 21.6 for master
- remove stray code in ParentTwoChildrenFilter.cxx
Tag @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46169TrigT1Monitoring: Fix cppcheck warnings.2021-09-01T03:02:34+02:00Scott SnyderTrigT1Monitoring: Fix cppcheck warnings.Use range-for. Avoid unneeded copies.Use range-for. Avoid unneeded copies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46073TrigDecisionTool: cleanup message logging2021-09-01T03:02:28+02:00Frank WinklmeierTrigDecisionTool: cleanup message loggingRewrite the `Logger` class to take an instance of `AsgTool` as the
logging destination. This ensures we have a single source of `MsgStream`
instances (either from `AthAlgTool` or `AsgMessaging`). This also fixes
the problem of not being ...Rewrite the `Logger` class to take an instance of `AsgTool` as the
logging destination. This ensures we have a single source of `MsgStream`
instances (either from `AthAlgTool` or `AsgMessaging`). This also fixes
the problem of not being able to udpate the `OutputLevel` of the
`TrigDecisionTool`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46208Adding new TCT test2021-09-01T01:58:50+02:00Peter BertaAdding new TCT testThis MR adds one new test into TCT similar to the one from RecJobTransformTests in the master branch:
https://gitlab.cern.ch/atlas/athena/-/blob/834e96a55afc6f4f2daed311896e21e293afbe56/Reconstruction/RecExample/RecJobTransformTests/tes...This MR adds one new test into TCT similar to the one from RecJobTransformTests in the master branch:
https://gitlab.cern.ch/atlas/athena/-/blob/834e96a55afc6f4f2daed311896e21e293afbe56/Reconstruction/RecExample/RecJobTransformTests/test/test_mc20e_13TeV_MultipleThreads.sh
This is needed because RecJobTransformTests are not enabled in 22.0-mc20.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46156Fix beamspot reweighting autoconfiguration2021-08-31T15:21:13+02:00Tadej Novaktadej.novak@cern.chFix beamspot reweighting autoconfigurationFix beamspot reweighting autoconfiguration. It should basically be enabled all the time except for pile-up presampling.
Needed for reprocessing so marking as ~urgent.
/cc @mduehrss @jchapman @elmsheus @emoyseFix beamspot reweighting autoconfiguration. It should basically be enabled all the time except for pile-up presampling.
Needed for reprocessing so marking as ~urgent.
/cc @mduehrss @jchapman @elmsheus @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46157Fix missing pile-up jets/particles in pile-up presampling jobs2021-08-31T15:20:25+02:00Tadej Novaktadej.novak@cern.chFix missing pile-up jets/particles in pile-up presampling jobsFix missing pile-up jets/particles in pile-up presampling jobs by explicitly adding a prefix to output containers after wildcarding was removed in !45568.
Needed for reprocessing so marking as ~urgent.
/cc @akraszna @jchapman @mduehrss...Fix missing pile-up jets/particles in pile-up presampling jobs by explicitly adding a prefix to output containers after wildcarding was removed in !45568.
Needed for reprocessing so marking as ~urgent.
/cc @akraszna @jchapman @mduehrss @elmsheus @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45424Generic Algorithm to run LAr NB chain in HLT finalise over all accepted event...2021-08-31T14:56:49+02:00Stefanie MorgensternGeneric Algorithm to run LAr NB chain in HLT finalise over all accepted events ATR-22474* generic EndOfEventROIConfirmerAlg to ensure that all handles are there
* run LAr NB alg on each accepted event in HLT finalise sequence
* change seed of LAr NB chain to L1All
* update references* generic EndOfEventROIConfirmerAlg to ensure that all handles are there
* run LAr NB alg on each accepted event in HLT finalise sequence
* change seed of LAr NB chain to L1All
* update referenceshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45885Updating valid1 TCT with a more recent AOD input file2021-08-31T14:49:56+02:00Cristiano AlpigianiUpdating valid1 TCT with a more recent AOD input fileThis MR updates the valid1TCT with an AOD file produced with 22.0.40 (the same AOD used for the mc16 TCT). It also cleans up the preExec removing the various DynVarFixer that are not needed anymore with recent AODs.This MR updates the valid1TCT with an AOD file produced with 22.0.40 (the same AOD used for the mc16 TCT). It also cleans up the preExec removing the various DynVarFixer that are not needed anymore with recent AODs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/46146Fix missing import in ELG_prun2021-08-31T14:11:14+02:00Tadej Novaktadej.novak@cern.chFix missing import in ELG_prunFixes missing `ROOT` import after !41064.
/cc @krumnackFixes missing `ROOT` import after !41064.
/cc @krumnack