athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-19T03:04:22+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43424Manual loop unrolling in SensorSim3DTool2021-05-19T03:04:22+02:00Tobias BisanzManual loop unrolling in SensorSim3DToolI'll post some profiles. These changes don't help readability, but seem to have a significant impact on speed - unfortunatelyI'll post some profiles. These changes don't help readability, but seem to have a significant impact on speed - unfortunatelyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43421Migrate preInclude.Run3G4Optimiziations.py back to python 2 syntax2021-05-13T09:22:52+02:00John Derek ChapmanMigrate preInclude.Run3G4Optimiziations.py back to python 2 syntaxThe original version (backported from ~master) used python 3 `print` syntax.
FYI @tadej, @nkoehlerThe original version (backported from ~master) used python 3 `print` syntax.
FYI @tadej, @nkoehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43420Updates to particle flow job options2021-05-13T03:02:48+02:00Mark HodgkinsonUpdates to particle flow job optionsThis updates the job options we use to rerun from ESD such that ATLASRECTS-6180 is fixed.
I also added some new variations on the default configuration of particle flow and added associated tests to run them in ART daily.This updates the job options we use to rerun from ESD such that ATLASRECTS-6180 is fixed.
I also added some new variations on the default configuration of particle flow and added associated tests to run them in ART daily.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43419(Re)addition of LAr ZEE in L1Topo legacy(ATR-23403)2021-05-15T03:03:42+02:00Daniele Zanzi(Re)addition of LAr ZEE in L1Topo legacy(ATR-23403)(Re)addition of LAr ZEE in L1Topo legacy(ATR-23403)(Re)addition of LAr ZEE in L1Topo legacy(ATR-23403)https://gitlab.cern.ch/atlas/athena/-/merge_requests/43418Updated ref. using confTool2021-05-13T03:04:50+02:00Tomasz BoldUpdated ref. using confToolFollowup fix of MR: !43350
Tagging @wlampl
Fixes ATEAM-744.Followup fix of MR: !43350
Tagging @wlampl
Fixes ATEAM-744.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43416Manual sweep of !43415 (Use new Run3 simulation tag in ART tests)2021-05-13T09:23:02+02:00Nicolas KoehlerManual sweep of !43415 (Use new Run3 simulation tag in ART tests)Hi,
this MR is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/43415 into ~"21.3" and ~"21.9".
Best, NicoHi,
this MR is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/43415 into ~"21.3" and ~"21.9".
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43415Use new Run3 simulation tag in ART tests2021-05-13T09:23:02+02:00Nicolas KoehlerUse new Run3 simulation tag in ART testsHi,
this MR moves to using the newly created Run3 simulation tag in the ART tests.
Best, NicoHi,
this MR moves to using the newly created Run3 simulation tag in the ART tests.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43414Fix memory leaks during PixelGeoModel building.2021-05-14T03:02:33+02:00Goetz GayckenFix memory leaks during PixelGeoModel building.Delete unused GeoModelNodes when building the PixelGeoModel and ensure that all GeoAlignableTransform are deleted on exit. This fixes one time memory leaks during initialize. Should not have a significant impact other than removing clutt...Delete unused GeoModelNodes when building the PixelGeoModel and ensure that all GeoAlignableTransform are deleted on exit. This fixes one time memory leaks during initialize. Should not have a significant impact other than removing clutter from valgrind logs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4341321.9: fixing brem model for fast track reconstruction using full detector2021-05-13T03:07:01+02:00Noemi Calace21.9: fixing brem model for fast track reconstruction using full detectorSelf explanatory.
@tstrebleSelf explanatory.
@tstrebleNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43412Optimisation of radiation damage simulation2021-05-13T03:04:57+02:00Tomas DadoOptimisation of radiation damage simulationThis MR does few small things
* Removes useless variable
* Moves some code outside of the loop
* Stores the value of the member variable outside of the loop - this was identified by vtune to be slow
Has no impact on the output
cc @t...This MR does few small things
* Removes useless variable
* Moves some code outside of the loop
* Stores the value of the member variable outside of the loop - this was identified by vtune to be slow
Has no impact on the output
cc @tbisanzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43411fix for medium1 tracktwo/track tau trigger combinations2021-05-13T14:40:15+02:00Antonio De Mariafix for medium1 tracktwo/track tau trigger combinationsIssue was caused by calling `TrigEFTauMVHypoTool`twice : once at Preselection and another time at Precision step.
Bug : for "medium1", TrigEFTauMVHypoTool is trying to cut on the BDT score which is not calculated at Preselection level, ...Issue was caused by calling `TrigEFTauMVHypoTool`twice : once at Preselection and another time at Precision step.
Bug : for "medium1", TrigEFTauMVHypoTool is trying to cut on the BDT score which is not calculated at Preselection level, but it's calculated only at Precision level
-> Hypo was cutting on null quantity
Solution : bypass the cut on BDT score for the first `TrigEFTauMVHypoTool` instance and let the cut be applied only during the second instance at Precision level
References updated -> expect count increase for "medium1_tracktwo" and "medium1_track" combinations
pinging @iriu and @carquin
Hope to not pickup MR conflicts with https://gitlab.cern.ch/atlas/athena/-/merge_requests/43405https://gitlab.cern.ch/atlas/athena/-/merge_requests/43410L1Calo legacy menu cleaup (ATR-23241)2021-05-18T03:05:40+02:00Daniele ZanziL1Calo legacy menu cleaup (ATR-23241)remove L1Calo legacy thresholds not planned to be kept in run3remove L1Calo legacy thresholds not planned to be kept in run3https://gitlab.cern.ch/atlas/athena/-/merge_requests/43409Remove doTrigger from preExec ART tests to fix ATR-233822021-05-13T03:04:30+02:00Mark HodgkinsonRemove doTrigger from preExec ART tests to fix ATR-23382Remove preExec with noTrigger from many tests.
Rename noTrigger tests to reflect that.
Fixes ATR-23382Remove preExec with noTrigger from many tests.
Rename noTrigger tests to reflect that.
Fixes ATR-23382https://gitlab.cern.ch/atlas/athena/-/merge_requests/43408TriggerMenuMT: stop building LVL1 JSON menus2021-05-13T03:03:24+02:00Frank WinklmeierTriggerMenuMT: stop building LVL1 JSON menusStop producing the (Run-3) L1 menu JSON files during the build and do
not install them as part of the release. Instead introduce unit tests
for each L1 menu. This might help in reducing sporadic build failures
seen in the TriggerMenuMT p...Stop producing the (Run-3) L1 menu JSON files during the build and do
not install them as part of the release. Instead introduce unit tests
for each L1 menu. This might help in reducing sporadic build failures
seen in the TriggerMenuMT package (ATR-21862).
The legacy L1 XML menus continue to be produced during the build until
all remaining clients are migrated to JSON (ATR-21862).
This change (but for both XML and JSON) was first attempted in
!33843 but reverted again due to ATR-21612. So this time we only remove the building of the JSON files.
To produce the L1 JSON files manually, there are several options:
1. Build the package and run `ctest`. This will produce the menu files in your **build area** under: `Trigger/TriggerCommon/TriggerMenuMT/Menus`
2. Run the generation script directly, e.g. `generateL1MenuRun3.py Physics_pp_run3_v1`
3. Run a full athena[HLT] trigger job
cc @mark and menu coordinators (@khoo @dzanzi @markowen) as this may have implications for workflows where the L1 JSON files are required (e.g. DB upload)https://gitlab.cern.ch/atlas/athena/-/merge_requests/43407MuonTrackQuerry - Remove constexpr to avoid clang-10 build failure2021-05-13T03:04:48+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonTrackQuerry - Remove constexpr to avoid clang-10 build failureHi,
apologies my last MR introduced a massive failure in the `clang-10` builds as `constexpr` and the call of std math functions do not like each other:
https://bigpanda.cern.ch/compsview/?nightly=master_Athena_x86_64-centos7-clang10-opt...Hi,
apologies my last MR introduced a massive failure in the `clang-10` builds as `constexpr` and the call of std math functions do not like each other:
https://bigpanda.cern.ch/compsview/?nightly=master_Athena_x86_64-centos7-clang10-opt&rel=2021-05-10T2130&ar=x86_64-centos7-clang10-opt&proj=Athena
I removed the `constexpr` to fix the error. Tagging: @ssnyder, @christos, @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43406TrigBjetHypo: drop "MT" from component names2021-05-13T03:05:20+02:00Frank WinklmeierTrigBjetHypo: drop "MT" from component namesThe "MT" in the component name is no longer needed now that the Run-2 trigger code is gone from master.The "MT" in the component name is no longer needed now that the Run-2 trigger code is gone from master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43405TrigTauHypo: drop "MT" from component names2021-05-13T03:04:11+02:00Frank WinklmeierTrigTauHypo: drop "MT" from component namesThe "MT" in the component name is no longer needed now that all Run-2 trigger code is gone from master. Also delete unused `TrigL2TauHypoTool.py`.The "MT" in the component name is no longer needed now that all Run-2 trigger code is gone from master. Also delete unused `TrigL2TauHypoTool.py`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43404Run2 to Run3 navigation conversion update2021-05-14T03:03:32+02:00Witold Wojciech PrzygodaRun2 to Run3 navigation conversion updateUpdated: correct roi node search and inheritance implemented as roiFinder lambda expression.Updated: correct roi node search and inheritance implemented as roiFinder lambda expression.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43403L1TopoSimulation: Fixes in TopoSteeringStructure2021-05-13T03:05:14+02:00Carlos Moreno MartinezL1TopoSimulation: Fixes in TopoSteeringStructureThis MR fixes an issue seen in the L1Topo simulation, where the output of algorithms configured simultaneously in Phase-1 and Legacy boards gets mixed. By slightly modifying the name of the registered algorithms in AlgFactory the problem...This MR fixes an issue seen in the L1Topo simulation, where the output of algorithms configured simultaneously in Phase-1 and Legacy boards gets mixed. By slightly modifying the name of the registered algorithms in AlgFactory the problem is solved. This affects ATR-23196 . Also the algID field that was previously used in the simulation to link the parameters to the topological algorithms has been removed as it is not used anymore.
Adding @orlando @asonay @paulama @iriu @dzanzihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43402Migrate TrigL2MuonSA to AthReentrantAlgorithm2021-05-14T03:03:46+02:00Yohei YamaguchiMigrate TrigL2MuonSA to AthReentrantAlgorithmThe steering class of TrigL2MuonSA is migrated from `AthAlgorithm` to `AthReentrantAlgorithm` in response to a discussion in ATR-21908.
Local tests were repeated to check the thread-safety with 16-thread, 1000 events.
tagging @nakahama ...The steering class of TrigL2MuonSA is migrated from `AthAlgorithm` to `AthReentrantAlgorithm` in response to a discussion in ATR-21908.
Local tests were repeated to check the thread-safety with 16-thread, 1000 events.
tagging @nakahama , @cdiez and @smh