athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-01-12T15:42:41+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/49223Adding Jet Timing variable to TriggerEDMRun3 (ATR-23555)2022-01-12T15:42:41+01:00Gentian ShatriAdding Jet Timing variable to TriggerEDMRun3 (ATR-23555)Context : delayed jets produced by LLPs. Since these LLPs move slowly in the detector, they will decay and produce jets that arrive
later than the usual jets. Use of the calorimeter timing to describe these delayed jets.
Add of a new va...Context : delayed jets produced by LLPs. Since these LLPs move slowly in the detector, they will decay and produce jets that arrive
later than the usual jets. Use of the calorimeter timing to describe these delayed jets.
Add of a new variable to study the correlation of the Timing variable between online and offline jets.
Change applied only to HLT EMTopo jets.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49221IOVDbSvc: Fix cppcheck warnings.2021-12-17T15:43:04+01:00Scott SnyderIOVDbSvc: Fix cppcheck warnings.Clases that manage resources should not have a default copy ctor/assignment op.Clases that manage resources should not have a default copy ctor/assignment op.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49220SCT_ConditionsData: Update for thread-safety checker const changes.2021-12-17T15:42:57+01:00Scott SnyderSCT_ConditionsData: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49219RDBAccessSvc: Update for thread-safety checker const changes.2021-12-17T15:42:06+01:00Scott SnyderRDBAccessSvc: Update for thread-safety checker const changes.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.The thread-safety checker is getting more strict on const checks.
Fix resulting warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49218TrigCompositeUtils: Fix cppcheck warnings.2021-12-18T21:43:26+01:00Scott SnyderTrigCompositeUtils: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49217CaloClusterCorrection cppcheck and clang-tidy related fixes2021-12-17T15:44:35+01:00Christos Anastopouloschristos.anastopoulos@cern.chCaloClusterCorrection cppcheck and clang-tidy related fixesCaloClusterCorrection cppcheck and clang-tidy related fixesCaloClusterCorrection cppcheck and clang-tidy related fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49216TrkGaussianSumFilter: Revert diagnostic patches.2021-12-17T15:44:20+01:00Scott SnyderTrkGaussianSumFilter: Revert diagnostic patches.Remove patches to write-protect TrackStateOnSurface memory.
The underlying problem has been solved, and these changes affect performance.
This reverts commit d01d804238ac6f89aec302247fc34ee821d80bf1 and part of
e91fb9719a130d0e3ddfc1550...Remove patches to write-protect TrackStateOnSurface memory.
The underlying problem has been solved, and these changes affect performance.
This reverts commit d01d804238ac6f89aec302247fc34ee821d80bf1 and part of
e91fb9719a130d0e3ddfc1550b1c04a2176595b6.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49214RK Propagator. Rm seemingly unused method. Move internal methods to anonymous...2021-12-17T15:42:30+01:00Christos Anastopouloschristos.anastopoulos@cern.chRK Propagator. Rm seemingly unused method. Move internal methods to anonymous namespaceRK Propagator. Rm seemingly unused method. Move internal methods to anonymous namespaceRK Propagator. Rm seemingly unused method. Move internal methods to anonymous namespacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49213FastSiDigitization+InDetSecVertexValidation+InDetVKalVxInJetTool+TRT_TrackSeg...2021-12-17T15:42:14+01:00Scott SnyderFastSiDigitization+InDetSecVertexValidation+InDetVKalVxInJetTool+TRT_TrackSegmentsTool_xk: Fix clang13 warnings.Uninitialized variables.Uninitialized variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49212TPhotonSelectorTool postpone calculation until is needed2022-01-04T12:17:58+01:00Christos Anastopouloschristos.anastopoulos@cern.chTPhotonSelectorTool postpone calculation until is neededTPhotonSelectorTool postpone calculation until is neededTPhotonSelectorTool postpone calculation until is neededhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49210TRT_ConditionsData: Fix clang13 warnings.2021-12-17T15:44:18+01:00Scott SnyderTRT_ConditionsData: Fix clang13 warnings.Unused variable.Unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49209MuonCombinedReco - Put back the layer intersections for Stau seeds, Fix segme...2022-03-08T14:03:19+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonCombinedReco - Put back the layer intersections for Stau seeds, Fix segment sorting, SpeedUp extensionsHi everybody,
this MR restores the `MuonLayerIntersections` for `MuGirlStau`, which were also killed in !48823. Instead of extrapolating the `InDetCandidate` through the MS, the `TSOS` of the `MuidCo` track are exploited:
1. The TrackSt...Hi everybody,
this MR restores the `MuonLayerIntersections` for `MuGirlStau`, which were also killed in !48823. Instead of extrapolating the `InDetCandidate` through the MS, the `TSOS` of the `MuidCo` track are exploited:
1. The TrackStates are filtered for `TSOS` having trackParameters in the MuonSpectrometer
2. The muonLayerSurfaces are selected using the `phi()` angle of the calo-extension. This is quite the same to the ordinary approach
3. The `TSOS` which is closest to the surface plane is selected as starting point for the extrapolation. This reduces the extrapolation path from several meters to 10-20cm.
* As a performance present, I discovered that the algorithm can be made twice as fast by relaxing the requirements on updating the starting point for the extrapolations when going from one layer to the next of the MS. The physics impact has been tested on 20k data16 events and is found to be quite small (cf. [All_quick_plots.pdf](/uploads/8ebe326d06b2d3fa9325473313aa6dfe/All_quick_plots.pdf) ). While the footprint reduces from
```
"MuonInDetToMuonSystemExtensionAlg": {
"count": 20298,
"cpuTime": 6941314.445365001,
"malloc": 0,
"vmem": 0,
"wallTime": 7044486.0}
```
to
```
"MuonInDetToMuonSystemExtensionAlg": {
"count": 20298,
"cpuTime": 3494300.50838695,
"malloc": 0,
"vmem": 0,
"wallTime": 3554827.0}
```
Tagging here @amete, @tcuhadar, @wleight
* The `MuonCandidateTool` associates the `MuonSegments` to the `MuonCandidate`. The association could be useful for later optimizations in th`MuonInDetToSystemExtensionAlg` and will replace the segment association in the `MuonCreatorTool` in a later MR
* The segments are now sorted following the same logic as in [MuonSelectionTool](https://gitlab.cern.ch/atlas/athena/blob/master/PhysicsAnalysis/MuonID/MuonSelectorTools/Root/MuonSelectionTool.cxx#L21-49). Tagging @mkbugge, @yoyamagu
Tagging: @goblirsc, @sabidi, @dcieri, @minionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49207Remove dependence on RPC cabling from the RpcPadContainerCnv2022-03-15T09:02:52+01:00William Axel LeightRemove dependence on RPC cabling from the RpcPadContainerCnvThe cabling is used only to define the size of the RpcPadContainer, which can just as easily be done using the RpcIdHelper. The advantage of this approach is that the RpcIdHelper is available even if the muon reconstruction is not schedu...The cabling is used only to define the size of the RpcPadContainer, which can just as easily be done using the RpcIdHelper. The advantage of this approach is that the RpcIdHelper is available even if the muon reconstruction is not scheduled. Presumably there aren't yet any cases in which the RpcPadContainerCnv needs to be run even though muon reco is not scheduled, but the track overlay will eventually need to be able to do this.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49206MaterialComposition, add all ctors as coverity was complaining on missing moves2021-12-17T21:42:52+01:00Christos Anastopouloschristos.anastopoulos@cern.chMaterialComposition, add all ctors as coverity was complaining on missing movesMaterialComposition, add all ctors as coverity was complaining on missing movesMaterialComposition, add all ctors as coverity was complaining on missing moveshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49205Fix coverity warning (null pointer not checked)2021-12-17T15:42:39+01:00Giovanni MarchioriFix coverity warning (null pointer not checked)Check a potentially null pointerCheck a potentially null pointerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49204Sweeping !49190 from 22.0-mc20 to master.
TCT: Adding new MC test for Run2 re...2021-12-17T15:43:15+01:00Atlas NightlybuildSweeping !49190 from 22.0-mc20 to master.
TCT: Adding new MC test for Run2 reprocessingTCT: Adding new MC test for Run2 reprocessing
See merge request atlas/athena!49190TCT: Adding new MC test for Run2 reprocessing
See merge request atlas/athena!49190https://gitlab.cern.ch/atlas/athena/-/merge_requests/49203CA config should use StreamX naming2021-12-20T21:42:39+01:00Tadej Novaktadej.novak@cern.chCA config should use StreamX namingCA config should use `StreamX` naming for both backwards compatibility and to avoid confusion. The algorithm itself is still named `OutputStreamX`.
We should really cleanup this automagic configuration from algorithm name at some point ...CA config should use `StreamX` naming for both backwards compatibility and to avoid confusion. The algorithm itself is still named `OutputStreamX`.
We should really cleanup this automagic configuration from algorithm name at some point as it's causing more issues than benefits I guess.
/cc @gemmeren @amete @emoyse @wlampl @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49202TestTools: add FPEs and tweak error pattern in noerror.sh2021-12-17T15:44:01+01:00Frank WinklmeierTestTools: add FPEs and tweak error pattern in noerror.shTreat FPEs as error in the `noerror.sh` post-processing script. Also
tweak the existing error patterns to not pick-up false positives.
cc @emoyseTreat FPEs as error in the `noerror.sh` post-processing script. Also
tweak the existing error patterns to not pick-up false positives.
cc @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49201ElectronLH : rm un-needed check that made coverity complain2021-12-17T15:42:22+01:00Christos Anastopouloschristos.anastopoulos@cern.chElectronLH : rm un-needed check that made coverity complainElectronLH : rm un-needed check that made coverity complain
ping @psommerElectronLH : rm un-needed check that made coverity complain
ping @psommerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49200MuonConfig|MuonCombinedConfig: add noerror to some tests2021-12-17T21:43:11+01:00Edward MoyseMuonConfig|MuonCombinedConfig: add noerror to some testsTested locally with `make test`.
Had to add an exclusion for:
`Py:ComponentAccumulator INFO * IsActiveStatus: ['OK', 'WARNING', 'ERROR', 'FATAL']`
cc @fwinklTested locally with `make test`.
Had to add an exclusion for:
`Py:ComponentAccumulator INFO * IsActiveStatus: ['OK', 'WARNING', 'ERROR', 'FATAL']`
cc @fwinkl