athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-13T15:44:26+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/47096ATR-24117 various menu fixes2021-10-13T15:44:26+02:00Giulia GonellaATR-24117 various menu fixesChains removed for new T&P version, T&P legacy arrangements and other small fixes in both LS2 and Physics menus.
Closes ATR-24117Chains removed for new T&P version, T&P legacy arrangements and other small fixes in both LS2 and Physics menus.
Closes ATR-24117https://gitlab.cern.ch/atlas/athena/-/merge_requests/47095Cleanup some references to SLHC2021-10-13T15:42:11+02:00Tadej Novaktadej.novak@cern.chCleanup some references to SLHCCleanup some references to SLHC.Cleanup some references to SLHC.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47094Remove unused EnvelopeTool2021-10-13T15:46:13+02:00Tadej Novaktadej.novak@cern.chRemove unused EnvelopeToolRemove unused `EnvelopeTool`.
/cc @jchapmanRemove unused `EnvelopeTool`.
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47093LAr DB fixes2021-10-13T15:46:02+02:00Pavol StrizenecLAr DB fixesThis is set of fixes in scripts used for handlig LAr conditions for DB update.
Nothing from those is used in standard reco workflow, only in calibration jobs.This is set of fixes in scripts used for handlig LAr conditions for DB update.
Nothing from those is used in standard reco workflow, only in calibration jobs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47092MuonART -- Remove doTrigger flag to fix the ART tests2021-10-13T15:43:17+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonART -- Remove doTrigger flag to fix the ART testsCloses ATLASRECTS-6606Closes ATLASRECTS-6606https://gitlab.cern.ch/atlas/athena/-/merge_requests/47091AthenaCommon: create Ath[Begin,End]Seq at module level2021-10-13T15:44:56+02:00Frank WinklmeierAthenaCommon: create Ath[Begin,End]Seq at module levelMake the `AthBeginSeq` and `AthEndSeq` available at module level like it
is done already for the other sequences. Otherwise, for some reason,
multiple sequences of that name are being created when a user tries to
create these sequences.Make the `AthBeginSeq` and `AthEndSeq` available at module level like it
is done already for the other sequences. Otherwise, for some reason,
multiple sequences of that name are being created when a user tries to
create these sequences.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47090ComponentAccumulator.getXYZ: Return None if component not found2021-10-13T15:46:49+02:00Walter LamplComponentAccumulator.getXYZ: Return None if component not foundWith this MR, calls like `cfg.getService("InexistentSvc")` return None instead of rising an exception. This should help determining if a to-be-modified service is actually present in a post-exec-like scenario. Same for other types of com...With this MR, calls like `cfg.getService("InexistentSvc")` return None instead of rising an exception. This should help determining if a to-be-modified service is actually present in a post-exec-like scenario. Same for other types of components.
CC @pavol who raised this use-case.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47089Extend IOVDbSvcConfig.addFolder(List) methods2021-10-13T15:45:40+02:00Walter LamplExtend IOVDbSvcConfig.addFolder(List) methodsIOVDbSvcConfig.addFolder(List) methods: Add parameter to pass generic xml-modifiers (like ForceRunNumer or ChannelSelection)IOVDbSvcConfig.addFolder(List) methods: Add parameter to pass generic xml-modifiers (like ForceRunNumer or ChannelSelection)https://gitlab.cern.ch/atlas/athena/-/merge_requests/47087Bjet HLT TriggerMenuMT documentation2021-10-14T09:45:04+02:00Christian NassBjet HLT TriggerMenuMT documentationDocumentation for the TriggerMenuMT Bjet-signature code. [ATR-24226](https://its.cern.ch/jira/browse/ATR-24226)Documentation for the TriggerMenuMT Bjet-signature code. [ATR-24226](https://its.cern.ch/jira/browse/ATR-24226)https://gitlab.cern.ch/atlas/athena/-/merge_requests/47086Bjet HLT TriggerMenuMT documentation2021-10-11T11:03:23+02:00Christian NassBjet HLT TriggerMenuMT documentationDocumentation for the TriggerMenuMT Bjet-signature code. [ATR-24226](https://its.cern.ch/jira/browse/ATR-24226)Documentation for the TriggerMenuMT Bjet-signature code. [ATR-24226](https://its.cern.ch/jira/browse/ATR-24226)https://gitlab.cern.ch/atlas/athena/-/merge_requests/47085Preselection for all primary jet chains2021-10-15T11:26:30+02:00Teng Jian KhooPreselection for all primary jet chainsAdds calo preselection to all primary jet/bjet chains, with the exception of VBF chains for which the eta ranges are not (yet) supported. Copies have been made of all primaries such that we have versions with and without the preselection...Adds calo preselection to all primary jet/bjet chains, with the exception of VBF chains for which the eta ranges are not (yet) supported. Copies have been made of all primaries such that we have versions with and without the preselection. Thresholds are tentative.
This required padding out the preselection mock chain used to configure the preselection hypo tool because otherwise if the presel selection had fewer legs than the main chain (e.g. `3j35_j35_b70_presel4j25`) the ComboHypo would reject on the missing leg indices.
Also introduces `DevGroup` to explicitly mark development chains that are not intended for the physics menu.
Attn @valentem, @ayana. I reshuffled a bunch of chains and have commented various that I think are purely for testing, but for which the developments are essentially complete. We may wish to set up a separate jet testing menu to run only in developer tests or maybe in ART, to reduce the clutter.
Attn @cpollard, @guest, I did the same for b-jets.
We should follow up with:
* Revisiting DevGroup chains and which ones we want to keep in LS2
* Adding the capability to do preselection with non-default eta selection, e.g. 'c' for central (0eta240), 'a' for all-eta (0eta490) and f for forward (320eta490). But we should be aa bit careful with eta boundaries, and 0eta240 in particular -- or consider a margin.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47084add RNN score monitoring histogram in HypoTool and online monitoring2021-10-13T15:45:51+02:00Antonio De Mariaadd RNN score monitoring histogram in HypoTool and online monitoringnotifying also @iriu and @carquin. These histograms will be useful in OHP for tau triggernotifying also @iriu and @carquin. These histograms will be useful in OHP for tau triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47083Electron recommendations for ID and iso2021-10-11T21:45:23+02:00Philip SommerElectron recommendations for ID and isoHello,
we're updating e/y recommendations. This MR provides:
- a new map file containing the recommended SFs
- an update to the CI test (because the SFs changed)
- the test script had to be updated to hold a finite run number (because t...Hello,
we're updating e/y recommendations. This MR provides:
- a new map file containing the recommended SFs
- an update to the CI test (because the SFs changed)
- the test script had to be updated to hold a finite run number (because the new files limit the run number range to run-2)
Cheers,
Philip, @jpoveda, @turra, @jmaurer, @ahadef, @htorreshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47082GsfMaterialMixtureConvolution remove redundant simplified material effects2021-10-13T15:43:01+02:00Christos Anastopouloschristos.anastopoulos@cern.chGsfMaterialMixtureConvolution remove redundant simplified material effectsGsfMaterialMixtureConvolution remove redundant simplified material effects
ping @amorleyGsfMaterialMixtureConvolution remove redundant simplified material effects
ping @amorleyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47081Fix LAr config for splash run2021-10-11T15:44:32+02:00Pavol StrizenecFix LAr config for splash runThis MR should fix problems with autoconfiguration of LAr reco for the splashes (LAr in raw data mode), and add the CAF transform for producing LAr cells ntuple.
Would be good to have this merged soon.This MR should fix problems with autoconfiguration of LAr reco for the splashes (LAr in raw data mode), and add the CAF transform for producing LAr cells ntuple.
Would be good to have this merged soon.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47080Updating Frozen Derivation test2021-10-10T15:44:55+02:00Cristiano AlpigianiUpdating Frozen Derivation testThis MR updates the preExec and the data input file for the frozen derivation test. The most recent b-tagging calibration used in production is now used.This MR updates the preExec and the data input file for the frozen derivation test. The most recent b-tagging calibration used in production is now used.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47079remove other tracks links/calls for DiTau2021-10-11T21:45:30+02:00Antonio De Mariaremove other tracks links/calls for DiTauThis MR will remove the call to "other" tracks for DiTau objects since they were not used for ID tuning
and "other" tracks are also not provided in the TauCP smart slimming list
Tagging @martindl, @qbuat and @dtaThis MR will remove the call to "other" tracks for DiTau objects since they were not used for ID tuning
and "other" tracks are also not provided in the TauCP smart slimming list
Tagging @martindl, @qbuat and @dtahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47078tauRec: drop tool caching in TauAlgorithmsHolder2021-10-13T15:42:35+02:00Bertrand Martin Dit LatourtauRec: drop tool caching in TauAlgorithmsHolderHello,
This MR is removing a caching mechanism that was used when creating tools in the tau reconstruction.
It addresses the comment raised by @tbold in https://gitlab.cern.ch/atlas/athena/-/merge_requests/34427#note_3614684 .
I will ne...Hello,
This MR is removing a caching mechanism that was used when creating tools in the tau reconstruction.
It addresses the comment raised by @tbold in https://gitlab.cern.ch/atlas/athena/-/merge_requests/34427#note_3614684 .
I will need to learn about ComponentAccumulator to understand how this could have led to crosstalk between components :-)
This MR does not change the tau reconstruction output. The `--dump-configuration` output is also unchanged.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47077Two algorithms in CaloCondPhysAlgs switched to reading CaloDD Manager from Co...2021-10-11T21:43:14+02:00Vakhtang TsulaiaTwo algorithms in CaloCondPhysAlgs switched to reading CaloDD Manager from Cond StoreThe algorithms affected by this change:
- `CaloCellNoiseAlg`
- `LArMinBiasAlg`
FYI @wlamplThe algorithms affected by this change:
- `CaloCellNoiseAlg`
- `LArMinBiasAlg`
FYI @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47076PerfMonComps: Update PerfMonMT CA configuration2021-10-11T15:44:51+02:00Alaettin Serhan MetePerfMonComps: Update PerfMonMT CA configurationThis MR should fix the failing CA-based simulation ART tests in the latest nightly. The problem originated from two MRs that did play nicely with each other: !47011 and !47014. Originally we were inserting `PerfMonMTAlg` to the standard ...This MR should fix the failing CA-based simulation ART tests in the latest nightly. The problem originated from two MRs that did play nicely with each other: !47011 and !47014. Originally we were inserting `PerfMonMTAlg` to the standard `AthAlgSeq`. After the former, this algorithm is now being added to `AthBeginSeq` but by default a bare `ComponentAccumulator` doesn't know about this. So, things needed to be adjusted a little bit to accomodate that. Let me cc @jchapman and @tadej so that they're aware.
Also, the legacy configuration allows one to insert an algorithm to anywhere in a sequence (by index). Admittedly, this can be a little fiddly but it was nice to have. This doesn't seem to be possible in the new configuration from a quick glance. Maybe @wlampl has an idea on that.