athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-11T15:44:10+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/47060Dropped the access to CaloDetDescrManager as singleton from GeoCaloCalibHit2021-10-11T15:44:10+02:00Vakhtang TsulaiaDropped the access to CaloDetDescrManager as singleton from GeoCaloCalibHitA pointer to the manager is passed now to the constructor of `GeoCaloCalibHit`.
The clients have been adapted to this change.
Also implemented some formatting and stylistic changes in `GeoCaloCalibHit.icc`.A pointer to the manager is passed now to the constructor of `GeoCaloCalibHit`.
The clients have been adapted to this change.
Also implemented some formatting and stylistic changes in `GeoCaloCalibHit.icc`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47059AGDDHandlers: Enable thread-safety checking.2021-10-11T15:42:05+02:00Scott SnyderAGDDHandlers: Enable thread-safety checking.Remove static variables.Remove static variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47058AGDDControl: Fix cppcheck warnings.2021-10-11T15:43:36+02:00Scott SnyderAGDDControl: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47057ElectronPhotonSelectorTools cleanup more obsolete working points2021-10-13T15:42:03+02:00Christos Anastopouloschristos.anastopoulos@cern.chElectronPhotonSelectorTools cleanup more obsolete working pointsElectronPhotonSelectorTools cleanup more obsolete working pointsElectronPhotonSelectorTools cleanup more obsolete working pointshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47055Make L1Calo gFEXOutputCollection work with read and write handles2022-07-13T14:05:05+02:00Cecilia TosciriMake L1Calo gFEXOutputCollection work with read and write handlesThis MR makes the L1Calo gFEXOutputCollection work with read and write handles, and includes the gFEXNtuplewriter back in the gFEX JobOptions file. The changes have been made according to the similar modifications recently made for eFEX ...This MR makes the L1Calo gFEXOutputCollection work with read and write handles, and includes the gFEXNtuplewriter back in the gFEX JobOptions file. The changes have been made according to the similar modifications recently made for eFEX (!45871) and jFEX (!46819).https://gitlab.cern.ch/atlas/athena/-/merge_requests/47052CaloTopoTowerFromClusterMaker: Retrieve CaloDetDescrManager from ConditionStore2021-10-11T15:42:15+02:00Walter LamplCaloTopoTowerFromClusterMaker: Retrieve CaloDetDescrManager from ConditionStoreI think this is the only incarnation of CaloTower-makers that is actually in use. Migrating it to retrieve `CaloDetDescrManager` from `ConditionStore`.I think this is the only incarnation of CaloTower-makers that is actually in use. Migrating it to retrieve `CaloDetDescrManager` from `ConditionStore`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47051Add CA-based VolumeDebugger UserAction config2021-10-24T17:29:45+02:00Nicholas StylesAdd CA-based VolumeDebugger UserAction configAdd ```VolumeDebugger``` configurations, plus a few pre-defined options for volumes to run it on as ```PostIncludes```.
As always with configurations involving adding ```UserActions```, the configuration here is pretty complicated. In p...Add ```VolumeDebugger``` configurations, plus a few pre-defined options for volumes to run it on as ```PostIncludes```.
As always with configurations involving adding ```UserActions```, the configuration here is pretty complicated. In principle, it seems like this really ought to be possible to streamline, but whatever I tried didn't seem to work, so it people have specific suggestions I'm happy to try them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47050TrigCost: Calculate unique CPU time of chains2021-10-11T15:45:03+02:00Aleksandra PorebaTrigCost: Calculate unique CPU time of chainsAdd cost columns (total unique time [s] and total unique time as a fraction of total time [%]) and histograms (Unique time per chain call) containing information about the time of algorithms executed uniquely for a given chain (were acti...Add cost columns (total unique time [s] and total unique time as a fraction of total time [%]) and histograms (Unique time per chain call) containing information about the time of algorithms executed uniquely for a given chain (were active in an event only for one chain).
Example made with 20 events: https://atlas-trig-cost.cern.ch/?dir=aporeba&type=&tag=data18-13TeV&run=00000024&range=LumiBlock_00150&level=HLT&summary=Chain
tagging @tamartin @markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47049Monitoring: fixing copying of data to shifted live histograms including TProfile2021-10-15T21:56:49+02:00Iskander IbragimovMonitoring: fixing copying of data to shifted live histograms including TProfile- refilling of new kLive histograms with offset (on Xaxis = Lumiblocks ) w.r.t. old ones
- special treatment of the TProfile histograms for this- refilling of new kLive histograms with offset (on Xaxis = Lumiblocks ) w.r.t. old ones
- special treatment of the TProfile histograms for thishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47048manual cherrypick of 467242021-10-12T21:45:16+02:00Peter Bertamanual cherrypick of 46724This MR is a manual cherry-pick of the changes in !46724 (merged) (merged) to fix ATEAM-780 for branch 21.0-mc16d. But it seems the two branches (master and 21.0-mc16d) diverged quite a lot and there were conflicts. I tried to resolve th...This MR is a manual cherry-pick of the changes in !46724 (merged) (merged) to fix ATEAM-780 for branch 21.0-mc16d. But it seems the two branches (master and 21.0-mc16d) diverged quite a lot and there were conflicts. I tried to resolve them but there are much more changes in this MR as in the original MR !46724 (merged) (merged). @ssnyder , can you please take a loo whether this MR is ok?https://gitlab.cern.ch/atlas/athena/-/merge_requests/47047Manual cherrypick for MR 467242021-10-12T19:47:58+02:00Peter BertaManual cherrypick for MR 46724This MR is a manual cherry-pick of the changes in !46724 (merged) to fix ATEAM-780 in 21.0-mc16a. But it seems the two branches (master and 21.0-mc16a) diverged quite a lot and there were conflicts. I tried to resolve them but there are ...This MR is a manual cherry-pick of the changes in !46724 (merged) to fix ATEAM-780 in 21.0-mc16a. But it seems the two branches (master and 21.0-mc16a) diverged quite a lot and there were conflicts. I tried to resolve them but there are much more changes in this MR as in the original MR !46724 (merged). @ssnyder , can you please take a loo whether this MR is ok?https://gitlab.cern.ch/atlas/athena/-/merge_requests/47046ATR-24237: bs-streamerinfos from master, for Run-2 reprocessing2021-10-09T19:10:01+02:00Oleg KuprashATR-24237: bs-streamerinfos from master, for Run-2 reprocessingManual cherry pick of !46967 from master.
Tagging @pbertaManual cherry pick of !46967 from master.
Tagging @pbertahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47045Propogate conditions/geometry tag parameters to RDOtoRDOtrigger2021-10-13T15:46:07+02:00Savanna ShawPropogate conditions/geometry tag parameters to RDOtoRDOtriggerPropogating the transform parameters for the conditions and geometry tags to runHLT_standalone so that they can be set for the RDOtoRDOtrigger step consistently with other transform steps (ATR-24277).Propogating the transform parameters for the conditions and geometry tags to runHLT_standalone so that they can be set for the RDOtoRDOtrigger step consistently with other transform steps (ATR-24277).https://gitlab.cern.ch/atlas/athena/-/merge_requests/47044Temporary disable NSW ART trigger jobs due to ATR-243112021-10-09T19:04:59+02:00Tim MartinTemporary disable NSW ART trigger jobs due to ATR-24311Due to excessive memory usage.
This is just a short term solution until the issue is understood.Due to excessive memory usage.
This is just a short term solution until the issue is understood.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47043Draft: Adding METSignificance in AT2021-10-08T13:23:35+02:00Buddhadeb MondalDraft: Adding METSignificance in ATAdding METSignificance in ATAdding METSignificance in AThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47042Update input file name for mc20 rdotobs test to the correct one.2021-10-09T19:07:26+02:00Mark HodgkinsonUpdate input file name for mc20 rdotobs test to the correct one.Update input file name for mc20 rdotobs test to the correct one.Update input file name for mc20 rdotobs test to the correct one.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47041Remove old SLHC InDetServMat geometry2021-10-09T19:04:00+02:00Tadej Novaktadej.novak@cern.chRemove old SLHC InDetServMat geometryRemove old SLHC InDet service materials geometry.
/cc @nstylesRemove old SLHC InDet service materials geometry.
/cc @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47040Properly define ITk volumes to G42021-10-11T21:43:36+02:00Tadej Novaktadej.novak@cern.chProperly define ITk volumes to G4ITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquITk now uses `ITK` global envelope and not `IDET`. Try to migrate all the clients and add some handling to debugging tools.
/cc @jchapman @nstyles @mbandier @dellacquhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47039StoreGate: remove Updater mode from VarHandleKey2021-10-11T15:44:59+02:00Frank WinklmeierStoreGate: remove Updater mode from VarHandleKeyThe `Updater` mode of `DataHandle` is removed in [Gaudi v36r1](gaudi/Gaudi%v36r1) and our
`UpdateHandle` uses the `Reader` mode anyway (see discussion in
gaudi/Gaudi!1237). Remove usage of this mode and update unit tests. Fixes build fai...The `Updater` mode of `DataHandle` is removed in [Gaudi v36r1](gaudi/Gaudi%v36r1) and our
`UpdateHandle` uses the `Reader` mode anyway (see discussion in
gaudi/Gaudi!1237). Remove usage of this mode and update unit tests. Fixes build failures in [Gaudi nightlies](https://bigpanda.cern.ch/nview/?nightly=master--masterGAUDI_Athena_x86_64-centos7-gcc8-dbg).
Also update `pythonRepr` to use the now available `className()`
function instead of parsing the full key name.
cc @leggett @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47038Fix naming of PixelReadoutManager2021-10-09T19:05:40+02:00Tadej Novaktadej.novak@cern.chFix naming of PixelReadoutManagerFix naming of `PixelReadoutManager` in some of the job options.
FYI @ytakuboFix naming of `PixelReadoutManager` in some of the job options.
FYI @ytakubo