athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-12-20T15:42:07+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/49197Adding new AFP track reconstruction tool2021-12-20T15:42:07+01:00Petr BalekAdding new AFP track reconstruction toolAdding new AFP track reconstruction tool that uses linear regression. This version follows the one from `AFPAnalysisTool`; all the options have been kept as well.
`AFPSiDBasicKalmanTool` is still used by default though, only added a few...Adding new AFP track reconstruction tool that uses linear regression. This version follows the one from `AFPAnalysisTool`; all the options have been kept as well.
`AFPSiDBasicKalmanTool` is still used by default though, only added a few (commented out) lines for easy setup of `AFPSiDLinRegTool`.
Closes AFPSOFT-113, Closes AFPSOFT-117https://gitlab.cern.ch/atlas/athena/-/merge_requests/49196Renamed CSCPEB to LArPEBNoise and added NSW to configuration, added full-scan...2021-12-21T15:43:14+01:00Giulia GonellaRenamed CSCPEB to LArPEBNoise and added NSW to configuration, added full-scan...Renamed CSCPEB to LArPEBNoise and added NSW to configuration, added full-scan LATOME data to LArPEB and LArPEBHLT
Closes ATR-24593Renamed CSCPEB to LArPEBNoise and added NSW to configuration, added full-scan LATOME data to LArPEB and LArPEBHLT
Closes ATR-24593https://gitlab.cern.ch/atlas/athena/-/merge_requests/49195update Gaudi version to v36r3.0002021-12-17T21:42:32+01:00Charles Leggettupdate Gaudi version to v36r3.000update Gaudi version to v36r3.000update Gaudi version to v36r3.000https://gitlab.cern.ch/atlas/athena/-/merge_requests/49194Updated muComb to be reentrant (ATR-22131)2021-12-17T21:42:05+01:00Stefano Giagustefano.giagu@cern.chUpdated muComb to be reentrant (ATR-22131)muComb updated to be reentrant.
- changed the algorithm from AthAlgorithm to AthReentrantAlgorithm
- added the event context to the execute method and passed the event context to read/write handles
- tested with:
runTrigART.py -m -j4
...muComb updated to be reentrant.
- changed the algorithm from AthAlgorithm to AthReentrantAlgorithm
- added the event context to the execute method and passed the event context to read/write handles
- tested with:
runTrigART.py -m -j4
test_trig_mc_v1Dev_slice_muon_build.py
test_trig_mc_v1Dev_slice_muon_grid.py
(all tests ended w/o problems, results and trigger counts identical wrt master)https://gitlab.cern.ch/atlas/athena/-/merge_requests/49192Minor tweaks for SiHitAnalysis for HGTD2021-12-17T15:42:40+01:00Tadej Novaktadej.novak@cern.chMinor tweaks for SiHitAnalysis for HGTDMinor tweaks for SiHitAnalysis for HGTD. Something that I had changed locally but never pushed.
/cc @aleopold @dshopeMinor tweaks for SiHitAnalysis for HGTD. Something that I had changed locally but never pushed.
/cc @aleopold @dshopehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49191Update RIG ART test scripts2021-12-17T15:43:44+01:00Mark HodgkinsonUpdate RIG ART test scriptsA few updates to test scripts:
Remove return statements that are not needed.
Add print outs of return codes which ART will pick up.
Add statements to retain specific log files.A few updates to test scripts:
Remove return statements that are not needed.
Add print outs of return codes which ART will pick up.
Add statements to retain specific log files.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49189Epos_i fix interface to work with the new version, SuperChic_i a fix to make...2021-12-21T15:42:45+01:00Ewelina Maria LobodzinskaEpos_i fix interface to work with the new version, SuperChic_i a fix to make...Epos_i fix interface to work with the new version:
set the kMaxParticles = 10000 - as done for GENSER
change the signatures for crmc_set_f and crmc_init_f
change the orget in which crmc_set_f and crmc_init_f are called
SuperChic_i a fi...Epos_i fix interface to work with the new version:
set the kMaxParticles = 10000 - as done for GENSER
change the signatures for crmc_set_f and crmc_init_f
change the orget in which crmc_set_f and crmc_init_f are called
SuperChic_i a fix to make the generator running with HepMC3https://gitlab.cern.ch/atlas/athena/-/merge_requests/49188TrigT1TGC clean-up of FrontEnd-related codes2021-12-17T15:44:16+01:00Junpei MaedaTrigT1TGC clean-up of FrontEnd-related codesFor the maintenance point of view, the pointers of variable size arrays for member objects in `TGCSector` class have been changed to `std::vector`. Moreover, `= delete` context is attached to hidden/forbidden copy constructor and assignm...For the maintenance point of view, the pointers of variable size arrays for member objects in `TGCSector` class have been changed to `std::vector`. Moreover, `= delete` context is attached to hidden/forbidden copy constructor and assignment operator.
Also removed unused member functions and a variable in `TGCHitPattern` class.
`test_trig_mc_v1Dev_L1SimuOnly_build.py` has been passed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49187Fixing ATLASRECTS-67532021-12-17T15:43:53+01:00Rafal SikoraFixing ATLASRECTS-6753Variable nPlateID in AFP_Geometry.cxx exceeded the vector size when reading its elements; now protection implemented which is needed only for phantom vacuum planes in AFP.
jenkins please retry a build.Variable nPlateID in AFP_Geometry.cxx exceeded the vector size when reading its elements; now protection implemented which is needed only for phantom vacuum planes in AFP.
jenkins please retry a build.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49186MVAUtils fix cppcheck warnings2021-12-17T15:44:03+01:00Christos Anastopouloschristos.anastopoulos@cern.chMVAUtils fix cppcheck warningsMVAUtils fix cppcheck warningsMVAUtils fix cppcheck warningshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49184Updated NSW ReadoutElements after implementation & validation of A-lines for ...2021-12-17T15:43:49+01:00Stylianos AngelidakisUpdated NSW ReadoutElements after implementation & validation of A-lines for sTGCs and MMs.This MR is the second checkpoint, after validating the implementation of a-lines (alignment transformations) with the alignment group. The next MR will include b-lines (deformations). Some code cleanup was also performed...This MR is the second checkpoint, after validating the implementation of a-lines (alignment transformations) with the alignment group. The next MR will include b-lines (deformations). Some code cleanup was also performed...https://gitlab.cern.ch/atlas/athena/-/merge_requests/49178TauTrigMon : improve and disentangle Phase1 and Legacy L1 monitoring2021-12-16T15:43:06+01:00Antonio De MariaTauTrigMon : improve and disentangle Phase1 and Legacy L1 monitoringIn this MR:
* improve legacy L1 monitoring checking the passed thresholds through thrNames() function available for EmTauRoIs
* load the "L1_eTauRoI" container for Phase-1 L1 items (eFexTauRoI) -> this will make sure Phase-1 L1 items ar...In this MR:
* improve legacy L1 monitoring checking the passed thresholds through thrNames() function available for EmTauRoIs
* load the "L1_eTauRoI" container for Phase-1 L1 items (eFexTauRoI) -> this will make sure Phase-1 L1 items are properly monitored and disentangled from legacy L1 items
* Note : for Phase-1 L1 items, eFexTauRoI are monitored only of they pass the energy threshold wrt nominal threshold from L1 item in the trigger name
Tagging @iriu, @gipezzul, @afaulkne and @dzanzihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49177idcalib trigger implementation (ATR-17329)2021-12-20T21:42:27+01:00Kunihiro Naganoidcalib trigger implementation (ATR-17329)Implementation of "IDCalib" trigger chain - calibration triggers for ID detector alignment.
- Add a new directory(/package), TrigTrackHypo, under Trigger/TriggerHypothesis
- Under TrigTrackHypo, IDCalibHypoAlg and IDCalibHypoTool are add...Implementation of "IDCalib" trigger chain - calibration triggers for ID detector alignment.
- Add a new directory(/package), TrigTrackHypo, under Trigger/TriggerHypothesis
- Under TrigTrackHypo, IDCalibHypoAlg and IDCalibHypoTool are added
- Define "IDCalib" trigger sequence in the menu (in CalibCosmicMon), as well as adding a new EDM (RoI).
* The trigger is PEB, collecting ID detector data around the RoIs identified with the hypo
* The hypo selection currently implemented is just with pT (to be optimized - QT by Sean)
- Three chains are added in LS2_v1: HLT_idcalib_trk9_IDCalibPEB_L1XE50, _L1J100, _L14J15
* trk9 - 9 GeV cut
* IDCalibPEB - to specify the chain is PEB (for IDCalib)https://gitlab.cern.ch/atlas/athena/-/merge_requests/49176Fix ATLFAST3 configuration and enable ATLFAST3MT ART tests2022-01-10T21:51:27+01:00John Derek ChapmanFix ATLFAST3 configuration and enable ATLFAST3MT ART testsThere was a bug in the old-style configuraion of ATLFAST3 jobs in master. The CA-based configuration was correct (AFAICT).
This will change the output of the existing AF3 ART and CI jobs.
FYI @ahasib, @mfauccig, @cyoungThere was a bug in the old-style configuraion of ATLFAST3 jobs in master. The CA-based configuration was correct (AFAICT).
This will change the output of the existing AF3 ART and CI jobs.
FYI @ahasib, @mfauccig, @cyounghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49175add VRJetOverlapDecorator variables to VR track jet output in DerivationFrame...2021-12-16T15:43:20+01:00Philipp Gadowadd VRJetOverlapDecorator variables to VR track jet output in DerivationFrameworkThe VR track jets used for b-tagging boosted objects have an ill-defined b-tagging calibration for event topologies with overlapping track jets.
The [FTAG recommendations for VR track jets](https://twiki.cern.ch/twiki/bin/view/AtlasProte...The VR track jets used for b-tagging boosted objects have an ill-defined b-tagging calibration for event topologies with overlapping track jets.
The [FTAG recommendations for VR track jets](https://twiki.cern.ch/twiki/bin/view/AtlasProtected/BTagCalibrationRecommendationsRelease21#Recommendations_for_variable_rad) suggest to veto events "if any of your signal jets have relativeDeltaRToVRJet < 1.0."
Currently, this variable is missing in the VR track jet output.
This MR schedules the [VRJetOverlapDecorator](https://gitlab.cern.ch/atlas/athena/-/tree/21.2/PhysicsAnalysis/JetTagging/FlavorTagDiscriminants#hbb-tagging)](https://gitlab.cern.ch/atlas/athena/-/tree/21.2/PhysicsAnalysis/JetTagging/FlavorTagDiscriminants#hbb-tagging) as a jet modifier when adding VR track jets to a derivation output and add its output to the list of VR track jet variables to be written out.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49174[TriggerMenuMT] Replace RecoFragmentsPool internal implementation with Accumu...2021-12-16T15:44:00+01:00Rafal Bielskirafal.bielski@cern.ch[TriggerMenuMT] Replace RecoFragmentsPool internal implementation with AccumulatorCacheReplace the whole `RecoFragmentsPool` custom cache implementation with new one based on the `AccumulatorCache`, which is a new central solution for ATLAS configuration code. It comes with many useful features for debugging, as well as pr...Replace the whole `RecoFragmentsPool` custom cache implementation with new one based on the `AccumulatorCache`, which is a new central solution for ATLAS configuration code. It comes with many useful features for debugging, as well as profits from any new features, bug fixes and improvements to be implemented in the central code.
The new solution is stricter than the old one. It requires config flags to be always passed and practically eliminates non-cacheable calls with unhashable arguments. With the implementation of arguments parsing provided here, the hashability is enforced while keeping the arguments intact in all known and tested cases.
Since this MR replaces one cache with another, it doesn't really improve the configuration timing. It does, however, improve the correctness of the configuration and eliminates some previously unnoticed bad patterns. It also makes debugging cache misses much easier and using these features, I already improved some functions in the TriggerMenuMT to limit unnecessary cache misses (commit 0adb4efea40dfd69b34c4103cbe92c8d6be8868f).
Fixes include:
* pass keyword arguments consistently in all calls to the same functions
* avoid functions local to an object of a class - make them static or move out of the class
The latter in two cases fixes actual caching bugs:
* In `MinBiasChainConfiguration.py` the two temporary lambdas had the same memory address and signature, so the same hash, even though they were separate functions. Result of one may have been cached and returned as a result of the other function.
* Similar situation in `BjetChainConfiguration.py` made chain configuration of the first jet collection type be returned for all subsequent calls regardless of the collection type passed. Fixing this uncovered a series of downstream bugs in b-jet chain configuration, so the affected 5 b-jet EMTopo chains are commented out. The issue is followed up in ATR-24730
A nice feature of the AccumulatorCache is its summary print-out which is now added in runHLT_standalone.py and shows for LS2_v1 menu:
```
----------------------------------------------------------------------------------------------------------
AccumulatorCache | Hits (time) | Misses (time) |
----------------------------------------------------------------------------------------------------------
TriggerMenuMT.HLTMenuConfig.Menu.MenuComponents.retrieve_cacheable | 10017 ( 1.5s) | 493 (78.0s) |
...ndAlg.AtlasTrackingGeometryCondAlgConfig.TrackingGeometryCondAlgCfg | 19 ( 0.0s) | 1 ( 0.4s) |
IOVDbSvc.IOVDbSvcConfig.IOVDbSvcCfg | 111 ( 0.0s) | 1 ( 0.0s) |
...Config.MinBias.MinBiasMenuSequences.MinBiasZVertexFinderSequenceCfg | 0 ( 0.0s) | 1 ( 0.0s) |
...nuMT.HLTMenuConfig.MinBias.MinBiasMenuSequences.SPCounterRecoAlgCfg | 0 ( 0.0s) | 1 ( 0.0s) |
TrigConfigSvc.TrigConfigSvcCfg.L1ConfigSvcCfg | 1 ( 0.0s) | 1 ( 0.0s) |
TrigConfigSvc.TrigConfigSvcCfg.HLTConfigSvcCfg | 1 ( 0.0s) | 1 ( 0.0s) |
----------------------------------------------------------------------------------------------------------
```
The chain removals + the code improvements in this MR dropped the number of cache misses from >600 to <500.
cc @tbold, @ktopolni, @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49173AthenaMPTools: added support for running jobs with no Event Selector2021-12-20T15:43:20+01:00Vakhtang TsulaiaAthenaMPTools: added support for running jobs with no Event SelectorThis change allows running tests like Hello World in AthenaMP. It
affects only the Shared Event Queue strategy.
Also fixed a small bug in the `AthenaEventLoopMgr`.This change allows running tests like Hello World in AthenaMP. It
affects only the Shared Event Queue strategy.
Also fixed a small bug in the `AthenaEventLoopMgr`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49172RungeKuttaPropagator : use std for math functions and try to tidy a bit the code2021-12-16T15:43:42+01:00Christos Anastopouloschristos.anastopoulos@cern.chRungeKuttaPropagator : use std for math functions and try to tidy a bit the codeRungeKuttaPropagator : use std for math functions and try to tidy a bit the codeRungeKuttaPropagator : use std for math functions and try to tidy a bit the codehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49171RungeKuttaUtils : Move methods that are used only internally in the anonymous...2021-12-16T15:42:22+01:00Christos Anastopouloschristos.anastopoulos@cern.chRungeKuttaUtils : Move methods that are used only internally in the anonymous namespaceRungeKuttaUtils
Move methods that are used only internally in the anonymous namespace inside the .cxx
The MR mainly moves the :
`jacobianTransformCurvilinearToDisc`,`jacobianTransformCurvilinearToPlane`,`jacobianTransformCurvilinearTo...RungeKuttaUtils
Move methods that are used only internally in the anonymous namespace inside the .cxx
The MR mainly moves the :
`jacobianTransformCurvilinearToDisc`,`jacobianTransformCurvilinearToPlane`,`jacobianTransformCurvilinearToCylinder`
`jacobianTransformCurvilinearToStraightLine`, methods inside the anonymous namespace.
As they are only used internally in this module.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49170InDetTrackValidation: Migrate to IAthRNGSvc.2021-12-16T15:42:32+01:00Scott SnyderInDetTrackValidation: Migrate to IAthRNGSvc.Migrate from the deprecated IAtRndmSvc to the thread-safe IAthRNGSvc.Migrate from the deprecated IAtRndmSvc to the thread-safe IAthRNGSvc.